Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-25 Thread James Cameron
On Sun, Apr 25, 2010 at 11:46:41AM -0400, Bernie Innocenti wrote: > As we're there, how do we get rid of the useless UL screen with its ugly > inverted color scheme? For OLPC builds we'd need a product safety review to remove it. ;-) For deployment builds, you could hide /usr/sbin/ul-warning ...

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-25 Thread Paul Fox
bernie wrote: > On Wed, 2010-04-21 at 10:32 +1000, James Cameron wrote: > > > However, I've just applied the patch on os119 on XO-1.5, restarted Sugar > > and tested Restart and Shutdown options, and they function correctly. > > Restart causes a UL screen and reboot. Shutdown causes a UL scr

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-25 Thread Bernie Innocenti
On Wed, 2010-04-21 at 10:32 +1000, James Cameron wrote: > However, I've just applied the patch on os119 on XO-1.5, restarted Sugar > and tested Restart and Shutdown options, and they function correctly. > Restart causes a UL screen and reboot. Shutdown causes a UL screen and > power off. As we'r

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Daniel Drake
On 21 April 2010 19:07, James Cameron wrote: > On Wed, Apr 21, 2010 at 10:17:14AM +0200, Sascha Silbe wrote: >> Since I've run into the same issue before (i.e. with HAL), I suppose >> the default is the same but the OLPC builds explicitly configure HAL >> to allow shutdowns even for multiple sessi

[Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Michael Stone
Sascha wrote: > HAL is dead, ConsoleKit now handles shutdown / reboot. I still prefer the "/sbin/shutdown" approach taken in sl#615 to the D-Bus based mechanisms that Tomeu prefers but I am concerned that this may be an area of irreconcilable difference between Tomeu and myself. Therefore, in the

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 10:17:14AM +0200, Sascha Silbe wrote: > Since I've run into the same issue before (i.e. with HAL), I suppose > the default is the same but the OLPC builds explicitly configure HAL > to allow shutdowns even for multiple sessions? I've looked and not found where this might oc

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread James Cameron
On Wed, Apr 21, 2010 at 10:12:43AM +0100, Peter Robinson wrote: > I thought the point of these patches was to move from HAL to > ConsoleKit so surely it should work whether HAL is there or not > especially with everyone moving away from HAL to > ConsoleKit/upower/udisk/udev etc/ The failure was un

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Jonas Smedegaard
On Wed, Apr 21, 2010 at 10:12:43AM +0100, Peter Robinson wrote: On Wed, Apr 21, 2010 at 1:32 AM, James Cameron wrote: On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Now, if one also stops HAL, the shutdown or restart options don't work, and shell.log says: I thought the point

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Peter Robinson
On Wed, Apr 21, 2010 at 1:32 AM, James Cameron wrote: > On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: >> Hi James/Sascha, >>    > Reviewed-by: James Cameron >> Did you test on XO-1 or XO-1.5?  I'm curious how much of a backwards- >> compatibility break this is. > > No, I only did a

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Sascha Silbe
On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: Hi James/Sascha, Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. While the actual patch was only tested on XO-1, I tried out the ConsoleKit API on XO-1.5 first. Both times Debian sque

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-21 Thread Sascha Silbe
On Wed, Apr 21, 2010 at 01:18:53PM +1000, James Cameron wrote: dbus.exceptions.DBusException: org.freedesktop.ConsoleKit.Manager.NotPrivileged: Not privileged for action: org.freedesktop.consolekit.system.restart-multiple-users auth_admin_keep_always After the patch is applied, Sugar's shutdow

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
On Wed, Apr 21, 2010 at 10:32:28AM +1000, James Cameron wrote: > dbus.exceptions.DBusException: > org.freedesktop.ConsoleKit.Manager.NotPrivileged: Not privileged for action: > org.freedesktop.consolekit.system.restart-multiple-users > auth_admin_keep_always After the patch is applied, Sugar's

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Paul Fox
james wrote: > On Tue, Apr 20, 2010 at 08:37:54PM -0400, Paul Fox wrote: > > so, can someone tell me (gently) why either of these techniques > > is better than simply invoking /bin/reboot or /bin/shutdown? > > (other than the fact that those will work even if hal isn't > > running?) > > Le

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
On Tue, Apr 20, 2010 at 08:37:54PM -0400, Paul Fox wrote: > so, can someone tell me (gently) why either of these techniques > is better than simply invoking /bin/reboot or /bin/shutdown? > (other than the fact that those will work even if hal isn't > running?) Lets Sugar hop the privilege barrier

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Paul Fox
james wrote: > On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: > > Hi James/Sascha, > >> Reviewed-by: James Cameron > > Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- > > compatibility break this is. > > No, I only did a code review and cross-check ag

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
On Tue, Apr 20, 2010 at 07:55:45PM -0400, Chris Ball wrote: > Hi James/Sascha, >> Reviewed-by: James Cameron > Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- > compatibility break this is. No, I only did a code review and cross-check against ConsoleKit API documentation

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Chris Ball
Hi James/Sascha, > Reviewed-by: James Cameron Did you test on XO-1 or XO-1.5? I'm curious how much of a backwards- compatibility break this is. - Chris. -- Chris Ball One Laptop Per Child ___ Sugar-devel mailing list Sugar-devel@lists.sugarlab

Re: [Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread James Cameron
Reviewed-by: James Cameron -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH] use ConsoleKit instead of HAL for shutdown/reboot

2010-04-20 Thread Sascha Silbe
HAL is dead, ConsoleKit now handles shutdown / reboot. Shutdown tested on Debian squeeze with consolekit 0.4.1-4. Reboot mode cannot be triggered by UI in Sugar 0.88, so not tested. Signed-off-by: Sascha Silbe --- src/jarabe/model/session.py | 10 +- 1 files changed, 5 insertions(+),