Re: [Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-23 Thread Lucian Branescu
On 23 May 2011 17:46, Rafael Ortiz wrote: > > > On Mon, May 23, 2011 at 11:28 AM, Lucian Branescu > wrote: >> >> I gave you commit and review rights. Feel free to commit the two >> patches yourself, removing me as a bottleneck. >> > > Ok Thanks Lucian, about new releases, are you available to do

Re: [Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-23 Thread Rafael Ortiz
On Mon, May 23, 2011 at 11:28 AM, Lucian Branescu wrote: > I gave you commit and review rights. Feel free to commit the two > patches yourself, removing me as a bottleneck. > > Ok Thanks Lucian, about new releases, are you available to do so ? or should I ? ;). > On 23 May 2011 17:14, Lucian

Re: [Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-23 Thread Lucian Branescu
I gave you commit and review rights. Feel free to commit the two patches yourself, removing me as a bottleneck. On 23 May 2011 17:14, Lucian Branescu wrote: > Looks good, although it'd be nice at some point for Sugar itself to > manage force closes better. > > Wouldn't it be better if I gave you

Re: [Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-23 Thread Lucian Branescu
Looks good, although it'd be nice at some point for Sugar itself to manage force closes better. Wouldn't it be better if I gave you commit rights on mainline instead? On 23 May 2011 16:30, Rafael Ortiz wrote: > > > On Sat, May 21, 2011 at 10:24 AM, Sascha Silbe > wrote: >> >> sugar.activity.act

Re: [Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-23 Thread Rafael Ortiz
On Sat, May 21, 2011 at 10:24 AM, Sascha Silbe wrote: > sugar.activity.activity.Activity.close() doesn't take a force parameter. > Instead we need to make sure can_close() returns True the next time and > call > close() without parameters. > > The user-visible effect was that they needed to use St

[Sugar-devel] [PATCH Browse 1/2] Fix Stopping if downloads are in progress

2011-05-21 Thread Sascha Silbe
sugar.activity.activity.Activity.close() doesn't take a force parameter. Instead we need to make sure can_close() returns True the next time and call close() without parameters. The user-visible effect was that they needed to use Stop twice (once to stop the pending downloads and a second time to