Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-27 Thread Manuel Kaufmann
On Mon, Mar 26, 2012 at 14:59, Sascha Silbe wrote: > The first argument to the log. family of functions is a format > string. If you wish to log the value of some variable, you should use > %s or %r in the format string and pass the variable as second+ parameter: > >                log.debug('even

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-26 Thread Rafael Ortiz
On Mon, Mar 26, 2012 at 1:16 PM, Manuel Kaufmann wrote: > On Mon, Mar 26, 2012 at 14:59, Sascha Silbe > wrote: > > First of all, thanks for the patch! Your help is very welcome. > > > > Disclaimer: I'm neither the maintainer of Maze nor a regular > > contributor to it. My opinions and advice may

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-26 Thread Manuel Kaufmann
On Mon, Mar 26, 2012 at 14:59, Sascha Silbe wrote: > First of all, thanks for the patch! Your help is very welcome. > > Disclaimer: I'm neither the maintainer of Maze nor a regular > contributor to it. My opinions and advice may differ from what you > need to do to get your patch accepted by the M

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-26 Thread Sascha Silbe
Excerpts from Manuel Kaufmann's message of 2012-03-21 02:52:54 +0100: First of all, thanks for the patch! Your help is very welcome. Disclaimer: I'm neither the maintainer of Maze nor a regular contributor to it. My opinions and advice may differ from what you need to do to get your patch accept

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-21 Thread Rafael Ortiz
On Wed, Mar 21, 2012 at 5:27 PM, James Cameron wrote: > On Tue, Mar 20, 2012 at 10:52:54PM -0300, Manuel Kaufmann wrote: > > Ability to 'save' (when the user closes the Activity) and 'restore' > (when the > > user launch it from the Journal or the Home without holding Alt) the > state of > > the

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-21 Thread James Cameron
On Tue, Mar 20, 2012 at 10:52:54PM -0300, Manuel Kaufmann wrote: > Ability to 'save' (when the user closes the Activity) and 'restore' (when the > user launch it from the Journal or the Home without holding Alt) the state of > the game. > > For this ability I had to upgrade 'olpcgames' to 1.6 beca

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-21 Thread Gonzalo Odiard
The maintainer have the last word. It's ok if you coordinate with him. Gonzalo On Wed, Mar 21, 2012 at 8:15 AM, Manuel Kaufmann wrote: > On Wed, Mar 21, 2012 at 07:37, Gonzalo Odiard wrote: > > Rafael is the maintainer, but may be for clarity is better do two > patches, > > one upgrading olpcg

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-21 Thread Manuel Kaufmann
On Wed, Mar 21, 2012 at 07:37, Gonzalo Odiard wrote: > Rafael is the maintainer, but may be for clarity is better do two patches, > one upgrading olpcgames and other doing the changes to save/restore the > state. I can do you it if you want. Yesterday I chat with Rafael on IRC and he didn't menti

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-21 Thread Manuel Kaufmann
On Wed, Mar 21, 2012 at 07:37, Gonzalo Odiard wrote: > Question: I don't know pygame, why can't be used the standard > read_file/write_file methods in the activity? Because of the way that PyGame works. The class that handle the game don't inheritance from Activity, so read_file/write_file are no

Re: [Sugar-devel] [PATCH Maze 4/4] Save and restore state of the game

2012-03-21 Thread Gonzalo Odiard
Wow, this is a big change. Rafael is the maintainer, but may be for clarity is better do two patches, one upgrading olpcgames and other doing the changes to save/restore the state. Question: I don't know pygame, why can't be used the standard read_file/write_file methods in the activity? Gonzalo _