On Wed, Jun 27, 2012 at 12:46:00AM -0300, Agustin Zubiaga Sanchez wrote:
> Ok, In this message I send my patch again but without this line.
Reviewed-by: James Cameron
(Also tested that it applies cleanly to master).
--
James Cameron
http://quozl.linux.org.au/
__
Ok, In this message I send my patch again but without this line.
Regards,
aguz
2012/6/27 James Cameron
> On Wed, Jun 27, 2012 at 12:19:55AM -0300, Agustin Zubiaga Sanchez wrote:
> > sorry, I didn't want to do it.
> > Can you remove it?
>
> No, not me.
>
> This brings up an interesting process q
On Wed, Jun 27, 2012 at 12:19:55AM -0300, Agustin Zubiaga Sanchez wrote:
> sorry, I didn't want to do it.
> Can you remove it?
No, not me.
This brings up an interesting process question. If I was a committer,
I would modify and apply the patch. You would then have to merge the
conflict.
Howeve
Hi, James
sorry, I didn't want to do it.
Can you remove it?
2012/6/27 Rafael Ortiz
>
>
> On Tue, Jun 26, 2012 at 9:20 PM, James Cameron wrote:
>
>> Thanks for the patch. I have review comments for one change:
>>
>> On Tue, Jun 26, 2012 at 10:53:57PM -0300, Agustin Zubiaga wrote:
>> > [...]
>>
On Tue, Jun 26, 2012 at 9:20 PM, James Cameron wrote:
> Thanks for the patch. I have review comments for one change:
>
> On Tue, Jun 26, 2012 at 10:53:57PM -0300, Agustin Zubiaga wrote:
> > [...]
> > diff --git a/readtopbar.py b/readtopbar.py
> > index d0da3d0..b6fe196 100644
> > --- a/readtopba
Thanks for the patch. I have review comments for one change:
On Tue, Jun 26, 2012 at 10:53:57PM -0300, Agustin Zubiaga wrote:
> [...]
> diff --git a/readtopbar.py b/readtopbar.py
> index d0da3d0..b6fe196 100644
> --- a/readtopbar.py
> +++ b/readtopbar.py
> @@ -33,15 +33,16 @@ _UP_DEVICE_IFACE = '
Signed-off-by: Agustin Zubiaga
---
epubview/epubview.py |9 +
readactivity.py | 11 +++
readdialog.py| 11 +++
readsidebar.py |6 --
readtoolbar.py |3 ++-
readtopbar.py|5 +++--
sugarmenuitem.py |5 +++--
7
7 matches
Mail list logo
