Re: [Sugar-devel] [PATCH sugar] Allow to build outside the source directory

2012-08-07 Thread Simon Schampijer
On 06/26/2012 02:26 PM, Daniel Narvaez wrote: From: Daniel Narvaez This is based on a patch by Marco Pesenti Gritti , with reviewer comments addressed. Hi Daniel, thanks for following up on this! I pushed now all of them, hope it will ease your work now. Keep up the good work, Simon _

Re: [Sugar-devel] [PATCH sugar] Allow to build outside the source directory

2012-07-03 Thread Daniel Narvaez
Could a maintainer take a look please? It has been reviewed a few times now :) ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar] Allow to build outside the source directory

2012-06-27 Thread James Cameron
On Wed, Jun 27, 2012 at 10:45:13AM +0200, Daniel Narvaez wrote: > On 27 June 2012 02:42, James Cameron wrote: > >> diff --git a/autogen.sh b/autogen.sh > >> index a71e202..bac5247 100755 > >> --- a/autogen.sh > >> +++ b/autogen.sh > >> @@ -1,4 +1,13 @@ > >> ?#!/bin/sh > >> + > >> +test -n "${srcdi

Re: [Sugar-devel] [PATCH sugar] Allow to build outside the source directory

2012-06-27 Thread Daniel Narvaez
On 27 June 2012 02:42, James Cameron wrote: >> diff --git a/autogen.sh b/autogen.sh >> index a71e202..bac5247 100755 >> --- a/autogen.sh >> +++ b/autogen.sh >> @@ -1,4 +1,13 @@ >>  #!/bin/sh >> + >> +test -n "${srcdir}" || srcdir=`dirname "$0"` >> +test -n "${srcdir}" || srcdir="$(pwd)" > > I don'

Re: [Sugar-devel] [PATCH sugar] Allow to build outside the source directory

2012-06-26 Thread James Cameron
On Tue, Jun 26, 2012 at 02:26:02PM +0200, Daniel Narvaez wrote: > From: Daniel Narvaez > > This is based on a patch by > Marco Pesenti Gritti , > with reviewer comments addressed. > --- > autogen.sh | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/autogen.s

[Sugar-devel] [PATCH sugar] Allow to build outside the source directory

2012-06-26 Thread Daniel Narvaez
From: Daniel Narvaez This is based on a patch by Marco Pesenti Gritti , with reviewer comments addressed. --- autogen.sh | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index a71e202..bac5247 100755 --- a/autogen.sh +++ b/autogen.sh @@ -1