[Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-16 Thread Simon Schampijer
Signed-off-by: Simon Schampijer --- src/jarabe/model/neighborhood.py | 22 +- 1 files changed, 17 insertions(+), 5 deletions(-) diff --git a/src/jarabe/model/neighborhood.py b/src/jarabe/model/neighborhood.py index aef03b8..1394f44 100644 --- a/src/jarabe/model/neighborhood

[Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-23 Thread Simon Schampijer
When we update the nick name we need to update the information saved by the telepathy account manager. This does fix the complete update of the salut account information. Signed-off-by: Simon Schampijer --- src/jarabe/model/neighborhood.py | 41 +- 1 files c

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-22 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 16 18:57:17 +0100 2011: > Signed-off-by: Simon Schampijer As usual I'm missing some kind of explanation on the background (why UpdateParameters is needed etc.). :) [src/jarabe/model/neighborhood.py] > @@ -812,10 +812,22 @@ class Neighborhood(

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-23 Thread Simon Schampijer
On 03/22/2011 03:45 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Wed Mar 16 18:57:17 +0100 2011: Signed-off-by: Simon Schampijer As usual I'm missing some kind of explanation on the background (why UpdateParameters is needed etc.). :) I did put a bit more info in the

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011: What message is <300298237-10204-1-git-send-email-si...@schampijer.de>? It never arrived here. And why did both Gonzalo and you make your (unrelated) patches a reply to it? This is really confusing. Please use --in-reply

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Simon Schampijer
On 03/24/2011 08:18 AM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011: What message is<300298237-10204-1-git-send-email-si...@schampijer.de>? It never arrived here. And why did both Gonzalo and you make your (unrelated) patches a reply to it? Thi

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-24 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Thu Mar 24 15:01:44 +0100 2011: > http://lists.sugarlabs.org/archive/sugar-devel/2011-March/030439.html > This is the message, so that looks right to me. Ah, looks like a copy & paste error: Message-ID: 1300298237-10204-1-git-send-email-si...@schampije

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-29 Thread Simon Schampijer
Sascha, in the '--in-reply-to' conversation this might have been falling of the crack :) At least was not part of the great review replies I found in my inbox this morning. Cheers, Simon On 03/23/2011 10:56 AM, Simon Schampijer wrote: When we update the nick name we need to update the inf

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-31 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011: [src/jarabe/model/neighborhood.py] > +params_needing_reconnect = account.UpdateParameters( > +{'server': server, > + 'account': account_id, > + 'register': True}, > +

Re: [Sugar-devel] [PATCH sugar] Fully update the salut account information when the nick name changes #10749

2011-03-31 Thread Simon Schampijer
On 03/31/2011 08:27 AM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of Wed Mar 23 15:56:54 +0100 2011: [src/jarabe/model/neighborhood.py] +params_needing_reconnect = account.UpdateParameters( +{'server': server, + 'account': account_id, +