Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)

2010-10-14 Thread Dipankar Patro
Glad I could clarify my modifications. :) I will send the corrected e-mail as soon as possible. On Thu, Oct 14, 2010 at 4:29 AM, James Cameron wrote: > On Wed, Oct 13, 2010 at 04:31:00PM +0530, Dipankar Patro wrote: > > Thanks for reviewing it, James. > > Sorry, it was late, and I misunderstood

Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)

2010-10-13 Thread James Cameron
On Wed, Oct 13, 2010 at 04:31:00PM +0530, Dipankar Patro wrote: > Thanks for reviewing it, James. Sorry, it was late, and I misunderstood the code you had written ... I withdraw my comment "You are effectively repeating the previous if statement but using the output ... seems a bit obscure." Apar

Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)

2010-10-13 Thread Dipankar Patro
Thanks for reviewing it, James. if have_ofw_tree(): >sn = read_ofw('mfg-data/SN') >uuid_ = read_ofw('mfg-data/U#') >sn = sn or 'SHF' >uuid_ = uuid_ or '----' > > > else: > > sn = generate_serial_number() > >

Re: [Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)

2010-10-13 Thread James Cameron
On Wed, Oct 13, 2010 at 03:53:22PM +0530, Dipankar Patro wrote: > Previously registration url was set hardcoded for XO device. > Modififed the code for same behavior on all devices. Register url is taken > from gconf prop. > If the gconf is empty or unset, registration url falls back to 'schoolser

[Sugar-devel] [PATCH sugar] Removed hardcoded server url (SL #1976)

2010-10-13 Thread Dipankar Patro
Previously registration url was set hardcoded for XO device. Modififed the code for same behavior on all devices. Register url is taken from gconf prop. If the gconf is empty or unset, registration url falls back to 'schoolserver'. --- src/jarabe/desktop/schoolserver.py |9 ++--- 1 files