Re: [Sugar-devel] [PATCH sugar-toolkit] bundlebuilder: refactor get_files_git to Packager to avoid code duplication

2011-09-28 Thread Simon Schampijer
On 09/26/2011 03:10 PM, Sascha Silbe wrote: Excerpts from Simon Schampijer's message of 2011-09-19 19:12:39 +0200: Follow up patch for b582736375218e8944b3ce3daac667c7910a7e73 Thanks for the patch! Acked-By: Sascha Silbe Sascha Thanks Daniel and Sascha for the review, pushed as: 37568a0

Re: [Sugar-devel] [PATCH sugar-toolkit] bundlebuilder: refactor get_files_git to Packager to avoid code duplication

2011-09-26 Thread Sascha Silbe
Excerpts from Simon Schampijer's message of 2011-09-19 19:12:39 +0200: > Follow up patch for b582736375218e8944b3ce3daac667c7910a7e73 Thanks for the patch! Acked-By: Sascha Silbe Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: PGP signature

Re: [Sugar-devel] [PATCH sugar-toolkit] bundlebuilder: refactor get_files_git to Packager to avoid code duplication

2011-09-19 Thread Daniel Drake
On Mon, Sep 19, 2011 at 6:12 PM, Simon Schampijer wrote: > Follow up patch for b582736375218e8944b3ce3daac667c7910a7e73 > > Signed-off-by: Simon Schampijer Reviewed, looks good to me - exactly what I was thinking. Thanks Daniel ___ Sugar-devel mailing

[Sugar-devel] [PATCH sugar-toolkit] bundlebuilder: refactor get_files_git to Packager to avoid code duplication

2011-09-19 Thread Simon Schampijer
Follow up patch for b582736375218e8944b3ce3daac667c7910a7e73 Signed-off-by: Simon Schampijer --- src/sugar/activity/bundlebuilder.py | 40 -- 1 files changed, 14 insertions(+), 26 deletions(-) diff --git a/src/sugar/activity/bundlebuilder.py b/src/sugar/activi