Re: [Sugar-devel] [PATCH toolkit-gtk3 1/2] Add new PaletteMenuItem widget for usage in mixed content Palettes

2012-09-13 Thread Simon Schampijer
On 09/13/2012 05:40 PM, Manuel Quiñones wrote: Thanks a lot Simon. Yes I think this is the right approach. The only things I see are: - a trailing whitespace that gives a warning when applied. - add "Sugar" prefix to the type name of PaletteMenuItem Fixed up and pushed. We can pretty the sty

Re: [Sugar-devel] [PATCH toolkit-gtk3 1/2] Add new PaletteMenuItem widget for usage in mixed content Palettes

2012-09-13 Thread Manuel Quiñones
Thanks a lot Simon. Yes I think this is the right approach. The only things I see are: - a trailing whitespace that gives a warning when applied. - add "Sugar" prefix to the type name of PaletteMenuItem 2012/9/13 Simon Schampijer : > From: Simon Schampijer > > As Palettes can either include a

[Sugar-devel] [PATCH toolkit-gtk3 1/2] Add new PaletteMenuItem widget for usage in mixed content Palettes

2012-09-13 Thread Simon Schampijer
From: Simon Schampijer As Palettes can either include a Gtk.Menu or a Gtk.Window we have to use a "false" menu when we want to have both functionality in a Palette. This is a new class PaletteMenuItem for those use cases. Code highly based on the work from Gonzalo Odiard. The API is based on the