[Sugar-devel] [read PATCH] sdxo#4448: Revert back to the earlier behaviour, of re-computing filehash every time when needed.

2013-02-28 Thread Ajay Garg
This reverts commit 21af7cc988320c8a53c946253d52fe1bb6ff9a7e. Thankfully, we do not lose anything, as the commit 21af7cc988320c8a53c946253d52fe1bb6ff9a7e was just an "optimisation"-commit; we don't lose anything on the frontend/backend/anywhere :) readactivity.py| 10 ++ 1 files

Re: [Sugar-devel] [read PATCH] sdxo#4448: Revert back to the earlier behaviour, of re-computing filehash every time when needed.

2013-02-28 Thread Gonzalo Odiard
How is this related with collaboration? Gonzalo On Thu, Feb 28, 2013 at 12:23 PM, Ajay Garg wrote: > This reverts commit 21af7cc988320c8a53c946253d52fe1bb6ff9a7e. > > Thankfully, we do not lose anything, as the commit > 21af7cc988320c8a53c946253d52fe1bb6ff9a7e was just an "optimisation"-commit;

Re: [Sugar-devel] [read PATCH] sdxo#4448: Revert back to the earlier behaviour, of re-computing filehash every time when needed.

2013-02-28 Thread Gonzalo Odiard
Hmm, may be I misreaded. What is trying to solve this patch? Gonzalo On Thu, Feb 28, 2013 at 1:01 PM, Gonzalo Odiard wrote: > How is this related with collaboration? > > Gonzalo > > > On Thu, Feb 28, 2013 at 12:23 PM, Ajay Garg wrote: > >> This reverts commit 21af7cc988320c8a53c946253d52fe1bb6f

Re: [Sugar-devel] [read PATCH] sdxo#4448: Revert back to the earlier behaviour, of re-computing filehash every time when needed.

2013-02-28 Thread Ajay Garg
Hi Gonzalo. 1) XO-A shares a document. 2) XO-B joins the activity. 3) Now, at XO-B, there is a call to "write_file" for the "just-loaded" document; however, the "self.filehash" being None, fails to save. There are also other issues with "self.filehash" as part of sharing-wokflows. On Thu, Feb

Re: [Sugar-devel] [read PATCH] sdxo#4448: Revert back to the earlier behaviour, of re-computing filehash every time when needed.

2013-02-28 Thread Gonzalo Odiard
In the ticket I have attached a alternative solution. If you can confirm is working for you should be nice. Gonzalo On Thu, Feb 28, 2013 at 1:05 PM, Ajay Garg wrote: > Hi Gonzalo. > > 1) > XO-A shares a document. > > 2) > XO-B joins the activity. > > 3) > Now, at XO-B, there is a call to "write