[Sugar-devel] Acked-by vs Reviewed-by

Hi, it seems that most of our patches should have a Reviewed-by tag, on the contrary I see Acked-by used most of the time (at the top of the sugar-toolkit-gtk3 log at least). Am I missing something? -- Daniel Narvaez ___ Sugar-devel mailing list Sugar

Re: [Sugar-devel] Acked-by vs Reviewed-by

I think only the maintainer can Ack (and imply a review) and anybody else can add a Reviewed-by Gonzalo On Wed, Apr 3, 2013 at 5:07 PM, Daniel Narvaez wrote: > Hi, > > it seems that most of our patches should have a Reviewed-by tag, on the > contrary I see Acked-by used most of the time (at the

Re: [Sugar-devel] Acked-by vs Reviewed-by

Ok I see how you can read https://www.kernel.org/doc/Documentation/SubmittingPatches that way. Though, man, the whole document feels so unnecessarily complicated and unclear if applied to Sugar. If we keep using these tags I think we should write a simpler explanation which applies to our project.

Re: [Sugar-devel] Acked-by vs Reviewed-by

2013/4/3 Daniel Narvaez : > Ok I see how you can read > https://www.kernel.org/doc/Documentation/SubmittingPatches that way. > > Though, man, the whole document feels so unnecessarily complicated and > unclear if applied to Sugar. If we keep using these tags I think we should > write a simpler expl

Re: [Sugar-devel] Acked-by vs Reviewed-by

On Wed, Apr 03, 2013 at 10:07:07PM +0200, Daniel Narvaez wrote: > it seems that most of our patches should have a Reviewed-by tag, on the > contrary I see Acked-by used most of the time (at the top of the > sugar-toolkit-gtk3 log at least). > > Am I missing something? I agree with others; for Glu

Re: [Sugar-devel] Acked-by vs Reviewed-by

So, if I understand this correctly, every Glucose patch should have had an Acked-by tag, since every patch should have been approved by a maintainer according to our review policies. (That has not been the case) On 3 April 2013 23:50, James Cameron wrote: > On Wed, Apr 03, 2013 at 10:07:07PM +0

Re: [Sugar-devel] Acked-by vs Reviewed-by

That's really up to the maintainer. If the maintainer pushes the patch, then Acked-by may be inferred. In general these procedures scale well to large numbers of maintainers, contributors, and reviewers. I'm not sure they remain appropriate for Sugar given the size of the community at the moment

Re: [Sugar-devel] Acked-by vs Reviewed-by

2013/4/3 James Cameron : > That's really up to the maintainer. If the maintainer pushes the > patch, then Acked-by may be inferred. > > In general these procedures scale well to large numbers of > maintainers, contributors, and reviewers. I'm not sure they remain > appropriate for Sugar given the

Re: [Sugar-devel] Acked-by vs Reviewed-by

On 4 April 2013 19:02, Manuel Quiñones wrote: > 2013/4/3 James Cameron : > > That's really up to the maintainer. If the maintainer pushes the > > patch, then Acked-by may be inferred. > > > > In general these procedures scale well to large numbers of > > maintainers, contributors, and reviewers.