Re: [Sugar-devel] Change request: Fix open with API

2015-07-03 Thread Gonzalo Odiard
Ok, I will do. Thanks all for the review and comments. Gonzalo On Fri, Jul 3, 2015 at 2:55 PM, Martin Abente < martin.abente.lah...@gmail.com> wrote: > Considering that James, Sam and I have reviewed and tested these changes, > the consensus is to include them to fix the API. Therefore, Gonzalo

Re: [Sugar-devel] Change request: Fix open with API

2015-07-03 Thread Martin Abente
Considering that James, Sam and I have reviewed and tested these changes, the consensus is to include them to fix the API. Therefore, Gonzalo has green light for merge. On Fri, Jul 3, 2015 at 5:41 AM, Tony Anderson wrote: > Thanks James and Sam for your replies. > > The references to Rainbow Se

Re: [Sugar-devel] Change request: Fix open with API

2015-07-03 Thread Tony Anderson
Thanks James and Sam for your replies. The references to Rainbow Security model are a bit confusing. The Rainbow model was dropped by the second G1G1 as I recollect. As far as I can tell, Browse launches child processes (pdfviewer). These typically are represented in the frame by a grey circle

Re: [Sugar-devel] Change request: Fix open with API

2015-07-03 Thread Sam P.
Hi Tony, I think you have misunderstood the capabilities of the api. The api does not support launching with uris (which is something to look into for 108) or "activity ids". The api supports bundle ids (open a new terminal activity) and object ids (open this memorize set). This allows for many

Re: [Sugar-devel] Change request: Fix open with API

2015-07-02 Thread James Cameron
On Fri, Jul 03, 2015 at 07:14:47AM +0200, Tony Anderson wrote: > As I understand it, the release of 0.106 is to be made on Monday. Yes. > This does not seem to warrant a delay in that release. This is maintainer Martin's decision that you're offering your opinion on, but I'll offer a countering

Re: [Sugar-devel] Change request: Fix open with API

2015-07-02 Thread Tony Anderson
As I understand it, the release of 0.106 is to be made on Monday. This does not seem to warrant a delay in that release. Moving a capability from sugar or sugar3 to the toolkit doesn't imply a visible change to the api as seen by an activity developer. I don't understand the assumption that do

Re: [Sugar-devel] Change request: Fix open with API

2015-07-02 Thread Martin Abente
Hello Gonzalo, To me this is basically a new feature, in terms of how it does impact sugar (adding new method to the activity class and adding a new dbus endpoint to the shell). It breaks feature, API and code freezes. I believe the change is kind of sensible considering what it does and speciall

[Sugar-devel] Change request: Fix open with API

2015-07-02 Thread Gonzalo Odiard
I found a problem in the implementation of "Start_activity_from_another_activity" feature [1] Usually, when the programmer want start one activity from another, need display in the user interface information about the activity, like the name or the icon. One example of the use is in Browse activity