Re: [Sugar-devel] Reg.: Ticket 1429

2014-12-16 Thread Walter Bender
Of course, where we want to override the default we can, but defining the default in the toolkit can only help lead to more consistency. Glad this is landing. On Tue, Dec 16, 2014 at 11:36 AM, Gonzalo Odiard wrote: > Ok Goutam, > Looks like there are consensus. > Could you add a constant in style

Re: [Sugar-devel] Reg.: Ticket 1429

2014-12-16 Thread Gonzalo Odiard
Ok Goutam, Looks like there are consensus. Could you add a constant in style.py like ELLIPSIZE_MODE_DEFAULT = Pango.EllipsizeMode.END and replace the use of the gtk constants in sugar-tookit-gtk3 and sugar? Gonzalo On Tue, Dec 16, 2014 at 1:05 PM, Martin Abente < martin.abente.lah...@gmail.com>

Re: [Sugar-devel] Reg.: Ticket 1429

2014-12-16 Thread Martin Abente
There might be cases where a particular ellipse fits better, but I personally would prefer a general consistency. As Gonzalo mentioned, we don't rely on file extensions, so END would be fitter choice. On Mon, Dec 15, 2014 at 6:14 PM, Walter Bender wrote: > > I am happy with defaulting to END but

Re: [Sugar-devel] Reg.: Ticket 1429

2014-12-15 Thread Walter Bender
I am happy with defaulting to END but I think we should define a constant in style.py. -walter On Mon, Dec 15, 2014 at 2:49 PM, Gonzalo Odiard wrote: > Hello, > Thanks for working on this issue. > > I think we should use Pango.EllipsizeMode.END always to be consistent. > In particular, when the

Re: [Sugar-devel] Reg.: Ticket 1429

2014-12-15 Thread Gonzalo Odiard
Hello, Thanks for working on this issue. I think we should use Pango.EllipsizeMode.END always to be consistent. In particular, when the text is short, like in the palettes, ellipsize MIDDLE does not provide a good output. Also, we do a ellipsize "by hand" in multiple lines in the secondary text on

[Sugar-devel] Reg.: Ticket 1429

2014-12-15 Thread Goutam Nair
Hey all, For this bug http://bugs.sugarlabs.org/ticket/1429, when the cursor hovers over the activity icon the ellipses are in the middle when it is supposed to be at the end. So, in order to fix that, should I have to change this file as well: sugar3/graphics/palette.py on line 143? Thanks Gout