[Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-01 Thread Martin Abente
Hello Sam, Different people reported an error while building sugar-artwork packages. The error is caused by this commit [1] which makes GTK a building requirement for sugar-artwork, but: a) if GTK version version is really used on building time, then the approach used in [1] is wrong, because the

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-01 Thread Martin Abente
>From the tests I have done, I confirmed it is used in building time, therefore I have reverted the patch until we can determine a better solution. On Wed, Jul 1, 2015 at 12:05 PM, Martin Abente < martin.abente.lah...@gmail.com> wrote: > Hello Sam, > > Different people reported an error while bui

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-01 Thread Gonzalo Odiard
Sam, I don't have rawhide installed to test, can you try adding rules for the two new and old ways, like here: diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em index 67e4e48..d14bbfb 100644 --- a/gtk3/theme/gtk-widgets.css.em +++ b/gtk3/theme/gtk-widgets.css.em @@ -221,10

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-01 Thread Gonzalo Odiard
If that don't work, should be good test: diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em index 67e4e48..af87900 100644 --- a/gtk3/theme/gtk-widgets.css.em +++ b/gtk3/theme/gtk-widgets.css.em @@ -221,9 +221,18 @@ column-header .button:hover:active { border-width: 0px

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-02 Thread Sam P.
Hi Gonzalo, Testing without your patch it appears that the journal background didn't get broken - so most of the breakage must have been fixed later in the Gtk+ 3.17 cycle! Using your patch (the 1st one), it fixes the log tree view and the journal still works fine. I will send a patch. Next tim

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-02 Thread Gonzalo Odiard
Great! On Thu, Jul 2, 2015 at 7:05 AM, Sam P. wrote: > Hi Gonzalo, > > Testing without your patch it appears that the journal background didn't > get broken - so most of the breakage must have been fixed later in the Gtk+ > 3.17 cycle! > > Using your patch (the 1st one), it fixes the log tree vi

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-02 Thread Sam P.
Patch: https://github.com/sugarlabs/sugar-artwork/pull/67 On Thu, Jul 2, 2015 at 9:15 PM Gonzalo Odiard wrote: > Great! > > On Thu, Jul 2, 2015 at 7:05 AM, Sam P. wrote: > >> Hi Gonzalo, >> >> Testing without your patch it appears that the journal background didn't >> get broken - so most of t

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-02 Thread Gonzalo Odiard
Martin, Are you ok with this new patch? Gonzalo On Thu, Jul 2, 2015 at 8:22 AM, Sam P. wrote: > Patch: https://github.com/sugarlabs/sugar-artwork/pull/67 > > On Thu, Jul 2, 2015 at 9:15 PM Gonzalo Odiard > wrote: > >> Great! >> >> On Thu, Jul 2, 2015 at 7:05 AM, Sam P. wrote: >> >>> Hi Gonza

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-02 Thread Martin Abente
Will check today! Thanks Gonzalo and Sam! On Thu, Jul 2, 2015 at 7:29 AM, Gonzalo Odiard wrote: > Martin, > Are you ok with this new patch? > > Gonzalo > > On Thu, Jul 2, 2015 at 8:22 AM, Sam P. wrote: > >> Patch: https://github.com/sugarlabs/sugar-artwork/pull/67 >> >> On Thu, Jul 2, 2015 at

Re: [Sugar-devel] adding gtk as a dependency on sugar-artwork

2015-07-02 Thread Martin Abente
Hello Sam, Gonzalo, Now the new patch breaks it for Ubuntu 14.04, so I sent a new PR [1] which doesn't break it (see my patch comment), please check it that works in newer Fedora versions. Regards, Martin. Refs: 1. https://github.com/sugarlabs/sugar-artwork/pull/68 On Thu, Jul 2, 2015 at 9:01 A