Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Walter Bender
On Tue, Mar 26, 2013 at 5:28 PM, Daniel Narvaez dwnarv...@gmail.com wrote: Some initial comments on 0001 I've renamed this thread to be specific to 0001, which is adding a comments field to the journal expanded entry. Thanks for the review. * Did you post screenshots of this so that we can

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Daniel Narvaez
Hi, would you mind to submit these as a pull request of https://github.com/sugarlabs/sugar As discussed in another thread I would like to give github workflow a try. I will of course push the changes back to the official repo then. On 28 March 2013 14:26, Walter Bender walter.ben...@gmail.com

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Walter Bender
On Thu, Mar 28, 2013 at 10:03 AM, Daniel Narvaez dwnarv...@gmail.com wrote: Hi, would you mind to submit these as a pull request of https://github.com/sugarlabs/sugar As discussed in another thread I would like to give github workflow a try. I will of course push the changes back to the

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Walter Bender
On Thu, Mar 28, 2013 at 10:34 AM, Walter Bender walter.ben...@gmail.com wrote: On Thu, Mar 28, 2013 at 10:03 AM, Daniel Narvaez dwnarv...@gmail.com wrote: Hi, would you mind to submit these as a pull request of https://github.com/sugarlabs/sugar As discussed in another thread I would like

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Walter Bender
A couple of problems on github (I may be doing things wrong): 1. No pull request shows up on my dashboard even though I seeming successfully submitted one. How do I confirm it was received? 2. It is generated, because when I try to submit a second pull request from the same fork for a different

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Walter Bender
On Thu, Mar 28, 2013 at 10:53 AM, Walter Bender walter.ben...@gmail.com wrote: A couple of problems on github (I may be doing things wrong): 1. No pull request shows up on my dashboard even though I seeming successfully submitted one. How do I confirm it was received? Never mind. I was

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Daniel Narvaez
I have not tried to push multiple requests myself yet so I can't be of much help. Quick googling seems to indicate that selecting specific commits might be possible but complicated... It think using one branch per patchset would be good practice anyway. On Thursday, 28 March 2013, Walter Bender

Re: [Sugar-devel] journal comments field patch (again)

2013-03-28 Thread Walter Bender
On Thu, Mar 28, 2013 at 11:34 AM, Daniel Narvaez dwnarv...@gmail.com wrote: I have not tried to push multiple requests myself yet so I can't be of much help. Quick googling seems to indicate that selecting specific commits might be possible but complicated... It think using one branch per