Re: [Suspend-devel] use pm_ops->{prepare, enter, finish} aka platform mode in userspace

2006-09-25 Thread Pavel Machek
Hi! > > Note that we could get rid of that platform_mode variable if we had the > > possibility to specify defaults in the struct config_par (without resorting > > to platform_mode i would have had multiple incarnations of > > > > if (strcmp(shutdown_method, "reboot") || strcmp(shutdown_method,

Re: [Suspend-devel] [PATCH] make shutdown method configurable

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 09:42, Stefan Seyfried wrote: > On Mon, Sep 25, 2006 at 09:18:16AM +0200, Rafael J. Wysocki wrote: > > On Monday, 25 September 2006 08:32, Stefan Seyfried wrote: > > > On Sun, Sep 24, 2006 at 10:09:44AM +0200, Pavel Machek wrote: > > > > Hi! > > > > > > > > > Make it p

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 16:51, Luca Tettamanti wrote: > On 9/25/06, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > > On Monday, 25 September 2006 10:40, Pavel Machek wrote: > > > So let's do: > > > > > > before suspend, swap header says "this is swapspace" > > > suspend image is written, heade

Re: [Suspend-devel] use pm_ops->{prepare, enter, finish} aka platform mode in userspace

2006-09-25 Thread Stefan Seyfried
On Mon, Sep 25, 2006 at 06:50:17PM +0200, Stefan Seyfried wrote: > Note that we could get rid of that platform_mode variable if we had the > possibility to specify defaults in the struct config_par (without resorting > to platform_mode i would have had multiple incarnations of > > if (strcmp(sh

Re: [Suspend-devel] [PATCH 1/2] print s2disk benchmarks during resume

2006-09-25 Thread Stefan Seyfried
On Mon, Sep 25, 2006 at 11:41:29AM -0400, Jason Lunz wrote: > On Mon, Sep 25, 2006 at 08:22:09AM +0200, Stefan Seyfried wrote: > > - What happens if i suspend with a "timing enabled" s2disk and resume with a > > "pre-timing-enabled" resume? (Somebody updates the package but forgets to > > run m

[Suspend-devel] use pm_ops->{prepare, enter, finish} aka platform mode in userspace

2006-09-25 Thread Stefan Seyfried
Hi, following the submission of the kernel patch, here is my try at an implementation in userspace: Note that we could get rid of that platform_mode variable if we had the possibility to specify defaults in the struct config_par (without resorting to platform_mode i would have had multiple incarn

Re: [Suspend-devel] [PATCH 1/2] print s2disk benchmarks during resume

2006-09-25 Thread Jason Lunz
On Mon, Sep 25, 2006 at 08:22:09AM +0200, Stefan Seyfried wrote: > - What happens if i suspend with a "timing enabled" s2disk and resume with a > "pre-timing-enabled" resume? (Somebody updates the package but forgets to > run mkinitrd). > Will it just fail (invalid header) or will it cause tota

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Luca Tettamanti
On 9/25/06, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > On Monday, 25 September 2006 10:40, Pavel Machek wrote: > > So let's do: > > > > before suspend, swap header says "this is swapspace" > > suspend image is written, header says "this is image, suspend time was > > 5 seconds" > > then comes p

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 10:40, Pavel Machek wrote: > Hi! > > > > > > If you want to do it _right_, write timing info onto disk, then read > > > > > it from there. That will not slow the user down, while still telling > > > > > them nice statistics when resume is done. Hmmm? > > > > > > > > w

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Pavel Machek
Hi! > > > > If you want to do it _right_, write timing info onto disk, then read > > > > it from there. That will not slow the user down, while still telling > > > > them nice statistics when resume is done. Hmmm? > > > > > > where? there's no fs mounted. Is there a place to put it in the swap >

Re: [Suspend-devel] [PATCH] make shutdown method configurable

2006-09-25 Thread Stefan Seyfried
On Mon, Sep 25, 2006 at 09:18:16AM +0200, Rafael J. Wysocki wrote: > On Monday, 25 September 2006 08:32, Stefan Seyfried wrote: > > On Sun, Sep 24, 2006 at 10:09:44AM +0200, Pavel Machek wrote: > > > Hi! > > > > > > > Make it possible to set the s2disk shutdown method in the config > > > > file. >

Re: [Suspend-devel] s2ram

2006-09-25 Thread Stefan Seyfried
On Fri, Sep 22, 2006 at 09:09:44PM +0200, Carl-Daniel Hailfinger wrote: > Stefan: > Maybe s2ram should trigger an informational message if is sees this > card so users of other laptops with the same card have a chance to > get suspend fixed? -ENOPATCH :-) I'm not sure it is worth the effort. I be

Re: [Suspend-devel] uswsusp and /sys/power/disk

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 08:57, Stefan Seyfried wrote: > On Sun, Sep 17, 2006 at 02:30:49PM +0200, Pavel Machek wrote: > > Hi! > > > > > > i finally tested it and it seems to work. > > > > > > no, it didn't. But i fixed it. The placement of platform_finish() is > > > non-intuitive :-) > > >

Re: [Suspend-devel] [PATCH] add optional pause during resume

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 00:18, Pavel Machek wrote: > Hi! > > > > If you want to do it _right_, write timing info onto disk, then read > > > it from there. That will not slow the user down, while still telling > > > them nice statistics when resume is done. Hmmm? > > > > where? there's no fs

Re: [Suspend-devel] [PATCH] make shutdown method configurable

2006-09-25 Thread Rafael J. Wysocki
On Monday, 25 September 2006 08:32, Stefan Seyfried wrote: > On Sun, Sep 24, 2006 at 10:09:44AM +0200, Pavel Machek wrote: > > Hi! > > > > > Make it possible to set the s2disk shutdown method in the config > > > file. > > > > Thanks, applied. > > Now somebody please write a parser that overrides