Re: svn commit: r228616 - head/usr.bin/tar

2011-12-17 Thread Kostik Belousov
On Sat, Dec 17, 2011 at 01:36:51AM +, Dimitry Andric wrote: Author: dim Date: Sat Dec 17 01:36:50 2011 New Revision: 228616 URL: http://svn.freebsd.org/changeset/base/228616 Log: In usr.bin/tar/tree.c, if you really want to poke to NULL, you must use volatile, otherwise the

svn commit: r228621 - in head/sys: dev/an dev/ath dev/bwi dev/bwn dev/if_ndis dev/ipw dev/iwi dev/iwn dev/malo dev/mwl dev/ral dev/usb/wlan dev/wi dev/wpi net80211

2011-12-17 Thread Bernhard Schmidt
Author: bschmidt Date: Sat Dec 17 10:23:17 2011 New Revision: 228621 URL: http://svn.freebsd.org/changeset/base/228621 Log: Fix some net80211 enum nits: - ic_vap_create() uses an ieee80211_opmode argument - ieee80211_rate2media() takes an ieee80211_phymode argument - ieee80211_plcp2rate()

svn commit: r228622 - head/sys/net80211

2011-12-17 Thread Bernhard Schmidt
Author: bschmidt Date: Sat Dec 17 10:32:31 2011 New Revision: 228622 URL: http://svn.freebsd.org/changeset/base/228622 Log: Remove now redundant mac argument. Discussed with: adrian@ Modified: head/sys/net80211/ieee80211_acl.c head/sys/net80211/ieee80211_hostap.c

Re: svn commit: r228621 - in head/sys: dev/an dev/ath dev/bwi dev/bwn dev/if_ndis dev/ipw dev/iwi dev/iwn dev/malo dev/mwl dev/ral dev/usb/wlan dev/wi dev/wpi net80211

2011-12-17 Thread Alexander Best
On Sat Dec 17 11, Bernhard Schmidt wrote: Author: bschmidt Date: Sat Dec 17 10:23:17 2011 New Revision: 228621 URL: http://svn.freebsd.org/changeset/base/228621 Log: Fix some net80211 enum nits: - ic_vap_create() uses an ieee80211_opmode argument - ieee80211_rate2media() takes an

svn commit: r228623 - head/contrib/bsnmp/snmp_mibII

2011-12-17 Thread Bjoern A. Zeeb
Author: bz Date: Sat Dec 17 11:06:22 2011 New Revision: 228623 URL: http://svn.freebsd.org/changeset/base/228623 Log: Adter r228571 unbreak architectures with strict alignment rules by copying rather than casting. Modified: head/contrib/bsnmp/snmp_mibII/mibII.c Modified:

Re: svn commit: r228614 - head/sbin/dhclient

2011-12-17 Thread Joerg Sonnenberger
On Sat, Dec 17, 2011 at 01:19:07AM +, Dimitry Andric wrote: Log: In sbin/dhclient, work around warnings about the size argument to strlcpy appearing to be the size of the source buffer, instead of the destination. If you touch this and don't want to use strdup-like functions, at

Re: svn commit: r228616 - head/usr.bin/tar

2011-12-17 Thread Dimitry Andric
On 2011-12-17 09:33, Kostik Belousov wrote: const char *msg = Unable to continue traversing directory hierarchy after a fatal error.; write(2, msg, strlen(msg)); -*(int *)0 = 1; /* Deliberate SEGV; NULL pointer dereference. */ +

svn commit: r228624 - head/contrib/bzip2

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 12:52:58 2011 New Revision: 228624 URL: http://svn.freebsd.org/changeset/base/228624 Log: In contrib/bzip2/bzip2recover.c, use the correct printf length modifier for unsigned long long. MFC after:1 week Modified: head/contrib/bzip2/bzip2recover.c

svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 13:14:44 2011 New Revision: 228625 URL: http://svn.freebsd.org/changeset/base/228625 Log: In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the shared secret, and use long long format to snprintf a time_t. MFC after:1 week Modified:

svn commit: r228626 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 13:52:53 2011 New Revision: 228626 URL: http://svn.freebsd.org/changeset/base/228626 Log: In usr.bin/csup/proto.c, use the correct printf length modifier to print an off_t. MFC after:1 week Modified: head/usr.bin/csup/proto.c Modified:

svn commit: r228627 - head/contrib/ee

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 14:26:16 2011 New Revision: 228627 URL: http://svn.freebsd.org/changeset/base/228627 Log: In contrib/ee/ee.c, fix a few warnings about format strings not being literals. Also, change the direction argument to move_rel() from char to int; KR function definions

svn commit: r228628 - head/usr.bin/gprof

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 14:37:41 2011 New Revision: 228628 URL: http://svn.freebsd.org/changeset/base/228628 Log: In usr.bin/gprof/aout.c, use the correct printf length modifier for a uint32_t. MFC after:1 week Modified: head/usr.bin/gprof/aout.c Modified:

svn commit: r228629 - head/usr.bin/gprof

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 14:51:24 2011 New Revision: 228629 URL: http://svn.freebsd.org/changeset/base/228629 Log: More fixes for correct printf length modifiers usr.bin/gprof. MFC after:1 week Modified: head/usr.bin/gprof/aout.c head/usr.bin/gprof/arcs.c Modified:

svn commit: r228630 - head/lib/libc/net

2011-12-17 Thread Michael Tuexen
Author: tuexen Date: Sat Dec 17 14:55:19 2011 New Revision: 228630 URL: http://svn.freebsd.org/changeset/base/228630 Log: Address warnings found by clang. MFC after: 3 months. Modified: head/lib/libc/net/sctp_sys_calls.c Modified: head/lib/libc/net/sctp_sys_calls.c

svn commit: r228631 - in head/sys: dev/cfe dev/dcons dev/ofw dev/sio dev/syscons dev/uart dev/usb/serial dev/xen/console gdb ia64/ia64 kern mips/adm5120 pc98/cbus powerpc/mambo sys

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:08:43 2011 New Revision: 228631 URL: http://svn.freebsd.org/changeset/base/228631 Log: kern cons: introduce infrastructure for console grabbing by kernel At the moment grab and ungrab methods of all console drivers are no-ops. Current intended meaning

Re: svn commit: r228435 - in head/libexec/rtld-elf: . amd64 arm i386 ia64 mips powerpc powerpc64 sparc64

2011-12-17 Thread Nathan Whitehorn
This broke PowerPC really, really badly. Basically every dynamically-linked executable dies with an illegal instruction trap. -Nathan On 12/12/11 05:03, Konstantin Belousov wrote: Author: kib Date: Mon Dec 12 11:03:14 2011 New Revision: 228435 URL: http://svn.freebsd.org/changeset/base/228435

svn commit: r228632 - head/sys/kern

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:11:22 2011 New Revision: 228632 URL: http://svn.freebsd.org/changeset/base/228632 Log: introduce cngrab/cnungrab stub calls in some places where they make sense MFC after:2 months Modified: head/sys/kern/kern_cons.c head/sys/kern/kern_shutdown.c

svn commit: r228633 - in head/sys: kern sys

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:16:54 2011 New Revision: 228633 URL: http://svn.freebsd.org/changeset/base/228633 Log: introduce cngets, a method for kernel to read a string from console This is intended as a replacement for libkern's gets and mostly borrows its implementation. It uses

svn commit: r228634 - in head/sys: geom/eli kern

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:26:34 2011 New Revision: 228634 URL: http://svn.freebsd.org/changeset/base/228634 Log: replace uses of libkern gets with cngets MFC after:2 months Modified: head/sys/geom/eli/g_eli.c head/sys/kern/vfs_mountroot.c Modified: head/sys/geom/eli/g_eli.c

Re: svn commit: r228415 - head/sys/dev/e1000

2011-12-17 Thread Bjoern A. Zeeb
On 12. Dec 2011, at 13:08 , Luigi Rizzo wrote: On Sun, Dec 11, 2011 at 06:46:14PM +, Jack F Vogel wrote: Author: jfv Date: Sun Dec 11 18:46:14 2011 New Revision: 228415 URL: http://svn.freebsd.org/changeset/base/228415 Log: Last change still had an issue, one more time... Jack,

Re: svn commit: r228631 - in head/sys: dev/cfe dev/dcons dev/ofw dev/sio dev/syscons dev/uart dev/usb/serial dev/xen/console gdb ia64/ia64 kern mips/adm5120 pc98/cbus powerpc/mambo sys

2011-12-17 Thread Andriy Gapon
on 17/12/2011 17:08 Andriy Gapon said the following: +void +cngrab() +{ + struct cn_device *cnd; + struct consdev *cn; + + STAILQ_FOREACH(cnd, cn_devlist, cnd_next) { + cn = cnd-cnd_cn; + if (!kdb_active || !(cn-cn_flags CN_FLAG_NODEBUG)) +

svn commit: r228635 - head/libexec/rtld-elf/powerpc

2011-12-17 Thread Nathan Whitehorn
Author: nwhitehorn Date: Sat Dec 17 15:31:00 2011 New Revision: 228635 URL: http://svn.freebsd.org/changeset/base/228635 Log: Fix RTLD on PowerPC after r228435. Changing the order of init_pltgot() caused the icache to be invalidated at the wrong time, resulting in an icache full of nonsense

Re: svn commit: r228435 - in head/libexec/rtld-elf: . amd64 arm i386 ia64 mips powerpc powerpc64 sparc64

2011-12-17 Thread Nathan Whitehorn
Fixed in r228635. -Nathan On 12/17/11 09:09, Nathan Whitehorn wrote: This broke PowerPC really, really badly. Basically every dynamically-linked executable dies with an illegal instruction trap. -Nathan On 12/12/11 05:03, Konstantin Belousov wrote: Author: kib Date: Mon Dec 12 11:03:14 2011

svn commit: r228636 - head/usr.bin/hexdump

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 15:33:26 2011 New Revision: 228636 URL: http://svn.freebsd.org/changeset/base/228636 Log: Correct a logic error in usr.bin/hexdump/conv.c, found by clang. Whenever the conv_c() function encounters an incomplete multibyte char, it peeks ahead. It also sets p

Re: svn commit: r228629 - head/usr.bin/gprof

2011-12-17 Thread Garrett Cooper
On Sat, Dec 17, 2011 at 6:51 AM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Sat Dec 17 14:51:24 2011 New Revision: 228629 URL: http://svn.freebsd.org/changeset/base/228629 Log:  More fixes for correct printf length modifiers usr.bin/gprof. These fixes should be contributed

svn commit: r228637 - in head/sys/dev/usb: . net

2011-12-17 Thread Kevin Lo
Author: kevlo Date: Sat Dec 17 15:38:16 2011 New Revision: 228637 URL: http://svn.freebsd.org/changeset/base/228637 Log: Another axe(4), found in ASUS zenbook. Modified: head/sys/dev/usb/net/if_axe.c head/sys/dev/usb/usbdevs Modified: head/sys/dev/usb/net/if_axe.c

svn commit: r228638 - head/sys/sys

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:39:14 2011 New Revision: 228638 URL: http://svn.freebsd.org/changeset/base/228638 Log: move GETS_*ECHO* defintions from libkern.h to cons.h MFC after:2 months Modified: head/sys/sys/cons.h head/sys/sys/libkern.h Modified: head/sys/sys/cons.h

svn commit: r228639 - head/usr.bin/indent

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 15:41:58 2011 New Revision: 228639 URL: http://svn.freebsd.org/changeset/base/228639 Log: In usr.bin/indent/io.c, fix a few warnings about format strings not being literals. MFC after:1 week Modified: head/usr.bin/indent/io.c Modified:

svn commit: r228640 - head/sys/mips/cavium/usb

2011-12-17 Thread Bjoern A. Zeeb
Author: bz Date: Sat Dec 17 15:42:37 2011 New Revision: 228640 URL: http://svn.freebsd.org/changeset/base/228640 Log: Unbreak the OCTEON1 kernel build after r228483 removing the left over declaration. MFC after:11 days Modified: head/sys/mips/cavium/usb/octusb_octeon.c Modified:

svn commit: r228641 - head/sbin/ifconfig

2011-12-17 Thread Bjoern A. Zeeb
Author: bz Date: Sat Dec 17 15:44:34 2011 New Revision: 228641 URL: http://svn.freebsd.org/changeset/base/228641 Log: Allow toggling of IFCAP_VLAN_HWCSUM for hardware that supports checksum offloading on vlans and document the new option. MFC after:2 weeks Sponsored by: The FreeBSD

svn commit: r228642 - in head/sys: conf libkern sys

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:48:55 2011 New Revision: 228642 URL: http://svn.freebsd.org/changeset/base/228642 Log: retire libkern gets Inspired by: bde MFC after:2 months X-MFC-Note: if deemed a part of KPI, just call cngets internally Deleted: head/sys/libkern/gets.c

svn commit: r228643 - head/sys/kern

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:50:45 2011 New Revision: 228643 URL: http://svn.freebsd.org/changeset/base/228643 Log: belatedly transfer copyrights from libkern/gets.c to kern_cons.c MFC after:2 months MFC with: r228642 Modified: head/sys/kern/kern_cons.c Modified:

svn commit: r228644 - head/sys/dev/syscons

2011-12-17 Thread Andriy Gapon
Author: avg Date: Sat Dec 17 15:57:39 2011 New Revision: 228644 URL: http://svn.freebsd.org/changeset/base/228644 Log: syscons: provide a first iteration of cngrab/cnungrab implementation - put underlying keyboard(s) into the polling mode for the whole duration of the grab, instead of

svn commit: r228645 - head/contrib/less

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 16:10:14 2011 New Revision: 228645 URL: http://svn.freebsd.org/changeset/base/228645 Log: In contrib/less, cast away const a bunch of times, to make it build without conversion warnings. This code desparately needs a good dose of const poison, but fixing all

Re: svn commit: r228644 - head/sys/dev/syscons

2011-12-17 Thread Andriy Gapon
on 17/12/2011 17:57 Andriy Gapon said the following: Author: avg Date: Sat Dec 17 15:57:39 2011 New Revision: 228644 URL: http://svn.freebsd.org/changeset/base/228644 Log: syscons: provide a first iteration of cngrab/cnungrab implementation - put underlying keyboard(s) into the

svn commit: r228646 - in head/libexec/rtld-elf: powerpc powerpc64

2011-12-17 Thread Nathan Whitehorn
Author: nwhitehorn Date: Sat Dec 17 16:20:27 2011 New Revision: 228646 URL: http://svn.freebsd.org/changeset/base/228646 Log: Additional icache paranoia: non-PLT relocations can modify the text segment. It is then important to make sure the icache is synchronized again to prevent (rare)

svn commit: r228647 - head/usr.bin/mail

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 16:30:42 2011 New Revision: 228647 URL: http://svn.freebsd.org/changeset/base/228647 Log: In usr.bin/mail/cmd1.c, use the correct printf length modifier for a ptrdiff_t. In usr.bin/mail/main.c, cast a field width to int. MFC after:1 week Modified:

svn commit: r228648 - in head/sys: kern sys

2011-12-17 Thread Mikolaj Golub
Author: trociny Date: Sat Dec 17 16:59:22 2011 New Revision: 228648 URL: http://svn.freebsd.org/changeset/base/228648 Log: On start most of sysctl_kern_proc functions use the same pattern: locate a process calling pfind() and do some additional checks like p_candebug(). To reduce this code

svn commit: r228649 - head/usr.bin/ncplist

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 17:04:30 2011 New Revision: 228649 URL: http://svn.freebsd.org/changeset/base/228649 Log: Use NO_WCAST_ALIGN for usr.bin/ncplist, as there are many potential alignment issues in it. (Though I doubt anyone still cares about NetWare support...) MFC after:

svn commit: r228650 - head/usr.bin/netstat

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 17:21:47 2011 New Revision: 228650 URL: http://svn.freebsd.org/changeset/base/228650 Log: In usr.bin/netstat/atalk.c, work around a clang false positive with printf format warnings and conditional operators. MFC after:1 week Modified:

svn commit: r228651 - head/contrib/telnet/telnet

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 18:18:36 2011 New Revision: 228651 URL: http://svn.freebsd.org/changeset/base/228651 Log: In contrib/telnet/telnet/utilities.c, fix a few warnings about format strings not being literals. MFC after:1 week Modified:

svn commit: r228652 - head/usr.bin/vacation

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 18:39:04 2011 New Revision: 228652 URL: http://svn.freebsd.org/changeset/base/228652 Log: Unfortunately, clang gives warnings about sendmail code that cannot be turned off yet. Since this is contrib code, and we don't really care about the warnings, just turn

svn commit: r228653 - in head/sys: netinet netinet6

2011-12-17 Thread Michael Tuexen
Author: tuexen Date: Sat Dec 17 19:21:40 2011 New Revision: 228653 URL: http://svn.freebsd.org/changeset/base/228653 Log: Fix unused parameter warnings. While there, fix some whitespace issues. MFC after: 3 months. Modified: head/sys/netinet/sctp.h head/sys/netinet/sctp_asconf.c

svn commit: r228654 - head/usr.bin/vmstat

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 19:22:24 2011 New Revision: 228654 URL: http://svn.freebsd.org/changeset/base/228654 Log: In usr.bin/vmstat/vmstat.c, cast several printf field widths to int, and use printf format specifiers from inttypes.h for uint64_t's. MFC after:1 week Modified:

svn commit: r228655 - head/usr.sbin/bluetooth/sdpd

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 19:26:03 2011 New Revision: 228655 URL: http://svn.freebsd.org/changeset/base/228655 Log: In usr.sbin/bluetooth/sdpd/server.c, don't use the size of a pointer as the length argument to memset, but the size of the object pointed to. MFC after:1 week

svn commit: r228656 - head/usr.sbin/boot0cfg

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 19:33:26 2011 New Revision: 228656 URL: http://svn.freebsd.org/changeset/base/228656 Log: Use NO_WCAST_ALIGN for usr.sbin/boot0cfg; because this is only built for x86, any alignment warnings can be safely ignored. MFC after:1 week Modified:

svn commit: r228657 - head/usr.sbin/bsnmpd/modules/snmp_wlan

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 19:53:08 2011 New Revision: 228657 URL: http://svn.freebsd.org/changeset/base/228657 Log: In usr.sbin/bsnmpd/modules/snmp_wlan/wlan_snmp.h, use the correct enumeration types for the mesh_peering and mesh_forwarding members of struct wlan_iface, to fix enum

svn commit: r228658 - head/usr.sbin/cpucontrol

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 19:58:48 2011 New Revision: 228658 URL: http://svn.freebsd.org/changeset/base/228658 Log: Use NO_WCAST_ALIGN for usr.sbin/cpucontrol; because this is only built for x86, any alignment warnings can be safely ignored. MFC after:1 week Modified:

svn commit: r228659 - head/usr.sbin/ctm/ctm_dequeue

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 20:07:42 2011 New Revision: 228659 URL: http://svn.freebsd.org/changeset/base/228659 Log: In usr.sbin/ctm/ctm_dequeue/ctm_dequeue.c, cast a printf field width parameter to int. MFC after:1 week Modified: head/usr.sbin/ctm/ctm_dequeue/ctm_dequeue.c

svn commit: r228660 - head/usr.sbin/i2c

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 20:12:17 2011 New Revision: 228660 URL: http://svn.freebsd.org/changeset/base/228660 Log: In usr.sbin/i2c/i2c.c, fix a few warnings about format strings not being literals. MFC after:1 week Modified: head/usr.sbin/i2c/i2c.c Modified:

svn commit: r228661 - head/usr.sbin/iostat

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 20:25:23 2011 New Revision: 228661 URL: http://svn.freebsd.org/changeset/base/228661 Log: In usr.sbin/iostat/iostat.c, use printf format specifiers from inttypes.h for u_int64_t's. While here, sort #include directives. MFC after:1 week Modified:

svn commit: r228662 - head/usr.sbin/keyserv

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 20:53:06 2011 New Revision: 228662 URL: http://svn.freebsd.org/changeset/base/228662 Log: In usr.sbin/keyserv, fix some implicit enum conversions, and use the correct printf length modifiers for uid_t. MFC after:1 week Modified:

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread mdf
On Sat, Dec 17, 2011 at 5:14 AM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Sat Dec 17 13:14:44 2011 New Revision: 228625 URL: http://svn.freebsd.org/changeset/base/228625 Log:  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the  shared secret, and use

svn commit: r228663 - head/usr.sbin/lpr/filters

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 21:37:21 2011 New Revision: 228663 URL: http://svn.freebsd.org/changeset/base/228663 Log: In usr.sbin/lpr/filters/lpf.c, use a less obtuse way of clearing the buffer, that also avoids warnings. MFC after:1 week Modified: head/usr.sbin/lpr/filters/lpf.c

Re: svn commit: r228663 - head/usr.sbin/lpr/filters

2011-12-17 Thread Kostik Belousov
On Sat, Dec 17, 2011 at 09:37:22PM +, Dimitry Andric wrote: Author: dim Date: Sat Dec 17 21:37:21 2011 New Revision: 228663 URL: http://svn.freebsd.org/changeset/base/228663 Log: In usr.sbin/lpr/filters/lpf.c, use a less obtuse way of clearing the buffer, that also avoids

Re: svn commit: r228663 - head/usr.sbin/lpr/filters

2011-12-17 Thread Dimitry Andric
On 2011-12-17 22:44, Kostik Belousov wrote: #define MAXWIDTH 132 #define MAXREP10 @@ -115,7 +116,7 @@ main(int argc, char *argv[]) acctfile = cp; } -for (cp = buf[0], limit = buf[MAXREP]; cp limit; *cp++ = ' '); +memset(buf, ' ', sizeof(buf));

Re: svn commit: r228650 - head/usr.bin/netstat

2011-12-17 Thread Bjoern A. Zeeb
On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: Author: dim Date: Sat Dec 17 17:21:47 2011 New Revision: 228650 URL: http://svn.freebsd.org/changeset/base/228650 Log: In usr.bin/netstat/atalk.c, work around a clang false positive with printf format warnings and conditional

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
On 2011-12-17 22:32, m...@freebsd.org wrote: ... In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the shared secret, and use long long format to snprintf a time_t. If casting is necessary, style prefers intmax_t or uintmax_t, since those are always wide enough. I don't

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Bjoern A. Zeeb
On 17. Dec 2011, at 21:54 , Dimitry Andric wrote: On 2011-12-17 22:32, m...@freebsd.org wrote: ... In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the shared secret, and use long long format to snprintf a time_t. If casting is necessary, style prefers intmax_t or

Re: svn commit: r228650 - head/usr.bin/netstat

2011-12-17 Thread Dimitry Andric
On 2011-12-17 22:53, Bjoern A. Zeeb wrote: On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: Author: dim Date: Sat Dec 17 17:21:47 2011 New Revision: 228650 URL: http://svn.freebsd.org/changeset/base/228650 Log: In usr.bin/netstat/atalk.c, work around a clang false positive with

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Bjoern A. Zeeb
On 17. Dec 2011, at 21:56 , Bjoern A. Zeeb wrote: On 17. Dec 2011, at 21:54 , Dimitry Andric wrote: On 2011-12-17 22:32, m...@freebsd.org wrote: ... In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the shared secret, and use long long format to snprintf a time_t. If

Re: svn commit: r228650 - head/usr.bin/netstat

2011-12-17 Thread Bjoern A. Zeeb
On 17. Dec 2011, at 21:58 , Dimitry Andric wrote: On 2011-12-17 22:53, Bjoern A. Zeeb wrote: On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: Author: dim Date: Sat Dec 17 17:21:47 2011 New Revision: 228650 URL: http://svn.freebsd.org/changeset/base/228650 Log: In

svn commit: r228664 - head/usr.sbin/lpr/lpd

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 22:05:28 2011 New Revision: 228664 URL: http://svn.freebsd.org/changeset/base/228664 Log: In usr.sbin/lpr/lpd/printjob.c, use the correct printf length modifiers for off_t (aka int64_t). MFC after:1 week Modified: head/usr.sbin/lpr/lpd/printjob.c

svn commit: r228665 - head/usr.sbin/ndiscvt

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 22:16:27 2011 New Revision: 228665 URL: http://svn.freebsd.org/changeset/base/228665 Log: Use NO_WCAST_ALIGN for usr.sbin/ndiscvt; because this is only built for x86, any alignment warnings can be safely ignored. Define YY_NO_INPUT in

svn commit: r228666 - head/sys/kern

2011-12-17 Thread Mikolaj Golub
Author: trociny Date: Sat Dec 17 22:18:26 2011 New Revision: 228666 URL: http://svn.freebsd.org/changeset/base/228666 Log: Fix style and white spaces. MFC after:1 week Modified: head/sys/kern/kern_proc.c Modified: head/sys/kern/kern_proc.c

svn commit: r228667 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 22:20:46 2011 New Revision: 228667 URL: http://svn.freebsd.org/changeset/base/228667 Log: In usr.bin/csup/auth.c, cast time_t to intmax_t instead, and use the corresponding printf length modifier. Requested by: mdf MFC after:1 week Modified:

svn commit: r228668 - head/usr.bin/netstat

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 22:32:00 2011 New Revision: 228668 URL: http://svn.freebsd.org/changeset/base/228668 Log: Revert r228650, and work around the clang false positive with printf formats in usr.bin/netstat/atalk.c by conditionally adding NO_WFORMAT to the Makefile instead. MFC

Re: svn commit: r228668 - head/usr.bin/netstat

2011-12-17 Thread Dimitry Andric
On 2011-12-17 23:32, Dimitry Andric wrote: Author: dim Date: Sat Dec 17 22:32:00 2011 New Revision: 228668 URL: http://svn.freebsd.org/changeset/base/228668 Log: Revert r228650, and work around the clang false positive with printf formats in usr.bin/netstat/atalk.c by conditionally

svn commit: r228669 - head/usr.bin/du

2011-12-17 Thread Jilles Tjoelker
Author: jilles Date: Sat Dec 17 23:18:14 2011 New Revision: 228669 URL: http://svn.freebsd.org/changeset/base/228669 Log: du: Allow multiple -HLP options, the last one wins. This matches 4.4BSD tradition and other utilities with these options and is required by POSIX (POSIX does not

svn commit: r228670 - head/usr.sbin/pkg_install/updating

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 23:35:46 2011 New Revision: 228670 URL: http://svn.freebsd.org/changeset/base/228670 Log: In usr.sbin/pkg_install/updating/main.c, use the size of the destination buffer as size argument to strlcpy(), not the length of the source. MFC after:1 week

svn commit: r228671 - head/usr.sbin/pmccontrol

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 23:39:13 2011 New Revision: 228671 URL: http://svn.freebsd.org/changeset/base/228671 Log: In usr.sbin/pmccontrol/pmccontrol.c, fix a few warnings about format strings not being literals. MFC after:1 week Modified: head/usr.sbin/pmccontrol/pmccontrol.c

svn commit: r228672 - head/contrib/pnpinfo

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 23:43:40 2011 New Revision: 228672 URL: http://svn.freebsd.org/changeset/base/228672 Log: In contrib/pnpinfo/pnpinfo.c, remove an extraneous parameter from the call to isolation_protocol(). MFC after:1 week Modified: head/contrib/pnpinfo/pnpinfo.c

svn commit: r228673 - head/usr.sbin/pw

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sat Dec 17 23:46:47 2011 New Revision: 228673 URL: http://svn.freebsd.org/changeset/base/228673 Log: In usr.sbin/pw/pw_user.c, use the correct printf length modifier for a ptrdiff_t. MFC after:1 week Modified: head/usr.sbin/pw/pw_user.c Modified:

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread mdf
On Sat, Dec 17, 2011 at 1:54 PM, Dimitry Andric d...@freebsd.org wrote: On 2011-12-17 22:32, m...@freebsd.org wrote: ...  In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the  shared secret, and use long long format to snprintf a time_t. If casting is necessary, style

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Dimitry Andric
On 2011-12-18 00:49, m...@freebsd.org wrote: ... Also, long long is a bit of a hack that came in before C99 standardized on a few wider types, and the PRIu64 macros are really hideous. I agree they're ugly, but C99 should simply have defined length modifiers for int64_t and friends, then the

svn commit: r228674 - head/usr.sbin/route6d

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 00:03:03 2011 New Revision: 228674 URL: http://svn.freebsd.org/changeset/base/228674 Log: In usr.sbin/route6d/route6d.c, use the correct printf length modifier for an ssize_t. MFC after:1 week Modified: head/usr.sbin/route6d/route6d.c Modified:

svn commit: r228675 - head/share/mk

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 00:24:11 2011 New Revision: 228675 URL: http://svn.freebsd.org/changeset/base/228675 Log: Disable yet another clang warning (-Wconversion) when WARNS = 3. MFC after:1 week Modified: head/share/mk/bsd.sys.mk Modified: head/share/mk/bsd.sys.mk

svn commit: r228677 - head/share/mk

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 00:34:42 2011 New Revision: 228677 URL: http://svn.freebsd.org/changeset/base/228677 Log: Disable another clang warning (-Wempty-body) when WARNS = 2. MFC after:1 week Modified: head/share/mk/bsd.sys.mk Modified: head/share/mk/bsd.sys.mk

svn commit: r228678 - head/usr.sbin/rpc.ypupdated

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 00:40:30 2011 New Revision: 228678 URL: http://svn.freebsd.org/changeset/base/228678 Log: In usr.sbin/rpc.ypupdated/yp_dbupdate.c, use the appropriate printf length modifier for time_t (after casting it to intmax_t). MFC after:1 week Modified:

svn commit: r228679 - head/usr.sbin/rpc.ypupdated

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 00:44:59 2011 New Revision: 228679 URL: http://svn.freebsd.org/changeset/base/228679 Log: In usr.sbin/rpc.ypupdated/yp_dbupdate.c, include stdint.h, so intmax_t is known, otherwise it won't build. Pointy hat to:dim MFC after:1 week Modified:

svn commit: r228680 - head/usr.sbin/rpc.ypupdated

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 00:55:46 2011 New Revision: 228680 URL: http://svn.freebsd.org/changeset/base/228680 Log: In usr.sbin/rpc.ypupdated/yp_dbupdate.c, since intmax_t is signed, just like time_t, better use %jd instead of %ju. Strangely enough, neither gcc, clang nor gcc 4.6 warn

svn commit: r228681 - head/usr.sbin/sa

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 01:08:25 2011 New Revision: 228681 URL: http://svn.freebsd.org/changeset/base/228681 Log: In usr.sbin/sa/db.c, avoid warnings about assigning two const char arrays to non-const void pointers, by casting away const explicitly. MFC after:1 week Modified:

svn commit: r228682 - head/usr.sbin/sade

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 01:13:21 2011 New Revision: 228682 URL: http://svn.freebsd.org/changeset/base/228682 Log: In usr.sbin/sade/install.c and usr.sbin/sade/label.c, fix a few warnings about format strings not being literals. MFC after:1 week Modified:

svn commit: r228683 - head/usr.sbin/sade

2011-12-17 Thread Dimitry Andric
Author: dim Date: Sun Dec 18 01:14:38 2011 New Revision: 228683 URL: http://svn.freebsd.org/changeset/base/228683 Log: Forgot to add usr.sbin/sade/label.c in the previous commit. MFC after:1 week Modified: head/usr.sbin/sade/label.c Modified: head/usr.sbin/sade/label.c

Re: svn commit: r228668 - head/usr.bin/netstat

2011-12-17 Thread David Schultz
On Sat, Dec 17, 2011, Dimitry Andric wrote: On 2011-12-17 23:32, Dimitry Andric wrote: Author: dim Date: Sat Dec 17 22:32:00 2011 New Revision: 228668 URL: http://svn.freebsd.org/changeset/base/228668 Log: Revert r228650, and work around the clang false positive with printf

Re: svn commit: r228668 - head/usr.bin/netstat

2011-12-17 Thread David Schultz
On Sat, Dec 17, 2011, David Schultz wrote: On Sat, Dec 17, 2011, Dimitry Andric wrote: On 2011-12-17 23:32, Dimitry Andric wrote: Author: dim Date: Sat Dec 17 22:32:00 2011 New Revision: 228668 URL: http://svn.freebsd.org/changeset/base/228668 Log: Revert r228650, and

Re: svn commit: r228650 - head/usr.bin/netstat

2011-12-17 Thread Joerg Sonnenberger
On Sat, Dec 17, 2011 at 09:53:56PM +, Bjoern A. Zeeb wrote: On 17. Dec 2011, at 17:21 , Dimitry Andric wrote: Author: dim Date: Sat Dec 17 17:21:47 2011 New Revision: 228650 URL: http://svn.freebsd.org/changeset/base/228650 Log: In usr.bin/netstat/atalk.c, work around a

Re: svn commit: r228670 - head/usr.sbin/pkg_install/updating

2011-12-17 Thread Joerg Sonnenberger
On Sat, Dec 17, 2011 at 11:35:46PM +, Dimitry Andric wrote: Modified: head/usr.sbin/pkg_install/updating/main.c == --- head/usr.sbin/pkg_install/updating/main.c Sat Dec 17 23:18:14 2011 (r228669) +++

Re: svn commit: r228631 - in head/sys: dev/cfe dev/dcons dev/ofw dev/sio dev/syscons dev/uart dev/usb/serial dev/xen/console gdb ia64/ia64 kern mips/adm5120 pc98/cbus powerpc/mambo sys

2011-12-17 Thread Bruce Evans
On Sat, 17 Dec 2011, Andriy Gapon wrote: Log: kern cons: introduce infrastructure for console grabbing by kernel At the moment grab and ungrab methods of all console drivers are no-ops. Current intended meaning of the calls is that the kernel takes control of console input. In the future

Re: svn commit: r228625 - head/usr.bin/csup

2011-12-17 Thread Bruce Evans
On Sat, 17 Dec 2011 m...@freebsd.org wrote: On Sat, Dec 17, 2011 at 1:54 PM, Dimitry Andric d...@freebsd.org wrote: On 2011-12-17 22:32, m...@freebsd.org wrote: ... ?In usr.bin/csup/auth.c, use the correct number of bytes for zeroing the ?shared secret, and use long long format to snprintf a