svn commit: r295834 - in head/sys: arm/arm conf

Author: skra Date: Sat Feb 20 07:45:21 2016 New Revision: 295834 URL: https://svnweb.freebsd.org/changeset/base/295834 Log: Rename busdma_machdep.c to busdma_machdep-v4.c, pmap.c to pmap-v4.c and trap.c to trap-v4.c to be plain and consistent with other armv4 specific files. Added: head/s

Re: svn commit: r295833 - head/sys/sys

On 2/19/16, Bruce Evans wrote: > On Sat, 20 Feb 2016, Justin Hibbits wrote: > >> Log: >> Fix the definition of RM_MAX_END. >> >> Even though casting from signed to unsigned is well-defined in C, it's >> better to >> first cast to the larger unsigned type, then negate. > > Casting ~0 is well-def

Re: svn commit: r295756 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries

This was not tinderboxed. I'm getting build failures for powerpc and sparc64. Please revert or fix. Least of which: sys/dev/ofw/ofw_pci.c conflicts with sys/powerpc/ofw/ofw_pci.c, which I mentioned in phabricator long ago. Additionally, several files are missing includes of dev/ofw/ofw_bus_subr

Re: svn commit: r295833 - head/sys/sys

On Sat, 20 Feb 2016, Justin Hibbits wrote: Log: Fix the definition of RM_MAX_END. Even though casting from signed to unsigned is well-defined in C, it's better to first cast to the larger unsigned type, then negate. Casting ~0 is well-defined, but ~0 isn't. The operation is complementati

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, Feb 19, 2016 at 6:50 PM, Conrad Meyer wrote: > On Fri, Feb 19, 2016 at 3:14 PM, Benjamin Kaduk wrote: > > On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff > wrote: > >> Isn't zero filling part of the standard? I don't see why lack of > >> explicit zeroing is a warning? Looks a false warni

Re: svn commit: r295800 - head/usr.bin/cap_mkdb

On 2/19/16 6:40 PM, Bryan Drewery wrote: On 2/19/2016 12:42 AM, Stefan Esser wrote: Author: se Date: Fri Feb 19 08:42:13 2016 New Revision: 295800 URL: https://svnweb.freebsd.org/changeset/base/295800 Log: Remove O_SYNC from the options passed to dbmopen(). Uh, this is a full revert of r293

Re: svn commit: r295768 - head/usr.sbin/iostat

On Sat, 20 Feb 2016, Dimitry Andric wrote: On 19 Feb 2016, at 16:49, Alan Somers wrote: On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote: ... -struct nlist namelist[] = { +static struct nlist namelist[] = { #define X_TTY_NIN 0 - { "_tty_nin" }, + { .n_name = "_tty_n

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, 19 Feb 2016, Benjamin Kaduk wrote: On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff wrote: On Fri, Feb 19, 2016 at 08:49:43AM -0700, Alan Somers wrote: A> On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote: A> Yeah, it was being implicitly zeroized before. But Clang complained A>

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, Feb 19, 2016 at 3:14 PM, Benjamin Kaduk wrote: > On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff wrote: >> Isn't zero filling part of the standard? I don't see why lack of >> explicit zeroing is a warning? Looks a false warning to me. > > > It is not quite as simple as this would make it s

svn commit: r295833 - head/sys/sys

Author: jhibbits Date: Sat Feb 20 01:34:13 2016 New Revision: 295833 URL: https://svnweb.freebsd.org/changeset/base/295833 Log: Fix the definition of RM_MAX_END. Even though casting from signed to unsigned is well-defined in C, it's better to first cast to the larger unsigned type, then

svn commit: r295832 - in head/sys: arm/at91 arm/cavium/cns11xx arm/mv arm64/arm64 arm64/cavium dev/acpica dev/eisa dev/fdt dev/gpio dev/mca dev/ofw dev/pccard dev/siba dev/vnic kern mips/adm5120 mi...

Author: jhibbits Date: Sat Feb 20 01:32:58 2016 New Revision: 295832 URL: https://svnweb.freebsd.org/changeset/base/295832 Log: Introduce a RMAN_IS_DEFAULT_RANGE() macro, and use it. This simplifies checking for default resource range for bus_alloc_resource(), and improves readability.

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, Feb 19, 2016 at 3:06 PM, Gleb Smirnoff wrote: > Isn't zero filling part of the standard? I don't see why lack of > explicit zeroing is a warning? Looks a false warning to me. Yep. This is Clang being too whiney, IMO. I think a good workaround is to add -Wno-missing-field-initializers to

Re: svn commit: r295800 - head/usr.bin/cap_mkdb

On 2/19/2016 12:42 AM, Stefan Esser wrote: > Author: se > Date: Fri Feb 19 08:42:13 2016 > New Revision: 295800 > URL: https://svnweb.freebsd.org/changeset/base/295800 > > Log: > Remove O_SYNC from the options passed to dbmopen(). Uh, this is a full revert of r293312's changes to cap_mkdb which

Re: svn commit: r295800 - head/usr.bin/cap_mkdb

* Stefan Esser (s...@freebsd.org) wrote: > Log: > Remove O_SYNC from the options passed to dbmopen(). > > The output file is created as a temporary file that is moved over the > existing file after completion. Thus there is no need to immediately > flush all created db records to the te

Re: svn commit: r295768 - head/usr.sbin/iostat

On Sat, Feb 20, 2016 at 12:23:40AM +0100, Dimitry Andric wrote: D> You got this warning, most likely: D> D> usr.sbin/iostat/iostat.c:122:15: error: missing field 'n_type' initializer [-Werror,-Wmissing-field-initializers] D> { "_tty_nin" }, D> ^ D> D> This warning is

Re: svn commit: r295828 - head/sys/dev/ixl

Eric, do you mean that this specific PCI ID goes to a certain device manufacturer who is known to install only specific software on their devices? Even in that case I don't see any improvement in removing the PCI IDs from the driver. People could use these devices aftermarket, and install wha

Re: svn commit: r295768 - head/usr.sbin/iostat

On 19 Feb 2016, at 16:49, Alan Somers wrote: > > On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote: ... >>> -struct nlist namelist[] = { >>> +static struct nlist namelist[] = { >>> #define X_TTY_NIN 0 >>> - { "_tty_nin" }, >>> + { .n_name = "_tty_nin", >>> + .n_typ

Re: svn commit: r295828 - head/sys/dev/ixl

The driver worked for the most part on the 20G hardware, but it's specific hardware for an OEM that doesn't use FreeBSD. The KX_A device ID never made it into any hardware. On Fri, Feb 19, 2016 at 3:08 PM Gleb Smirnoff wrote: > On Fri, Feb 19, 2016 at 10:33:51PM +, Eric Joyner wrote: > E> A

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, Feb 19, 2016 at 5:06 PM, Gleb Smirnoff wrote: > On Fri, Feb 19, 2016 at 08:49:43AM -0700, Alan Somers wrote: > A> On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov > wrote: > A> Yeah, it was being implicitly zeroized before. But Clang complained > A> about the structures being only part

Re: svn commit: r295828 - head/sys/dev/ixl

On Fri, Feb 19, 2016 at 10:33:51PM +, Eric Joyner wrote: E> Author: erj E> Date: Fri Feb 19 22:33:50 2016 E> New Revision: 295828 E> URL: https://svnweb.freebsd.org/changeset/base/295828 E> E> Log: E> ixl(4): Remove unsupported device IDs. E> E> There is no official support for 20G SKUs

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, Feb 19, 2016 at 08:49:43AM -0700, Alan Somers wrote: A> On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote: A> > On 18 February 2016 at 23:08, Alan Somers wrote: A> >> Author: asomers A> >> Date: Thu Feb 18 20:08:01 2016 A> >> New Revision: 295768 A> >> URL: https://svnweb.freebsd.or

svn commit: r295831 - head/sys/dev/ixl

Author: erj Date: Fri Feb 19 22:48:20 2016 New Revision: 295831 URL: https://svnweb.freebsd.org/changeset/base/295831 Log: ixl(4)/ixlv(4): Revert m_collapse() in ixl_xmit() to m_defrag(). The m_collapse() call would fail when transmitting medium-sized packets when the interface mtu was se

svn commit: r295830 - head/sys/dev/bxe

Author: davidcs Date: Fri Feb 19 22:46:52 2016 New Revision: 295830 URL: https://svnweb.freebsd.org/changeset/base/295830 Log: Remove dead code. Code Cleanup. Improve clarity in debug messages MFC after:5 days Modified: head/sys/dev/bxe/bxe.c head/sys/dev/bxe/bxe.h head/sys/dev/bxe/b

svn commit: r295829 - head/sys/dev/ixl

Author: erj Date: Fri Feb 19 22:45:09 2016 New Revision: 295829 URL: https://svnweb.freebsd.org/changeset/base/295829 Log: ixl(4): Fix errors in queue interrupt setup in MSIX mode. - I40E_PFINT_DYN_CTLN needs to be cleared, and not have a queue index written to it. - The interrupt lin

svn commit: r295828 - head/sys/dev/ixl

Author: erj Date: Fri Feb 19 22:33:50 2016 New Revision: 295828 URL: https://svnweb.freebsd.org/changeset/base/295828 Log: ixl(4): Remove unsupported device IDs. There is no official support for 20G SKUs on FreeBSD, and the KX_A device ID was never used. Differential Revision:

svn commit: r295827 - head/share/mk

Author: bdrewery Date: Fri Feb 19 22:28:45 2016 New Revision: 295827 URL: https://svnweb.freebsd.org/changeset/base/295827 Log: DIRDEPS_BUILD: Enable the post-build footer/stats display. There is no real downside to this and it is useful to have enabled. Sponsored by: EMC / Isilon Stor

svn commit: r295826 - head/sys/dev/ixl

Author: erj Date: Fri Feb 19 21:58:14 2016 New Revision: 295826 URL: https://svnweb.freebsd.org/changeset/base/295826 Log: ixl(4): Fix two important RSS bugs. - Change tc_mapping field to assign 64 queues instead of 16 to the PF's VSI; add comments to describe how this is done. - S

svn commit: r295825 - in head/bin/sh: . tests/parser

Author: jilles Date: Fri Feb 19 21:53:12 2016 New Revision: 295825 URL: https://svnweb.freebsd.org/changeset/base/295825 Log: sh: Rework code to remove '\0' from shell input. This fixes bugs where '\0' was not removed correctly and speeds up the parser. Added: head/bin/sh/tests/parser/

svn commit: r295824 - stable/9/sys/dev/qlxgbe

Author: davidcs Date: Fri Feb 19 21:51:27 2016 New Revision: 295824 URL: https://svnweb.freebsd.org/changeset/base/295824 Log: MFC r294854 Upgrade FW to 5.4.56 Update driver version to 3.10.26 Modified: stable/9/sys/dev/qlxgbe/ql_fw.c stable/9/sys/dev/qlxgbe/ql_ver.h Directory Prope

svn commit: r295823 - head/sys/dev/bxe

Author: davidcs Date: Fri Feb 19 21:32:49 2016 New Revision: 295823 URL: https://svnweb.freebsd.org/changeset/base/295823 Log: Modified the use of bxe_grc_dump() function so that it can be invoked directly at any potential error path, where a fwdump is needed. The fwdump (a.k.a grcdump) is sto

Re: svn commit: r295760 - head/usr.sbin/pciconf

On Thursday, February 18, 2016 09:15:27 PM Stefan Esser wrote: > Am 18.02.2016 um 19:07 schrieb John Baldwin: > >> @@ -172,6 +175,7 @@ cap_pcix(int fd, struct pci_conf *p, uin > >>} > >>if ((p->pc_hdr & PCIM_HDRTYPE) == 1) > >>return; > >> + max_burst_read = 0; > >>switch (

svn commit: r295822 - head/sys/dev/qlxgb

Author: pfg Date: Fri Feb 19 18:05:02 2016 New Revision: 295822 URL: https://svnweb.freebsd.org/changeset/base/295822 Log: qlxgb: fix mismatch. Found by: PVS Static Analysis Reviewed by: davidcs MFC after:1 month Modified: head/sys/dev/qlxgb/qla_hw.c Modified: head/sys/dev/

svn commit: r295819 - stable/10/sys/cam/scsi

Author: ken Date: Fri Feb 19 17:14:34 2016 New Revision: 295819 URL: https://svnweb.freebsd.org/changeset/base/295819 Log: MFC, r295417: r295417 | ken | 2016-02-08 15:13:08 -0700 (Mon, 08 Feb 2016) | 9 lines Fix the SCSI Extended INQUIRY probe case when an error is returned and

svn commit: r295818 - head/bin/sh/tests/parser

Author: jilles Date: Fri Feb 19 16:56:07 2016 New Revision: 295818 URL: https://svnweb.freebsd.org/changeset/base/295818 Log: sh: Add tests for comments in sh -c. Added: head/bin/sh/tests/parser/comment1.0 (contents, props changed) head/bin/sh/tests/parser/comment2.42 (contents, props c

svn commit: r295816 - head/sys/dev/pci

Author: se Date: Fri Feb 19 16:53:21 2016 New Revision: 295816 URL: https://svnweb.freebsd.org/changeset/base/295816 Log: Fix syntax error introduced in previous commit where I removed one character to few. I should have waited for the kernel compile to finish, even though the change seemed

svn commit: r295813 - head/sys/dev/pci

Author: se Date: Fri Feb 19 16:43:03 2016 New Revision: 295813 URL: https://svnweb.freebsd.org/changeset/base/295813 Log: Remove redundant check for "(dinfo != NULL)", it has already been performed as the first part of this complex loop conditional. Found by:PVS Static Analysis Modif

svn commit: r295811 - head/sys/fs/ext2fs

Author: pfg Date: Fri Feb 19 15:53:08 2016 New Revision: 295811 URL: https://svnweb.freebsd.org/changeset/base/295811 Log: Ext2: cleanup setting of ctime/mtime/birthtime. This adopts the same change as r291936 for UFS. Directly clear IN_ACCESS or IN_UPDATE when user supplied the time, and

Re: svn commit: r295768 - head/usr.sbin/iostat

On Fri, Feb 19, 2016 at 5:24 AM, Sergey Kandaurov wrote: > On 18 February 2016 at 23:08, Alan Somers wrote: >> Author: asomers >> Date: Thu Feb 18 20:08:01 2016 >> New Revision: 295768 >> URL: https://svnweb.freebsd.org/changeset/base/295768 >> >> Log: >> Fix compiler warnings in iostat > >> Mo

svn commit: r295810 - head/sys/dev/firewire

Author: pfg Date: Fri Feb 19 15:35:20 2016 New Revision: 295810 URL: https://svnweb.freebsd.org/changeset/base/295810 Log: firewire: fix a mismatch introduced in r230558. Found by: PVS Static Analysis Reviewed by: sbruno MFC after:1 month Modified: head/sys/dev/firewire/sbp_

svn commit: r295809 - head/tools/build/mk

Author: emaste Date: Fri Feb 19 15:11:54 2016 New Revision: 295809 URL: https://svnweb.freebsd.org/changeset/base/295809 Log: Remove objcopy in WITHOUT_TOOLCHAIN if it's from elftoolchain Modified: head/tools/build/mk/OptionalObsoleteFiles.inc Modified: head/tools/build/mk/OptionalObsoleteFi

svn commit: r295808 - head/sys/arm/allwinner

Author: andrew Date: Fri Feb 19 14:15:31 2016 New Revision: 295808 URL: https://svnweb.freebsd.org/changeset/base/295808 Log: Add initial support for the Allwinner A31i and A31s. This just adds the FDT platform code to detect when we are booting on one of these SoCs. The driver changes will

svn commit: r295807 - head/sys/arm/mv

Author: andrew Date: Fri Feb 19 14:05:28 2016 New Revision: 295807 URL: https://svnweb.freebsd.org/changeset/base/295807 Log: Include ofw_bus_subr.h before ofw_pci.h for the definition of struct ofw_bus_iinfo. Sponsored by: ABT Systems Ltd Modified: head/sys/arm/mv/mv_pci.c Modified:

svn commit: r295806 - head/usr.sbin/pciconf

Author: se Date: Fri Feb 19 14:01:35 2016 New Revision: 295806 URL: https://svnweb.freebsd.org/changeset/base/295806 Log: Fix possible out-of-bounds access detected by Ulrich Spörleins "scan-build". Some invalid PCI device selectors could cause read access to an initialized variable next to

Re: svn commit: r295768 - head/usr.sbin/iostat

On 18 February 2016 at 23:08, Alan Somers wrote: > Author: asomers > Date: Thu Feb 18 20:08:01 2016 > New Revision: 295768 > URL: https://svnweb.freebsd.org/changeset/base/295768 > > Log: > Fix compiler warnings in iostat > Modified: head/usr.sbin/iostat/iostat.c > =

svn commit: r295805 - head/sys/netinet

Author: tuexen Date: Fri Feb 19 11:25:18 2016 New Revision: 295805 URL: https://svnweb.freebsd.org/changeset/base/295805 Log: Use the SCTP level pointer, not the interface level. MFC after:3 days Modified: head/sys/netinet/sctp_pcb.c Modified: head/sys/netinet/sctp_pcb.c ===

svn commit: r295804 - head/sys/arm/arm

Author: skra Date: Fri Feb 19 10:40:04 2016 New Revision: 295804 URL: https://svnweb.freebsd.org/changeset/base/295804 Log: Remove not used static function pmap_kenter_attr(). Modified: head/sys/arm/arm/pmap-v6.c Modified: head/sys/arm/arm/pmap-v6.c ==

svn commit: r295803 - head/sys/arm/include

Author: skra Date: Fri Feb 19 10:32:17 2016 New Revision: 295803 URL: https://svnweb.freebsd.org/changeset/base/295803 Log: Remove not used definitions and fix some style nits. No functional changes. Modified: head/sys/arm/include/pmap-v6.h Modified: head/sys/arm/include/pmap-v6.h

Re: svn commit: r294693 - in stable/10: . crypto/openssh secure/lib/libssh secure/usr.bin/ssh secure/usr.sbin/sshd share/mk tools/build/options

Bryan Drewery writes: > If this is true it needs to be fixed. We can't be causing sshd to not > come up on a minor upgrade. It's ssh, not sshd. DES -- Dag-Erling Smørgrav - d...@des.no ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org

svn commit: r295802 - head/sys/arm/include

Author: skra Date: Fri Feb 19 09:52:11 2016 New Revision: 295802 URL: https://svnweb.freebsd.org/changeset/base/295802 Log: Remove AP_KRW definition not needed after r295801. Modified: head/sys/arm/include/pte-v6.h Modified: head/sys/arm/include/pte-v6.h =

svn commit: r295801 - in head: lib/libkvm sys/arm/arm sys/arm/include

Author: skra Date: Fri Feb 19 09:23:32 2016 New Revision: 295801 URL: https://svnweb.freebsd.org/changeset/base/295801 Log: Rename pte.h to pte-v4.h and start including directly either pte-v4.h or pte-v6.h in files which needs it. There are quite internal definitions in pte-v4.h and pte-v

Re: svn commit: r295796 - head/sys/net

On 19/02/2016 6:07 PM, Marcelo Araujo wrote: > > > 2016-02-19 15:03 GMT+08:00 Kubilay Kocak >: > > On 19/02/2016 5:35 PM, Marcelo Araujo wrote: > > Author: araujo > > Date: Fri Feb 19 06:35:53 2016 > > New Revision: 295796 > > URL: https://svnweb.fr

svn commit: r295800 - head/usr.bin/cap_mkdb

Author: se Date: Fri Feb 19 08:42:13 2016 New Revision: 295800 URL: https://svnweb.freebsd.org/changeset/base/295800 Log: Remove O_SYNC from the options passed to dbmopen(). The output file is created as a temporary file that is moved over the existing file after completion. Thus there is

svn commit: r295799 - head/sys/arm/include

Author: skra Date: Fri Feb 19 08:41:47 2016 New Revision: 295799 URL: https://svnweb.freebsd.org/changeset/base/295799 Log: Move common definitions from both pmap-v4.h and pmap-v6.h into pmap.h. (1) MI interface needed for vm subsystem. (2) MD interface created for ARM architecture to be use

svn commit: r295798 - head/sys/arm/include

Author: skra Date: Fri Feb 19 08:35:29 2016 New Revision: 295798 URL: https://svnweb.freebsd.org/changeset/base/295798 Log: Rename pmap.h to pmap-v4.h and remove pmap-v6.h include from it. Create new pmap.h which includes specific header according to __ARM_ARCH. Note that is included f