svn commit: r327581 - head/usr.sbin/pciconf

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:29:02 2018 New Revision: 327581 URL: https://svnweb.freebsd.org/changeset/base/327581 Log: Remove dead code (comma is either 0 or 1 for sure, no need to test). Close /dev/pci when we're done with it. CID: 1007450, 1007449, 1008615, 1008614 Modified: head

svn commit: r327580 - head/usr.sbin/ifmcstat

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:28:58 2018 New Revision: 327580 URL: https://svnweb.freebsd.org/changeset/base/327580 Log: bits is never null when we call ot. Add an assert to that effect and remove test for NULL. CID: 270774 Modified: head/usr.sbin/ifmcstat/printb.c Modified: head/us

svn commit: r327579 - head/usr.sbin/fdcontrol

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:28:48 2018 New Revision: 327579 URL: https://svnweb.freebsd.org/changeset/base/327579 Log: Tag 'a' case as one we're intentionally falling through to the 'F' case. CID: 1008176 Modified: head/usr.sbin/fdcontrol/fdcontrol.c Modified: head/usr.sbin/fdcont

svn commit: r327578 - head/usr.bin/units

2018-01-04 Thread Eitan Adler
Author: eadler Date: Fri Jan 5 07:24:43 2018 New Revision: 327578 URL: https://svnweb.freebsd.org/changeset/base/327578 Log: units(1): add missing ':' for two short arguments PR: 209850 MFC After:3 days Modified: head/usr.bin/units/units.c Modified: head/usr.bin/units/u

svn commit: r327577 - head/sys/cam/ata

2018-01-04 Thread Eitan Adler
Author: eadler Date: Fri Jan 5 07:14:39 2018 New Revision: 327577 URL: https://svnweb.freebsd.org/changeset/base/327577 Log: cam/da: QUIRK: Add 4K quirks for WD Red and Black MHDDs PR: 188685 Submitted by: Jeremy Chadwick Reported by: Martin Birgmeier Modified: head/sys

svn commit: r327576 - head/usr.sbin/dumpcis

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:09:40 2018 New Revision: 327576 URL: https://svnweb.freebsd.org/changeset/base/327576 Log: Add a number of sanity checks to the data that we're handling from the CIS. Coverity has tagged it as tainted. While this data is more trusted than your average data, we

svn commit: r327573 - head/usr.sbin/efibootmgr

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:09:19 2018 New Revision: 327573 URL: https://svnweb.freebsd.org/changeset/base/327573 Log: Free options before setting them. This will prevent us from leaking memory when we have multiple copies of the same option from being specified. Sponsored by: Netfl

svn commit: r327572 - head/usr.sbin/efibootmgr

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:09:09 2018 New Revision: 327572 URL: https://svnweb.freebsd.org/changeset/base/327572 Log: Ensure that we have a description string. When unspecified, default to "". Sponsored by: Netflix Modified: head/usr.sbin/efibootmgr/efibootmgr.c Modified: head/usr.

svn commit: r327575 - head/lib/libefivar

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:09:29 2018 New Revision: 327575 URL: https://svnweb.freebsd.org/changeset/base/327575 Log: Need to convert '/' back to '\' when creating a path. Ideally, this would be filesystem type dependent, but that's difficult to accomplish and it's unclear how the UEFI

svn commit: r327574 - in head: lib/libefivar usr.sbin/efidp

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 07:09:24 2018 New Revision: 327574 URL: https://svnweb.freebsd.org/changeset/base/327574 Log: Set dp to NULL when we free it, and tree a NULL dp as an error condition. This should prevent a double free. In addition, prevent a leak by freeing dp each loop and when

svn commit: r327571 - head/usr.sbin/fwcontrol

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 05:34:20 2018 New Revision: 327571 URL: https://svnweb.freebsd.org/changeset/base/327571 Log: Don't close fd twice. This line should have been deleted in r327279. CID: 1384015 Modified: head/usr.sbin/fwcontrol/fwdv.c Modified: head/usr.sbin/fwcontrol/fwdv.c

svn commit: r327570 - head/sbin/newfs_msdos

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 05:34:14 2018 New Revision: 327570 URL: https://svnweb.freebsd.org/changeset/base/327570 Log: Only call close if fd and fd1 are not -1. CID: 1384018, 1384017 Modified: head/sbin/newfs_msdos/mkfs_msdos.c Modified: head/sbin/newfs_msdos/mkfs_msdos.c ==

svn commit: r327569 - head/usr.sbin/devmatch

2018-01-04 Thread Warner Losh
Author: imp Date: Fri Jan 5 05:02:09 2018 New Revision: 327569 URL: https://svnweb.freebsd.org/changeset/base/327569 Log: Fix cut and paste error from devinfo.8 origin of this file Noticed by: kevans@ Modified: head/usr.sbin/devmatch/devmatch.8 Modified: head/usr.sbin/devmatch/devmatch

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Adrian Chadd
does it also happen when you actually enable RSS in the kernel? Since like I went through a whole lot of pain to assign a flowid at connection setup time. -a On 4 January 2018 at 15:37, Steven Hartland wrote: > > > On 04/01/2018 22:42, hiren panchasara wrote: > > On 01/04/18 at 09:52P, Steven

svn commit: r327568 - in stable/11/sys/dev: ahci usb/controller

2018-01-04 Thread Alexander Motin
Author: mav Date: Fri Jan 5 02:15:05 2018 New Revision: 327568 URL: https://svnweb.freebsd.org/changeset/base/327568 Log: MFC r327094: Add AHCI/XHCI device IDs found on AMD Ryzen+B350 system. Modified: stable/11/sys/dev/ahci/ahci_pci.c stable/11/sys/dev/usb/controller/xhci_pci.c Directory

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Eugene Grosbein
05.01.2018 6:37, Steven Hartland wrote: > Our TCP stack seems fragile during setup to out of order packets > which this multipath behavior causes, we've seen this on our loadbalancers > which is what triggered the investigation. The concrete result is many > aborted TCP connections, > over 300k

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Eugene Grosbein
05.01.2018 4:52, Steven Hartland wrote: >> RSS by definition has meaning to received stream. What is "outbound" stream >> in this context, why can the hash calculatiom method change and what exactly >> does it mean "a stream being incorrectly split"? > Yes RSS is indeed a received stream but that

svn commit: r327567 - head/usr.bin/hexdump

2018-01-04 Thread Kyle Evans
Author: kevans Date: Fri Jan 5 01:46:41 2018 New Revision: 327567 URL: https://svnweb.freebsd.org/changeset/base/327567 Log: hexdump(1): Speed up -s flag on devices Using the -s flag on devices is extraordinarily slow due to using fseek(3) a little too conservatively. Address this by usi

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Steven Hartland
On 04/01/2018 22:42, hiren panchasara wrote: On 01/04/18 at 09:52P, Steven Hartland wrote: On 04/01/2018 20:50, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/32755

svn commit: r327566 - head/sys/powerpc/pseries

2018-01-04 Thread Nathan Whitehorn
Author: nwhitehorn Date: Thu Jan 4 23:07:51 2018 New Revision: 327566 URL: https://svnweb.freebsd.org/changeset/base/327566 Log: Revert r327360, which can cause boot problems on high-CPU-count (>60) POWER8 and POWER9 systems, pending further analysis. PR: 224841 Modified: he

svn commit: r327565 - head/usr.bin/find/tests

2018-01-04 Thread Jilles Tjoelker
Author: jilles Date: Thu Jan 4 22:59:24 2018 New Revision: 327565 URL: https://svnweb.freebsd.org/changeset/base/327565 Log: find: Speed up tests by using touch -d instead of sleep for timestamps I have verified that the tests still detect the absence of the r327362 fix. Modified: head/

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread hiren panchasara
On 01/04/18 at 09:52P, Steven Hartland wrote: > On 04/01/2018 20:50, Eugene Grosbein wrote: > > 05.01.2018 3:05, Steven Hartland wrote: > > > >> Author: smh > >> Date: Thu Jan 4 20:05:47 2018 > >> New Revision: 327559 > >> URL: https://svnweb.freebsd.org/changeset/base/327559 > >> > >> Log: > >>

svn commit: r327564 - svnadmin/conf

2018-01-04 Thread Simon J. Gerraty
Author: sjg Date: Thu Jan 4 22:38:01 2018 New Revision: 327564 URL: https://svnweb.freebsd.org/changeset/base/327564 Log: Release stevek from bondage Reviewed by: sjg Modified: svnadmin/conf/mentors Modified: svnadmin/conf/mentors ==

svn commit: r327563 - in head/sys: arm/allwinner arm/conf arm64/conf conf

2018-01-04 Thread Kyle Evans
Author: kevans Date: Thu Jan 4 22:37:15 2018 New Revision: 327563 URL: https://svnweb.freebsd.org/changeset/base/327563 Log: if_awg: Use syscon prop if it exists The emac bindings that are landing in Linux 4.15 specify a syscon property on the emac node that point to /soc/syscon. Use thi

svn commit: r327562 - head/sys/kern

2018-01-04 Thread John Baldwin
Author: jhb Date: Thu Jan 4 22:07:58 2018 New Revision: 327562 URL: https://svnweb.freebsd.org/changeset/base/327562 Log: Always use atomic_fetchadd() when updating per-user accounting values. This avoids re-reading a variable after it has been updated via an atomic op. It is just a cos

svn commit: r327561 - head/sys/kern

2018-01-04 Thread John Baldwin
Author: jhb Date: Thu Jan 4 21:59:34 2018 New Revision: 327561 URL: https://svnweb.freebsd.org/changeset/base/327561 Log: Report offset relative to the backing object for kinfo_vmentry structures. For the pathname reported in kinfo_vmentry structures (kve_path), the sysctl handlers walk

svn commit: r327560 - in head/sys/compat: cloudabi cloudabi32 cloudabi64

2018-01-04 Thread Ed Schouten
Author: ed Date: Thu Jan 4 21:57:37 2018 New Revision: 327560 URL: https://svnweb.freebsd.org/changeset/base/327560 Log: Allow timed waits with relative timeouts on locks and condvars. Even though pthreads doesn't support this, there are various alternative APIs that use this. For exampl

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Steven Hartland
On 04/01/2018 20:50, Eugene Grosbein wrote: 05.01.2018 3:05, Steven Hartland wrote: Author: smh Date: Thu Jan 4 20:05:47 2018 New Revision: 327559 URL: https://svnweb.freebsd.org/changeset/base/327559 Log: Disabled the use of flowid for lagg by default Disabled the use of RSS hash f

Re: svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Eugene Grosbein
05.01.2018 3:05, Steven Hartland wrote: > Author: smh > Date: Thu Jan 4 20:05:47 2018 > New Revision: 327559 > URL: https://svnweb.freebsd.org/changeset/base/327559 > > Log: > Disabled the use of flowid for lagg by default > > Disabled the use of RSS hash from the network card aka flowid

Re: svn commit: r327086 - head/sys/dev/lmc

2018-01-04 Thread Kurt Lidl
On 1/4/18 5:00 AM, Poul-Henning Kamp wrote: In message <3f4a7247-e711-c65a-d973-c929ac872...@freebsd.org>, Stefan Esser writes: Am 04.01.18 um 00:41 schrieb Pedro Giffuni: It appears to be a strange beast that uses the Ethernet chip to generate a bit stream which is then converted t

svn commit: r327559 - in head: . sys/net

2018-01-04 Thread Steven Hartland
SPECIAL WARNING: ** +20180104: + The use of RSS hash from the network card aka flowid has been + disabled by default for lagg(4) as it's currently incompatible with + the lacp and loadbalance protocols. + + This can be re-enabled by

svn commit: r327558 - head/sys/dev/bhnd/cores/pmu

2018-01-04 Thread Landon J. Fuller
Author: landonf Date: Thu Jan 4 19:47:01 2018 New Revision: 327558 URL: https://svnweb.freebsd.org/changeset/base/327558 Log: bhnd(4): Add missing BCM4312 backplane clock speed entry. The default 80MHz clock speed returned by bhnd_pmu_si_clock() was already correct; this just prevents th

svn commit: r327557 - in stable/11: sys/conf sys/contrib/dev/acpica sys/contrib/dev/acpica/common sys/contrib/dev/acpica/compiler sys/contrib/dev/acpica/components/debugger sys/contrib/dev/acpica/c...

2018-01-04 Thread Jung-uk Kim
Author: jkim Date: Thu Jan 4 19:43:42 2018 New Revision: 327557 URL: https://svnweb.freebsd.org/changeset/base/327557 Log: MFC: r323076, r324502, r325670, r326866 Merge ACPICA 20171214. Added: stable/11/sys/contrib/dev/acpica/compiler/aslallocate.c - copied unchanged from r324502,

svn commit: r327556 - stable/11/sys/dev/acpica/Osd

2018-01-04 Thread Jung-uk Kim
Author: jkim Date: Thu Jan 4 19:35:55 2018 New Revision: 327556 URL: https://svnweb.freebsd.org/changeset/base/327556 Log: MFC: r324501 Do not check whether AcpiOsGetTimer() is called during boot. Modified: stable/11/sys/dev/acpica/Osd/OsdSchedule.c Directory Properties: stable/11/

svn commit: r327555 - head/sys/vm

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 18:14:58 2018 New Revision: 327555 URL: https://svnweb.freebsd.org/changeset/base/327555 Log: Restructure swapout tests after vm map locking was removed. Consolidate the regions covered by the process lock. Combine similar conditions tests into one, e.g. all p

svn commit: r327554 - head/share/misc

2018-01-04 Thread Jason Unovitch
Author: junovitch (ports committer) Date: Thu Jan 4 17:58:48 2018 New Revision: 327554 URL: https://svnweb.freebsd.org/changeset/base/327554 Log: Remove myself from ports-secteam I will be moving on to other life commitments this year and will not have the time to support contributions a

svn commit: r327553 - in stable/11/tests/sys/geom/class: . mirror

2018-01-04 Thread Mark Johnston
Author: markj Date: Thu Jan 4 16:19:56 2018 New Revision: 327553 URL: https://svnweb.freebsd.org/changeset/base/327553 Log: MFC r326861-r326863: Add some gmirror tests and fix indentation in existing tests. Added: stable/11/tests/sys/geom/class/mirror/10_test.sh - copied unchanged fro

svn commit: r327552 - stable/11/usr.sbin/makefs

2018-01-04 Thread Mark Johnston
Author: markj Date: Thu Jan 4 16:18:30 2018 New Revision: 327552 URL: https://svnweb.freebsd.org/changeset/base/327552 Log: MFC r326912: Fix a logic bug in makefs lazy inode initialization. Modified: stable/11/usr.sbin/makefs/ffs.c Directory Properties: stable/11/ (props changed) Modi

svn commit: r327551 - in stable/11/sys: amd64/amd64 cddl/contrib/opensolaris/uts/common/sys cddl/contrib/opensolaris/uts/intel/dtrace cddl/contrib/opensolaris/uts/powerpc/dtrace i386/i386 powerpc/p...

2018-01-04 Thread Mark Johnston
Author: markj Date: Thu Jan 4 16:17:31 2018 New Revision: 327551 URL: https://svnweb.freebsd.org/changeset/base/327551 Log: MFC r326774, r326811: Pass the trap frame to fasttrap hooks. Modified: stable/11/sys/amd64/amd64/trap.c stable/11/sys/cddl/contrib/opensolaris/uts/common/sys/fasttr

Re: svn commit: r327086 - head/sys/dev/lmc

2018-01-04 Thread Warner Losh
On Wed, Jan 3, 2018 at 4:41 PM, Pedro Giffuni wrote: > > > On 03/01/2018 18:03, Warner Losh wrote: > > > > On Jan 3, 2018 3:17 PM, "Brooks Davis" wrote: > > On Fri, Dec 22, 2017 at 05:15:02PM +, Pedro F. Giffuni wrote: > > Author: pfg > > Date: Fri Dec 22 17:15:02 2017 > > New Revision: 3270

svn commit: r327550 - stable/10/sys/netinet6

2018-01-04 Thread Pedro F. Giffuni
Author: pfg Date: Thu Jan 4 15:57:49 2018 New Revision: 327550 URL: https://svnweb.freebsd.org/changeset/base/327550 Log: MFC r327295: Start syncing changes from OpenBSD's ip6_id.c instead of ip_id.c. correct non-repetitive ID code, based on comments from niels provos. - seed2 is neces

svn commit: r327549 - stable/11/sys/netinet6

2018-01-04 Thread Pedro F. Giffuni
Author: pfg Date: Thu Jan 4 15:55:27 2018 New Revision: 327549 URL: https://svnweb.freebsd.org/changeset/base/327549 Log: MFC r327295: Start syncing changes from OpenBSD's ip6_id.c instead of ip_id.c. correct non-repetitive ID code, based on comments from niels provos. - seed2 is neces

svn commit: r327548 - stable/11/sys/fs/procfs

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:51:02 2018 New Revision: 327548 URL: https://svnweb.freebsd.org/changeset/base/327548 Log: MFC r327286: Reuse kern_proc_vmmap_resident() for procfs_map resident count. Modified: stable/11/sys/fs/procfs/procfs_map.c Directory Properties: stable/11/ (props

svn commit: r327547 - in stable/11/sys: kern sys

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:49:32 2018 New Revision: 327547 URL: https://svnweb.freebsd.org/changeset/base/327547 Log: MFC r327285: Make kern_proc_vmmap_resident() externally accesible, and move the vmmap_skip_res_cnt control check inside it. Modified: stable/11/sys/kern/kern_proc.c

svn commit: r327546 - stable/11/sys/vm

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:44:58 2018 New Revision: 327546 URL: https://svnweb.freebsd.org/changeset/base/327546 Log: MFC r327316: In vm_swapout_map_deactivate_pages(), it is enough to lock the map for read. Modified: stable/11/sys/vm/vm_swapout.c Directory Properties: stable/11/ (

svn commit: r327545 - stable/11/sys/vm

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:43:42 2018 New Revision: 327545 URL: https://svnweb.freebsd.org/changeset/base/327545 Log: MFC r327319: Clean up the comment. Modified: stable/11/sys/vm/vm_swapout.c Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/vm/vm_swapout.c

svn commit: r327544 - stable/11/sys/x86/include

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:40:22 2018 New Revision: 327544 URL: https://svnweb.freebsd.org/changeset/base/327544 Log: MFC r327469: Add CR4.SMAP control bit. Modified: stable/11/sys/x86/include/specialreg.h Directory Properties: stable/11/ (props changed) Modified: stable/11/sys/x8

svn commit: r327543 - stable/11/usr.sbin/cpucontrol

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:38:42 2018 New Revision: 327543 URL: https://svnweb.freebsd.org/changeset/base/327543 Log: MFC r327284: Style. Remove useless return. Modified: stable/11/usr.sbin/cpucontrol/intel.c Directory Properties: stable/11/ (props changed) Modified: stable/11/us

svn commit: r327542 - stable/11/usr.sbin/cpucontrol

2018-01-04 Thread Konstantin Belousov
Author: kib Date: Thu Jan 4 11:36:13 2018 New Revision: 327542 URL: https://svnweb.freebsd.org/changeset/base/327542 Log: MFC r327264i (by imp), r327283: Fix returns without cleanups. Modified: stable/11/usr.sbin/cpucontrol/intel.c stable/11/usr.sbin/cpucontrol/via.c Directory Properties

Re: svn commit: r327086 - head/sys/dev/lmc

2018-01-04 Thread Poul-Henning Kamp
In message <3f4a7247-e711-c65a-d973-c929ac872...@freebsd.org>, Stefan Esser writes: >Am 04.01.18 um 00:41 schrieb Pedro Giffuni: >It appears to be a strange beast that uses the Ethernet chip to generate a >bit stream which is then converted to HDLC. Not sure whether these were used >for

Re: svn commit: r327086 - head/sys/dev/lmc

2018-01-04 Thread Stefan Esser
Am 04.01.18 um 00:41 schrieb Pedro Giffuni: > Either the license is very naively stated or the device should have been added > in the contrib/gnu branches. This appears to be one of the dual-licensed drivers, that are the result of some BSD driver having been ported to Linux with the original copy

svn commit: r327541 - head/lib/libcasper/libcasper

2018-01-04 Thread Mariusz Zaborski
Author: oshogbo Date: Thu Jan 4 08:23:23 2018 New Revision: 327541 URL: https://svnweb.freebsd.org/changeset/base/327541 Log: cap_unwrap should return a descriptor but also free the structure. Modified: head/lib/libcasper/libcasper/libcasper.h Modified: head/lib/libcasper/libcasper/libcaspe

Re: svn commit: r327086 - head/sys/dev/lmc

2018-01-04 Thread Poul-Henning Kamp
In message , Warner Losh writes: >Deleting lmc(4) is probably the appropriate fix. >Inc is for very old interconnect to telco... So maybe that's safe to delete. As the guy who put lmc(4) in the tree I concur. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 p...@freebsd.org