svn commit: r340800 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:56 2018 New Revision: 340800 URL: https://svnweb.freebsd.org/changeset/base/340800 Log: sfxge(4): let caller know that queue is already flushed Tx/Rx queue may be already flushed due to Tx/Rx error on the queue or MC reboot. Caller needs to know

svn commit: r340798 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:34 2018 New Revision: 340798 URL: https://svnweb.freebsd.org/changeset/base/340798 Log: sfxge(4): fix out of bounds read in VIs allocation Submitted by: Andy Moreton Sponsored by: Solarflare Communications, Inc. MFC after: 1 week

svn commit: r340799 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:45 2018 New Revision: 340799 URL: https://svnweb.freebsd.org/changeset/base/340799 Log: sfxge(4): fix error code usage MCDI results returned in req.emr_rc have already been translated from MC_CMD_ERR_* to errno names, so using an MC_CMD_ERR_* value

svn commit: r340797 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:50:22 2018 New Revision: 340797 URL: https://svnweb.freebsd.org/changeset/base/340797 Log: sfxge(4): fix potential buffer overflow in Tx queue init Improve error checking to avoid a caller overflowing the MCDI request buffer if the requested TXQ size

svn commit: r340796 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:43:44 2018 New Revision: 340796 URL: https://svnweb.freebsd.org/changeset/base/340796 Log: sfxge(4): fix failure path in EF10 Tx queue PIO enable Submitted by: Andy Moreton Sponsored by: Solarflare Communications, Inc. MFC after: 1 week

svn commit: r340795 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:38:59 2018 New Revision: 340795 URL: https://svnweb.freebsd.org/changeset/base/340795 Log: sfxge(4): add advanced function to extract FW version Some libefx-based drivers might need this functionality to indicate DPCPU FW IDs as part of FW version

svn commit: r340794 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Fri Nov 23 07:26:37 2018 New Revision: 340794 URL: https://svnweb.freebsd.org/changeset/base/340794 Log: sfxge(4): add MCDI agnostic wrapper for MAC stats clear If a libefx-based driver needs some way to clear port statistics, then an MCDI agnostic method is

svn commit: r340793 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Fri Nov 23 04:38:50 2018 New Revision: 340793 URL: https://svnweb.freebsd.org/changeset/base/340793 Log: Revert "fork: fix use-after-free with vfork" This unreliably breaks libc handling of vfork where forking succeded, but execve did not. vfork code in libc

svn commit: r340792 - head/sbin/ipfw

2018-11-22 Thread Guangyuan Yang
Author: ygy (doc committer) Date: Fri Nov 23 03:42:05 2018 New Revision: 340792 URL: https://svnweb.freebsd.org/changeset/base/340792 Log: Fix a minor typo in ipfw(8) manual page. PR: 230747 Submitted by: f.tos...@hotmail.it MFC after:1 week Modified:

svn commit: r340791 - releng/12.0/sys/kern

2018-11-22 Thread Mark Johnston
Author: markj Date: Fri Nov 23 01:07:12 2018 New Revision: 340791 URL: https://svnweb.freebsd.org/changeset/base/340791 Log: MFstable/12 r340788: Clear pad bytes in the struct exported by kern.ntp_pll.gettime. Approved by: re (gjb) Modified: releng/12.0/sys/kern/kern_ntptime.c

svn commit: r340790 - stable/12/usr.sbin/kldxref

2018-11-22 Thread Ed Maste
Author: emaste Date: Fri Nov 23 01:05:42 2018 New Revision: 340790 URL: https://svnweb.freebsd.org/changeset/base/340790 Log: MFC r340285: kldxref: use appropriate Elf_Off type for offsets Submitted by: Mitchell Horne Sponsored by: The FreeBSD Foundation Modified:

svn commit: r340789 - stable/11/sys/kern

2018-11-22 Thread Mark Johnston
Author: markj Date: Fri Nov 23 00:59:42 2018 New Revision: 340789 URL: https://svnweb.freebsd.org/changeset/base/340789 Log: MFC r340699: Clear pad bytes in the struct exported by kern.ntp_pll.gettime. Modified: stable/11/sys/kern/kern_ntptime.c Directory Properties: stable/11/ (props

svn commit: r340788 - stable/12/sys/kern

2018-11-22 Thread Mark Johnston
Author: markj Date: Fri Nov 23 00:56:42 2018 New Revision: 340788 URL: https://svnweb.freebsd.org/changeset/base/340788 Log: MFC r340699: Clear pad bytes in the struct exported by kern.ntp_pll.gettime. Modified: stable/12/sys/kern/kern_ntptime.c Directory Properties: stable/12/ (props

svn commit: r340787 - head/sys/fs/nfsclient

2018-11-22 Thread Rick Macklem
Author: rmacklem Date: Fri Nov 23 00:17:47 2018 New Revision: 340787 URL: https://svnweb.freebsd.org/changeset/base/340787 Log: Make sure the NFS readdir client fills in all "struct dirent" data. The NFS client code (nfsrpc_readdir() and nfsrpc_readdirplus()) wasn't filling in parts of

svn commit: r340786 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Thu Nov 22 21:38:24 2018 New Revision: 340786 URL: https://svnweb.freebsd.org/changeset/base/340786 Log: Annotate TDP_RFPPWAIT as unlikely. The flag is only set on vfork, but is tested for *all* syscalls. On amd64 this shortens common-case (not vfork) code. Modified:

svn commit: r340785 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Thu Nov 22 21:29:36 2018 New Revision: 340785 URL: https://svnweb.freebsd.org/changeset/base/340785 Log: fork: remove avoidable proc lock/unlock pair We don't have to access the process after making it runnable, so there is no need to hold it either. Sponsored by:

svn commit: r340784 - head/sys/kern

2018-11-22 Thread Mateusz Guzik
Author: mjg Date: Thu Nov 22 21:08:37 2018 New Revision: 340784 URL: https://svnweb.freebsd.org/changeset/base/340784 Log: fork: fix use-after-free with vfork The pointer to the child is stored without any reference held. Then it is blindly used to wait until P_PPWAIT is cleared.

svn commit: r340783 - in head/sys: kern netinet netinet6 ofed/drivers/infiniband/ulp/sdp

2018-11-22 Thread Mark Johnston
Author: markj Date: Thu Nov 22 20:49:41 2018 New Revision: 340783 URL: https://svnweb.freebsd.org/changeset/base/340783 Log: Plug some networking sysctl leaks. Various network protocol sysctl handlers were not zero-filling their output buffers and thus would export uninitialized stack

svn commit: r340782 - head/sys/netinet/tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 20:05:57 2018 New Revision: 340782 URL: https://svnweb.freebsd.org/changeset/base/340782 Log: A TCP stack is required to check SEG.ACK first, when processing a segment in the SYN-SENT state as stated in Section 3.9 of RFC 793, page 66. Ensure this is also

svn commit: r340781 - head/sys/netinet/tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 20:02:39 2018 New Revision: 340781 URL: https://svnweb.freebsd.org/changeset/base/340781 Log: Ensure that the TCP RACK stack honours the setting of the net.inet.tcp.drop_synfin sysctl-variable. Reviewed by: rrs@ MFC after:1 week

svn commit: r340780 - stable/12/tests/sys/netpfil/pf

2018-11-22 Thread Kristof Provost
Author: kp Date: Thu Nov 22 20:00:56 2018 New Revision: 340780 URL: https://svnweb.freebsd.org/changeset/base/340780 Log: MFC r340266: pf tests: Test PR 183198 Create a table which is only used inside an anchor, ensure that the table exists. PR: 183198 Added:

svn commit: r340779 - stable/11/sbin/pfctl

2018-11-22 Thread Kristof Provost
Author: kp Date: Thu Nov 22 19:59:04 2018 New Revision: 340779 URL: https://svnweb.freebsd.org/changeset/base/340779 Log: MFC r340264: pfctl: Populate ifname in ifa_lookup() pfctl_adjust_skip_ifaces() relies on this name. Modified: stable/11/sbin/pfctl/pfctl_parser.c Directory

svn commit: r340778 - stable/12/sbin/pfctl

2018-11-22 Thread Kristof Provost
Author: kp Date: Thu Nov 22 19:59:02 2018 New Revision: 340778 URL: https://svnweb.freebsd.org/changeset/base/340778 Log: MFC r340264: pfctl: Populate ifname in ifa_lookup() pfctl_adjust_skip_ifaces() relies on this name. Modified: stable/12/sbin/pfctl/pfctl_parser.c Directory

svn commit: r340777 - head/sys/netinet/tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 19:56:52 2018 New Revision: 340777 URL: https://svnweb.freebsd.org/changeset/base/340777 Log: Ensure that the default RTT stack can make an RTT measurement if the TCP connection was initiated using the RACK stack, but the peer does not support the TCP RACK

svn commit: r340775 - stable/12/sys/netpfil/pf

2018-11-22 Thread Kristof Provost
Author: kp Date: Thu Nov 22 19:56:50 2018 New Revision: 340775 URL: https://svnweb.freebsd.org/changeset/base/340775 Log: MFC r340265: pf: Prevent tables referenced by rules in anchors from getting disabled. PR: 183198 Obtained from:OpenBSD Modified:

svn commit: r340776 - stable/11/sys/netpfil/pf

2018-11-22 Thread Kristof Provost
Author: kp Date: Thu Nov 22 19:56:51 2018 New Revision: 340776 URL: https://svnweb.freebsd.org/changeset/base/340776 Log: MFC r340265: pf: Prevent tables referenced by rules in anchors from getting disabled. PR: 183198 Obtained from:OpenBSD Modified:

svn commit: r340774 - in head/sys/netinet: . tcp_stacks

2018-11-22 Thread Michael Tuexen
Author: tuexen Date: Thu Nov 22 19:49:52 2018 New Revision: 340774 URL: https://svnweb.freebsd.org/changeset/base/340774 Log: Ensure that TCP RST-segments announce consistently a receiver window of zero. This was already done when sending them via tcp_respond(). Reviewed by:

svn commit: r340773 - in releng/12.0: . rescue/rescue share/mk tools/build/options

2018-11-22 Thread Ed Maste
Author: emaste Date: Thu Nov 22 18:59:05 2018 New Revision: 340773 URL: https://svnweb.freebsd.org/changeset/base/340773 Log: MF12 r340697: Introduce src.conf knob to build userland with retpoline MFC r339511: Introduce src.conf knob to build userland with retpoline WITH_RETPOLINE

svn commit: r340772 - head/sys/amd64/ia32

2018-11-22 Thread Mark Johnston
Author: markj Date: Thu Nov 22 17:51:19 2018 New Revision: 340772 URL: https://svnweb.freebsd.org/changeset/base/340772 Log: Clear unused bytes in ia32_osendsig(). Mirror the fix for the native i386 implementation from r218327. This code is compiled only when the non-default COMPAT_43

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-22 Thread Warner Losh
On Thu, Nov 22, 2018 at 10:28 AM Mateusz Guzik wrote: > On 11/20/18, Warner Losh wrote: > > On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > > > >> On 11/20/18, Konstantin Belousov wrote: > >> >> +#if defined(__mips__) || defined(__powerpc__) > >> > Please note what I asked about this

Re: svn commit: r340676 - in head/sys: kern sys

2018-11-22 Thread Mateusz Guzik
On 11/20/18, Warner Losh wrote: > On Tue, Nov 20, 2018 at 8:28 AM Mateusz Guzik wrote: > >> On 11/20/18, Konstantin Belousov wrote: >> >> +#if defined(__mips__) || defined(__powerpc__) >> > Please note what I asked about this #ifdefs in the review. mips >> > and powerpc machine/atomic.h should

svn commit: r340771 - head/sys/dev/proto

2018-11-22 Thread Ed Maste
Author: emaste Date: Thu Nov 22 16:55:09 2018 New Revision: 340771 URL: https://svnweb.freebsd.org/changeset/base/340771 Log: proto: change device permissions to 0600 C Turt reports that the driver is not thread safe and may have exploitable races. Note that the proto device is

svn commit: r340770 - stable/12/sys/fs/fuse

2018-11-22 Thread Mark Johnston
Author: markj Date: Thu Nov 22 16:53:30 2018 New Revision: 340770 URL: https://svnweb.freebsd.org/changeset/base/340770 Log: MFC r340639: Remove comments made obsolete by the ino64 work. Modified: stable/12/sys/fs/fuse/fuse_internal.c stable/12/sys/fs/fuse/fuse_internal.h Directory

svn commit: r340769 - stable/12/usr.bin/ldd

2018-11-22 Thread Mark Johnston
Author: markj Date: Thu Nov 22 16:52:30 2018 New Revision: 340769 URL: https://svnweb.freebsd.org/changeset/base/340769 Log: MFC r339653: Add an IMPLEMENTATION NOTES section to ldd.1. PR: 231926 Modified: stable/12/usr.bin/ldd/ldd.1 Directory Properties: stable/12/ (props

svn commit: r340768 - releng/12.0/sys/sparc64/sparc64

2018-11-22 Thread Marius Strobl
Author: marius Date: Thu Nov 22 16:27:30 2018 New Revision: 340768 URL: https://svnweb.freebsd.org/changeset/base/340768 Log: MFC: r340656, MF12: r340759 Given that the idea of D15374 was to "make memmove a first class citizen", provide a _MEMMOVE extension of _MEMCPY that deals with

svn commit: r340767 - in head/sys/dev/sfxge: . common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Thu Nov 22 16:15:24 2018 New Revision: 340767 URL: https://svnweb.freebsd.org/changeset/base/340767 Log: sfxge(4): limit max TXQ size on Medford to 2048 Queues with 4096 descriptors are not supported as the top bit is used for vfifo stuffing. Submitted by:

svn commit: r340766 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Thu Nov 22 14:31:35 2018 New Revision: 340766 URL: https://svnweb.freebsd.org/changeset/base/340766 Log: sfxge(4): support packed stream Rx mode in libefx Submitted by: Artem V. Andreev Sponsored by: Solarflare Communications, Inc. Differential Revision:

svn commit: r340765 - head/sys/dev/sfxge/common

2018-11-22 Thread Andrew Rybchenko
Author: arybchik Date: Thu Nov 22 14:10:46 2018 New Revision: 340765 URL: https://svnweb.freebsd.org/changeset/base/340765 Log: sfxge(4): cleanup: move into right place Due to incorrect merge the piece of code was put in incorrect place and diverge from libefx in other locations.

svn commit: r340764 - stable/10/sys/dev/sdhci

2018-11-22 Thread Marius Strobl
Author: marius Date: Thu Nov 22 13:18:58 2018 New Revision: 340764 URL: https://svnweb.freebsd.org/changeset/base/340764 Log: MFC: r339007, r340543, r340654 - Add ACPI identifier for AMD eMMC 5.0 controller [1] - Add a quirk handling for AMDI0040 controllers allowing them to do HS400.

Re: svn commit: r339516 - head/sys/cddl/dev/dtrace/powerpc

2018-11-22 Thread Kyle Evans
On Thu, Nov 22, 2018 at 1:16 AM Mark Johnston wrote: > > On Wed, Nov 21, 2018 at 10:02:15PM -0600, Kyle Evans wrote: > > On Wed, Nov 21, 2018 at 9:42 PM Kyle Evans wrote: > > > > > > On Sat, Oct 20, 2018 at 9:09 PM Justin Hibbits > > > wrote: > > > > > > > > Author: jhibbits > > > > Date: Sun

svn commit: r340763 - stable/11/sys/dev/sdhci

2018-11-22 Thread Marius Strobl
Author: marius Date: Thu Nov 22 13:14:15 2018 New Revision: 340763 URL: https://svnweb.freebsd.org/changeset/base/340763 Log: MFC: r339007, r340543, r340654 - Add ACPI identifier for AMD eMMC 5.0 controller [1] - Add a quirk handling for AMDI0040 controllers allowing them to do HS400.

svn commit: r340761 - releng/12.0/sys/compat/linux

2018-11-22 Thread Tijl Coosemans
Author: tijl Date: Thu Nov 22 13:09:42 2018 New Revision: 340761 URL: https://svnweb.freebsd.org/changeset/base/340761 Log: MFS r340755: Do proper copyin of control message data in the Linux sendmsg syscall. Instead of calling m_append with a user address, allocate an mbuf cluster

svn commit: r340760 - stable/12/sys/dev/sdhci

2018-11-22 Thread Marius Strobl
Author: marius Date: Thu Nov 22 13:09:03 2018 New Revision: 340760 URL: https://svnweb.freebsd.org/changeset/base/340760 Log: MFC: r340543, r340654 Add a quirk handling for AMDI0040 controllers allowing them to do HS400. Submitted by: Shreyank Amartya (original version) Modified:

svn commit: r340759 - stable/12/sys/sparc64/sparc64

2018-11-22 Thread Marius Strobl
Author: marius Date: Thu Nov 22 13:03:11 2018 New Revision: 340759 URL: https://svnweb.freebsd.org/changeset/base/340759 Log: MFC: r340656 Given that the idea of D15374 was to "make memmove a first class citizen", provide a _MEMMOVE extension of _MEMCPY that deals with overlap based on

svn commit: r340758 - stable/11/sys/compat/linux

2018-11-22 Thread Tijl Coosemans
Author: tijl Date: Thu Nov 22 09:47:51 2018 New Revision: 340758 URL: https://svnweb.freebsd.org/changeset/base/340758 Log: MFC r340674: Fix another user address dereference in linux_sendmsg syscall. This was hidden behind the LINUX_CMSG_NXTHDR macro which dereferences its second

svn commit: r340757 - stable/12/sys/compat/linux

2018-11-22 Thread Tijl Coosemans
Author: tijl Date: Thu Nov 22 09:47:42 2018 New Revision: 340757 URL: https://svnweb.freebsd.org/changeset/base/340757 Log: MFC r340674: Fix another user address dereference in linux_sendmsg syscall. This was hidden behind the LINUX_CMSG_NXTHDR macro which dereferences its second

svn commit: r340756 - stable/11/sys/compat/linux

2018-11-22 Thread Tijl Coosemans
Author: tijl Date: Thu Nov 22 09:41:54 2018 New Revision: 340756 URL: https://svnweb.freebsd.org/changeset/base/340756 Log: MFC r340631: Do proper copyin of control message data in the Linux sendmsg syscall. Instead of calling m_append with a user address, allocate an mbuf cluster

svn commit: r340755 - stable/12/sys/compat/linux

2018-11-22 Thread Tijl Coosemans
Author: tijl Date: Thu Nov 22 09:41:45 2018 New Revision: 340755 URL: https://svnweb.freebsd.org/changeset/base/340755 Log: MFC r340631: Do proper copyin of control message data in the Linux sendmsg syscall. Instead of calling m_append with a user address, allocate an mbuf cluster