Re: svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys

John: Thanks for the suggestions.. I have committed changes to the two nits. As to M_PROTO1, I see that in the NF world we have removed M_PROTO12 and moved the M_PROTO’s up 1 i.e. M_PROTO1 == 0x2000 So for now it is safe, since the M_TSTMP_LRO is not yet used.. but in my up and coming commits I

svn commit: r349908 - head/sys/netinet/tcp_stacks

Author: rrs Date: Thu Jul 11 04:40:58 2019 New Revision: 349908 URL: https://svnweb.freebsd.org/changeset/base/349908 Log: Update to jhb's other suggestion, use #error when we are missing HPTS. Modified: head/sys/netinet/tcp_stacks/rack.c Modified: head/sys/netinet/tcp_stacks/rack.c

svn commit: r349907 - head/sys/netinet/tcp_stacks

Author: rrs Date: Thu Jul 11 04:38:33 2019 New Revision: 349907 URL: https://svnweb.freebsd.org/changeset/base/349907 Log: Update copyright per JBH's suggestions.. thanks. Modified: head/sys/netinet/tcp_stacks/rack.c Modified: head/sys/netinet/tcp_stacks/rack.c

svn commit: r349906 - head/sys/powerpc/powerpc

Author: jhibbits Date: Thu Jul 11 03:29:25 2019 New Revision: 349906 URL: https://svnweb.freebsd.org/changeset/base/349906 Log: powerpc: Only worry about the lower 32 bits of SP in a 32-bit process Summary: Running a 32-bit process on a 64-bit POWER CPU may still use all 64-bits in

svn commit: r349905 - head/sys/arm64/arm64

Author: alc Date: Thu Jul 11 02:43:23 2019 New Revision: 349905 URL: https://svnweb.freebsd.org/changeset/base/349905 Log: According to Section D5.10.3 "Maintenance requirements on changing System register values" of the architecture manual, an isb instruction should be executed after

svn commit: r349904 - head

Author: markj Date: Thu Jul 11 02:15:50 2019 New Revision: 349904 URL: https://svnweb.freebsd.org/changeset/base/349904 Log: Add vm_page_hold.9 to ObsoleteFiles.inc. Add a missing .gz suffix to pwm.9 while here. Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc

Re: svn commit: r349890 - head/contrib/telnet/telnet

In message <20190711014729.gb23...@freebsd.org>, Alexey Dokuchaev writes: > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > New Revision: 349890 > > URL: https://svnweb.freebsd.org/changeset/base/349890 > > > > Log: > > telnet: fix a couple of snprintf() buffer overflows > >

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > New Revision: 349890 > URL: https://svnweb.freebsd.org/changeset/base/349890 > > Log: > telnet: fix a couple of snprintf() buffer overflows > > Modified: head/contrib/telnet/telnet/commands.c > @@ -1655,10 +1655,11 @@

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 04:45:06PM -0600, Warner Losh wrote: > On Wed, Jul 10, 2019 at 4:43 PM Shawn Webb > > ... > > Because the existing code already used malloc + snprintf. And this is > > contrib/telnet/telnet, which arguably should be `rm -rf`ed. ;) > > > > The bike shed is now

svn commit: r349903 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:44:09 2019 New Revision: 349903 URL: https://svnweb.freebsd.org/changeset/base/349903 Log: MFC 349843: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port

svn commit: r349903 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:44:09 2019 New Revision: 349903 URL: https://svnweb.freebsd.org/changeset/base/349903 Log: MFC 349843: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port

svn commit: r349903 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:44:09 2019 New Revision: 349903 URL: https://svnweb.freebsd.org/changeset/base/349903 Log: MFC 349843: Update frtuc struct comments. It not only defines TCP things we are interested in but also UDP. While at it document the source and destination port

svn commit: r349902 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:38:10 2019 New Revision: 349902 URL: https://svnweb.freebsd.org/changeset/base/349902 Log: MFC r349842: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description.

svn commit: r349902 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:38:10 2019 New Revision: 349902 URL: https://svnweb.freebsd.org/changeset/base/349902 Log: MFC r349842: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description.

svn commit: r349902 - in stable: 10/sys/contrib/ipfilter/netinet 11/sys/contrib/ipfilter/netinet 12/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:38:10 2019 New Revision: 349902 URL: https://svnweb.freebsd.org/changeset/base/349902 Log: MFC r349842: Correct the description for the low port in the port compare struct. Adjust the high port description to match that of the low port description.

svn commit: r349901 - in stable/10: contrib/libarchive/libarchive contrib/libarchive/libarchive/test lib/libarchive/tests

Author: mm Date: Thu Jul 11 00:22:10 2019 New Revision: 349901 URL: https://svnweb.freebsd.org/changeset/base/349901 Log: MFC r349527,349538: Sync libarchive with vendor. Relevant vendor changes: PR #1217: RAR5 reader - fix ARM filter going beyond window buffer boundary

svn commit: r349900 - in stable/11: contrib/libarchive/libarchive contrib/libarchive/libarchive/test lib/libarchive/tests

Author: mm Date: Thu Jul 11 00:21:47 2019 New Revision: 349900 URL: https://svnweb.freebsd.org/changeset/base/349900 Log: MFC r349527,349538: Sync libarchive with vendor. Relevant vendor changes: PR #1217: RAR5 reader - fix ARM filter going beyond window buffer boundary

svn commit: r349899 - in stable/12: contrib/libarchive/libarchive contrib/libarchive/libarchive/test lib/libarchive/tests

Author: mm Date: Thu Jul 11 00:21:15 2019 New Revision: 349899 URL: https://svnweb.freebsd.org/changeset/base/349899 Log: MFC r349527,349538: Sync libarchive with vendor. Relevant vendor changes: PR #1217: RAR5 reader - fix ARM filter going beyond window buffer boundary

svn commit: r349898 - head/sys/contrib/ipfilter/netinet

Author: cy Date: Thu Jul 11 00:08:46 2019 New Revision: 349898 URL: https://svnweb.freebsd.org/changeset/base/349898 Log: ipfilter commands, in this case ipf(8), passes its operations and rules via an ioctl interface. Rules can be added or removed and stats and counters can be zeroed out.

Re: svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys

On 7/10/19 1:40 PM, Randall Stewart wrote: > Author: rrs > Date: Wed Jul 10 20:40:39 2019 > New Revision: 349893 > URL: https://svnweb.freebsd.org/changeset/base/349893 > > Log: > This commit updates rack to what is basically being used at NF as > well as sets in some of the groundwork for

svn commit: r349897 - head/sys/arm64/arm64

Author: markj Date: Wed Jul 10 22:52:26 2019 New Revision: 349897 URL: https://svnweb.freebsd.org/changeset/base/349897 Log: Rename pmap_page_dirty() to pmap_pte_dirty(). This is a precursor to implementing dirty bit management. Discussed with: alc MFC after:1 week

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 4:43 PM Shawn Webb wrote: > On Wed, Jul 10, 2019 at 04:40:25PM -0600, Warner Losh wrote: > > On Wed, Jul 10, 2019 at 4:29 PM Shawn Webb > > wrote: > > > > > On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > > > > On Wed, Jul 10, 2019 at 03:19:44PM -0500,

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 04:40:25PM -0600, Warner Losh wrote: > On Wed, Jul 10, 2019 at 4:29 PM Shawn Webb > wrote: > > > On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > > > On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > > > > On Wed, 10 Jul 2019 15:55:48 -0400 >

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 4:29 PM Shawn Webb wrote: > On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > > On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > > > On Wed, 10 Jul 2019 15:55:48 -0400 > > > Shawn Webb wrote: > > > > > > > On Wed, Jul 10, 2019 at 05:42:04PM

svn commit: r349896 - head/contrib/telnet/telnet

Author: philip Date: Wed Jul 10 22:36:14 2019 New Revision: 349896 URL: https://svnweb.freebsd.org/changeset/base/349896 Log: telnet: fix minor style violation While here also fix a very unlikely NULL pointer dereference. Submitted by: Shawn Webb Modified:

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 04:22:18PM -0400, Shawn Webb wrote: > On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > > On Wed, 10 Jul 2019 15:55:48 -0400 > > Shawn Webb wrote: > > > > > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > > > Author: philip > > > > Date:

svn commit: r349895 - head/sys/dev/isci

Author: imp Date: Wed Jul 10 22:23:59 2019 New Revision: 349895 URL: https://svnweb.freebsd.org/changeset/base/349895 Log: Enforce a 4GB DMA boundary on isci(4) This device cannot cross a 4GB boundary with DMA. Removing the boundary in r346386 resulted in low frequency memory corruption

svn commit: r349894 - in stable/12/lib/libsecureboot: . h openpgp

Author: sjg Date: Wed Jul 10 21:35:55 2019 New Revision: 349894 URL: https://svnweb.freebsd.org/changeset/base/349894 Log: libsecureboot: allow OpenPGP support to be dormant Since we can now add OpenPGP trust anchors at runtime, ensure the latent support is available. Ensure we do

svn commit: r349893 - in head/sys: modules/tcp/rack netinet netinet/tcp_stacks sys

Author: rrs Date: Wed Jul 10 20:40:39 2019 New Revision: 349893 URL: https://svnweb.freebsd.org/changeset/base/349893 Log: This commit updates rack to what is basically being used at NF as well as sets in some of the groundwork for committing BBR. The hpts system is updated as well as some

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 03:19:44PM -0500, Justin Hibbits wrote: > On Wed, 10 Jul 2019 15:55:48 -0400 > Shawn Webb wrote: > > > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > > Author: philip > > > Date: Wed Jul 10 17:42:04 2019 > > > New Revision: 349890 > > > URL:

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, 10 Jul 2019 15:55:48 -0400 Shawn Webb wrote: > On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > > Author: philip > > Date: Wed Jul 10 17:42:04 2019 > > New Revision: 349890 > > URL: https://svnweb.freebsd.org/changeset/base/349890 > > > > Log: > > telnet: fix a couple

svn commit: r349892 - head/sys/kern

Author: markj Date: Wed Jul 10 19:57:48 2019 New Revision: 349892 URL: https://svnweb.freebsd.org/changeset/base/349892 Log: Inherit P2_PROTMAX_{ENABLE,DISABLE} across fork(). Thus, when using proccontrol(1) to disable implicit application of PROT_MAX within a process, child processes

Re: svn commit: r349890 - head/contrib/telnet/telnet

On Wed, Jul 10, 2019 at 05:42:04PM +, Philip Paeps wrote: > Author: philip > Date: Wed Jul 10 17:42:04 2019 > New Revision: 349890 > URL: https://svnweb.freebsd.org/changeset/base/349890 > > Log: > telnet: fix a couple of snprintf() buffer overflows > > Obtained from: Juniper

svn commit: r349891 - head/lib/libc/arm/gen

Author: ian Date: Wed Jul 10 19:32:50 2019 New Revision: 349891 URL: https://svnweb.freebsd.org/changeset/base/349891 Log: Reorganize the SRCS lists as one file per line, and then alphabetize them. No functional changes. Modified: head/lib/libc/arm/gen/Makefile.inc Modified:

svn commit: r349890 - head/contrib/telnet/telnet

Author: philip Date: Wed Jul 10 17:42:04 2019 New Revision: 349890 URL: https://svnweb.freebsd.org/changeset/base/349890 Log: telnet: fix a couple of snprintf() buffer overflows Obtained from:Juniper Networks MFC after:1 week Modified: head/contrib/telnet/telnet/commands.c

svn commit: r349889 - head/sys/mips/ingenic

Author: imp Date: Wed Jul 10 17:21:59 2019 New Revision: 349889 URL: https://svnweb.freebsd.org/changeset/base/349889 Log: Fix compile errors with the CI20 Fix mutex includes and fix a typo. The CI20 kernel is not built as part of universe. PR: 239115 Submitted by: Kai Nacke

svn commit: r349888 - stable/11/release/doc/share/xml

Author: gjb Date: Wed Jul 10 14:46:18 2019 New Revision: 349888 URL: https://svnweb.freebsd.org/changeset/base/349888 Log: Prune leftover security/errata information from 11.2 that was supposed to be removed when regenerating the 11.3 errata page. Reported by: Terry Kennedy Sponsored

svn commit: r349887 - head/sys/arm/include

Author: ian Date: Wed Jul 10 14:34:52 2019 New Revision: 349887 URL: https://svnweb.freebsd.org/changeset/base/349887 Log: De-pollute arm's sysarch.h. Instead of including stdint.h for uintptr_t, include sys/_types.h and use __types for everything that isn't a native C keyword type.

svn commit: r349886 - head/sys/compat/linux

Author: avg Date: Wed Jul 10 13:47:10 2019 New Revision: 349886 URL: https://svnweb.freebsd.org/changeset/base/349886 Log: linuxcommon: add module version MFC after:2 weeks Modified: head/sys/compat/linux/linux_common.c Modified: head/sys/compat/linux/linux_common.c

svn commit: r349885 - head/sys/powerpc/pseries

Author: luporl Date: Wed Jul 10 13:36:17 2019 New Revision: 349885 URL: https://svnweb.freebsd.org/changeset/base/349885 Log: [PPC64] pseries: fix realmaxaddr calculation On POWER9/pseries, QEMU passes several regions of memory, instead of a single region containing all memory, as the

svn commit: r349884 - stable/11/sys/conf

Author: gjb Date: Wed Jul 10 13:35:01 2019 New Revision: 349884 URL: https://svnweb.freebsd.org/changeset/base/349884 Log: Call stable/11 -STABLE now that 11.3-RELEASE is out. Reminded by: marck Sponsored by: Rubicon Communications, LLC (Netgate) Modified:

svn commit: r349883 - head/sys/dev/ow

Author: avg Date: Wed Jul 10 12:40:07 2019 New Revision: 349883 URL: https://svnweb.freebsd.org/changeset/base/349883 Log: owc_gpiobus: small formatting cleanup MFC after:1 week Modified: head/sys/dev/ow/owc_gpiobus.c Modified: head/sys/dev/ow/owc_gpiobus.c

svn commit: r349882 - stable/12/share/man/man4

Author: mav Date: Wed Jul 10 12:15:07 2019 New Revision: 349882 URL: https://svnweb.freebsd.org/changeset/base/349882 Log: MFC r340093 (by imp): Document disbale_phy in ahcich sysctls. Modified: stable/12/share/man/man4/ahci.4 Directory Properties: stable/12/ (props changed) Modified:

svn commit: r349881 - stable/12/sys/conf

Author: mav Date: Wed Jul 10 12:10:10 2019 New Revision: 349881 URL: https://svnweb.freebsd.org/changeset/base/349881 Log: MFC r349418: Fix qlxgbe(4) static build. Modified: stable/12/sys/conf/files.amd64 Directory Properties: stable/12/ (props changed) Modified:

svn commit: r349880 - head/sys/compat/linux

Author: tijl Date: Wed Jul 10 08:19:33 2019 New Revision: 349880 URL: https://svnweb.freebsd.org/changeset/base/349880 Log: Let linuxulator mprotect mask unsupported bits before calling kern_mprotect. After r349240 kern_mprotect returns EINVAL for unsupported bits in the prot argument.

svn commit: r349879 - stable/11/tools/build/mk

Author: tijl Date: Wed Jul 10 08:08:14 2019 New Revision: 349879 URL: https://svnweb.freebsd.org/changeset/base/349879 Log: MFC r349641: Also remove lib32 versions of libradius. Modified: stable/11/tools/build/mk/OptionalObsoleteFiles.inc Directory Properties: stable/11/ (props

svn commit: r349878 - stable/12/tools/build/mk

Author: tijl Date: Wed Jul 10 08:07:33 2019 New Revision: 349878 URL: https://svnweb.freebsd.org/changeset/base/349878 Log: MFC r349641: Also remove lib32 versions of libradius. Modified: stable/12/tools/build/mk/OptionalObsoleteFiles.inc Directory Properties: stable/12/ (props

svn commit: r349877 - stable/12

Author: tijl Date: Wed Jul 10 08:05:13 2019 New Revision: 349877 URL: https://svnweb.freebsd.org/changeset/base/349877 Log: MFC r349640, r349706: Also remove lib32 version of libcasper.so.0. Modified: stable/12/ObsoleteFiles.inc Directory Properties: stable/12/ (props changed)