On 19.07.2012 18:08, Doug Barton wrote:
On 07/19/2012 06:54, Alexander V. Chernikov wrote:
On 19.07.2012 17:44, Doug Barton wrote:
On 07/19/2012 06:00, Alexander V. Chernikov wrote:
Author: melifaro
Date: Thu Jul 19 13:00:31 2012
New Revision: 238620
URL: http://svn.freebsd.org/changeset/base
Author: melifaro
Date: Tue Jul 17 19:29:32 2012
New Revision: 238557
URL: http://svn.freebsd.org/changeset/base/238557
Log:
MFC r237479, r238265
Finally fix lookup (account remaining '\0') and deletion
(provide valid key length for radix lookup).
Submitted by:Ihor
Author: melifaro
Date: Mon Jul 16 06:56:46 2012
New Revision: 238515
URL: http://svn.freebsd.org/changeset/base/238515
Log:
MFC r237479, r238265
Finally fix lookup (account remaining '\0') and deletion
(provide valid key length for radix lookup).
Submitted by:Ihor
Author: melifaro
Date: Sun Jul 15 17:44:27 2012
New Revision: 238492
URL: http://svn.freebsd.org/changeset/base/238492
Log:
Permit changing MTU in 6to4 relay.
This behavior is recommended by RFC 4213 clause 3.2.
Sometimes fragmentation is the least evil.
For example, some Linux IPVS
On 09.07.2012 11:16, Hiroki Sato wrote:
Author: hrs
Date: Mon Jul 9 07:16:19 2012
New Revision: 238277
URL: http://svn.freebsd.org/changeset/base/238277
Log:
Make ipfw0 logging pseudo-interface clonable. It can be created
automatically
by $firewall_logif rc.conf(5) variable at boot
On 09.07.2012 12:08, Hiroki Sato wrote:
Alexander V. Chernikovmelif...@freebsd.org wrote
in4ffa894d.9050...@freebsd.org:
I meant there was no strong objection. I am sorry for not commenting
your implementation, but at least for ipfw0 it is difficult to
decouple ifnet and bpf because
Author: melifaro
Date: Mon Jul 9 11:53:06 2012
New Revision: 238295
URL: http://svn.freebsd.org/changeset/base/238295
Log:
Merge r237162, r237163, r237164, r237226.
Fix improper L4 header handling for IPv6 packets passed via DLT_RAW.
Set netflow v9 observation domain value to fib number
Author: melifaro
Date: Sun Jul 8 21:13:04 2012
New Revision: 238265
URL: http://svn.freebsd.org/changeset/base/238265
Log:
Finally fix lookup (account remaining '\0') and deletion
(provide valid key length for radix lookup).
Submitted by:Ihor Kaharlichenkomadkinder at gmail.com
Author: melifaro
Date: Sat Jun 23 12:40:24 2012
New Revision: 237479
URL: http://svn.freebsd.org/changeset/base/237479
Log:
Fix interface matching by ipfw table
Submitted by: Ihor Kaharlichenko madkin...@gmail.com
Tested by:Ihor Kaharlichenko madkin...@gmail.com
Approved
Author: melifaro
Date: Wed Jun 20 14:13:07 2012
New Revision: 237307
URL: http://svn.freebsd.org/changeset/base/237307
Log:
MFC r236819
Validate IPv4 network mask being passed to ipfw kernel interface.
Incorrect mask can possibly be one of the reasons for kern/127209 existance.
Author: melifaro
Date: Wed Jun 20 14:15:14 2012
New Revision: 237309
URL: http://svn.freebsd.org/changeset/base/237309
Log:
MFC r236819
Validate IPv4 network mask being passed to ipfw kernel interface.
Incorrect mask can possibly be one of the reasons for kern/127209 existance.
Author: melifaro
Date: Mon Jun 18 13:50:41 2012
New Revision: 237226
URL: http://svn.freebsd.org/changeset/base/237226
Log:
Simplify IP pointer recovery in case of mbuf reallocation.
Reviewed by: glebius (previous version)
Approved by: ae(mentor)
MFC after: 2 weeks
Author: melifaro
Date: Mon Jun 18 13:56:36 2012
New Revision: 237227
URL: http://svn.freebsd.org/changeset/base/237227
Log:
Make radix lookup on src and dst flow addresses optional
and configurable on per-interface basis.
Remove __inline__ for several functions being called once per
flow
Author: melifaro
Date: Sat Jun 16 13:51:01 2012
New Revision: 237162
URL: http://svn.freebsd.org/changeset/base/237162
Log:
Fix improper L4 header handling for IPv6 packets passed via DLT_RAW.
Reported by: Emil Muratov g...@hotplug.ru
Reviewed by: glebius
Approved by:
Author: melifaro
Date: Sat Jun 16 13:53:14 2012
New Revision: 237163
URL: http://svn.freebsd.org/changeset/base/237163
Log:
Set netflow v9 observation domain value to fib number instead of node id.
This fixes multi-fib netflow v9 export.
Reviewed by: glebius
Approved by:
Author: melifaro
Date: Sat Jun 16 13:55:31 2012
New Revision: 237164
URL: http://svn.freebsd.org/changeset/base/237164
Log:
Use time_uptime instead of getnanotime for accouting integer number of
seconds.
Reviewed by: glebius
Approved by: ae(mentor)
MFC after: 1 week
Author: melifaro
Date: Sat Jun 9 10:04:40 2012
New Revision: 236806
URL: http://svn.freebsd.org/changeset/base/236806
Log:
Fix typo introduced in r236559.
Pointed by: bcr
Approved by: kib(mentor)
Modified:
head/sys/net/bpf.c
Modified: head/sys/net/bpf.c
Author: melifaro
Date: Sat Jun 9 10:10:12 2012
New Revision: 236808
URL: http://svn.freebsd.org/changeset/base/236808
Log:
Add human option to print IPv4/IPv6 flows in human-readable format.
Show IPv4/IPv6 header IFF there are some flows following.
Wrap some long lines.
Sponsored by
Author: melifaro
Date: Sat Jun 9 17:39:05 2012
New Revision: 236819
URL: http://svn.freebsd.org/changeset/base/236819
Log:
Validate IPv4 network mask being passed to ipfw kernel interface.
Incorrect mask can possibly be one of the reasons for kern/127209 existance.
Approved by:
Author: melifaro
Date: Sat Jun 9 20:47:58 2012
New Revision: 236824
URL: http://svn.freebsd.org/changeset/base/236824
Log:
Update maximum number of tables available in ipfw to reflect
changes done in r233478.
Approved by: kib(mentor)
MFC after:3 days
Modified:
Author: melifaro
Date: Mon Jun 4 12:36:58 2012
New Revision: 236559
URL: http://svn.freebsd.org/changeset/base/236559
Log:
Fix panic introduced by r235745. Panic occurs after first packet traverse
renamed interface.
Add several comments on locking
Found by: avg
Approved by:
Author: melifaro
Date: Tue May 29 12:52:30 2012
New Revision: 236231
URL: http://svn.freebsd.org/changeset/base/236231
Log:
Fix BPF_JITTER code broken by r235746.
Pointed by: jkim
Reviewed by: jkim (except locking changes)
Approved by: (mentor)
MFC after:2
On 29.05.2012 16:52, Alexander V. Chernikov wrote:
Author: melifaro
Date: Tue May 29 12:52:30 2012
New Revision: 236231
URL: http://svn.freebsd.org/changeset/base/236231
Log:
Fix BPF_JITTER code broken by r235746.
Pointed by: jkim
Reviewed by: jkim (except locking changes
On 24.05.2012 04:18, Jung-uk Kim wrote:
...
@@ -1664,7 +1668,7 @@ bpf_setf(struct bpf_d *d, struct bpf_pro
struct bpf_insn *fcode, *old; u_int wfilter, flen, size; #ifdef
BPF_JITTER -bpf_jit_filter *ofunc; +bpf_jit_filter *ofunc,
*jfunc; #endif int need_upgrade; #ifdef
Author: melifaro
Date: Mon May 21 22:13:48 2012
New Revision: 235744
URL: http://svn.freebsd.org/changeset/base/235744
Log:
Fix panic on attaching to non-existent interface (introduced by r233937,
pointed by hrs@)
Fix panic on tcpdump being attached to interface being removed (introduced by
Author: melifaro
Date: Mon May 21 22:17:29 2012
New Revision: 235745
URL: http://svn.freebsd.org/changeset/base/235745
Log:
Fix old panic when BPF consumer attaches to destroying interface.
'flags' field is added to the end of bpf_if structure. Currently the only
flag is BPFIF_FLAG_DYING
Author: melifaro
Date: Mon May 21 22:19:19 2012
New Revision: 235746
URL: http://svn.freebsd.org/changeset/base/235746
Log:
Call bpf_jitter() before acquiring BPF global lock due to malloc() being used
inside bpf_jitter.
Eliminate bpf_buffer_alloc() and allocate BPF buffers on descriptor
Author: melifaro
Date: Mon May 21 22:21:00 2012
New Revision: 235747
URL: http://svn.freebsd.org/changeset/base/235747
Log:
Make most BPF ioctls() SMP-safe.
Approved by: kib(mentor)
MFC in:4 weeks
Modified:
head/sys/net/bpf.c
Modified: head/sys/net/bpf.c
Author: melifaro
Date: Sat May 5 11:33:48 2012
New Revision: 235055
URL: http://svn.freebsd.org/changeset/base/235055
Log:
MFC r234572
Do not require radix write lock to be held while dumping route table
via sysctl(4) interface. This permits router not to stop forwarding
packets while
Author: melifaro
Date: Sat May 5 11:34:27 2012
New Revision: 235056
URL: http://svn.freebsd.org/changeset/base/235056
Log:
MFC r234572
Do not require radix write lock to be held while dumping route table
via sysctl(4) interface. This permits router not to stop forwarding
packets while
Author: melifaro
Date: Thu May 3 08:56:43 2012
New Revision: 234946
URL: http://svn.freebsd.org/changeset/base/234946
Log:
Revert r234834 per luigi@ request.
Cleaner solution (e.g. adding another header) should be done here.
Original log:
Move several enums and structures
On 30.04.2012 17:39, Luigi Rizzo wrote:
On Mon, Apr 30, 2012 at 04:17:30PM +0400, Alexander V. Chernikov wrote:
On 30.04.2012 15:36, Gleb Smirnoff wrote:
On Mon, Apr 30, 2012 at 01:48:36PM +0200, Luigi Rizzo wrote:
L On Mon, Apr 30, 2012 at 10:22:23AM +, Alexander V. Chernikov wrote:
L
On 28.04.2012 00:42, Adrian Chadd wrote:
Hi Alex,
Hello!
I don't want to be demanding, but would you please consider committing
your fixes?
I've asked glebius@ for the review for a while ago, but it seems it is a
bit staled..
And if you could, would you please do it as a set of commits,
Author: melifaro
Date: Mon Apr 30 10:22:23 2012
New Revision: 234834
URL: http://svn.freebsd.org/changeset/base/234834
Log:
Move several enums and structures required for L2 filtering from
ip_fw_private.h to ip_fw.h.
Remove ipfw/ip_fw_private.h header from non-ipfw code.
Approved by:
On 30.04.2012 15:36, Gleb Smirnoff wrote:
On Mon, Apr 30, 2012 at 01:48:36PM +0200, Luigi Rizzo wrote:
L On Mon, Apr 30, 2012 at 10:22:23AM +, Alexander V. Chernikov wrote:
LAuthor: melifaro
LDate: Mon Apr 30 10:22:23 2012
LNew Revision: 234834
LURL: http://svn.freebsd.org
Author: melifaro
Date: Wed Apr 25 09:55:34 2012
New Revision: 234681
URL: http://svn.freebsd.org/changeset/base/234681
Log:
MFC r234574
Fix panic in ng_patch(4) caused by checksum flags being added to mbuf flags.
Tested by:Maxim Ignatenko gelraen...@gmail.com
Approved by:
Author: melifaro
Date: Wed Apr 25 09:56:35 2012
New Revision: 234682
URL: http://svn.freebsd.org/changeset/base/234682
Log:
MFC r234574
Fix panic in ng_patch(4) caused by checksum flags being added to mbuf flags.
Tested by:Maxim Ignatenko gelraen...@gmail.com
Approved by:
Author: melifaro
Date: Tue Apr 24 10:20:24 2012
New Revision: 234645
URL: http://svn.freebsd.org/changeset/base/234645
Log:
MFC r226186
Free mbuf in case when protocol in unknown in ng_ipfw_rcvdata().
This change fixes (theoretically) possible mbuf leak introduced in
r225586. Reorder
Author: melifaro
Date: Mon Apr 23 07:15:15 2012
New Revision: 234597
URL: http://svn.freebsd.org/changeset/base/234597
Log:
MFC r232865, r232868, r233478
- Add ipfw eXtended tables permitting radix to be used for any kind of keys.
- Add support for IPv6 and interface extended tables
-
Author: melifaro
Date: Sun Apr 22 16:13:23 2012
New Revision: 234572
URL: http://svn.freebsd.org/changeset/base/234572
Log:
Do not require radix write lock to be held while dumping route table
via sysctl(4) interface. This permits router not to stop forwarding
packets while route table is
Author: melifaro
Date: Sun Apr 22 17:00:52 2012
New Revision: 234574
URL: http://svn.freebsd.org/changeset/base/234574
Log:
Fix panic in ng_patch(4) caused by checksum flags being added to mbuf flags.
Tested by:Maxim Ignatenko gelraen...@gmail.com
Approved by: kib(mentor)
Author: melifaro
Date: Sat Apr 21 18:12:24 2012
New Revision: 234552
URL: http://svn.freebsd.org/changeset/base/234552
Log:
MFC r229930
Add setsockopt(2) example to ng_ksocket(4).
While here, fix formatting a bit
Approved by: ae(mentor)
Modified:
Author: melifaro
Date: Sat Apr 21 18:14:46 2012
New Revision: 234553
URL: http://svn.freebsd.org/changeset/base/234553
Log:
MFC r229930
Add setsockopt(2) example to ng_ksocket(4).
While here, fix formatting a bit
Approved by: ae(mentor)
Modified:
Author: melifaro
Date: Sat Apr 21 18:30:48 2012
New Revision: 234555
URL: http://svn.freebsd.org/changeset/base/234555
Log:
MFC: r228730
Add binding support to libradius(3).
Submitted by:Sergey Matveychuk se...@yandex-team.ru
Approved by: kib(mentor)
Modified:
On 17.04.2012 01:29, Adrian Chadd wrote:
On 15 April 2012 23:33, Alexander V. Chernikovmelif...@freebsd.org wrote:
On 16.04.2012 01:17, Adrian Chadd wrote:
Hi,
This has broken (at least) net80211 and bpf, with LOR:
Yes, it is. Please try the attached patch
Hi,
Hello!
Sorry for the late
()
* bpfdetach()
*something - I bet this is bpf_detachd()
* _mtx_assert()
From 5e621db1dae528f228e94374702d03501138fb1b Mon Sep 17 00:00:00 2001
From: Alexander V. Chernikov melif...@ipfw.ru
Date: Wed, 11 Apr 2012 20:04:58 +0400
Subject: [PATCH 1/1] * Final BPF locks patch
---
sys/net/bpf.c
Author: melifaro
Date: Thu Apr 12 17:49:53 2012
New Revision: 234191
URL: http://svn.freebsd.org/changeset/base/234191
Log:
MFC: r228730
Add binding support to libradius(3).
Submitted by:Sergey Matveychuk se...@yandex-team.ru
Approved by: kib(mentor)
Modified:
Author: melifaro
Date: Thu Apr 12 17:59:17 2012
New Revision: 234192
URL: http://svn.freebsd.org/changeset/base/234192
Log:
MFC: r214018
Add links for libradius(3) functions.
Approved by: pjd
Approved by: kib(mentor)
Modified:
stable/8/lib/libradius/Makefile
Directory
Author: melifaro
Date: Fri Apr 6 06:53:58 2012
New Revision: 233937
URL: http://svn.freebsd.org/changeset/base/233937
Log:
- Improve BPF locking model.
Interface locks and descriptor locks are converted from mutex(9) to rwlock(9).
This greately improves performance: in most common case
Author: melifaro
Date: Fri Apr 6 06:55:21 2012
New Revision: 233938
URL: http://svn.freebsd.org/changeset/base/233938
Log:
- Improve performace for writer-only BPF users.
Linux and Solaris (at least OpenSolaris) has PF_PACKET socket families to send
raw ethernet frames. The only FreeBSD
On 06.04.2012 10:53, Alexander V. Chernikov wrote:
Author: melifaro
Date: Fri Apr 6 06:53:58 2012
New Revision: 233937
URL: http://svn.freebsd.org/changeset/base/233937
Reviewed by:glebius (previous version)
Reviewed by:silence on -net@
Approved by:(mentor)
s/\(mentor
On 06.04.2012 10:55, Alexander V. Chernikov wrote:
Author: melifaro
Date: Fri Apr 6 06:55:21 2012
New Revision: 233938
URL: http://svn.freebsd.org/changeset/base/233938
Reviewed by:glebius (previous version)
Reviewed by:silence on -net@
Approved by:(mentor)
s/\(mentor
Author: melifaro
Date: Fri Apr 6 13:34:19 2012
New Revision: 233946
URL: http://svn.freebsd.org/changeset/base/233946
Log:
Fix build broken by r233938.
Pointed by: David Wolfskill da...@catwhisker.org
Approved by:kib (mentor)
Pointy hat to: melifaro
Modified:
Author: melifaro
Date: Mon Mar 26 09:34:17 2012
New Revision: 233505
URL: http://svn.freebsd.org/changeset/base/233505
Log:
- Add knlist_init_rw_reader() function to kqueue(9).
Function acquired reader lock if needed.
Assert check for reader or writer lock (RA_LOCKED / RA_UNLOCKED)
-
Author: melifaro
Date: Sun Mar 25 20:37:59 2012
New Revision: 233478
URL: http://svn.freebsd.org/changeset/base/233478
Log:
- Permit number of ipfw tables to be changed in runtime.
net.inet.ip.fw.tables_max is now read-write.
- Bump IPFW_TABLES_MAX to 65535
Default number of tables
On 12.03.2012 21:17, Marko Zec wrote:
On Monday 12 March 2012 16:41:36 Alexander V. Chernikov wrote:
Author: melifaro
Date: Mon Mar 12 15:41:36 2012
New Revision: 232868
URL: http://svn.freebsd.org/changeset/base/232868
Log:
Fix VNET build broken by r232865.
Temporary remove the ability
Author: melifaro
Date: Tue Mar 13 11:08:40 2012
New Revision: 232921
URL: http://svn.freebsd.org/changeset/base/232921
Log:
Use rt_numfibs variable instead of compile-time RT_NUMFIBS.
Reviewed by:glebius (previous version)
Approved by:kib(mentor), ae(mentor)
Modified:
On 13.03.2012 16:51, Bjoern A. Zeeb wrote:
On 13. Mar 2012, at 11:08 , Alexander V. Chernikov wrote:
Author: melifaro
Date: Tue Mar 13 11:08:40 2012
New Revision: 232921
URL: http://svn.freebsd.org/changeset/base/232921
Log:
Use rt_numfibs variable instead of compile-time RT_NUMFIBS
Author: melifaro
Date: Mon Mar 12 14:07:57 2012
New Revision: 232865
URL: http://svn.freebsd.org/changeset/base/232865
Log:
- Add ipfw eXtended tables permitting radix to be used for any kind of keys.
- Add support for IPv6 and interface extended tables
- Make number of tables to be loader
Author: melifaro
Date: Mon Mar 12 15:41:36 2012
New Revision: 232868
URL: http://svn.freebsd.org/changeset/base/232868
Log:
Fix VNET build broken by r232865.
Temporary remove the ability to assign different number of tables per VNET
instance.
Modified:
head/sys/netinet/ipfw/ip_fw2.c
Author: melifaro
Date: Tue Jan 10 12:45:24 2012
New Revision: 229930
URL: http://svn.freebsd.org/changeset/base/229930
Log:
Add setsockopt(2) example to ng_ksocket(4).
While here, fix formatting a bit
Approved by: kib(mentor)
MFC after: 2 weeks
Modified:
Author: melifaro
Date: Tue Dec 20 11:13:44 2011
New Revision: 228730
URL: http://svn.freebsd.org/changeset/base/228730
Log:
Add binding support to libradius(3).
Submitted by:Sergey Matveychuk se...@yandex-team.ru
Approved by: ae (mentor)
MFC after: 2 weeks
Modified:
Author: melifaro
Date: Wed Nov 2 11:05:11 2011
New Revision: 227017
URL: http://svn.freebsd.org/changeset/base/227017
Log:
MFC 213440 (by ru)
Show hostcache statistics in netstat(1).
Submitted by: Maxim Dounin
Approved by:ae
Approved by:ru
Modified:
Author: melifaro
Date: Mon Oct 10 09:33:07 2011
New Revision: 226186
URL: http://svn.freebsd.org/changeset/base/226186
Log:
Free mbuf in case when protocol in unknown in ng_ipfw_rcvdata().
This change fixes (theoretically) possible mbuf leak introduced in
r225586. Reorder code a bit and
Gleb Smirnoff wrote:
Alexander, Andrey,
see a couple of comments below please.
...
A + if (m-m_len sizeof(struct ip)
A + (m = m_pullup(m, sizeof(struct ip))) == NULL)
A + return (EINVAL);
In most cases we return ENOBUFS in case if m_pullup() failure. Lesser amount
Konovalov\nma...@freebsd.org\n2002/02/07]
mdf [label=Matthew Fleming\n...@freebsd.org\n2010/06/04]
mdodd [label=Matthew N. Dodd\nmd...@freebsd.org\n1999/07/27]
+melifaro [label=Alexander V. Chernikov\nmelif...@freebsd.org\n2011/10/04]
mjacob [label=Matt Jacob\nmja...@freebsd.org\n1997/08/13]
mlaier
On 04.10.2011 15:35, Bjoern A. Zeeb wrote:
Author: bz
Date: Tue Oct 4 11:35:18 2011
New Revision: 225970
URL: http://svn.freebsd.org/changeset/base/225970
Log:
MFC r225837:
Thanks for merging this very very long-awaited fix!
___
601 - 667 of 667 matches
Mail list logo
