svn commit: r197806 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/if_ndis dev/xen/xenpci

2009-10-06 Thread Coleman Kane
Author: cokane Date: Tue Oct 6 16:05:06 2009 New Revision: 197806 URL: http://svn.freebsd.org/changeset/base/197806 Log: MFC: r197403, r197644, r197654, and r197659 Fix some unexpected potential NULL de-references in kernel mode due to usage of pre-8.0 wifi operations with the ndis drive

Re: svn commit: r197654 - head/sys/dev/if_ndis

2009-10-01 Thread Coleman Kane
On Fri, 2009-10-02 at 04:20 +1000, Bruce Evans wrote: > On Thu, 1 Oct 2009, Coleman Kane wrote: > > > On Fri, 2009-10-02 at 00:36 +1000, Bruce Evans wrote: > >> On Thu, 1 Oct 2009, [utf-8] Dag-Erling Smørgrav wrote: > >> > >>> Coleman Kane writes:

Re: svn commit: r197654 - head/sys/dev/if_ndis

2009-10-01 Thread Coleman Kane
On Fri, 2009-10-02 at 00:36 +1000, Bruce Evans wrote: > On Thu, 1 Oct 2009, [utf-8] Dag-Erling Smørgrav wrote: > > > Coleman Kane writes: > >> - if (sc->ndis_80211 && vap) > >> + if ((sc->ndis_80211 != NULL) && (vap != NULL))

Re: svn commit: r197654 - head/sys/dev/if_ndis

2009-10-01 Thread Coleman Kane
On Thu, 2009-10-01 at 12:33 +0200, Dag-Erling Smørgrav wrote: > Coleman Kane writes: > > - if (sc->ndis_80211 && vap) > > + if ((sc->ndis_80211 != NULL) && (vap != NULL)) > > sc->ndis_80211 is an int. NULL is a pointer. > >

svn commit: r197659 - head/sys/dev/if_ndis

2009-10-01 Thread Coleman Kane
Author: cokane Date: Thu Oct 1 11:52:06 2009 New Revision: 197659 URL: http://svn.freebsd.org/changeset/base/197659 Log: Fix a bad use of NULL instead of zero for int comparison. Sorry for the breakage. Submitted by: bz, des, onemda MFC after:3 days Modified: head/sys/dev/if_ndi

svn commit: r197654 - head/sys/dev/if_ndis

2009-09-30 Thread Coleman Kane
Author: cokane Date: Thu Oct 1 02:43:51 2009 New Revision: 197654 URL: http://svn.freebsd.org/changeset/base/197654 Log: style(9) fixes (always compare pointers to NULL) Also, the previous commit to sys/dev/if_ndis/if_ndis.c also included the removal of a call to ndis_setstate_80211 that

svn commit: r197644 - head/sys/dev/if_ndis

2009-09-30 Thread Coleman Kane
Author: cokane Date: Wed Sep 30 14:28:38 2009 New Revision: 197644 URL: http://svn.freebsd.org/changeset/base/197644 Log: Correct a bug that could lead to a kernel panic if a user attempted to perform 802.11 operations directly on the ndis0 interface before the first VAP (wlan0) had been cre

svn commit: r197403 - head/sys/dev/if_ndis

2009-09-22 Thread Coleman Kane
Author: cokane Date: Tue Sep 22 12:36:51 2009 New Revision: 197403 URL: http://svn.freebsd.org/changeset/base/197403 Log: The ndis_scan function may be started after ndis vap have been destroyed PR: kern/138632 Submitted by: Paul B. Mahol MFC after:3 days Modified: hea

svn commit: r195791 - head/sys/dev/if_ndis

2009-07-20 Thread Coleman Kane
Author: cokane Date: Mon Jul 20 23:21:19 2009 New Revision: 195791 URL: http://svn.freebsd.org/changeset/base/195791 Log: Fix regression in last set of commits. Submitted via e-mail and then nagged again via PR. Thank Paul for his persistence and contributions. PR: 136895 Subm

svn commit: r194706 - head/sys/dev/if_ndis

2009-06-23 Thread Coleman Kane
Author: cokane Date: Tue Jun 23 14:37:07 2009 New Revision: 194706 URL: http://svn.freebsd.org/changeset/base/194706 Log: Code cleanup by moving some repetitive code into an ndis_get_bssid_list helper function. Also, add ieee80211_announce() call for bootverbose case. Submitted by: Paul B

svn commit: r194432 - head/sys/dev/if_ndis

2009-06-18 Thread Coleman Kane
Author: cokane Date: Thu Jun 18 11:12:10 2009 New Revision: 194432 URL: http://svn.freebsd.org/changeset/base/194432 Log: Replace use of ic->ic_flags with vap->iv_flags to operate on per-vap flags for ndis 802.11 work. Submitted by: Paul B. Mahol Modified: head/sys/dev/if_ndis/if_ndis

svn commit: r193937 - head/sys/dev/if_ndis

2009-06-10 Thread Coleman Kane
Author: cokane Date: Wed Jun 10 18:00:10 2009 New Revision: 193937 URL: http://svn.freebsd.org/changeset/base/193937 Log: Fix an LOR Submitted by: Paul B. Mahol MFC after:1 week Modified: head/sys/dev/if_ndis/if_ndis.c Modified: head/sys/dev/if_ndis/if_ndis.c

Re: svn commit: r191762 - in head/sys: conf dev/bwi modules/bwi

2009-05-03 Thread Coleman Kane
On Sun, 2009-05-03 at 12:11 -0600, M. Warner Losh wrote: > In message: <20090503175804.gc11...@citylink.fud.org.nz> > Andrew Thompson writes: > : On Sun, May 03, 2009 at 09:18:50AM -0400, Coleman Kane wrote: > : > On Sat, 2009-05-02 at 21:28 -0700, Andrew Thomp

Re: svn commit: r191762 - in head/sys: conf dev/bwi modules/bwi

2009-05-03 Thread Coleman Kane
; Log: > > Bring in Andrew Thompson's port of Sepherosa Ziehau's bwi driver for > > Broadcom BCM43xx chipsets. > > Actually Sam did the initial port, I just tinkered later on. Kudos to > him. > > Andrew Any idea what still needs to be done to support the 4

Re: svn commit: r190943 - head/include

2009-04-11 Thread Coleman Kane
mitted upstream. > > - -- > Stanislav Sedov > ST4096-RIPE I agree... if you've been discussing it with the Pth maintainer, then what are the chances that you can get Pth to change their behavior? Since Pth is supposed to be a support library that works on a large collection

Re: svn commit: r190775 - head/sbin/route

2009-04-06 Thread Coleman Kane
On Mon, 2009-04-06 at 12:21 -0400, Randall Stewart wrote: > On Apr 6, 2009, at 11:07 AM, Coleman Kane wrote: > > > On Mon, 2009-04-06 at 14:27 +, Randall Stewart wrote: > >> Author: rrs > >> Date: Mon Apr 6 14:27:28 2009 > >> New Revision: 190775 >

Re: svn commit: r190775 - head/sbin/route

2009-04-06 Thread Coleman Kane
} > - j <<= 1; > + j <<= 8; > } > /* i holds the first non zero bit */ > - bits = 32 - i; > + bits = 32 - (i*8); > } > mask = 0x << (32 - bits); > -- Coleman Kane signature.asc Description: This is a digitally signed message part

Re: svn commit: r189828 - in head: include sys/sys

2009-03-21 Thread Coleman Kane
On Sat, 2009-03-21 at 13:42 +, Bruce Simpson wrote: > Robert Watson wrote: > > On Fri, 20 Mar 2009, Coleman Kane wrote: > > > >> I've found that many of the GNU apps are notorious for this. I really > >> can't say that I know why libassuan or gnu

Re: svn commit: r189828 - in head: include sys/sys

2009-03-20 Thread Coleman Kane
On Fri, 2009-03-20 at 10:40 -0700, Sam Leffler wrote: > Coleman Kane wrote: > > On Fri, 2009-03-20 at 08:57 -0700, Sam Leffler wrote: > > > >> David Schultz wrote: > >> > >>> On Fri, Mar 20, 2009, Vasil Dimov wrote: > >>> >

Re: svn commit: r189828 - in head: include sys/sys

2009-03-20 Thread Coleman Kane
hat works for glibc is _BITS_SIGTHREAD_H. I'd rather not > > be complicit in these shenanigans, but if we can't easily fix the > > problem in Pth, I suppose we can teach signal.h about one of these > > bogus macros. What do you think? > > > > > > Dum

Re: svn commit: r189765 - in head: . lib/libc lib/libc/nls

2009-03-13 Thread Coleman Kane
But it may be used on other environment like X. So it is licensed > under dual(multiple?) license. > I thought that X.org was MIT/X11 licensed (which was very very similar to BSD). -- Coleman Kane signature.asc Description: This is a digitally signed message part

Re: svn commit: r189691 - head/sbin/recoverdisk

2009-03-11 Thread Coleman Kane
On Wed, 2009-03-11 at 10:25 -0400, Coleman Kane wrote: > On Wed, 2009-03-11 at 10:37 +, Poul-Henning Kamp wrote: > > Author: phk > > Date: Wed Mar 11 10:37:02 2009 > > New Revision: 189691 > > URL: http://svn.freebsd.org/changeset/base/189691 > > &g

Re: svn commit: r189691 - head/sbin/recoverdisk

2009-03-11 Thread Coleman Kane
;Bigsize = %u, medsize = %u, minsize = %u\n", > + bigsize, medsize, minsize); > + > buf = malloc(bigsize); > if (buf == NULL) > err(1, "Cannot allocate %jd bytes buffer", (intmax_t)bigsize); > That new fprintf warns in the case where sizeof(size_t) != sizeof(unsigned int), such as is the case on amd64. -- Coleman Kane signature.asc Description: This is a digitally signed message part

Re: svn commit: r188457 - head/sys/dev/bge

2009-02-10 Thread Coleman Kane
, bge_ifmedia_sts)) { > if (trys++ < 4) { > I'm curious... I recent ran into a problem where this driver was not properly recovering from an ACPI resume event (under amd64 with some patches). I am curious if this patch might fix that problem... as the death ha

Re: svn commit: r186919 - head/sys/dev/if_ndis

2009-01-08 Thread Coleman Kane
MODE_11A, 48); > TESTSETRATE(IEEE80211_MODE_11A, 72); > TESTSETRATE(IEEE80211_MODE_11A, 96); > TESTSETRATE(IEEE80211_MODE_11A, 108); > Good catch! -- Coleman Kane signature.asc Description: This is a digitally signed message part

Re: svn commit: r186751 - in head/sys: netinet6 netipsec

2009-01-05 Thread Coleman Kane
#x27;re working in an area of the code (and can verify your changes) but > knob polishing is just code churn and in my experience is > counter-productive. Spend your time and effort on fixing real problems; > god knows we've got enough of 'em... > > Sam > Maybe prep

Re: svn commit: r184691 - head/sys/compat/linprocfs

2008-11-08 Thread Coleman Kane
hat makes sense. > > Yes, UTF-8 is good. More UTF-8, please. > > Tim I third that motion. -- Coleman Kane signature.asc Description: This is a digitally signed message part