svn commit: r354290 - head

2019-11-03 Thread Conrad Meyer
Author: cem Date: Sun Nov 3 19:36:34 2019 New Revision: 354290 URL: https://svnweb.freebsd.org/changeset/base/354290 Log: Take arm.arm (armv5) out of universe It's on the chopping block in two months, the CI tinderbox doesn't bother with it anymore either, and buildworld fails today due

svn commit: r354289 - head/share/mk

2019-11-03 Thread Conrad Meyer
Author: cem Date: Sun Nov 3 19:33:49 2019 New Revision: 354289 URL: https://svnweb.freebsd.org/changeset/base/354289 Log: armv6: Switch to LLD by default This could just be ${__TT} == "arm", except armv5 isn't slated for death until EOY. arm tinderbox builds. Let's see what else

svn commit: r354167 - head/sys/x86/include

2019-10-29 Thread Conrad Meyer
Author: cem Date: Wed Oct 30 04:00:44 2019 New Revision: 354167 URL: https://svnweb.freebsd.org/changeset/base/354167 Log: amd64: Fix typo: RDPRU bit is 0x10, not 0x04 Bit 4 != 4, of course. X-MFC-With: r354162 Modified: head/sys/x86/include/specialreg.h Modified:

svn commit: r354162 - in head/sys/x86: include x86

2019-10-29 Thread Conrad Meyer
Author: cem Date: Wed Oct 30 01:41:14 2019 New Revision: 354162 URL: https://svnweb.freebsd.org/changeset/base/354162 Log: amd64: Define and decode new AMD64 feature bits These are documented in revisions 3.32 of the public AMD64 Vol. 2 and revision 3.28 of Vol. 3, published October and

svn commit: r354151 - in head: contrib/netbsd-tests/lib/libexecinfo lib/libexecinfo/tests

2019-10-29 Thread Conrad Meyer
Author: cem Date: Tue Oct 29 18:24:36 2019 New Revision: 354151 URL: https://svnweb.freebsd.org/changeset/base/354151 Log: libexecinfo test: Don't strip installed test It turns out that a test of backtrace symbol resolution and formatting requires symbols. Another option mightt be

svn commit: r354135 - head/contrib/netbsd-tests/lib/libexecinfo

2019-10-28 Thread Conrad Meyer
Author: cem Date: Mon Oct 28 17:12:45 2019 New Revision: 354135 URL: https://svnweb.freebsd.org/changeset/base/354135 Log: Remove bogus requirement from libexecinfo test The bogus requirement was causing CI infrastructure (which does not mount procfs) to skip the test. Procfs has not

svn commit: r354126 - in head: etc/mtree lib/libexecinfo lib/libexecinfo/tests

2019-10-26 Thread Conrad Meyer
Author: cem Date: Sun Oct 27 05:32:08 2019 New Revision: 354126 URL: https://svnweb.freebsd.org/changeset/base/354126 Log: libexecinfo: Integrate NetBSD test into FreeBSD Added: head/lib/libexecinfo/tests/ head/lib/libexecinfo/tests/Makefile (contents, props changed) Modified:

svn commit: r354112 - in head: contrib/libexecinfo lib/libexecinfo

2019-10-26 Thread Conrad Meyer
Author: cem Date: Sat Oct 26 06:59:59 2019 New Revision: 354112 URL: https://svnweb.freebsd.org/changeset/base/354112 Log: Sync up with NetBSD libexecinfo changes 2014-2019 Drop portions that are unlit or redundant with llvm-libunwind: builtin.c, unwind.h, and unwind_arm_ehabi_stub.c.

svn commit: r353959 - head/sys/amd64/include

2019-10-23 Thread Conrad Meyer
Author: cem Date: Wed Oct 23 19:03:03 2019 New Revision: 353959 URL: https://svnweb.freebsd.org/changeset/base/353959 Log: amd64: Add CFI directives for libc syscall stubs No functional change (in program code). Additional DWARF metadata is generated in the .eh_frame section. Also, it

svn commit: r353958 - head/lib/libthr/arch/amd64/amd64

2019-10-23 Thread Conrad Meyer
Author: cem Date: Wed Oct 23 18:27:30 2019 New Revision: 353958 URL: https://svnweb.freebsd.org/changeset/base/353958 Log: libthr: Add missing END() directive for umtx_op_err (amd64) Like r353929, related to D22122. No functional change. Reviewed by: emaste, kib (earlier version

svn commit: r353934 - head/sys/net

2019-10-23 Thread Conrad Meyer
Author: cem Date: Wed Oct 23 16:48:22 2019 New Revision: 353934 URL: https://svnweb.freebsd.org/changeset/base/353934 Log: Prevent a panic when a driver provides bogus debugnet parameters This is just a bandaid; we should fix the driver(s) too. Introduced in r353685. PR:

svn commit: r353929 - head/lib/msun/amd64

2019-10-23 Thread Conrad Meyer
Author: cem Date: Wed Oct 23 16:05:52 2019 New Revision: 353929 URL: https://svnweb.freebsd.org/changeset/base/353929 Log: libm: Add missing END() directives for amd64 routines No functional change. Related to D22122. Reviewed by: emaste, kib (earlier version both) Modified:

Re: svn commit: r353640 - head/sys/kern

2019-10-22 Thread Conrad Meyer
Theoretically the information should be here, but it's still locked: https://admbugs.freebsd.org/show_bug.cgi?id=651 . On Tue, Oct 22, 2019 at 8:51 AM Alan Somers wrote: > > On Wed, Oct 16, 2019 at 7:21 AM Andrew Turner wrote: >> >> Author: andrew >> Date: Wed Oct 16 13:21:01 2019 >> New

svn commit: r353767 - head/sys/x86/x86

2019-10-19 Thread Conrad Meyer
Author: cem Date: Sat Oct 19 16:37:49 2019 New Revision: 353767 URL: https://svnweb.freebsd.org/changeset/base/353767 Log: hw.intrbalance: Make sysctl tunable This allows specifying a boot-time preference in loader.conf. Modified: head/sys/x86/x86/intr_machdep.c Modified:

svn commit: r353742 - in head/sys: conf net

2019-10-18 Thread Conrad Meyer
Author: cem Date: Fri Oct 18 22:03:36 2019 New Revision: 353742 URL: https://svnweb.freebsd.org/changeset/base/353742 Log: Fix debugnet(4) link/build fallout on some configurations Introduced in r353685 (sys/conf/files), r353694 (debugnet.c db_printf). Submitted by: kevans Reported

svn commit: r353740 - head/sys/dev/nvdimm

2019-10-18 Thread Conrad Meyer
Author: cem Date: Fri Oct 18 21:32:45 2019 New Revision: 353740 URL: https://svnweb.freebsd.org/changeset/base/353740 Log: nvdimm(4): Persist unit numbers in cdev They're formatted into the device name like unit numbers, anyway; store the number in mda_unit => si_drv0 like dev2unit()

svn commit: r353714 - head/sys/dev/nvdimm

2019-10-17 Thread Conrad Meyer
Author: cem Date: Fri Oct 18 03:01:21 2019 New Revision: 353714 URL: https://svnweb.freebsd.org/changeset/base/353714 Log: nvdimm_e820: Fix braino in size=all SPA hint The sentinel value for "use the rest of the region," -1, isn't zero modulo PAGE_SIZE. Relax the check to permit the

svn commit: r353713 - head/sys/x86/x86

2019-10-17 Thread Conrad Meyer
Author: cem Date: Fri Oct 18 02:25:30 2019 New Revision: 353713 URL: https://svnweb.freebsd.org/changeset/base/353713 Log: x86: Remove unused variable from r353712 It was in my git tree (uncommitted) and didn't get carried over to SVN in r353712. X-MFC-With: r353712 Modified:

svn commit: r353712 - in head/sys/x86: include x86

2019-10-17 Thread Conrad Meyer
Author: cem Date: Fri Oct 18 02:18:17 2019 New Revision: 353712 URL: https://svnweb.freebsd.org/changeset/base/353712 Log: x86: Fetch and save standard CPUID leaf 6 in identcpu Rather than a few scattered places in the tree. Organize flag names in a contiguous region of specialreg.h.

svn commit: r353702 - head/sys/gdb

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 22:37:25 2019 New Revision: 353702 URL: https://svnweb.freebsd.org/changeset/base/353702 Log: gdb(4): Implement support for NoAckMode When the underlying debugport transport is reliable, GDB's additional checksums and acknowledgements are redundant.

svn commit: r353700 - in head: share/man/man4 sys/amd64/conf sys/conf sys/gdb sys/i386/conf sys/kern sys/net sys/sys

2019-10-17 Thread Conrad Meyer
== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/share/man/man4/netgdb.4Thu Oct 17 21:33:01 2019 (r353700) @@ -0,0 +1,147 @@ +.\"- +.\" Copyright (c) 2019 Conrad Meyer +.\" +.\" Re

svn commit: r353696 - in head/sys: net netinet/netdump

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 20:25:15 2019 New Revision: 353696 URL: https://svnweb.freebsd.org/changeset/base/353696 Log: debugnet(4): Add optional full-duplex mode It remains unattached to any client protocol. Netdump is unaffected (remaining half-duplex). The intended consumer is

svn commit: r353694 - in head: share/man/man4 sys/net sys/netinet/netdump

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 20:10:32 2019 New Revision: 353694 URL: https://svnweb.freebsd.org/changeset/base/353694 Log: debugnet(4): Infer non-server connection parameters Loosen requirements for connecting to debugnet-type servers. Only require a destination address; the rest can

svn commit: r353693 - head/sys/dev/acpica

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 19:53:55 2019 New Revision: 353693 URL: https://svnweb.freebsd.org/changeset/base/353693 Log: acpica: Fix for the fix, unfortunately Follow-up to incomplete pedantic change in r353691 by actually fixing the default implementation to match the interface type.

svn commit: r353692 - in head: share/man/man4 sys/net sys/netinet/netdump

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 19:49:20 2019 New Revision: 353692 URL: https://svnweb.freebsd.org/changeset/base/353692 Log: Add ddb(4) 'netdump' command to netdump a core without preconfiguration Add a 'X -s -c [-g ] -i ' subroutine to the generic debugnet code. The imagined use is

svn commit: r353691 - head/sys/dev/acpica

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 18:45:11 2019 New Revision: 353691 URL: https://svnweb.freebsd.org/changeset/base/353691 Log: acpica: Match ID_PROBE default implementation to interface After r339754, the additional interface parameter was accidentally left out of the default

svn commit: r353690 - in head/sys: kern sys

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 18:29:44 2019 New Revision: 353690 URL: https://svnweb.freebsd.org/changeset/base/353690 Log: Add a very limited DDB dumpon(8)-alike to MI dumper code This allows ddb(4) commands to construct a static dumperinfo during panic/debug and invoke doadump(false)

svn commit: r353689 - head/sys/net

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 17:48:32 2019 New Revision: 353689 URL: https://svnweb.freebsd.org/changeset/base/353689 Log: debugnet: Respond to broadcast ARP requests The in-tree netdump code has always ignored non-directed ARP requests, and that seems to work most of the time for

svn commit: r353688 - head/sys/net

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 17:19:16 2019 New Revision: 353688 URL: https://svnweb.freebsd.org/changeset/base/353688 Log: debugnet(4): Check hardware-validated UDP checksums Similar to INET checksums, lazily validate UDP checksums when the driver has already performed the check for us.

svn commit: r353685 - in head/sys: amd64/conf arm64/conf conf dev/alc dev/bge dev/bxe dev/cxgb dev/mlx4/mlx4_en dev/re dev/virtio/network i386/conf kern net netinet/netdump powerpc/conf sparc64/con...

2019-10-17 Thread Conrad Meyer
Author: cem Date: Thu Oct 17 16:23:03 2019 New Revision: 353685 URL: https://svnweb.freebsd.org/changeset/base/353685 Log: Split out a more generic debugnet(4) from netdump(4) Debugnet is a simplistic and specialized panic- or debug-time reliable datagram transport. It can drive a

svn commit: r353662 - head/sys/amd64/amd64

2019-10-16 Thread Conrad Meyer
Author: cem Date: Wed Oct 16 18:27:27 2019 New Revision: 353662 URL: https://svnweb.freebsd.org/changeset/base/353662 Log: ddb: Add support for disassembling 'crc32' on amd64 Modified: head/sys/amd64/amd64/db_disasm.c Modified: head/sys/amd64/amd64/db_disasm.c

svn commit: r353521 - in head/sys/x86: include x86

2019-10-14 Thread Conrad Meyer
Author: cem Date: Mon Oct 14 20:55:01 2019 New Revision: 353521 URL: https://svnweb.freebsd.org/changeset/base/353521 Log: x86: Use canonical spelling of MOVDIR64B feature/instruction The former spelling probably confused MOVDIR64B with MOVDIRI64. MOVDIR_64B is the 64-*byte* direct

Re: svn commit: r353408 - head

2019-10-11 Thread Conrad Meyer
19 at 1:04 AM Dimitry Andric wrote: > > On 11 Oct 2019, at 08:24, Andriy Gapon wrote: > > > > On 11/10/2019 09:07, Conrad Meyer wrote: > >> Fwiw, this doesn’t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. > > > > Does a clean build work for that config

Re: svn commit: r353408 - head

2019-10-11 Thread Conrad Meyer
Fwiw, this doesn’t seem to fix the NO_CLEAN build for amd64-xtoolchain-gcc. On Thu, Oct 10, 2019 at 09:29 Brooks Davis wrote: > Author: brooks > Date: Thu Oct 10 16:29:13 2019 > New Revision: 353408 > URL: https://svnweb.freebsd.org/changeset/base/353408 > > Log: > Fix -DNO_CLEAN build across

Re: svn commit: r353429 - in head: share/man/man4 sys/kern sys/vm

2019-10-11 Thread Conrad Meyer
Thanks Cy, you’re totally right. That explains the crazy cachefree/xfree numbers I was seeing. Should be fixed in 353430. Thanks, Conrad On Thu, Oct 10, 2019 at 21:20 Cy Schubert wrote: > In message <201910110131.x9b1vv1r047...@repo.freebsd.org>, Conrad Meyer > writes: > > Au

svn commit: r353430 - head/sys/vm

2019-10-11 Thread Conrad Meyer
Author: cem Date: Fri Oct 11 06:02:03 2019 New Revision: 353430 URL: https://svnweb.freebsd.org/changeset/base/353430 Log: Fix braino in r353429 cy@ points out that I got parameter order backwards between definition and invocation of the helper function. He is totally correct. The

svn commit: r353429 - in head: share/man/man4 sys/kern sys/vm

2019-10-10 Thread Conrad Meyer
Author: cem Date: Fri Oct 11 01:31:31 2019 New Revision: 353429 URL: https://svnweb.freebsd.org/changeset/base/353429 Log: ddb: Add CSV option, sorting to 'show (malloc|uma)' Add /i option for machine-parseable CSV output. This allows ready copy/ pasting into more sophisticated tooling

svn commit: r353417 - head/sys/dev/nvdimm

2019-10-10 Thread Conrad Meyer
Author: cem Date: Thu Oct 10 22:49:45 2019 New Revision: 353417 URL: https://svnweb.freebsd.org/changeset/base/353417 Log: nvdimm(4): Calculate and save memattr once; it never changes Refactor nvdimm_spa_memattr() routine and callers to just save the value at initialization and use the

svn commit: r353115 - head/sys/modules/nvdimm

2019-10-04 Thread Conrad Meyer
Author: cem Date: Fri Oct 4 21:47:09 2019 New Revision: 353115 URL: https://svnweb.freebsd.org/changeset/base/353115 Log: nvdimm(4): Fix Clang build after r353110 Clang spuriously warns about some well-defined C99 static initializers. Mute it. X-MFC-With: r353110 Modified:

svn commit: r353110 - in head/sys: dev/nvdimm modules/nvdimm

2019-10-04 Thread Conrad Meyer
Author: cem Date: Fri Oct 4 18:38:47 2019 New Revision: 353110 URL: https://svnweb.freebsd.org/changeset/base/353110 Log: nvdimm(4): Add nvdimm_e820 pseudo-bus nvdimm_e820 is a newbus pseudo driver that looks for "legacy" e820 PRAM spans and creates ordinary-looking SPA devfs nodes for

svn commit: r353020 - head/sys/dev/nvdimm

2019-10-02 Thread Conrad Meyer
Author: cem Date: Wed Oct 2 19:13:35 2019 New Revision: 353020 URL: https://svnweb.freebsd.org/changeset/base/353020 Log: nvdimm: Fix error path mis-free Regression introduced in r343629 when malloc result was renamed from spa to spa_mapping and the 'spa' name was instead used to

Re: svn commit: r352953 - in head/usr.bin: killall split

2019-10-02 Thread Conrad Meyer
Hi Alexander, Coverity has millions of spurious warnings of this class and they're basically all false positives. I think we should instead try to figure out how to disable this class of warning on our codebase, since it is largely incorrect. I would encourage reverting this change, because it

svn commit: r352798 - in head/sys: dev/nvdimm modules/nvdimm

2019-09-27 Thread Conrad Meyer
Author: cem Date: Fri Sep 27 16:32:44 2019 New Revision: 352798 URL: https://svnweb.freebsd.org/changeset/base/352798 Log: nvdimm(4): Extract ACPI root bus driver No functional change intended. The intent is to add a "legacy" e820 pmem newbus bus for nvdimm device in a subsequent

svn commit: r352734 - head/sys/amd64/amd64

2019-09-25 Thread Conrad Meyer
Author: cem Date: Thu Sep 26 01:51:55 2019 New Revision: 352734 URL: https://svnweb.freebsd.org/changeset/base/352734 Log: amd64 pmap: Clarify largemap bootverbose message units A PML4 covers 512 gigabytes, not gigabits. Use the typical B suffix for bytes. No functional change.

svn commit: r352733 - head/sys/amd64/amd64

2019-09-25 Thread Conrad Meyer
Author: cem Date: Thu Sep 26 01:50:26 2019 New Revision: 352733 URL: https://svnweb.freebsd.org/changeset/base/352733 Log: amd64: Expose vm.pmap.large_map_pml4_entries as a sysctl node It's nice to have sysctl nodes for tunables. Sponsored by: Dell EMC Isilon Modified:

Re: svn commit: r352623 - in head/sys: amd64/amd64 kern

2019-09-23 Thread Conrad Meyer
Hi Mark, On Mon, Sep 23, 2019 at 7:14 AM Mark Johnston wrote: > > Author: markj > Date: Mon Sep 23 14:14:43 2019 > New Revision: 352623 > URL: https://svnweb.freebsd.org/changeset/base/352623 > > Log: > Use elf_relocaddr() when handling R_X86_64_RELATIVE relocations. > > This is required for

Re: svn commit: r352603 - head/sys/conf

2019-09-22 Thread Conrad Meyer
Thanks! The more granular we can be about disabling specific warnings for specific compilers and/or files, the less we lose out on by disabling more broadly. On Sun, Sep 22, 2019 at 11:28 AM Kyle Evans wrote: > > Author: kevans > Date: Sun Sep 22 18:27:57 2019 > New Revision: 352603 > URL:

Re: svn commit: r352451 - head/stand/libsa

2019-09-17 Thread Conrad Meyer
Well, hang on; it's also perfectly legal for a malloc implementation to return NULL for requests of zero bytes. You can access exactly the number of bytes requested in the allocation; and free(NULL) works as expected. NULL (0) is also aligned to any size you could want. Best, Conrad On Tue,

Re: svn commit: r352337 - in head: share/man/man3 sys/sys tests/sys/sys

2019-09-15 Thread Conrad Meyer
On Sun, Sep 15, 2019 at 12:51 PM Edward Tomasz Napierala wrote: > On 0914T1532, Conrad Meyer wrote: > > On Sat, Sep 14, 2019 at 12:23 PM Edward Tomasz Napierala > > wrote: > > > URL: https://svnweb.freebsd.org/changeset/base/352337 > > > > > > Log: >

Re: svn commit: r352337 - in head: share/man/man3 sys/sys tests/sys/sys

2019-09-14 Thread Conrad Meyer
One correction: On Sat, Sep 14, 2019 at 12:23 PM Edward Tomasz Napierala wrote: > > Author: trasz > Date: Sat Sep 14 19:23:46 2019 > New Revision: 352337 > URL: https://svnweb.freebsd.org/changeset/base/352337 > > Log: > Introduce arb(3), the Array-based Red-Black Tree macros: similar > to

svn commit: r352233 - in head: sys/fs/msdosfs sys/kern sys/sys usr.sbin/makefs/msdos

2019-09-11 Thread Conrad Meyer
Author: cem Date: Wed Sep 11 21:24:14 2019 New Revision: 352233 URL: https://svnweb.freebsd.org/changeset/base/352233 Log: buf: Add B_INVALONERR flag to discard data Setting the B_INVALONERR flag before a synchronous write causes the buf cache to forcibly invalidate contents if the write

Re: svn commit: r352228 - head/sys/netinet

2019-09-11 Thread Conrad Meyer
Small nitpick: On Wed, Sep 11, 2019 at 11:48 AM Andrew Gallatin wrote: > Note that on a system under a syn flood attack, arc4random() > becomes quite expensive, and the chacha_poly crypto that it calls arc4random uses chacha20 — there is no "poly" involved. Best, Conrad

svn commit: r352113 - head/sys/net

2019-09-09 Thread Conrad Meyer
Author: cem Date: Tue Sep 10 01:56:47 2019 New Revision: 352113 URL: https://svnweb.freebsd.org/changeset/base/352113 Log: Appease Clang false-positive Werrors in r352112 Reported by: bcran Modified: head/sys/net/rtsock.c Modified: head/sys/net/rtsock.c

svn commit: r352112 - in head: share/man/man4 sys/net

2019-09-09 Thread Conrad Meyer
Author: cem Date: Mon Sep 9 22:54:27 2019 New Revision: 352112 URL: https://svnweb.freebsd.org/changeset/base/352112 Log: ddb(4): Add 'show route ' and 'show routetable []' These commands show the route resolved for a specified destination, or print out the entire routing table for a

Re: svn commit: r352059 - head/sys/kern

2019-09-09 Thread Conrad Meyer
Thanks! On Mon, Sep 9, 2019 at 11:48 AM Konstantin Belousov wrote: > > On Mon, Sep 09, 2019 at 11:31:32AM -0700, Conrad Meyer wrote: > > What’s the motivation for using more timehands? > See the thread titled 'Is it a good idea to use a usb-serial adapter > for PPS input? Y

Re: svn commit: r352059 - head/sys/kern

2019-09-09 Thread Conrad Meyer
What’s the motivation for using more timehands? On Mon, Sep 9, 2019 at 04:30 Konstantin Belousov wrote: > Author: kib > Date: Mon Sep 9 11:29:58 2019 > New Revision: 352059 > URL: https://svnweb.freebsd.org/changeset/base/352059 > > Log: > Make timehands count selectable at boottime. > >

svn commit: r352075 - head/sys/ddb

2019-09-09 Thread Conrad Meyer
Author: cem Date: Mon Sep 9 16:32:23 2019 New Revision: 352075 URL: https://svnweb.freebsd.org/changeset/base/352075 Log: ddb(4): Add some support for lexing IPv6 addresses Allow commands to specify that (hex) numbers may start with A-F, by adding the DRT_HEX flag for

svn commit: r352074 - head/sys/ddb

2019-09-09 Thread Conrad Meyer
Author: cem Date: Mon Sep 9 16:31:14 2019 New Revision: 352074 URL: https://svnweb.freebsd.org/changeset/base/352074 Log: ddb(4): Enhance lexer functionality for specialized commands Add a db_read_token_flags() variant of db_read_token() with configurable parameters. Allow

svn commit: r352053 - head/sys/ddb

2019-09-08 Thread Conrad Meyer
Author: cem Date: Mon Sep 9 01:33:45 2019 New Revision: 352053 URL: https://svnweb.freebsd.org/changeset/base/352053 Log: ddb(4): Move an extern variable declaration to a header Trivial cleanup, no functional change. Modified: head/sys/ddb/db_command.h head/sys/ddb/db_run.c

svn commit: r352050 - head/sys/gdb

2019-09-08 Thread Conrad Meyer
Author: cem Date: Sun Sep 8 22:52:47 2019 New Revision: 352050 URL: https://svnweb.freebsd.org/changeset/base/352050 Log: gdb(4): Root a sysctl tree at 'debug.gdb.' Like debug.ddb and debug.kdb. Rename 'debug.gdbcons' to 'debug.gdb.cons,' but leave the old name as a compatibility

svn commit: r351952 - head/sys/netinet

2019-09-06 Thread Conrad Meyer
Author: cem Date: Fri Sep 6 18:33:39 2019 New Revision: 351952 URL: https://svnweb.freebsd.org/changeset/base/351952 Log: Fix build after r351934 tcp_queue_pkts() is only used if TCPHPTS is defined (and it is not by default). Reported by: gcc Modified:

svn commit: r351929 - head/sys/ufs/ffs

2019-09-06 Thread Conrad Meyer
Author: cem Date: Fri Sep 6 08:08:33 2019 New Revision: 351929 URL: https://svnweb.freebsd.org/changeset/base/351929 Log: ufs: Remove redundant brelse() after r294954 Same automation. No functional change. Modified: head/sys/ufs/ffs/ffs_alloc.c head/sys/ufs/ffs/ffs_balloc.c

svn commit: r351928 - head/sys/fs/msdosfs

2019-09-06 Thread Conrad Meyer
Author: cem Date: Fri Sep 6 08:08:10 2019 New Revision: 351928 URL: https://svnweb.freebsd.org/changeset/base/351928 Log: msdosfs: Remove redundant brelse() after r294954 Same automation. No functional change. Modified: head/sys/fs/msdosfs/msdosfs_fat.c

svn commit: r351927 - head/sys/fs/cd9660

2019-09-06 Thread Conrad Meyer
Author: cem Date: Fri Sep 6 08:07:36 2019 New Revision: 351927 URL: https://svnweb.freebsd.org/changeset/base/351927 Log: cd9660: Remove redundant brelse() after r294954 Same automation. No functional change. Modified: head/sys/fs/cd9660/cd9660_vfsops.c

svn commit: r351926 - head/sys/fs/ext2fs

2019-09-06 Thread Conrad Meyer
Author: cem Date: Fri Sep 6 08:07:12 2019 New Revision: 351926 URL: https://svnweb.freebsd.org/changeset/base/351926 Log: ext2fs: Remove redundant brelse() after r294954 Coccinelle: @ rule1 @ identifier __error; @@ ... int __error; ... @ rule2 depends on rule1 @

svn commit: r351899 - in head/sys: fs/nfsclient kern sys

2019-09-05 Thread Conrad Meyer
Author: cem Date: Thu Sep 5 21:43:33 2019 New Revision: 351899 URL: https://svnweb.freebsd.org/changeset/base/351899 Log: Remove long-dead BUF_ASSERT_{,UN}HELD assertions These were fully neutered in r177676 (2008), but not removed at the time for unclear reasons. They're totally dead

svn commit: r351898 - head/sys/fs/msdosfs

2019-09-05 Thread Conrad Meyer
Author: cem Date: Thu Sep 5 21:30:52 2019 New Revision: 351898 URL: https://svnweb.freebsd.org/changeset/base/351898 Log: msdosfs: Drop an unneeded brelse in bread error condition After r294954, it is an invariant that bread returns non-NULL bp if and only if the routine succeeded. On

svn commit: r351835 - head/sys/sys

2019-09-04 Thread Conrad Meyer
Author: cem Date: Thu Sep 5 00:56:37 2019 New Revision: 351835 URL: https://svnweb.freebsd.org/changeset/base/351835 Log: sys/mount.h: Comment on distinction between vfs_{c,}mount Hope to save someone else a little future effort in ugly duplicated code. No functional change.

Re: svn commit: r346443 - head/tests/sys/opencrypto

2019-09-03 Thread Conrad Meyer
On Sat, Apr 20, 2019 at 9:54 AM John Baldwin wrote: > To be clear, I prefer the _new_ indentation. I kept having to go back and > manually > use tabify in emacs to work with the current scripts, so once my pending > stuff is > drained I will appreciate having it converted. > +1 as someone else

svn commit: r346599 - head/sys/netinet/netdump

2019-09-03 Thread Conrad Meyer
Author: cem Date: Tue Apr 23 17:05:57 2019 New Revision: 346599 URL: https://svnweb.freebsd.org/changeset/base/346599 Log: netdump: Fix !COMPAT_FREEBSD11 unused variable warning Reported by: Ralf Wenk Sponsored by: Dell EMC Isilon Modified: head/sys/netinet/netdump/netdump_client.c

svn commit: r346448 - head/sys/netinet/netdump

2019-09-03 Thread Conrad Meyer
Author: cem Date: Sat Apr 20 16:07:29 2019 New Revision: 346448 URL: https://svnweb.freebsd.org/changeset/base/346448 Log: netdump: Fix 11 compatibility DIOCSKERNELDUMP ioctl The logic was present for the 11 version of the DIOCSKERNELDUMP ioctl, but had not been updated for the 12 ABI.

svn commit: r346643 - head/sys/x86/x86

2019-09-03 Thread Conrad Meyer
Author: cem Date: Wed Apr 24 18:24:22 2019 New Revision: 346643 URL: https://svnweb.freebsd.org/changeset/base/346643 Log: x86: Halt non-BSP CPUs on panic IPI_STOP We may need the BSP to reboot, but we don't need any AP CPU that isn't the panic thread. Any CPU landing in this routine

svn commit: r346412 - head/sys/conf

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 20:08:45 2019 New Revision: 346412 URL: https://svnweb.freebsd.org/changeset/base/346412 Log: kernel build: Disable unhelpful GCC warning (tripped after r346352) -Wformat-zero-length does not highlight any particularly wrong code and it is especially

svn commit: r346358 - in head: . sys/dev/random sys/libkern sys/mips/conf sys/sys

2019-09-03 Thread Conrad Meyer
Author: cem Date: Thu Apr 18 20:48:54 2019 New Revision: 346358 URL: https://svnweb.freebsd.org/changeset/base/346358 Log: random(4): Restore availability tradeoff prior to r346250 As discussed in that commit message, it is a dangerous default. But the safe default causes enough pain on

svn commit: r346516 - head/sys/geom/nop

2019-09-03 Thread Conrad Meyer
Author: cem Date: Mon Apr 22 03:25:49 2019 New Revision: 346516 URL: https://svnweb.freebsd.org/changeset/base/346516 Log: gnop(8): Nopify configuration as a kernel dump device As a dummy / no-op dump device, to facilitate dumpon(8) testing. Reviewed by: markj (earlier version)

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
Hi Warner, On Wed, Apr 17, 2019 at 10:16 AM Warner Losh wrote: > I'm going to put a very fine point on this: any hard-requirement of entropy > sources is a non-starter. If you require that, your commit will be backed out > and/or hacked around by the addition of a nob in the future. It will

svn commit: r346601 - head/sys/netinet6

2019-09-03 Thread Conrad Meyer
Author: cem Date: Tue Apr 23 17:18:20 2019 New Revision: 346601 URL: https://svnweb.freebsd.org/changeset/base/346601 Log: ip6_randomflowlabel: Avoid blocking if random(4) is not available If kern.random.initial_seeding.bypass_before_seeding is disabled, random(4) and arc4random(9) will

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Wed, Apr 17, 2019 at 9:06 AM John Baldwin wrote: > > On 4/16/19 4:48 PM, Conrad Meyer wrote: > > Perhaps cryptographically random stack-protector cookies are simply > > inappropriate for MIPS or RISCV. Do we have any other examples of > > kernel random consumers block

svn commit: r346566 - head/lib/libc/stdlib

2019-09-03 Thread Conrad Meyer
Author: cem Date: Mon Apr 22 16:29:34 2019 New Revision: 346566 URL: https://svnweb.freebsd.org/changeset/base/346566 Log: random.3: Remove obsolete BUGS section Relative performance to rand(3) is sort of irrelevant; they do different things and a user with sensitivity to RNG

svn commit: r346410 - in head: lib/libc/gen share/man/man9 sys/conf sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 20:05:47 2019 New Revision: 346410 URL: https://svnweb.freebsd.org/changeset/base/346410 Log: libkern: Bring in arc4random_uniform(9) from libc It is a useful arc4random wrapper in the kernel for much the same reasons as in userspace. Move the source to

svn commit: r346364 - in head: sys/contrib/zstd sys/contrib/zstd/contrib/docker sys/contrib/zstd/contrib/experimental_dict_builders sys/contrib/zstd/contrib/largeNbDicts sys/contrib/zstd/contrib/pr...

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 02:54:13 2019 New Revision: 346364 URL: https://svnweb.freebsd.org/changeset/base/346364 Log: Update to Zstandard 1.4.0 The full release notes can be found on Github: https://github.com/facebook/zstd/releases/tag/v1.4.0 Relnotes: yes Added:

svn commit: r346411 - head/sys/sys

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 20:06:22 2019 New Revision: 346411 URL: https://svnweb.freebsd.org/changeset/base/346411 Log: Bump __FreeBSD_version after r346410 Modified: head/sys/sys/param.h Modified: head/sys/sys/param.h

svn commit: r346399 - head/share/man/man4

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 17:15:58 2019 New Revision: 346399 URL: https://svnweb.freebsd.org/changeset/base/346399 Log: random.4: Include description of knobs added in r346358 Reported by: ngie Sponsored by: Dell EMC Isilon Modified: head/share/man/man4/random.4 Modified:

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Mon, Apr 15, 2019 at 11:40 AM Conrad Meyer wrote: > > Author: cem > Date: Mon Apr 15 18:40:36 2019 > New Revision: 346250 > URL: https://svnweb.freebsd.org/changeset/base/346250 > > Log: > random(4): Block read_random(9) on initial seeding Hi, For anyone intereste

svn commit: r346565 - head/lib/libc/stdlib

2019-09-03 Thread Conrad Meyer
Author: cem Date: Mon Apr 22 16:26:39 2019 New Revision: 346565 URL: https://svnweb.freebsd.org/changeset/base/346565 Log: rand.3: Match better recommendation language from random.3 Sponsored by: Dell EMC Isilon Modified: head/lib/libc/stdlib/rand.3 Modified:

Re: svn commit: r346263 - head/contrib/tcpdump

2019-09-03 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 6:20 AM Shawn Webb wrote: > Is there any documentation anywhere telling users that Capsicum > support will be disabled under certain circumstances? Hi Shawn, I don't think documenting that makes much sense in general. It would be extremely burdensome to fully document

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 6:19 AM Warner Losh wrote: > On Tue, Apr 16, 2019, 7:04 AM Emmanuel Vadot wrote: >> It's not only CI, all release images (memstick, iso) don't have >> a /boot/entropy. >> Also all arm/arm64 image don't have this file too. >> If /boot/entropy is needed and isn't present

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
:22 AM Adrian Chadd wrote: > > > > On Mon, 15 Apr 2019 at 11:40, Conrad Meyer wrote: >> >> Author: cem >> Date: Mon Apr 15 18:40:36 2019 >> New Revision: 346250 >> URL: https://svnweb.freebsd.org/changeset/base/346250 >> >> Log: >> rand

svn commit: r346362 - in vendor/zstd/1.4.0: . contrib/adaptive-compression contrib/docker contrib/experimental_dict_builders contrib/largeNbDicts contrib/premake contrib/pzstd contrib/pzstd/utils c...

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 00:32:13 2019 New Revision: 346362 URL: https://svnweb.freebsd.org/changeset/base/346362 Log: tag zstd 1.4.0 Added: vendor/zstd/1.4.0/ - copied from r346360, vendor/zstd/dist/ vendor/zstd/1.4.0/CHANGELOG - copied unchanged from r346361,

Re: svn commit: r346259 - head/sys/dev/tpm

2019-09-03 Thread Conrad Meyer
Hi Marcin, Isn't this check racy? Thread TIDs are allocated from a fixed range and can be recycled. Best, Conrad On Mon, Apr 15, 2019 at 7:28 PM Marcin Wojtas wrote: > > Author: mw > Date: Tue Apr 16 02:28:35 2019 > New Revision: 346259 > URL: https://svnweb.freebsd.org/changeset/base/346259

svn commit: r346361 - in vendor/zstd/dist: . contrib/adaptive-compression contrib/docker contrib/experimental_dict_builders contrib/experimental_dict_builders/benchmarkDictBuilder contrib/experimen...

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 00:31:04 2019 New Revision: 346361 URL: https://svnweb.freebsd.org/changeset/base/346361 Log: import zstd 1.4.0 Added: vendor/zstd/dist/CHANGELOG vendor/zstd/dist/contrib/docker/ vendor/zstd/dist/contrib/docker/Dockerfile

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 4:31 PM John Baldwin wrote: > bhyveload is effectively the loader in this case. It runs the normal loader > scripts and logic and so would load the guests's /boot/entropy and pass it > to the guest kernel as metadata just like the regular loader. Right, except it doesn't

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
Hi John, On Wed, Apr 17, 2019 at 9:01 AM John Baldwin wrote: > You're missing the point which is that you've added potential blocking in a > lot of > places by changing the semantics of arc4random. I get it. The thing is, it's a weird blocking semantic. It's not the same as any other

svn commit: r346292 - in head: . sys/kern

2019-09-03 Thread Conrad Meyer
Author: cem Date: Tue Apr 16 18:47:20 2019 New Revision: 346292 URL: https://svnweb.freebsd.org/changeset/base/346292 Log: stack_protector: Add tunable to bypass random cookies This is a stopgap measure to unbreak installer/VM/embedded boot issues introduced (or at least exposed by) in

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 9:33 AM Warner Losh wrote: > In that case, we're better off having a MD routine that gets called if > there's no loader-provided entropy pool. Yes, this is more or less the same plan I had. There's no need to add anything MD specific; we already abstract MD random

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Mon, Apr 15, 2019 at 5:53 PM Conrad Meyer wrote: > E.g., the CI infrastructure for > Riscv/Arm is/was generating minimal filesystem images and not > populating /boot/entropy. I should add, I say "is/was" because I have a PR out which may address the problem: https://github.

svn commit: r346420 - in head: lib/libc/gen share/man/man9 sys/conf sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
Author: cem Date: Fri Apr 19 22:08:17 2019 New Revision: 346420 URL: https://svnweb.freebsd.org/changeset/base/346420 Log: Revert r346410 and r346411 libkern in .PATH has too many filename conflicts with libc and my -DNO_CLEAN tinderbox didn't catch that ahead of time. Mea culpa.

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 7:24 AM Justin Hibbits wrote: > > Hi Conrad, > ... > [Power] does use bsdinstall to install. How is entropy loaded at startup, > which causes the problem noted in github? There are a couple very early load sources. loader(8) will load early-boot entropy from

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
Hi Justin, On Mon, Apr 15, 2019 at 5:01 PM Justin Hibbits wrote: > Given the discussion over there it would probably also fail on powernv, which > also does not use loader. Does power use bsdinstall (which populates /boot/entropy at install time via usr.sbin/bsdinstall/scripts/entropy) and

Re: svn commit: r346250 - in head: share/man/man4 share/man/man9 sys/dev/random sys/kern sys/libkern sys/sys

2019-09-03 Thread Conrad Meyer
On Tue, Apr 16, 2019 at 4:28 PM John Baldwin wrote: > Yes, but we need some kind of non-blocking API, not an > unconditionally-blocking API > that deadlocks. I'm not sure we do. It would be sufficient to check once at subsystem initialization time. There's no race condition such that we block

<    1   2   3   4   5   6   7   8   9   10   >