Re: svn commit: r342140 - head/tools/build/mk

2018-12-16 Thread George Neville-Neil
Thanks. Best, George On 16 Dec 2018, at 6:02, Cy Schubert wrote: Author: cy Date: Sat Dec 15 22:02:02 2018 New Revision: 342140 URL: https://svnweb.freebsd.org/changeset/base/342140 Log: Repair build post-r342139 Modified: head/tools/build/mk/OptionalObsoleteFiles.inc Modified:

Re: svn commit: r313675 - in head/sys: netinet netinet6

2017-02-12 Thread George Neville-Neil
On 12 Feb 2017, at 6:10, Glen Barber wrote: > On Sun, Feb 12, 2017 at 06:56:33AM +, Ermal Luçi wrote: >> Author: eri >> Date: Sun Feb 12 06:56:33 2017 >> New Revision: 313675 >> URL: https://svnweb.freebsd.org/changeset/base/313675 >> >> Log: >> Committed without approval from mentor. >>

Re: svn commit: r311225 - head/sys/netinet

2017-01-07 Thread George Neville-Neil
On 7 Jan 2017, at 14:23, George Neville-Neil wrote: On 4 Jan 2017, at 13:26, Mark Johnston wrote: On Wed, Jan 04, 2017 at 02:19:13AM +, George V. Neville-Neil wrote: Author: gnn Date: Wed Jan 4 02:19:13 2017 New Revision: 311225 URL: https://svnweb.freebsd.org/changeset/base/311225

Re: svn commit: r311225 - head/sys/netinet

2017-01-07 Thread George Neville-Neil
On 4 Jan 2017, at 13:26, Mark Johnston wrote: On Wed, Jan 04, 2017 at 02:19:13AM +, George V. Neville-Neil wrote: Author: gnn Date: Wed Jan 4 02:19:13 2017 New Revision: 311225 URL: https://svnweb.freebsd.org/changeset/base/311225 Log: Fix DTrace TCP tracepoints to not use mtod() as

Re: svn commit: r301217 - in head/sys: net netinet netinet6

2016-06-02 Thread George Neville-Neil
On 2 Jun 2016, at 16:21, Ngie Cooper wrote: On Thu, Jun 2, 2016 at 10:51 AM, George V. Neville-Neil wrote: Author: gnn Date: Thu Jun 2 17:51:29 2016 New Revision: 301217 URL: https://svnweb.freebsd.org/changeset/base/301217 Log: This change re-adds L2 caching for TCP

Re: svn commit: r300003 - head/share/man/man4

2016-05-17 Thread George Neville-Neil
On 17 May 2016, at 3:16, Greg 'groggy' Lehey wrote: > On Tuesday, 17 May 2016 at 0:04:51 -0700, John Baldwin wrote: >> On Tuesday, May 17, 2016 04:40:01 AM Greg Lehey wrote: >>> Author: grog >>> Date: Tue May 17 04:40:00 2016 >>> New Revision: 33 >>> URL:

Re: svn commit: r297358 - head/sys/net

2016-03-28 Thread George Neville-Neil
On 28 Mar 2016, at 14:36, Jonathan T. Looney wrote: On 3/28/16, 2:25 PM, "owner-src-committ...@freebsd.org on behalf of George V. Neville-Neil" wrote: Author: gnn Date: Mon Mar 28 18:25:54 2016 New Revision: 297358 URL:

Re: svn commit: r297234 - in head/sys: net netinet

2016-03-24 Thread George Neville-Neil
Thanks, George On 24 Mar 2016, at 20:40, Bjoern A. Zeeb wrote: Author: bz Date: Thu Mar 24 11:40:10 2016 New Revision: 297234 URL: https://svnweb.freebsd.org/changeset/base/297234 Log: Fix compile errors after r297225: - properly V_irtualise variable access unbreaking VIMAGE kernels.

Re: svn commit: r294535 - in head/sys/netinet: . cc tcp_stacks

2016-01-22 Thread George Neville-Neil
On 22 Jan 2016, at 2:13, Lawrence Stewart wrote: Hi Gleb, On 01/22/16 09:34, Gleb Smirnoff wrote: Author: glebius Date: Thu Jan 21 22:34:51 2016 New Revision: 294535 URL: https://svnweb.freebsd.org/changeset/base/294535 Log: - Rename cc.h to more meaningful tcp_cc.h. As a bit of

Re: svn commit: r290383 - in head/sys: net netinet

2015-12-24 Thread George Neville-Neil
On 20 Dec 2015, at 13:02, Cy Schubert wrote: Cy Schubert writes: In message <201511050726.ta57qxlu074...@repo.freebsd.org>, "George V. Neville-N eil" writes: Author: gnn Date: Thu Nov 5 07:26:32 2015 New Revision: 290383 URL: https://svnweb.freebsd.org/changeset/base/290383 Log: Replace

Re: svn commit: r291341 - head/share/dtrace

2015-11-25 Thread George Neville-Neil
On 25 Nov 2015, at 18:20, Mark Johnston wrote: On Wed, Nov 25, 2015 at 10:59:41PM +, George V. Neville-Neil wrote: Author: gnn Date: Wed Nov 25 22:59:41 2015 New Revision: 291341 URL: https://svnweb.freebsd.org/changeset/base/291341 Log: Summary: A simple script to print the return

Re: svn commit: r287780 - in head: share/man/man9 sys/kern sys/sys

2015-09-19 Thread George Neville-Neil
On 19 Sep 2015, at 4:58, Hans Petter Selasky wrote: On 09/17/15 11:07, David Chisnall wrote: I would expect*anyone* making a change like this to have both the design and code reviewed for sanity checking. Please add an entry to MAINTAINERS for those parts of the kernel which require this

Re: svn commit: r286955 - in head/sys: net netinet netinet6

2015-08-20 Thread George Neville-Neil
Why was this work not in Phabricator? This is a large change that has not been reviewed, as far as I can tell, by anyone else on the project. I am tempted to ask that this be backed out and reviewed BEFORE it goes into the tree. Best, George On 20 Aug 2015, at 13:05, Alexander V. Chernikov

Re: svn commit: r285051 - head/sys/netinet

2015-07-29 Thread George Neville-Neil
On 29 Jul 2015, at 11:05, Gleb Smirnoff wrote: Ermal, On Wed, Jul 29, 2015 at 03:00:59PM +0200, Ermal Luçi wrote: E E @@ -934,6 +950,7 @@ ip_forward(struct mbuf *m, int srcrt) E E */ E E if (!srcrt ia == NULL) { E E icmp_error(m, ICMP_UNREACH, ICMP_UNREACH_HOST,

Re: svn commit: r285336 - in head/sys: netipsec opencrypto

2015-07-13 Thread George Neville-Neil
On 11 Jul 2015, at 3:57, John-Mark Gurney wrote: Matthew D. Fuller wrote this message on Fri, Jul 10, 2015 at 23:48 -0500: On Thu, Jul 09, 2015 at 06:16:36PM + I heard the voice of George V. Neville-Neil, and lo! it spake thus: New Revision: 285336 URL:

Re: svn commit: r285336 - in head/sys: netipsec opencrypto

2015-07-09 Thread George Neville-Neil
On 9 Jul 2015, at 18:26, Peter Wemm wrote: On Thursday, July 09, 2015 06:16:36 PM George V. Neville-Neil wrote: Author: gnn Date: Thu Jul 9 18:16:35 2015 New Revision: 285336 URL: https://svnweb.freebsd.org/changeset/base/285336 Log: Add support for AES modes to IPSec. These modes

Re: svn commit: r285336 - in head/sys: netipsec opencrypto

2015-07-09 Thread George Neville-Neil
Should have also pointed out that the original version of this patch comes from pfsense and Ermal (eri@). Best, George On 9 Jul 2015, at 14:16, George V. Neville-Neil wrote: Author: gnn Date: Thu Jul 9 18:16:35 2015 New Revision: 285336 URL: https://svnweb.freebsd.org/changeset/base/285336

Re: svn commit: r284198 - head/bin/ls

2015-06-13 Thread George Neville-Neil
On 06/13/2015 15:16, Gleb Smirnoff wrote: On Sat, Jun 13, 2015 at 11:38:11AM -0400, David Chisnall wrote: D If you would have told me a year ago that you had a simple scheme that D could make 30 years of experience maintaining code for unix-like systems D completely worthless I would have

Re: svn commit: r282240 - in head: cddl/lib/libdtrace sys/netinet

2015-05-25 Thread George Neville-Neil
On 24 May 2015, at 22:50, Julian Elischer wrote: On 5/24/15 9:24 PM, George Neville-Neil wrote: On 23 May 2015, at 17:59, hiren panchasara wrote: On 04/29/15 at 05:19P, George V. Neville-Neil wrote: Author: gnn Date: Wed Apr 29 17:19:55 2015 New Revision: 282240 URL: https

Re: svn commit: r282240 - in head: cddl/lib/libdtrace sys/netinet

2015-05-24 Thread George Neville-Neil
On 23 May 2015, at 17:59, hiren panchasara wrote: On 04/29/15 at 05:19P, George V. Neville-Neil wrote: Author: gnn Date: Wed Apr 29 17:19:55 2015 New Revision: 282240 URL: https://svnweb.freebsd.org/changeset/base/282240 Log: Brief demo script showing the various values that can be read

Re: svn commit: r282240 - in head: cddl/lib/libdtrace sys/netinet

2015-04-29 Thread George Neville-Neil
On 29 Apr 2015, at 18:23, Bjoern A. Zeeb wrote: On 29 Apr 2015, at 17:21 , Bjoern A. Zeeb b...@freebsd.org wrote: On 29 Apr 2015, at 17:19 , George V. Neville-Neil g...@freebsd.org wrote: Author: gnn Date: Wed Apr 29 17:19:55 2015 New Revision: 282240 URL:

Re: svn commit: r281352 - head/sys/netinet

2015-04-12 Thread George Neville-Neil
On 10 Apr 2015, at 15:06, Adrian Chadd wrote: I don't want to get this bikeshed going again, but: this is just hashing on the ip src/ip_id, and only for fragments. For now i think it's okay to leave as jenkins. Let's bikeshed it with more data about how it behaves when doing frag assembly

Re: svn commit: r281276 - head/sys/net

2015-04-09 Thread George Neville-Neil
On 8 Apr 2015, at 16:55, Gleb Smirnoff wrote: On Wed, Apr 08, 2015 at 08:25:51PM +, George V. Neville-Neil wrote: G Author: gnn G Date: Wed Apr 8 20:25:51 2015 G New Revision: 281276 G URL: https://svnweb.freebsd.org/changeset/base/281276 G G Log: G Add support for a netisr polling

Re: svn commit: r280971 - in head: contrib/ipfilter/tools share/man/man4 sys/contrib/ipfilter/netinet sys/netinet sys/netipsec sys/netpfil/pf

2015-04-03 Thread George Neville-Neil
OK, top post. This is a general discussion. Move to net@ and get this out of our commit mails please. Best, George On 3 Apr 2015, at 9:38, Emeric POUPON wrote: A good ip id random would be certainly better. But the current implementation is far from being optimized: a lock is being held

Re: svn commit: r279603 - in head: bin/rcp usr.bin/rlogin usr.bin/rsh

2015-03-05 Thread George Neville-Neil
On 5 Mar 2015, at 13:47, Garrett Cooper wrote: On Mar 5, 2015, at 10:21, Hans Ottevanger h...@beastielabs.net wrote: On 03/05/15 13:21, Slawa Olhovchenkov wrote: On Thu, Mar 05, 2015 at 02:48:29PM +0300, Gleb Smirnoff wrote: On Wed, Mar 04, 2015 at 10:01:45PM +, Baptiste Daroussin

Re: svn commit: r277835 - in head: lib/libpmc sys/arm/arm sys/arm/include sys/arm/ti sys/conf sys/dev/hwpmc sys/sys

2015-01-29 Thread George Neville-Neil
On 28 Jan 2015, at 14:27, Andrew Turner wrote: On Wed, 28 Jan 2015 18:39:13 + Ruslan Bukin b...@freebsd.org wrote: On Wed, Jan 28, 2015 at 09:35:03AM -0700, Ian Lepore wrote: Just from a quick glance at the part that wasn't truncated, I notice all the inline asm stuff is wrong -- it

Re: svn commit: r276142 - in head/sys: amd64/amd64 cddl/dev/dtrace/amd64 cddl/dev/dtrace/i386 cddl/dev/dtrace/mips cddl/dev/dtrace/powerpc i386/i386 mips/mips powerpc/aim sys

2014-12-28 Thread George Neville-Neil
On 23 Dec 2014, at 6:05, Mark Johnston wrote: On Tue, Dec 23, 2014 at 08:45:57AM -0700, Ian Lepore wrote: On Tue, 2014-12-23 at 15:38 +, Mark Johnston wrote: Author: markj Date: Tue Dec 23 15:38:19 2014 New Revision: 276142 URL: https://svnweb.freebsd.org/changeset/base/276142 Log:

Re: svn commit: r273733 - head/sys/netinet/cc

2014-10-27 Thread George Neville-Neil
Can you modify this to preserve the limitation of TCP_CA_NAME_MAX ? Best, George On 27 Oct 2014, at 7:21, Hans Petter Selasky wrote: Author: hselasky Date: Mon Oct 27 11:21:47 2014 New Revision: 273733 URL: https://svnweb.freebsd.org/changeset/base/273733 Log: Make assignments to

Re: svn commit: r273733 - head/sys/netinet/cc

2014-10-27 Thread George Neville-Neil
On 27 Oct 2014, at 12:09, Hans Petter Selasky wrote: On 10/27/14 16:45, George Neville-Neil wrote: Can you modify this to preserve the limitation of TCP_CA_NAME_MAX ? Best, George Can you verify the following change? Subtracted one character from the limit for the terminating zero

Re: svn commit: r266974 - in head/sys: dev/dc dev/fxp dev/mii dev/netmap kern net

2014-06-03 Thread George Neville-Neil
On 2 Jun 2014, at 14:37, Marcel Moolenaar wrote: On Jun 2, 2014, at 11:26 AM, Adrian Chadd adr...@freebsd.org wrote: Woo! Would you mind doing up a 30 second what convert X to Y document so I can do the driveby on the wireless stack and drivers? I'm having difficulty parsing the question,

Re: svn commit: r266757 - in head/sys: conf dev/cxgbe dev/cxgbe/common modules/cxgbe/if_cxgbe

2014-05-27 Thread George Neville-Neil
On 27 May 2014, at 20:42, Navdeep Parhar wrote: On 05/27/14 17:36, Luigi Rizzo wrote: On Tue, May 27, 2014 at 8:18 PM, Navdeep Parhar n...@freebsd.org mailto:n...@freebsd.org wrote: Author: np Date: Tue May 27 18:18:41 2014 New Revision: 266757 URL:

Re: svn commit: r262727 - head/sys/net

2014-03-04 Thread George Neville-Neil
On Mar 4, 2014, at 12:14 , John Baldwin j...@freebsd.org wrote: On Tuesday, March 04, 2014 12:09:47 am George V. Neville-Neil wrote: Author: gnn Date: Tue Mar 4 05:09:46 2014 New Revision: 262727 URL: http://svnweb.freebsd.org/changeset/base/262727 Log: Naming consistency fix. The

Re: svn commit: r258328 - head/sys/net

2013-11-20 Thread George Neville-Neil
On Nov 20, 2013, at 17:02 , Adrian Chadd adr...@freebsd.org wrote: Can we revert this and just quickly put together something else that won't potentially come back to bite us with weird side effects? My suggestions (and I'm happy to do this work if needed): * create a lightweight mbuf

Re: svn commit: r258142 - head/sys/net

2013-11-14 Thread George Neville-Neil
On Nov 14, 2013, at 16:03 , Sergey Kandaurov pluk...@freebsd.org wrote: On 15 November 2013 00:07, George V. Neville-Neil g...@freebsd.org wrote: Author: gnn Date: Thu Nov 14 20:07:17 2013 New Revision: 258142 URL: http://svnweb.freebsd.org/changeset/base/258142 Log: Shift our OUI

Re: svn commit: r243989 - in stable/9: cddl/lib/libdtrace sys/kern sys/modules/dtrace sys/modules/dtrace/dtio sys/modules/dtrace/dtraceall sys/sys

2012-12-07 Thread George Neville-Neil
On Dec 7, 2012, at 15:07 , Scott Long scott4l...@yahoo.com wrote: Publicly, I'll state that I don't think that devstat is the right place for these, and I was hoping to have some time to move them to a better place, or at least fix up the existing problems that are present. This commit

Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/

2012-06-29 Thread George Neville-Neil
On Jun 29, 2012, at 13:35 , Pedro Giffuni wrote: (Sorry for top-posting] Actually ... David pointed out a fundamental flaw on my part. These are new files under a non-BSD license. Even when they are only scripts used for testing I shouldn't have brought them in without -core

Re: svn commit: r237748 - in head/sys/cddl/dev/dtrace: amd64 i386

2012-06-29 Thread George Neville-Neil
On Jun 29, 2012, at 03:42 , Andriy Gapon wrote: on 29/06/2012 10:35 Andriy Gapon said the following: Author: avg Date: Fri Jun 29 07:35:37 2012 New Revision: 237748 URL: http://svn.freebsd.org/changeset/base/237748 Log: dtrace instruction decoder: add 0x0f 0x1f NOP opcode support

Re: svn commit: r217018 - stable/8/sys/netinet

2011-01-07 Thread George Neville-Neil
On Jan 7, 2011, at 08:04 , John Baldwin wrote: On Friday, January 07, 2011 4:36:38 am Bjoern A. Zeeb wrote: On Fri, 7 Jan 2011, Lawrence Stewart wrote: Hi George, On 01/06/11 05:52, George V. Neville-Neil wrote: Author: gnn Date: Wed Jan 5 18:52:30 2011 New Revision: 217018 URL:

Re: svn commit: r216964 - stable/8/usr.bin/netstat

2011-01-04 Thread George Neville-Neil
On Jan 4, 2011, at 16:21 , John Nielsen wrote: The build on -STABLE is broken for me at at least one other person today and my guess is that this commit is to blame. My buildworld output: === usr.bin/netstat (all) cc -O2 -pipe -march=k6-3 -fno-strict-aliasing -DIPSEC -DSCTP -DNETGRAPH

Re: svn commit: r215434 - in head: sys/netinet usr.bin/netstat

2010-11-17 Thread George Neville-Neil
On Nov 17, 2010, at 13:55 , George V. Neville-Neil wrote: Author: gnn Date: Wed Nov 17 18:55:12 2010 New Revision: 215434 URL: http://svn.freebsd.org/changeset/base/215434 Log: Add new, per connection, statistics for TCP, including: Retransmitted Packets Zero Window Advertisements

Re: svn commit: r215207 - in head: sys/net sys/netinet tools/regression/netinet/arphold

2010-11-13 Thread George Neville-Neil
On Nov 13, 2010, at 04:09 , Mikolaj Golub wrote: On Fri, 12 Nov 2010 22:03:02 + (UTC) George V. Neville-Neil wrote: GVN Author: gnn GVN Date: Fri Nov 12 22:03:02 2010 GVN New Revision: 215207 GVN URL: http://svn.freebsd.org/changeset/base/215207 cc -c -O -pipe -std=c99 -g

Re: svn commit: r209259 - head/sys/dev/e1000

2010-06-17 Thread George Neville-Neil
On Jun 17, 2010, at 13:38 , Jack F Vogel wrote: Author: jfv Date: Thu Jun 17 17:38:39 2010 New Revision: 209259 URL: http://svn.freebsd.org/changeset/base/209259 Log: Two stats were duplicated, thanks to Andrew Boyer for pointing this out. And thanks to you for fixing it! Best,

Re: svn commit: r196797 - in head: sys/net sys/netinet usr.bin/netstat

2009-09-04 Thread George Neville-Neil
On Sep 4, 2009, at 00:44 , Bruce Simpson wrote: George V. Neville-Neil wrote: Author: gnn Date: Thu Sep 3 21:10:57 2009 New Revision: 196797 URL: http://svn.freebsd.org/changeset/base/196797 Log: Add ARP statistics to the kernel and netstat. Thanks very much for this change. Any chance

Re: svn commit: r192398 - in head/usr.bin: . perror

2009-05-21 Thread George Neville-Neil
On May 21, 2009, at 10:52 , M. Warner Losh wrote: In message: 20090521110115.ga50...@freebsd.org Alexey Dokuchaev da...@freebsd.org writes: : Given how easy it is to grep errno /usr/include/sys/ errno.h or : perl -e '$! = errno; print $!\n;' : I'm not sure of the utility of

Re: svn commit: r192085 - head/sys/netinet

2009-05-14 Thread George Neville-Neil
On May 13, 2009, at 22:27 , Qing Li wrote: Author: qingli Date: Thu May 14 05:27:09 2009 New Revision: 192085 URL: http://svn.freebsd.org/changeset/base/192085 Log: Ignore the INADDR_ANY address inserted/deleted by DHCP when installing a loopback route to the interface address. Hi,