Re: svn commit: r348737 - head/sys/kern

2019-06-06 Thread John Baldwin
On 6/6/19 11:21 AM, Ian Lepore wrote: > On Thu, 2019-06-06 at 12:04 -0600, Alan Somers wrote: >> On Thu, Jun 6, 2019 at 12:01 PM John Baldwin wrote: >>> >>> On 6/6/19 10:39 AM, Alan Somers wrote: >>>> On Thu, Jun 6, 2019 at 11:35 AM Rodney W. Grimes &g

Re: svn commit: r348753 - stable/11/sys/kern

2019-06-06 Thread John Baldwin
that users know what these new messages they are getting > are about. I'm not sure if we need that? We've had deprecation warnings before (FCP-101, etc.) This was just an edge case where some recently-added warnings weren't triggering on 11. -- John Baldwin _

svn commit: r348754 - stable/12/share/man/man4

2019-06-06 Thread John Baldwin
Author: jhb Date: Thu Jun 6 19:48:27 2019 New Revision: 348754 URL: https://svnweb.freebsd.org/changeset/base/348754 Log: MFC 346931,346933: Note that ccr(4) now supports AES-CCM. 346931: Note that ccr(4) now supports AES-CCM. 346933: Rewrap some long lines. Whitespace only c

svn commit: r348753 - stable/11/sys/kern

2019-06-06 Thread John Baldwin
Author: jhb Date: Thu Jun 6 19:41:05 2019 New Revision: 348753 URL: https://svnweb.freebsd.org/changeset/base/348753 Log: MFC 348543: Warn about deprecated features on all major OS versions. Approved by: re (gjb) Modified: stable/11/sys/kern/subr_bus.c Directory Properties: stable/11

svn commit: r348752 - stable/12/sys/kern

2019-06-06 Thread John Baldwin
Author: jhb Date: Thu Jun 6 19:40:12 2019 New Revision: 348752 URL: https://svnweb.freebsd.org/changeset/base/348752 Log: MFC 348543: Warn about deprecated features on all major OS versions. Modified: stable/12/sys/kern/subr_bus.c Directory Properties: stable/12/ (props changed) Modifie

Re: svn commit: r348737 - head/sys/kern

2019-06-06 Thread John Baldwin
e field. The potential downside is > limited, because only root can write to the sysctls, and the > worse-case damage is similar to a "umount -f". A compromise might be to stick this in a kernel module instead of in the base kernel. You could still kldload it in the field for debugging b

Re: svn commit: r348745 - head/sys/net

2019-06-06 Thread John Baldwin
On 6/6/19 10:43 AM, Mark Johnston wrote: > On Thu, Jun 06, 2019 at 10:13:13AM -0700, John Baldwin wrote: >> On 6/6/19 9:22 AM, Mark Johnston wrote: >>> Author: markj >>> Date: Thu Jun 6 16:22:29 2019 >>> New Revision: 348745 >>> URL: https://svnweb.

Re: svn commit: r348745 - head/sys/net

2019-06-06 Thread John Baldwin
GG_XLOCK_ASSERT(sc); > +#endif FWIW, the comment wasn't stale but on purpose (I added it when I added the check). The idea is to be the equivalent of assert(in_epoch(net_epoch_preempt) || lagg_xlocked(sc)) However, I couldn't write it that way, so I use LAGG_XLOCK_ASSERT when !in_ep

svn commit: r348712 - head/usr.sbin/bhyve

2019-06-05 Thread John Baldwin
Author: jhb Date: Wed Jun 5 23:37:50 2019 New Revision: 348712 URL: https://svnweb.freebsd.org/changeset/base/348712 Log: Use parse_integer to avoid sign extension. Coverity warned about gdb_write_mem sign extending the result of parse_byte shifted left by 24 bits when generating a 32-bi

svn commit: r348695 - head/sys/amd64/vmm/io

2019-06-05 Thread John Baldwin
Author: jhb Date: Wed Jun 5 19:30:32 2019 New Revision: 348695 URL: https://svnweb.freebsd.org/changeset/base/348695 Log: Support MSI-X for passthrough devices with a separate PBA BAR. pci_alloc_msix() requires both the table and PBA BARs to be allocated by the driver. ppt was only allo

svn commit: r348694 - head/usr.sbin/bhyve

2019-06-05 Thread John Baldwin
Author: jhb Date: Wed Jun 5 19:29:02 2019 New Revision: 348694 URL: https://svnweb.freebsd.org/changeset/base/348694 Log: Don't simulate PBA access if the PBA is in a separate BAR. bhyve has to virtualize the MSI-X table to trap reads and writes to that table and map those to virtual int

Re: svn commit: r348610 - in head: lib/clang/libllvm usr.bin/clang

2019-06-04 Thread John Baldwin
usr.bin/clang/Makefile I think you missed updating OptionalObsoleteFiles.inc or ObsoleteFiles.inc or some such because 'make delete-old' wants to delete these after they have been installed. Possibly the same for the recently-enabled llvm-symbolizer as well. -- John Baldwin __

svn commit: r348592 - head/usr.sbin/bhyve

2019-06-03 Thread John Baldwin
Author: jhb Date: Mon Jun 3 23:17:35 2019 New Revision: 348592 URL: https://svnweb.freebsd.org/changeset/base/348592 Log: Emulate the AMD MSR_LS_CFG MSR used for various Ryzen errata. Writes are ignored and reads always return zero. Submitted by: José Albornoz (write-only version)

svn commit: r348588 - in stable/11: sbin/geom/class/eli sys/geom/eli tests/sys/geom/class/eli

2019-06-03 Thread John Baldwin
Author: jhb Date: Mon Jun 3 21:04:23 2019 New Revision: 348588 URL: https://svnweb.freebsd.org/changeset/base/348588 Log: MFC 348206,348231,348454: GELI crypto deprecation warnings. 348206: Add deprecation warnings for weaker algorithms to geli(4). - Triple DES has been formally dep

svn commit: r348587 - in stable/12: lib/geom/eli sys/geom/eli tests/sys/geom/class/eli

2019-06-03 Thread John Baldwin
Author: jhb Date: Mon Jun 3 21:03:28 2019 New Revision: 348587 URL: https://svnweb.freebsd.org/changeset/base/348587 Log: MFC 348206,348231,348454: GELI crypto deprecation warnings. 348206: Add deprecation warnings for weaker algorithms to geli(4). - Triple DES has been formally dep

svn commit: r348543 - head/sys/kern

2019-06-03 Thread John Baldwin
Author: jhb Date: Mon Jun 3 15:43:40 2019 New Revision: 348543 URL: https://svnweb.freebsd.org/changeset/base/348543 Log: Warn about deprecated features on all major OS versions. Reviewed by: imp MFC after:3 days Sponsored by: Chelsio Communications Differential Revision:

svn commit: r348542 - head/share/man/man4

2019-06-03 Thread John Baldwin
Author: jhb Date: Mon Jun 3 15:41:54 2019 New Revision: 348542 URL: https://svnweb.freebsd.org/changeset/base/348542 Log: Add 'device cxgbe' explicitly in the synopsis. ccr depends on symbols exported by the cxgbe driver as well as having a runtime dependency. While the runtime depenenc

Re: svn commit: r348482 - stable/11/sys/netipsec

2019-05-31 Thread John Baldwin
On 5/31/19 3:47 PM, Warner Losh wrote: > On Fri, May 31, 2019 at 4:36 PM John Baldwin wrote: > >> On 5/31/19 1:26 PM, John Baldwin wrote: >>> Author: jhb >>> Date: Fri May 31 20:26:56 2019 >>> New Revision: 348482 >>> URL: https://svnweb.freebsd.

Re: svn commit: r348482 - stable/11/sys/netipsec

2019-05-31 Thread John Baldwin
On 5/31/19 1:26 PM, John Baldwin wrote: > Author: jhb > Date: Fri May 31 20:26:56 2019 > New Revision: 348482 > URL: https://svnweb.freebsd.org/changeset/base/348482 > > Log: > MFC 348205: > Add deprecation warnings for IPsec algorithms deprecated in RFC 8221. >

Re: svn commit: r348481 - stable/12/sys/netipsec

2019-05-31 Thread John Baldwin
On 5/31/19 1:25 PM, John Baldwin wrote: > Author: jhb > Date: Fri May 31 20:25:57 2019 > New Revision: 348481 > URL: https://svnweb.freebsd.org/changeset/base/348481 > > Log: > MFC 348205: > Add deprecation warnings for IPsec algorithms deprecated in RFC 8221. >

svn commit: r348482 - stable/11/sys/netipsec

2019-05-31 Thread John Baldwin
Author: jhb Date: Fri May 31 20:26:56 2019 New Revision: 348482 URL: https://svnweb.freebsd.org/changeset/base/348482 Log: MFC 348205: Add deprecation warnings for IPsec algorithms deprecated in RFC 8221. All of these algorithms are either explicitly marked MUST NOT, or they are implici

svn commit: r348481 - stable/12/sys/netipsec

2019-05-31 Thread John Baldwin
Author: jhb Date: Fri May 31 20:25:57 2019 New Revision: 348481 URL: https://svnweb.freebsd.org/changeset/base/348481 Log: MFC 348205: Add deprecation warnings for IPsec algorithms deprecated in RFC 8221. All of these algorithms are either explicitly marked MUST NOT, or they are implici

svn commit: r348472 - head/usr.sbin/bhyve

2019-05-31 Thread John Baldwin
Author: jhb Date: Fri May 31 18:00:44 2019 New Revision: 348472 URL: https://svnweb.freebsd.org/changeset/base/348472 Log: Whitespace cleanups, no functional change. Modified: head/usr.sbin/bhyve/pci_emul.c Modified: head/usr.sbin/bhyve/pci_emul.c

svn commit: r348448 - svnadmin/conf

2019-05-30 Thread John Baldwin
Author: jhb Date: Thu May 30 21:54:49 2019 New Revision: 348448 URL: https://svnweb.freebsd.org/changeset/base/348448 Log: Welcome D Scott Phillips (scottph) as a src committer. Scott will be working on various Intel-focused changes. Approved by: core Modified: svnadmin/conf/access

svn commit: r348442 - stable/12/sys/dev/cxgbe/crypto

2019-05-30 Thread John Baldwin
Author: jhb Date: Thu May 30 18:44:19 2019 New Revision: 348442 URL: https://svnweb.freebsd.org/changeset/base/348442 Log: MFC 346650: Add support for AES-CCM to ccr(4). This is fairly similar to the AES-GCM support in ccr(4) in that it will fall back to software for certain cases (reques

Re: svn commit: r348435 - stable/11/sys/netinet

2019-05-30 Thread John Baldwin
c cc1: warnings being treated as errors /usr/src/sys/netinet/tcp_subr.c:232: warning: 'tcp_default_fb_init' declared 'static' but never defined /usr/src/sys/netinet/tcp_subr.c:233: warning: 'tcp_default_fb_fini' declared 'static' but never defined /usr/src

svn commit: r348437 - stable/11/sys/amd64/vmm

2019-05-30 Thread John Baldwin
Author: jhb Date: Thu May 30 16:42:57 2019 New Revision: 348437 URL: https://svnweb.freebsd.org/changeset/base/348437 Log: MFC 347964: Expose the MD_CLEAR capability used by Intel MDS mitigations to guests. Approved by: re (gjb) Modified: stable/11/sys/amd64/vmm/x86.c Directory Proper

svn commit: r348436 - stable/12/sys/amd64/vmm

2019-05-30 Thread John Baldwin
Author: jhb Date: Thu May 30 16:40:21 2019 New Revision: 348436 URL: https://svnweb.freebsd.org/changeset/base/348436 Log: MFC 347964: Expose the MD_CLEAR capability used by Intel MDS mitigations to guests. Modified: stable/12/sys/amd64/vmm/x86.c Directory Properties: stable/12/ (props

svn commit: r348375 - stable/11/usr.sbin/bhyve

2019-05-29 Thread John Baldwin
Author: jhb Date: Wed May 29 23:11:07 2019 New Revision: 348375 URL: https://svnweb.freebsd.org/changeset/base/348375 Log: MFC 347033: Increase the VirtIO segment count to support modern Windows guests. The Windows virtio driver ignores the advertized seg_max field and assumes the host

svn commit: r348374 - stable/12/usr.sbin/bhyve

2019-05-29 Thread John Baldwin
Author: jhb Date: Wed May 29 23:05:26 2019 New Revision: 348374 URL: https://svnweb.freebsd.org/changeset/base/348374 Log: MFC 347033: Increase the VirtIO segment count to support modern Windows guests. The Windows virtio driver ignores the advertized seg_max field and assumes the host

svn commit: r348371 - stable/11/usr.sbin/bhyve

2019-05-29 Thread John Baldwin
Author: jhb Date: Wed May 29 20:45:31 2019 New Revision: 348371 URL: https://svnweb.freebsd.org/changeset/base/348371 Log: MFC 345158: Fix uart emulation bug THRE is always asserted in LSR reads, so REG_IER writes that raise IER_ETXRDY must also set thre_int_pending. Approved by: re

Re: svn commit: r348338 - head/sys/fs/pseudofs

2019-05-29 Thread John Baldwin
re set to VNOVAL by via VATTR_NULL and then the caller sets the fields they want to change. You can then reject attempts to set attributes you don't support. (e.g. see how ufs_setattr fails with EINVAL if fields it doesn't support aren't set to VNOVAL). You should also likely valida

svn commit: r348254 - in head/sys: dev/cxgbe dev/mlx5/mlx5_en kern net net80211 netinet netinet6 netpfil/ipfw sys

2019-05-24 Thread John Baldwin
Author: jhb Date: Fri May 24 22:30:40 2019 New Revision: 348254 URL: https://svnweb.freebsd.org/changeset/base/348254 Log: Restructure mbuf send tags to provide stronger guarantees. - Perform ifp mismatch checks (to determine if a send tag is allocated for a different ifp than the one t

svn commit: r348253 - head/usr.sbin/bhyve

2019-05-24 Thread John Baldwin
Author: jhb Date: Fri May 24 22:11:37 2019 New Revision: 348253 URL: https://svnweb.freebsd.org/changeset/base/348253 Log: Add initial support for 'qSupported' to the debug server. This doesn't recognize any features yet, but does parse the features string. It advertises an arbitrary pac

Re: svn commit: r348241 - head

2019-05-24 Thread John Baldwin
gt; less memorable build step: > > export NCPU=$((1 * $(sysctl -n hw.ncpu) / 3)); make -sj${NCPU} > tinderbox JFLAG=-j${NCPU} UNIVERSE_TARGET=kernel-toolchain -DNO_CLEAN You can spell it slightly shorter as 'make kernel-toolchains' (but still needing -j, etc.) -- John Baldwin ___

Re: svn commit: r348205 - head/sys/netipsec

2019-05-24 Thread John Baldwin
n't quite clear. Also, just to make it clear, I don't care about IANA numbers, I was merely referencing the RFC's wording as the "why". -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/lis

Re: svn commit: r348205 - head/sys/netipsec

2019-05-23 Thread John Baldwin
ipemd160 is a more obscure hash that is more like sha1 than the sha2 variants. RFC 6071 states that you can't use ripemd with IKE due to no IANA number which would seem to preclude its use in any "real" deployments (and 6071 is already 8 years old). -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r348205 - head/sys/netipsec

2019-05-23 Thread John Baldwin
On 5/23/19 5:53 PM, Rodney W. Grimes wrote: >> On 5/23/19 3:06 PM, John Baldwin wrote: >>> Author: jhb >>> Date: Thu May 23 22:06:57 2019 >>> New Revision: 348205 >>> URL: https://svnweb.freebsd.org/changeset/base/348205 >>> >>> Log: &g

svn commit: r348213 - in stable/12/sys/dev/cxgbe: crypto tom

2019-05-23 Thread John Baldwin
Author: jhb Date: Fri May 24 00:44:31 2019 New Revision: 348213 URL: https://svnweb.freebsd.org/changeset/base/348213 Log: MFC 340486: Consolidate on a single set of constants for SCMD fields. Both ccr(4) and the TOE TLS code had separate sets of constants for fields in SCMD messages. Mo

svn commit: r348212 - head/usr.sbin/bhyve

2019-05-23 Thread John Baldwin
Author: jhb Date: Fri May 24 00:34:13 2019 New Revision: 348212 URL: https://svnweb.freebsd.org/changeset/base/348212 Log: Add support for writing to guest memory in the debug server. - Add a write_mem counterpart to read_mem to handle writes to MMIO. - Add support for the GDB 'M' packet

svn commit: r348210 - in head/sys: amd64/amd64 x86/include

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 23:37:11 2019 New Revision: 348210 URL: https://svnweb.freebsd.org/changeset/base/348210 Log: Add a constant for the LS config MSR on AMD CPUs. MFC after:1 week Differential Revision:https://reviews.freebsd.org/D19506 Modified: head/sys/amd64/am

svn commit: r348206 - in head: lib/geom/eli sys/geom/eli

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 22:31:55 2019 New Revision: 348206 URL: https://svnweb.freebsd.org/changeset/base/348206 Log: Add deprecation warnings for weaker algorithms to geli(4). - Triple DES has been formally deprecated in Kerberos (RFC 8429) and is soon to be deprecated in IPsec (R

Re: svn commit: r348205 - head/sys/netipsec

2019-05-23 Thread John Baldwin
On 5/23/19 3:06 PM, John Baldwin wrote: > Author: jhb > Date: Thu May 23 22:06:57 2019 > New Revision: 348205 > URL: https://svnweb.freebsd.org/changeset/base/348205 > > Log: > Add deprecation warnings for IPsec algorithms deprecated in RFC 8221. > > All of

Re: svn commit: r348185 - in head: . etc lib/libc/gen usr.sbin/etcupdate usr.sbin/mergemaster

2019-05-23 Thread John Baldwin
H mechanism instead so keep installing them from lib/libc/gen > > While here revert 347961 and 347893 which are no longer needed > > Discussed with: manu > Tested by: manu > ok manu@ Thank you. -- John Baldwin _

svn commit: r348205 - head/sys/netipsec

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 22:06:57 2019 New Revision: 348205 URL: https://svnweb.freebsd.org/changeset/base/348205 Log: Add deprecation warnings for IPsec algorithms deprecated in RFC 8221. All of these algorithms are either explicitly marked MUST NOT, or they are implicitly MUST NOTs

svn commit: r348203 - stable/12/tests/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 21:57:58 2019 New Revision: 348203 URL: https://svnweb.freebsd.org/changeset/base/348203 Log: MFC 346617: Test the AES-CCM test vectors from the NIST Known Answer Tests. The CCM test vectors use a slightly different file format in that there are global key-val

svn commit: r348202 - stable/12/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 21:52:24 2019 New Revision: 348202 URL: https://svnweb.freebsd.org/changeset/base/348202 Log: MFC 346649: Don't panic for empty CCM requests. A request to encrypt an empty payload without any AAD is unusual, but it is defined behavior. Removing this assertion

svn commit: r348200 - stable/12/sys/dev/cxgbe/crypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 21:05:05 2019 New Revision: 348200 URL: https://svnweb.freebsd.org/changeset/base/348200 Log: MFC 346648: Fix requests for "plain" SHA digests of an empty buffer. To workaround limitations in the crypto engine, empty buffers are handled by manually constructin

svn commit: r348193 - stable/12/tests/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 19:20:37 2019 New Revision: 348193 URL: https://svnweb.freebsd.org/changeset/base/348193 Log: MFC 346616: Run the plain SHA digest tests from NIST. Pass in an explicit digest length to the Crypto constructor since it was assuming only sessions with a MAC key w

svn commit: r348192 - stable/12/tests/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 19:19:09 2019 New Revision: 348192 URL: https://svnweb.freebsd.org/changeset/base/348192 Log: MFC 346615: Use more descriptive algorithm names in skip messages. Modified: stable/12/tests/sys/opencrypto/cryptotest.py Directory Properties: stable/12/ (props chan

svn commit: r348191 - stable/12/tests/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 19:18:21 2019 New Revision: 348191 URL: https://svnweb.freebsd.org/changeset/base/348191 Log: MFC 346614: Skip tests with missing test vectors instead of failing. This copes more gracefully when older version of the nist-kat package are intalled that don't hav

svn commit: r348190 - stable/12/tests/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 19:13:38 2019 New Revision: 348190 URL: https://svnweb.freebsd.org/changeset/base/348190 Log: MFC 346421: Test SHA2-224-HMAC now that OCF supports it. Modified: stable/12/tests/sys/opencrypto/cryptotest.py Directory Properties: stable/12/ (props changed) Modi

svn commit: r348189 - stable/12/tests/sys/opencrypto

2019-05-23 Thread John Baldwin
Author: jhb Date: Thu May 23 19:12:47 2019 New Revision: 348189 URL: https://svnweb.freebsd.org/changeset/base/348189 Log: MFC 346419: Sync cryptographic algorithm constants with current cryptodev.h. Modified: stable/12/tests/sys/opencrypto/cryptodevh.py Directory Properties: stable/12/ (

Re: svn commit: r348109 - in head/sys/x86: include x86

2019-05-22 Thread John Baldwin
>> >> Just curious, what is SMCA? > > Scalable MCA. It's a set of AMD Fam17h MCA extensions. How is it different aside from using different MSR numbers (which seems a bit gratuitous if that is really all the change is). -- John Baldwin __

Re: svn commit: r347961 - head

2019-05-22 Thread John Baldwin
why these files were moved out of their perfectly > (and likely the only) reasonable location (etc/) under some cryptic > libc/gen/ which not only makes little sense per se, but also breaks > mergemaster(8) and similar tools? Because bmake doesn't support .PATH? Oh wait... -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r347951 - stable/12/lib/libc/stdlib

2019-05-21 Thread John Baldwin
t be hard to do that inside a man page... > > Given the current tooling I concur, so we need .include > for mandoc, and teach mandoc how to format example code which > is mostly knows how to do, or atleast there was lots of groff > code to do th

Re: svn commit: r348012 - in stable/12: libexec/rc sbin/ifconfig share/man/man5 tools/tools/tinybsd/conf/firewall/etc usr.sbin/jail

2019-05-21 Thread John Baldwin
at aren't already comments should be fixed to be comments in HEAD at least. I think it is safe to merge all of the changes that aren't uncommented lines in rc.conf though. -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r347964 - head/sys/amd64/vmm

2019-05-18 Thread John Baldwin
Author: jhb Date: Sat May 18 21:20:38 2019 New Revision: 347964 URL: https://svnweb.freebsd.org/changeset/base/347964 Log: Expose the MD_CLEAR capability used by Intel MDS mitigations to guests. Submitted by: Patrick Mooney Reviewed by: kib Tested by:Patrick on SmartOS with Linux

svn commit: r347465 - head/sys/netinet6

2019-05-10 Thread John Baldwin
Author: jhb Date: Fri May 10 20:15:40 2019 New Revision: 347465 URL: https://svnweb.freebsd.org/changeset/base/347465 Log: Apply r280991 to ip6_fragment. This uses m_dup_pkthdr() to copy all of the metadata about a packet to each of its fragments including VLAN tags, mbuf tags, etc. inste

svn commit: r347443 - stable/11/sys/amd64/vmm/io

2019-05-10 Thread John Baldwin
Author: jhb Date: Fri May 10 16:51:36 2019 New Revision: 347443 URL: https://svnweb.freebsd.org/changeset/base/347443 Log: Complete the MFC of 345963 after the MFC of 333174. Suggested by: kib Modified: stable/11/sys/amd64/vmm/io/ppt.c Modified: stable/11/sys/amd64/vmm/io/ppt.c

svn commit: r347437 - stable/11/usr.sbin/bhyve

2019-05-10 Thread John Baldwin
Author: jhb Date: Fri May 10 16:38:48 2019 New Revision: 347437 URL: https://svnweb.freebsd.org/changeset/base/347437 Log: MFC 342944: Fix spelling of identifier Modified: stable/11/usr.sbin/bhyve/bhyve.8 Directory Properties: stable/11/ (props changed) Modified: stable/11/usr.sbin/bhyve

svn commit: r347436 - stable/11/usr.sbin/bhyve

2019-05-10 Thread John Baldwin
Author: jhb Date: Fri May 10 16:36:38 2019 New Revision: 347436 URL: https://svnweb.freebsd.org/changeset/base/347436 Log: MFC 340707: Define AHCI_PORT_IDENT and increase by 1 the VTBLK_BLK_ID_BYTES to avoid buffer accessed out of bounds, also switch to snprintf(3). PR: 200859

svn commit: r347435 - in stable/11/sys/amd64: include vmm vmm/intel

2019-05-10 Thread John Baldwin
Author: jhb Date: Fri May 10 16:32:44 2019 New Revision: 347435 URL: https://svnweb.freebsd.org/changeset/base/347435 Log: MFC 338957: Handle a guest executing a vm instruction by trapping and raising an undefined instruction exception. Previously we would exit the guest, however an unpriv

svn commit: r347416 - in stable/11/sys/amd64: include vmm vmm/intel

2019-05-09 Thread John Baldwin
Author: jhb Date: Thu May 9 23:57:02 2019 New Revision: 347416 URL: https://svnweb.freebsd.org/changeset/base/347416 Log: MFC 332479: Add SDT probes to vmexit on Intel. Modified: stable/11/sys/amd64/include/vmm.h stable/11/sys/amd64/vmm/intel/vmx.c stable/11/sys/amd64/vmm/vmm.c Directory

svn commit: r347412 - stable/11/usr.sbin/bhyve

2019-05-09 Thread John Baldwin
Author: jhb Date: Thu May 9 22:42:23 2019 New Revision: 347412 URL: https://svnweb.freebsd.org/changeset/base/347412 Log: MFC 334272: bhyve: guarantee NUL termination Use strlcpy to guarantee NUL termination of the path to a virtio console socket. Modified: stable/11/usr.sbin/bhyve/pc

svn commit: r347411 - stable/11/usr.sbin/bhyve

2019-05-09 Thread John Baldwin
Author: jhb Date: Thu May 9 22:39:24 2019 New Revision: 347411 URL: https://svnweb.freebsd.org/changeset/base/347411 Log: MFC 334271: bhyve: fix small memory leak in virtio console Modified: stable/11/usr.sbin/bhyve/pci_virtio_console.c Directory Properties: stable/11/ (props changed) M

svn commit: r347409 - in stable/11/sys/amd64: include vmm

2019-05-09 Thread John Baldwin
Author: jhb Date: Thu May 9 22:31:47 2019 New Revision: 347409 URL: https://svnweb.freebsd.org/changeset/base/347409 Log: MFC 333639: vmmdev: return EFAULT when trying to read beyond VM system memory max address Currently, when using dd(1) to take a VM memory image, the capture never end

svn commit: r347406 - stable/11/usr.sbin/bhyve

2019-05-09 Thread John Baldwin
Author: jhb Date: Thu May 9 20:30:35 2019 New Revision: 347406 URL: https://svnweb.freebsd.org/changeset/base/347406 Log: MFC 333235: Allow arbitrary numbers of columns for VNC server screen resolution. The prior code only allowed multiples of 32 for the numbers of columns. Remove this

svn commit: r347374 - stable/11/sys/amd64/vmm/io

2019-05-08 Thread John Baldwin
Author: jhb Date: Wed May 8 23:24:47 2019 New Revision: 347374 URL: https://svnweb.freebsd.org/changeset/base/347374 Log: MFC 333174: Use PCI power-mgmt to reset a device if FLR fails. A large number of devices don't support PCIe FLR, in particular graphics adapters. Use PCI power manage

Re: svn commit: r347063 - head/sys/kern

2019-05-07 Thread John Baldwin
On 5/7/19 8:45 AM, Bruce Evans wrote: > On Mon, 6 May 2019, John Baldwin wrote: > >> On 5/6/19 11:45 AM, Mark Johnston wrote: >>> On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: >>>> On 5/3/19 2:26 PM, Mark Johnston wrote: >>>>> Au

Re: svn commit: r347063 - head/sys/kern

2019-05-06 Thread John Baldwin
On 5/6/19 1:57 PM, Mark Johnston wrote: > On Mon, May 06, 2019 at 01:40:19PM -0700, John Baldwin wrote: >> On 5/6/19 11:45 AM, Mark Johnston wrote: >>> On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: >>>> On 5/3/19 2:26 PM, Mark Johnston wrote: >>&

Re: svn commit: r347063 - head/sys/kern

2019-05-06 Thread John Baldwin
On 5/6/19 11:45 AM, Mark Johnston wrote: > On Mon, May 06, 2019 at 11:07:18AM -0700, John Baldwin wrote: >> On 5/3/19 2:26 PM, Mark Johnston wrote: >>> Author: markj >>> Date: Fri May 3 21:26:44 2019 >>> New Revision: 347063 >>> URL: https://svnweb.

Re: svn commit: r347063 - head/sys/kern

2019-05-06 Thread John Baldwin
nce, but I can't see why you are checking against utc_offset() vs some small constant? None of the discussion in the review mentioned the reason for using this particular value, and I didn't see any comparisons against utc_offset or kernadjtz in kern

Re: svn commit: r347180 - head/sys/vm

2019-05-06 Thread John Baldwin
sored by: The FreeBSD Foundation > MFC after: 6 days Did the log message get lost? -- John Baldwin ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r347074 - in stable/11/sys/amd64: include vmm/intel

2019-05-03 Thread John Baldwin
Author: jhb Date: Sat May 4 00:59:11 2019 New Revision: 347074 URL: https://svnweb.freebsd.org/changeset/base/347074 Log: MFC 330615: Fix a lock recursion introduced in r327065. Modified: stable/11/sys/amd64/include/vmm.h stable/11/sys/amd64/vmm/intel/vmx.c Directory Properties: stable/1

svn commit: r347073 - stable/11/sys/amd64/vmm/intel

2019-05-03 Thread John Baldwin
Author: jhb Date: Sat May 4 00:56:47 2019 New Revision: 347073 URL: https://svnweb.freebsd.org/changeset/base/347073 Log: MFC 327065: Recognize a pending virtual interrupt while emulating the halt instruction. Modified: stable/11/sys/amd64/vmm/intel/vmx.c Directory Properties: stable/11/

svn commit: r347065 - head/sys/amd64/vmm

2019-05-03 Thread John Baldwin
Author: jhb Date: Fri May 3 21:48:42 2019 New Revision: 347065 URL: https://svnweb.freebsd.org/changeset/base/347065 Log: Emulate the "ADD reg, r/m" instruction (opcode 03H). OVMF's flash variable storage is using add instructions when indexing the variable store bootrom location. S

svn commit: r347036 - stable/11/usr.sbin/bhyve

2019-05-02 Thread John Baldwin
Author: jhb Date: Fri May 3 00:20:02 2019 New Revision: 347036 URL: https://svnweb.freebsd.org/changeset/base/347036 Log: MFC 325727: bhyve: avoid applying capsicum capabilities to file that was not opened When using -l option targeting file that can't be opened (ie. nmdm module is not

svn commit: r347035 - stable/11/usr.sbin/bhyve

2019-05-02 Thread John Baldwin
Author: jhb Date: Fri May 3 00:02:07 2019 New Revision: 347035 URL: https://svnweb.freebsd.org/changeset/base/347035 Log: MFC 313732: bhyve: whitespace fix for r313727 Modified: stable/11/usr.sbin/bhyve/consport.c Directory Properties: stable/11/ (props changed) Modified: stable/11/usr.

svn commit: r347033 - head/usr.sbin/bhyve

2019-05-02 Thread John Baldwin
Author: jhb Date: Thu May 2 22:46:37 2019 New Revision: 347033 URL: https://svnweb.freebsd.org/changeset/base/347033 Log: Increase the VirtIO segment count to support modern Windows guests. The Windows virtio driver ignores the advertized seg_max field and assumes the host can accept up

svn commit: r347022 - svnadmin/conf

2019-05-02 Thread John Baldwin
Author: jhb Date: Thu May 2 16:57:39 2019 New Revision: 347022 URL: https://svnweb.freebsd.org/changeset/base/347022 Log: Release peterj@ from mentorship. Modified: svnadmin/conf/mentors Modified: svnadmin/conf/mentors

svn commit: r347006 - stable/12/sys/netinet

2019-05-01 Thread John Baldwin
Author: jhb Date: Wed May 1 21:54:21 2019 New Revision: 347006 URL: https://svnweb.freebsd.org/changeset/base/347006 Log: MFC 345712: Don't check the inp socket pointer in in_pcboutput_eagain. Modified: stable/12/sys/netinet/in_pcb.c Directory Properties: stable/12/ (props changed) Modi

svn commit: r347005 - stable/12/sys/net

2019-05-01 Thread John Baldwin
Author: jhb Date: Wed May 1 21:45:15 2019 New Revision: 347005 URL: https://svnweb.freebsd.org/changeset/base/347005 Log: MFC 345655: Remove nested epochs from lagg(4). lagg_bcast_start appeared to have a bug in that was using the last lagg port structure after exiting the epoch that was

svn commit: r347004 - stable/12/sys/net

2019-05-01 Thread John Baldwin
Author: jhb Date: Wed May 1 21:26:33 2019 New Revision: 347004 URL: https://svnweb.freebsd.org/changeset/base/347004 Log: MFC 345659: Use a dedicated malloc type for lagg(4)'s structures. Modified: stable/12/sys/net/if_lagg.c Directory Properties: stable/12/ (props changed) Modified: st

svn commit: r347000 - stable/12/sys/dev/acpica

2019-05-01 Thread John Baldwin
Author: jhb Date: Wed May 1 18:17:42 2019 New Revision: 347000 URL: https://svnweb.freebsd.org/changeset/base/347000 Log: MFC 346066: Refine r330113 to honor the ProducerConsumer flag most of the time. While it is true that the ACPI spec says that the flag is only valid on Extended Addr

svn commit: r346999 - in stable: 11/sys/dev/acpica 12/sys/dev/acpica

2019-05-01 Thread John Baldwin
Author: jhb Date: Wed May 1 17:30:14 2019 New Revision: 346999 URL: https://svnweb.freebsd.org/changeset/base/346999 Log: MFC 346063: Don't pre-reserve resources for CPU devices when they are set. CPUs can use shared (RF_SHAREABLE) resources for the I/O port used for entering and exiting

svn commit: r346999 - in stable: 11/sys/dev/acpica 12/sys/dev/acpica

2019-05-01 Thread John Baldwin
Author: jhb Date: Wed May 1 17:30:14 2019 New Revision: 346999 URL: https://svnweb.freebsd.org/changeset/base/346999 Log: MFC 346063: Don't pre-reserve resources for CPU devices when they are set. CPUs can use shared (RF_SHAREABLE) resources for the I/O port used for entering and exiting

Re: svn commit: r341586 - head/sys/dev/mlx5/mlx5_en

2019-05-01 Thread John Baldwin
On 5/1/19 1:05 AM, Slava Shwartsman wrote: > > > On 01-May-19 10:28, Slava Shwartsman wrote: >> >> >> On 01-May-19 10:09, Slava Shwartsman wrote: >>> >>> >>> On 30-Apr-19 00:14, John Baldwin wrote: >>>> On 4/25/19 12:10 AM,

svn commit: r346978 - in stable: 11/sys/amd64/vmm/intel 12/sys/amd64/vmm/intel

2019-04-30 Thread John Baldwin
Author: jhb Date: Tue Apr 30 23:53:54 2019 New Revision: 346978 URL: https://svnweb.freebsd.org/changeset/base/346978 Log: MFC 344711: Fix missed posted interrupts in VT-x in bhyve. When a vCPU is HLTed, interrupts with a priority below the processor priority (PPR) should not resume the v

svn commit: r346978 - in stable: 11/sys/amd64/vmm/intel 12/sys/amd64/vmm/intel

2019-04-30 Thread John Baldwin
Author: jhb Date: Tue Apr 30 23:53:54 2019 New Revision: 346978 URL: https://svnweb.freebsd.org/changeset/base/346978 Log: MFC 344711: Fix missed posted interrupts in VT-x in bhyve. When a vCPU is HLTed, interrupts with a priority below the processor priority (PPR) should not resume the v

svn commit: r346933 - head/share/man/man4

2019-04-29 Thread John Baldwin
Author: jhb Date: Mon Apr 29 22:15:51 2019 New Revision: 346933 URL: https://svnweb.freebsd.org/changeset/base/346933 Log: Rewrap some long lines. Whitespace only change. Modified: head/share/man/man4/ccr.4 Modified: head/share/man/man4/ccr.4

Re: svn commit: r346931 - head/share/man/man4

2019-04-29 Thread John Baldwin
On 4/29/19 3:04 PM, Enji Cooper wrote: > >> On Apr 29, 2019, at 15:00, John Baldwin wrote: >> >> Author: jhb >> Date: Mon Apr 29 22:00:45 2019 >> New Revision: 346931 >> URL: https://svnweb.freebsd.org/changeset/base/346931 >> >> Log: >

svn commit: r346931 - head/share/man/man4

2019-04-29 Thread John Baldwin
Author: jhb Date: Mon Apr 29 22:00:45 2019 New Revision: 346931 URL: https://svnweb.freebsd.org/changeset/base/346931 Log: Note that ccr(4) now supports AES-CCM. Modified: head/share/man/man4/ccr.4 Modified: head/share/man/man4/ccr.4 ==

svn commit: r346929 - stable/12/share/man/man4

2019-04-29 Thread John Baldwin
Author: jhb Date: Mon Apr 29 21:39:09 2019 New Revision: 346929 URL: https://svnweb.freebsd.org/changeset/base/346929 Log: MFC 345041: Update ccr(4) to note recent support for SHA2-224 and plain SHA hashes. Modified: stable/12/share/man/man4/ccr.4 Directory Properties: stable/12/ (props

Re: svn commit: r341586 - head/sys/dev/mlx5/mlx5_en

2019-04-29 Thread John Baldwin
On 4/25/19 12:10 AM, Slava Shwartsman wrote: > > > On 17-Apr-19 00:28, John Baldwin wrote: >> On 4/16/19 8:32 AM, Hans Petter Selasky wrote: >>> On 4/16/19 4:39 PM, Andrey V. Elsukov wrote: >>>> On 05.12.2018 17:25, Slava Shwartsman wrote: >>>>&

Re: svn commit: r346386 - in head/sys: dev/bge dev/pci dev/twa x86/iommu

2019-04-25 Thread John Baldwin
:43:33 2019 >>> (r346386) >>> @@ -551,7 +551,7 @@ tw_osli_alloc_mem(struct twa_softc *sc) >>> /* Create the parent dma tag. */ >>> if (bus_dma_tag_create(bus_get_dma_tag(sc->bus_dev), /* parent */ >>>

Re: svn commit: r346687 - head/sys/compat/linuxkpi/common/src

2019-04-25 Thread John Baldwin
maxsegsz */ >> 0, /* flags */ >> NULL, NULL, /* lockfunc, lockfuncarg */ >> &priv->dmat); > > It seems that amd64 BUS_SPACE_MAXSIZE is 4G, I do not know why. > Eith

svn commit: r346695 - in head/sys: kern sys

2019-04-25 Thread John Baldwin
Author: jhb Date: Thu Apr 25 18:42:07 2019 New Revision: 346695 URL: https://svnweb.freebsd.org/changeset/base/346695 Log: Remove p_code from struct proc. Contrary to the comments, it was never used by core dumps or debuggers. Instead, it used to hold the signal code of a pending signa

svn commit: r346651 - head/usr.sbin/kldxref

2019-04-24 Thread John Baldwin
+1,99 @@ +/*- + * SPDX-License-Identifier: BSD-2-Clause-FreeBSD + * + * Copyright (c) 2019 John Baldwin + * + * This software was developed by SRI International and the University of + * Cambridge Computer Laboratory (Department of Computer Science and + * Technology) under DARPA contract HR0011-18

svn commit: r346650 - head/sys/dev/cxgbe/crypto

2019-04-24 Thread John Baldwin
Author: jhb Date: Wed Apr 24 23:31:46 2019 New Revision: 346650 URL: https://svnweb.freebsd.org/changeset/base/346650 Log: Add support for AES-CCM to ccr(4). This is fairly similar to the AES-GCM support in ccr(4) in that it will fall back to software for certain cases (requests with only

<    5   6   7   8   9   10   11   12   13   14   >