svn commit: r247584 - head/sys/kern

2013-03-01 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Mar 1 21:57:02 2013 New Revision: 247584 URL: http://svnweb.freebsd.org/changeset/base/247584 Log: Reduce lock scope a little. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c

svn commit: r247442 - head/contrib/openbsm/bin/auditdistd

2013-02-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 28 01:24:24 2013 New Revision: 247442 URL: http://svnweb.freebsd.org/changeset/base/247442 Log: When we are waiting for new trail files we may have been disconnected and reconnected in the meantime. Check if reset is set before opening next trail file, as not doing

svn commit: r247284 - head/sys/kern

2013-02-25 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 25 20:51:29 2013 New Revision: 247284 URL: http://svnweb.freebsd.org/changeset/base/247284 Log: Style. Suggested by: kib Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c ==

svn commit: r247283 - head/sys/kern

2013-02-25 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 25 20:50:08 2013 New Revision: 247283 URL: http://svnweb.freebsd.org/changeset/base/247283 Log: After r237012, the fdgrowtable() doesn't drop the filedesc lock anymore, so update a stale comment. Reviewed by: kib, keramida Modified: head/sys/kern/kern_descrip

svn commit: r247164 - head/usr.sbin/extattr

2013-02-22 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Feb 22 20:49:50 2013 New Revision: 247164 URL: http://svnweb.freebsd.org/changeset/base/247164 Log: Don't print an empty line for files with no attributes when -q is given for lsextattr(8). Modified: head/usr.sbin/extattr/rmextattr.c Modified: head/usr.sbin/extattr/rm

svn commit: r247061 - in head/sys: crypto/aesni opencrypto

2013-02-20 Thread Pawel Jakub Dawidek
(r247060) +++ head/sys/crypto/aesni/aesni_wrap.c Wed Feb 20 22:59:53 2013 (r247061) @@ -1,4 +1,5 @@ /*- + * Copyright (C) 2008 Damien Miller * Copyright (c) 2010 Konstantin Belousov * Copyright (c) 2010-2011 Pawel Jakub Dawidek * All rights reserved. Modified: head/sys

svn commit: r246954 - head/sys/sys

2013-02-18 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 18 23:58:05 2013 New Revision: 246954 URL: http://svnweb.freebsd.org/changeset/base/246954 Log: More white-space cleanups. Reported by: zont (the first one) Modified: head/sys/sys/protosw.h Modified: head/sys/sys/protosw.h =

svn commit: r246925 - head/contrib/openbsm/bin/auditdistd

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 18 00:38:40 2013 New Revision: 246925 URL: http://svnweb.freebsd.org/changeset/base/246925 Log: Allow [] in remote address, which fixes IPv6 support. Reported by: simon Modified: head/contrib/openbsm/bin/auditdistd/token.l Modified: head/contrib/openbsm/bin/au

svn commit: r246923 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 21:37:32 2013 New Revision: 246923 URL: http://svnweb.freebsd.org/changeset/base/246923 Log: Update the comment: we do show the backtrace of misbehaving thread. Modified: head/sys/kern/subr_turnstile.c Modified: head/sys/kern/subr_turnstile.c

svn commit: r246922 - head/sbin/hastd

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 21:12:34 2013 New Revision: 246922 URL: http://svnweb.freebsd.org/changeset/base/246922 Log: - Add support for 'memsync' mode. This is the fastest replication mode that's why it will now be the default. - Bump protocol version to 2 and add backward compatibilit

svn commit: r246912 - head/sys/sys

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:58:30 2013 New Revision: 246912 URL: http://svnweb.freebsd.org/changeset/base/246912 Log: Remove space before tab. Modified: head/sys/sys/filedesc.h Modified: head/sys/sys/filedesc.h =

svn commit: r246911 - head/sys/security/audit

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:57:47 2013 New Revision: 246911 URL: http://svnweb.freebsd.org/changeset/base/246911 Log: Remove redundant check. Modified: head/sys/security/audit/audit_bsm.c Modified: head/sys/security/audit/audit_bsm.c ==

svn commit: r246910 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:56:36 2013 New Revision: 246910 URL: http://svnweb.freebsd.org/changeset/base/246910 Log: Style. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c == --- he

svn commit: r246909 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:53:51 2013 New Revision: 246909 URL: http://svnweb.freebsd.org/changeset/base/246909 Log: - Require CAP_FSYNC capability right when opening a file with O_SYNC or O_FSYNC flags. - While here simplify check for locking flags. Sponsored by: The FreeBSD Fo

svn commit: r246908 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:49:21 2013 New Revision: 246908 URL: http://svnweb.freebsd.org/changeset/base/246908 Log: Remove redundant parenthesis. Modified: head/sys/kern/sys_capability.c Modified: head/sys/kern/sys_capability.c ==

svn commit: r246907 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:48:16 2013 New Revision: 246907 URL: http://svnweb.freebsd.org/changeset/base/246907 Log: Remove redundant space. Modified: head/sys/kern/sys_pipe.c Modified: head/sys/kern/sys_pipe.c

svn commit: r246906 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:47:58 2013 New Revision: 246906 URL: http://svnweb.freebsd.org/changeset/base/246906 Log: Add break to the default case. Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c =

svn commit: r246905 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:47:30 2013 New Revision: 246905 URL: http://svnweb.freebsd.org/changeset/base/246905 Log: Don't treat pointers as booleans. Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c ==

svn commit: r246904 - head/sys/kern

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:47:01 2013 New Revision: 246904 URL: http://svnweb.freebsd.org/changeset/base/246904 Log: Remove redundant parenthesis. Modified: head/sys/kern/kern_fork.c Modified: head/sys/kern/kern_fork.c

svn commit: r246903 - head/sys/sys

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:36:41 2013 New Revision: 246903 URL: http://svnweb.freebsd.org/changeset/base/246903 Log: Remove redundant space. Modified: head/sys/sys/namei.h Modified: head/sys/sys/namei.h == --- h

svn commit: r246902 - head/sys/sys

2013-02-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 17 11:36:13 2013 New Revision: 246902 URL: http://svnweb.freebsd.org/changeset/base/246902 Log: Remove trailing spaces. Modified: head/sys/sys/protosw.h Modified: head/sys/sys/protosw.h == -

svn commit: r246884 - in head/lib/libc: gen sys

2013-02-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Feb 16 22:21:46 2013 New Revision: 246884 URL: http://svnweb.freebsd.org/changeset/base/246884 Log: Put one file per line so it is easier to read diffs against those files. Modified: head/lib/libc/gen/Makefile.inc head/lib/libc/sys/Makefile.inc Modified: head/lib/libc

Re: svn commit: r246675 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2013-02-13 Thread Pawel Jakub Dawidek
> +"Allow writing data to degraded vdevs"); BTW. Those two lines fit into 80 chars just fine. > +TUNABLE_INT("vfs.zfs.write_to_degraded", &zfs_write_to_degraded); -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpwpegytG5Ic.pgp Description: PGP signature

svn commit: r246698 - head/sys/bsm

2013-02-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 11 23:14:54 2013 New Revision: 246698 URL: http://svnweb.freebsd.org/changeset/base/246698 Log: Style. Modified: head/sys/bsm/audit_kevents.h Modified: head/sys/bsm/audit_kevents.h == --- he

svn commit: r246691 - head/sys/security/audit

2013-02-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 11 22:54:23 2013 New Revision: 246691 URL: http://svnweb.freebsd.org/changeset/base/246691 Log: Style. Modified: head/sys/security/audit/audit_private.h Modified: head/sys/security/audit/audit_private.h ===

svn commit: r246644 - head/usr.bin/procstat

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Feb 11 00:10:35 2013 New Revision: 246644 URL: http://svnweb.freebsd.org/changeset/base/246644 Log: Capability rights for process management via process descriptors do exist already, so uncomment them. Sponsored by: The FreeBSD Foundation Modified: head/usr.bin/pr

svn commit: r246643 - head/usr.bin/procstat

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 23:51:26 2013 New Revision: 246643 URL: http://svnweb.freebsd.org/changeset/base/246643 Log: Add CAP_MKNOD right. Sponsored by: The FreeBSD Foundation Modified: head/usr.bin/procstat/procstat_files.c Modified: head/usr.bin/procstat/procstat_files.c =

svn commit: r246622 - head/sbin/geom/class/eli

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 15:56:47 2013 New Revision: 246622 URL: http://svnweb.freebsd.org/changeset/base/246622 Log: Fix minor memory leak. Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c ===

svn commit: r246621 - head/sbin/geom/class/eli

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 15:56:20 2013 New Revision: 246621 URL: http://svnweb.freebsd.org/changeset/base/246621 Log: Assert that if we are not dealing with keyfile we are dealing with passfile. Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c =

svn commit: r246620 - head/sbin/geom/class/eli

2013-02-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Feb 10 15:55:42 2013 New Revision: 246620 URL: http://svnweb.freebsd.org/changeset/base/246620 Log: Use arc4random_buf(3) instead of reimplementing it. Modified: head/sbin/geom/class/eli/geom_eli.c Modified: head/sbin/geom/class/eli/geom_eli.c ==

svn commit: r246448 - head/sys/kern

2013-02-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 7 00:36:00 2013 New Revision: 246448 URL: http://svnweb.freebsd.org/changeset/base/246448 Log: Audit sockaddr argument for bind(2), connect(2), accept(2), sendto(2) and recvfrom(2) syscalls. Sponsored by: The FreeBSD Foundation Modified: head/sys/kern/uipc_sy

svn commit: r246447 - head/sys/kern

2013-02-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 7 00:27:11 2013 New Revision: 246447 URL: http://svnweb.freebsd.org/changeset/base/246447 Log: Minor style tweaks. Modified: head/sys/kern/uipc_syscalls.c Modified: head/sys/kern/uipc_syscalls.c ==

svn commit: r246446 - head/sys/security/audit

2013-02-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Feb 7 00:24:23 2013 New Revision: 246446 URL: http://svnweb.freebsd.org/changeset/base/246446 Log: Add AUDIT_ARG_SOCKADDR() macro so we can start using the audit_arg_sockaddr() function, which is currently unused. Sponsored by: The FreeBSD Foundation Modified: he

svn commit: r246177 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:20:05 2013 New Revision: 246177 URL: http://svnweb.freebsd.org/changeset/base/246177 Log: Now that MPSAFE flag is gone, we can arrange code a bit better. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c

svn commit: r246172 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:15:41 2013 New Revision: 246172 URL: http://svnweb.freebsd.org/changeset/base/246172 Log: Remove leftover label after Giant removal from VFS. Modified: head/sys/kern/vfs_syscalls.c Modified: head/sys/kern/vfs_syscalls.c

svn commit: r246171 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:14:16 2013 New Revision: 246171 URL: http://svnweb.freebsd.org/changeset/base/246171 Log: Remove label that was accidentally moved during Giant removal from VFS. Modified: head/sys/kern/kern_descrip.c Modified: head/sys/kern/kern_descrip.c

svn commit: r246169 - head/sys/kern

2013-01-31 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 31 22:12:48 2013 New Revision: 246169 URL: http://svnweb.freebsd.org/changeset/base/246169 Log: Simplify code a bit. This is leftover after Giant removal from VFS. Modified: head/sys/kern/vfs_vnops.c Modified: head/sys/kern/vfs_vnops.c ==

Re: svn commit: r245751 - head/tools

2013-01-22 Thread Pawel Jakub Dawidek
On Tue, Jan 22, 2013 at 07:00:05PM +0100, Pawel Jakub Dawidek wrote: > On Mon, Jan 21, 2013 at 10:32:00PM +, Brooks Davis wrote: > > Author: brooks > > Date: Mon Jan 21 22:32:00 2013 > > New Revision: 245751 > > URL: http://svnweb.freebsd.org/changeset/base/245751 &g

Re: svn commit: r245751 - head/tools

2013-01-22 Thread Pawel Jakub Dawidek
t; > Ignore the new options -D, -h, -T, and -U. Adjust -M support to ignore > an argument. I was doing installworld today and it failed on 'install -l ...' saying '/sys/sys' is not empty. When I removed /sys symlink it installed ok. Was this because of your change?

svn commit: r245750 - head/lib/libc/sys

2013-01-21 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Jan 21 22:07:34 2013 New Revision: 245750 URL: http://svnweb.freebsd.org/changeset/base/245750 Log: Note that SIGCHLD is special and if ignored, won't be recorded by the filter. Modified: head/lib/libc/sys/kqueue.2 Modified: head/lib/libc/sys/kqueue.2 ==

Re: svn commit: r245696 - head/usr.sbin/inetd

2013-01-21 Thread Pawel Jakub Dawidek
On Mon, Jan 21, 2013 at 12:54:31PM +0400, Andrey Zonov wrote: > On 1/21/13 12:49 PM, Pawel Jakub Dawidek wrote: > > On Sun, Jan 20, 2013 at 07:44:34PM +, Andrey Zonov wrote: > >> Author: zont > >> Date: Sun Jan 20 19:44:33 2013 > >> New Revision: 245696

Re: svn commit: r245696 - head/usr.sbin/inetd

2013-01-21 Thread Pawel Jakub Dawidek
96) > @@ -1387,7 +1387,7 @@ setsockopt(fd, SOL_SOCKET, opt, (char *) > } > } > if (sep->se_socktype == SOCK_STREAM) > - listen(sep->se_fd, 64); > + listen(sep->se_fd, -1); > enable(sep); > if (debug)

Re: svn commit: r245506 - head/bin/pwait

2013-01-17 Thread Pawel Jakub Dawidek
for errno. For me those values represent sets of failure cases rather than allow to distinguish between every possible failure case. It would probably be the best to define exit codes for every application separately, but maybe selection of exit codes provided by sysexits(3) is good enough

Re: svn commit: r244585 - in head: . sys/geom/label

2013-01-05 Thread Pawel Jakub Dawidek
chronization issues in glabel updating in response to > changes in gpart, is why the installer doesn't use labels in fstab. I fully agree that gpart should manage GEOM providers based on labels on its own, especially that it doesn't update label by writing to underlying provider

svn commit: r244857 - head/cddl/contrib/opensolaris/cmd/zpool

2012-12-30 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 30 13:47:40 2012 New Revision: 244857 URL: http://svnweb.freebsd.org/changeset/base/244857 Log: Allow to create pool even if mount point directory is not empty if -f is given. Obtained from:WHEEL Systems Modified: head/cddl/contrib/opensolaris/cmd/zpool

Re: svn commit: r244663 - stable/9

2012-12-30 Thread Pawel Jakub Dawidek
file to just build kernel modules to verify they at least compile. This would help catch problems like the recent one with VM KPI change and VirtualBox modules easier. As for the KBI, maybe installkernel could verify that modules in ${DESTDIR}/boot/modules/ are compiled for the same __Fre

Re: svn commit: r244752 - head/sys/net

2012-12-27 Thread Pawel Jakub Dawidek
fc1918, 0, "Permit the use of private IPv4 addresses"); > > #define STFUNIT 0 -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgphNBzU2HcBk.pgp Description: PGP signature

Re: svn commit: r244747 - head/lib/libutil

2012-12-27 Thread Pawel Jakub Dawidek
= dst; dst = stpcpy(dst, gr->gr_mem[ndx]) + 1; } newgr->gr_mem[ndx] = NULL; } -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am!

Re: svn commit: r244682 - head/bin/sh

2012-12-26 Thread Pawel Jakub Dawidek
igname. Yes, that would be very handy. BTW. > + sigstr = strsignal(i); > + if (sigstr != NULL) > + strcpy(statestr, sigstr); > else > strcpy(statestr, "Suspended"); When strsignal(3)

svn commit: r244716 - head/sys/geom

2012-12-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 26 20:07:47 2012 New Revision: 244716 URL: http://svnweb.freebsd.org/changeset/base/244716 Log: Reset provider-specific fields when resending I/O request in low memory conditions. This fixes assertion which checks those fields when kernel is compiled with DIAGNOSTIC

Re: svn commit: r244608 - head/usr.sbin/pkg

2012-12-23 Thread Pawel Jakub Dawidek
if ( argv[1] != NULL && strcmp(argv[1], "-N") == 0) > + errx(EXIT_FAILURE, "pkg is not installed\n"); How about removing space after 'if (' and redundant '\n'? -- Pawel Jakub Dawidek http

Re: svn commit: r244198 - in head: etc/rc.d sbin/sysctl

2012-12-21 Thread Pawel Jakub Dawidek
e, O_RDONLY); You override 'fd'. After first file read it will stop working. > + if (fd < 0 || fstat(fd, &sb) != 0) { > + warn("%s", de->d_name); If 'fd' is >= 0 you should close it. > + continue; > + } else if (!S_ISREG(sb.st_mode)) > + continue; You are leaking it here as well. > + warncount += parsefile(fd); > + close(fd); [...] > - fclose(file); Removing fclose() is wrong. Once you do fdopen(3) you should use fclose(), instead you removed fclose(3) and you close(2) after parsefile() returned. You leak FILE structure this way. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpx0ttpn6kwi.pgp Description: PGP signature

svn commit: r244452 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 23:59:48 2012 New Revision: 244452 URL: http://svnweb.freebsd.org/changeset/base/244452 Log: Replace expand_name() function with corefile_open() function, which not only returns name, but also vnode of corefile to use. This simplifies the code and closes few r

svn commit: r244451 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 23:40:02 2012 New Revision: 244451 URL: http://svnweb.freebsd.org/changeset/base/244451 Log: Use correct file permissions when looking for available core file if kern.corefile contains %I. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig

svn commit: r244429 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:14:08 2012 New Revision: 244429 URL: http://svnweb.freebsd.org/changeset/base/244429 Log: The 'flags' argument can be modified in vn_open_cred(), so we need to set it for every loop interation. Pointed out by: kib Modified: head/sys/kern/kern_sig.c

svn commit: r244428 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:12:53 2012 New Revision: 244428 URL: http://svnweb.freebsd.org/changeset/base/244428 Log: Do not audit paths we try when kern.corefile contains %I. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c =

svn commit: r244426 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:10:14 2012 New Revision: 244426 URL: http://svnweb.freebsd.org/changeset/base/244426 Log: Style cleanups. Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c == --- h

svn commit: r244424 - head/sys/kern

2012-12-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 19 12:00:09 2012 New Revision: 244424 URL: http://svnweb.freebsd.org/changeset/base/244424 Log: The expand_name() function isn't called with the process lock held anymore, so we can safely use malloc(M_WAITOK) now. Pointed out by: kib Modified: head/sys/

Re: svn commit: r244154 - head/bin/ps

2012-12-17 Thread Pawel Jakub Dawidek
On Sat, Dec 15, 2012 at 03:13:00AM +0200, Konstantin Belousov wrote: > On Fri, Dec 14, 2012 at 10:42:47PM +0100, Pawel Jakub Dawidek wrote: > > In that case I'd prefer to make existing kern.pid_max sysctl read-only > > and make it loader tunable. I don't expect the

svn commit: r244352 - head/sys/kern

2012-12-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Dec 17 10:51:22 2012 New Revision: 244352 URL: http://svnweb.freebsd.org/changeset/base/244352 Log: Minor style tweaks. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c ===

svn commit: r244351 - head/sys/kern

2012-12-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Dec 17 10:48:10 2012 New Revision: 244351 URL: http://svnweb.freebsd.org/changeset/base/244351 Log: Better variables naming in expand_name() to be more consistent with coredump(). Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: hea

svn commit: r244347 - head/sys/netpfil/pf

2012-12-17 Thread Pawel Jakub Dawidek
Author: pjd Date: Mon Dec 17 10:10:13 2012 New Revision: 244347 URL: http://svnweb.freebsd.org/changeset/base/244347 Log: Warn about reaching various PF limits. Reviewed by: glebius Obtained from:WHEEL Systems Modified: head/sys/netpfil/pf/pf.c head/sys/netpfil/pf/pf_norm.c

svn commit: r244324 - in stable/9/sys: kern security/audit

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:41:34 2012 New Revision: 244324 URL: http://svnweb.freebsd.org/changeset/base/244324 Log: MFC r243719,r243720,r243722,r243723,r243726,r243727,r243746: r243719: IFp4 @208450: Remove redundant call to AUDIT_ARG_UPATH1(). Path will be remembered by t

svn commit: r244323 - in head: . etc/defaults

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:29:56 2012 New Revision: 244323 URL: http://svnweb.freebsd.org/changeset/base/244323 Log: Use new savecore(8) option and limit number of kernel dumps that will be kept around to the 10 most recent ones. Add UPDATING entry with info how to return to the prev

svn commit: r244321 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:09:27 2012 New Revision: 244321 URL: http://svnweb.freebsd.org/changeset/base/244321 Log: With rotating kernel dumps the higest dump number is not necessarily the last one. To make it easier to find the last one create symlinks with 'last' suffix that will poi

svn commit: r244320 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:06:12 2012 New Revision: 244320 URL: http://svnweb.freebsd.org/changeset/base/244320 Log: Implement -m option to savecore(8) that allows to limit number of kernel dumps stored. Once the limit is reached it restarts from 0. Reviewed by: avg Obtained from:

svn commit: r244319 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 23:04:31 2012 New Revision: 244319 URL: http://svnweb.freebsd.org/changeset/base/244319 Log: Make use of the fact that we changed working directory to the dump directory earlier. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c M

svn commit: r244317 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 22:59:58 2012 New Revision: 244317 URL: http://svnweb.freebsd.org/changeset/base/244317 Log: Sort flags properly. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c

svn commit: r244316 - head/sbin/savecore

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 22:59:25 2012 New Revision: 244316 URL: http://svnweb.freebsd.org/changeset/base/244316 Log: Prefer snprintf() over sprintf(). Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c ===

svn commit: r244296 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:53:27 2012 New Revision: 244296 URL: http://svnweb.freebsd.org/changeset/base/244296 Log: Move expand_name() after process lock is released. This fixed panic where we hold mutex (process lock) and try to obtain sleepable lock (vnode lock in expand_name()).

svn commit: r244294 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:24:59 2012 New Revision: 244294 URL: http://svnweb.freebsd.org/changeset/base/244294 Log: Don't add audit record when coredumps are disabled or name cannot be expanded. Discussed with: rwatson Obtained from:WHEEL Systems Modified: head/sys/

svn commit: r244293 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 14:14:18 2012 New Revision: 244293 URL: http://svnweb.freebsd.org/changeset/base/244293 Log: Make the check easier to read. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c

svn commit: r244288 - head/sys/kern

2012-12-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 16 13:56:38 2012 New Revision: 244288 URL: http://svnweb.freebsd.org/changeset/base/244288 Log: Use 'cred' variable. Obtained from:WHEEL Systems Modified: head/sys/kern/kern_sig.c Modified: head/sys/kern/kern_sig.c ==

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
t use it myself. When you are > > dumping your kernel is in undefined state, so the less code you execute > > in that state the higher chances your dump will succeed. I much prefer > > to either compress the dumps with savecore(8) or use ZFS dataset with > > compr

svn commit: r244280 - head/sys/dev/wbwd

2012-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 15 22:26:16 2012 New Revision: 244280 URL: http://svnweb.freebsd.org/changeset/base/244280 Log: sbuf_trim() cannot be used on sbuf with drain function set. This fixes panic when listing sysctls on INVARIANTS-enabled kernel while having wbwd loaded. This panic w

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
that state the higher chances your dump will succeed. I much prefer to either compress the dumps with savecore(8) or use ZFS dataset with compression enabled for /var/crash/. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer htt

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
it as quickly as possible. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpSQNTGWj3gR.pgp Description: PGP signature

Re: svn commit: r244112 - head/sys/kern

2012-12-15 Thread Pawel Jakub Dawidek
k of a way to limit number of kernel dumps, which could lead to filling /var/ after hitting some panic/reboot cycle. My contribution to solve this is implementation of 3: http://people.freebsd.org/~pjd/patches/savecore.patch The first two should be easy to do. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpPFtlMMeIJB.pgp Description: PGP signature

Re: svn commit: r244188 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2012-12-14 Thread Pawel Jakub Dawidek
de > > +static boolean_t vdev_trim_on_init = B_TRUE; > +SYSCTL_DECL(_vfs_zfs_vdev); > +SYSCTL_INT(_vfs_zfs_vdev, OID_AUTO, trim_on_init, CTLFLAG_RW, > +&vdev_trim_on_init, 0, "Enable/disable full vdev trim on > initialisation"); I'd

Re: svn commit: r244154 - head/bin/ps

2012-12-14 Thread Pawel Jakub Dawidek
On Fri, Dec 14, 2012 at 11:52:15AM -0500, John Baldwin wrote: > On Thursday, December 13, 2012 6:12:44 am Pawel Jakub Dawidek wrote: > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > > On Wed, Dec 12, 2012 at 03:45:04PM +, Pawel Jakub Dawidek wro

svn commit: r244218 - in head: etc/rc.d sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:12:08 2012 New Revision: 244218 URL: http://svnweb.freebsd.org/changeset/base/244218 Log: - When checking if a dump exists on the given device there is no need to provide dump directory. Eliminate this redundant argument. This changes the usage, but the on

svn commit: r244217 - head/sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:04:39 2012 New Revision: 244217 URL: http://svnweb.freebsd.org/changeset/base/244217 Log: The clear option (-c) is not compatible with keep (-k) and compress (-z) options. Obtained from:WHEEL Systems Modified: head/sbin/savecore/savecore.c Modif

svn commit: r244216 - head/sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:03:12 2012 New Revision: 244216 URL: http://svnweb.freebsd.org/changeset/base/244216 Log: If we are not going to clear the dump (we are either just checking if the dump exists or we want to keep it), open device read-only. Obtained from:WHEEL System

svn commit: r244215 - head/sbin/savecore

2012-12-14 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 14 15:01:23 2012 New Revision: 244215 URL: http://svnweb.freebsd.org/changeset/base/244215 Log: Whitespace cleanups. Modified: head/sbin/savecore/savecore.c Modified: head/sbin/savecore/savecore.c =

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Thu, Dec 13, 2012 at 08:16:21PM +0200, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 05:55:41PM +0100, Pawel Jakub Dawidek wrote: > > On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: > > > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Thu, Dec 13, 2012 at 06:12:42PM +0200, Konstantin Belousov wrote: > On Thu, Dec 13, 2012 at 12:12:44PM +0100, Pawel Jakub Dawidek wrote: > > On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > > I saw CTLFLAG_TUN on the sysctl and assumed it is read-only..

Re: svn commit: r244154 - head/bin/ps

2012-12-13 Thread Pawel Jakub Dawidek
On Wed, Dec 12, 2012 at 11:06:52PM +0200, Konstantin Belousov wrote: > On Wed, Dec 12, 2012 at 03:45:04PM +0000, Pawel Jakub Dawidek wrote: > > Author: pjd > > Date: Wed Dec 12 15:45:03 2012 > > New Revision: 244154 > > URL: http://svnweb.freebsd.org/changeset/base/244

svn commit: r244181 - head/etc/rc.d

2012-12-13 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 13 09:41:32 2012 New Revision: 244181 URL: http://svnweb.freebsd.org/changeset/base/244181 Log: Fix the location of auditdistd configuration file. Reported by: Johan Hendriks Modified: head/etc/rc.d/auditdistd Modified: head/etc/rc.d/auditdistd ==

Re: svn commit: r244154 - head/bin/ps

2012-12-12 Thread Pawel Jakub Dawidek
On Wed, Dec 12, 2012 at 11:37:00AM -0500, Eitan Adler wrote: > On 12 December 2012 10:45, Pawel Jakub Dawidek wrote: > > > + if (sysctlbyname("kern.pid_max", &pid_max, &intsize, NULL, 0) < 0) { > > + warn("unable to read kern.pid

svn commit: r244154 - head/bin/ps

2012-12-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 12 15:45:03 2012 New Revision: 244154 URL: http://svnweb.freebsd.org/changeset/base/244154 Log: Use kern.max_pid sysctl to obtain maximum PID number instead of using local define. Reviewed by: jhb Modified: head/bin/ps/ps.c Modified: head/bin/ps/ps.c ===

svn commit: r244153 - head/lib/libc/gen

2012-12-12 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Dec 12 15:27:33 2012 New Revision: 244153 URL: http://svnweb.freebsd.org/changeset/base/244153 Log: Eliminate redundant variable. Modified: head/lib/libc/gen/sysctlbyname.c Modified: head/lib/libc/gen/sysctlbyname.c ==

Re: svn commit: r244106 - head/sbin/sysctl

2012-12-11 Thread Pawel Jakub Dawidek
hat the given sysctl can be changed via loader tunable on boot only (or on module load via kenv(1)). Your change makes it useful to also mark read-write sysctls as tunables and I suspect there is huge number of such sysctls that have no CTLFLAG_TUN flag. -- Pawel Jakub Dawidek

svn commit: r244123 - head/sys/sys

2012-12-11 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Dec 11 19:54:35 2012 New Revision: 244123 URL: http://svnweb.freebsd.org/changeset/base/244123 Log: Similar to CTLFLAG_RDTUN, provide CTLFLAG_RWTUN that defines writable sysctl that can also be modified by loader tunable. Modified: head/sys/sys/sysctl.h Modified: head

svn commit: r244031 - head/sys/netinet

2012-12-08 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 8 12:51:06 2012 New Revision: 244031 URL: http://svnweb.freebsd.org/changeset/base/244031 Log: More warnings for zones that depend on the kern.ipc.maxsockets limit. Obtained from:WHEEL Systems Modified: head/sys/netinet/in_pcb.c head/sys/netinet/tcp_s

Re: svn commit: r243999 - head/sys/kern

2012-12-08 Thread Pawel Jakub Dawidek
On Sat, Dec 08, 2012 at 02:24:03PM +1100, Bruce Evans wrote: > On Fri, 7 Dec 2012, Pawel Jakub Dawidek wrote: > > > Log: > > Configure UMA warnings for the following zones: > > - unp_zone: kern.ipc.maxsockets limit reached > > - socket_zone: kern.ipc.maxsockets

Re: svn commit: r243994 - head/sys/kern

2012-12-08 Thread Pawel Jakub Dawidek
On Fri, Dec 07, 2012 at 08:19:03PM -0800, Neel Natu wrote: > Hi Pawel, > > On Fri, Dec 7, 2012 at 2:15 PM, Pawel Jakub Dawidek wrote: > > Author: pjd > > Date: Fri Dec 7 22:15:51 2012 > > New Revision: 243994 > > URL: http://svnweb.freebsd.org/changeset/base

svn commit: r244024 - head/sys/vm

2012-12-08 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 8 09:23:05 2012 New Revision: 244024 URL: http://svnweb.freebsd.org/changeset/base/244024 Log: White-space cleanups. Modified: head/sys/vm/uma.h Modified: head/sys/vm/uma.h == --- head/sys/

Re: svn commit: r244022 - head/sys/sys

2012-12-08 Thread Pawel Jakub Dawidek
On Sat, Dec 08, 2012 at 08:35:50AM +, Pawel Jakub Dawidek wrote: > Author: pjd > Date: Sat Dec 8 08:35:49 2012 > New Revision: 244022 > URL: http://svnweb.freebsd.org/changeset/base/244022 > > Log: > The socket_zone UMA zone is now private to uipc_socket.c. My local b

svn commit: r244022 - head/sys/sys

2012-12-08 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 8 08:35:49 2012 New Revision: 244022 URL: http://svnweb.freebsd.org/changeset/base/244022 Log: The socket_zone UMA zone is now private to uipc_socket.c. Modified: head/sys/sys/socketvar.h Modified: head/sys/sys/socketvar.h ==

svn commit: r243999 - head/sys/kern

2012-12-07 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 7 22:30:30 2012 New Revision: 243999 URL: http://svnweb.freebsd.org/changeset/base/243999 Log: Configure UMA warnings for the following zones: - unp_zone: kern.ipc.maxsockets limit reached - socket_zone: kern.ipc.maxsockets limit reached - zone_mbuf: kern.ipc.nmb

<    1   2   3   4   5   6   7   8   9   10   >