Re: svn commit: r230869 - head/usr.sbin/daemon

2012-02-06 Thread Pawel Jakub Dawidek
On Mon, Feb 06, 2012 at 11:46:24PM +0200, Mikolaj Golub wrote: On Mon, 6 Feb 2012 09:27:06 +0100 Pawel Jakub Dawidek wrote: PJD For the patch itself. PJD You don't have to have two separate cases depending on request for PJD pidfile. You can specify NULL pfh to the pidfile functions

Re: svn commit: r230869 - head/usr.sbin/daemon

2012-02-05 Thread Pawel Jakub Dawidek
Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpVVADgPlh78.pgp Description: PGP signature

Re: svn commit: r230869 - head/usr.sbin/daemon

2012-02-05 Thread Pawel Jakub Dawidek
On Sat, Feb 04, 2012 at 10:32:56AM -0600, Guy Helmer wrote: On Feb 4, 2012, at 1:42 AM, Pawel Jakub Dawidek wrote: On Wed, Feb 01, 2012 at 04:41:00PM +, Guy Helmer wrote: Author: ghelmer Date: Wed Feb 1 16:40:59 2012 New Revision: 230869 URL: http://svn.freebsd.org/changeset

Re: svn commit: r230869 - head/usr.sbin/daemon

2012-02-05 Thread Pawel Jakub Dawidek
On Sun, Feb 05, 2012 at 04:46:53AM -0800, Doug Barton wrote: On 02/05/2012 01:59, Pawel Jakub Dawidek wrote: I seem to miss positives of the other approach. Leaving stale PIDs in pidfile is something we should avoid at all costs, so recommending that in the manual page is not the best

Re: svn commit: r230869 - head/usr.sbin/daemon

2012-02-05 Thread Pawel Jakub Dawidek
fork(2) and pidfile_write(3). This way pidfiles will always be created with root privileges and we can forget about all the mess with pid directories, etc. - With the above you can wait for child to exit with simple wait(2). -- Pawel Jakub Dawidek http

svn commit: r230996 - head/sys/conf

2012-02-04 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Feb 4 20:17:07 2012 New Revision: 230996 URL: http://svn.freebsd.org/changeset/base/230996 Log: After multiple requests for back out, after multiple promisses from adrian@ to fix it (without fixing it), after making one of my servers unbootable, after now making also

Re: svn commit: r230869 - head/usr.sbin/daemon

2012-02-03 Thread Pawel Jakub Dawidek
directory. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpGHuoFBMHb2.pgp Description: PGP signature

svn commit: r230976 - head/sbin/hastd

2012-02-03 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Feb 4 07:59:12 2012 New Revision: 230976 URL: http://svn.freebsd.org/changeset/base/230976 Log: Fix typo in comment. MFC after:3 days Modified: head/sbin/hastd/parse.y Modified: head/sbin/hastd/parse.y

Re: svn commit: r230623 - in head/sys: amd64/amd64 cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs sys vm

2012-01-28 Thread Pawel Jakub Dawidek
including UMA now entails the addition of a single flag to kmem_alloc or uma zone create M_NODUMP and UMA_ZONE_NODUMP are very useful, not only for ZFS. I'll look into using it for GELI memory used to store keys. Could you please document those flags in malloc(9) and uma(9)? -- Pawel Jakub Dawidek

Re: svn commit: r230623 - in head/sys: amd64/amd64 cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs sys vm

2012-01-28 Thread Pawel Jakub Dawidek
that will prevent dumping the memory and that will clear memory on free. How hard would that be? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl

Re: svn commit: r230623 - in head/sys: amd64/amd64 cddl/compat/opensolaris/sys cddl/contrib/opensolaris/uts/common/fs/zfs sys vm

2012-01-28 Thread Pawel Jakub Dawidek
On Sat, Jan 28, 2012 at 01:36:05PM +0100, K Macy wrote: Il giorno 28/gen/2012, alle ore 09:39, Pawel Jakub Dawidek p...@freebsd.org ha scritto: How do you handle the case when there are two small allocations within one page, where one has the NODUMP flag and one doesn't have the flag

svn commit: r230515 - head/sbin/hastd

2012-01-24 Thread Pawel Jakub Dawidek
(r230514) +++ head/sbin/hastd/hast.conf.5 Tue Jan 24 23:43:13 2012(r230515) @@ -1,8 +1,8 @@ .\ Copyright (c) 2010 The FreeBSD Foundation -.\ Copyright (c) 2010-2011 Pawel Jakub Dawidek pa...@dawidek.net +.\ Copyright (c) 2010-2012 Pawel Jakub Dawidek pa...@dawidek.net .\ All rights

svn commit: r230454 - head/sys/cddl/compat/opensolaris/sys

2012-01-22 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Jan 22 10:58:17 2012 New Revision: 230454 URL: http://svn.freebsd.org/changeset/base/230454 Log: Use provided name when allocating ksid domain. It isn't really used on FreeBSD, but should fix a panic when pool is imported from another OS that is using this. MFC

svn commit: r230455 - in head/sys: arm/arm kern

2012-01-22 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Jan 22 11:01:36 2012 New Revision: 230455 URL: http://svn.freebsd.org/changeset/base/230455 Log: TDF_* flags should be used with td_flags field and TDP_* flags should be used with td_pflags field. Correct two places where it was not the case. Discussed with:

svn commit: r230456 - head/lib/libc/sys

2012-01-22 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Jan 22 11:15:48 2012 New Revision: 230456 URL: http://svn.freebsd.org/changeset/base/230456 Log: The sys/uio.h header is needed only for readv(2), preadv(2), writev(2) and pwritev(2). Document it more precisely. Reviewed by: jilles MFC after:3 days Modified:

svn commit: r230457 - head/sbin/hastd

2012-01-22 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Jan 22 11:20:42 2012 New Revision: 230457 URL: http://svn.freebsd.org/changeset/base/230457 Log: Free memory that won't be used in child. MFC after:1 week Modified: head/sbin/hastd/hastd.c Modified: head/sbin/hastd/hastd.c

Re: svn commit: r230307 - in head: lib/libfetch usr.bin/fetch

2012-01-21 Thread Pawel Jakub Dawidek
; + buf+= total; Style nit (missing space before +=). -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl pgpgLDJI2Gt0M.pgp Description

Re: svn commit: r229800 - head/sys/conf

2012-01-21 Thread Pawel Jakub Dawidek
On Sun, Jan 08, 2012 at 02:58:56PM -0800, Adrian Chadd wrote: On 8 January 2012 02:43, Pawel Jakub Dawidek p...@freebsd.org wrote: If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS

svn commit: r230436 - head/sbin/hastd

2012-01-21 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Jan 21 20:13:37 2012 New Revision: 230436 URL: http://svn.freebsd.org/changeset/base/230436 Log: Fix minor memory leak. MFC after:3 days Modified: head/sbin/hastd/parse.y Modified: head/sbin/hastd/parse.y

svn commit: r230438 - in head: cddl/contrib/opensolaris/cmd/zfs cddl/contrib/opensolaris/lib/libzfs/common sys/cddl/contrib/opensolaris/uts/common/fs/zfs sys/cddl/contrib/opensolaris/uts/common/fs/...

2012-01-21 Thread Pawel Jakub Dawidek
@@ */ /* * Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2012 Pawel Jakub Dawidek pa...@dawidek.net. + * All rights reserved. */ #include libintl.h @@ -129,8 +131,11 @@ zfs_callback(zfs_handle_t *zhp, void *da cb-cb_depth

svn commit: r230395 - head/sbin/hastd

2012-01-20 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 20 21:45:24 2012 New Revision: 230395 URL: http://svn.freebsd.org/changeset/base/230395 Log: Remove unused token 'port'. MFC after:3 days Modified: head/sbin/hastd/parse.y head/sbin/hastd/token.l Modified: head/sbin/hastd/parse.y

svn commit: r230396 - head/sbin/hastd

2012-01-20 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 20 21:49:56 2012 New Revision: 230396 URL: http://svn.freebsd.org/changeset/base/230396 Log: Remove another unused token. MFC after:3 days Modified: head/sbin/hastd/parse.y Modified: head/sbin/hastd/parse.y

svn commit: r230397 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2012-01-20 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 20 22:04:59 2012 New Revision: 230397 URL: http://svn.freebsd.org/changeset/base/230397 Log: By default turn off prefetch when listing snapshots. In my tests it makes listing snapshots 19% faster with cold cache and 47% faster with warm cache. MFC after:1

Re: svn commit: r230037 - head/lib/libutil

2012-01-16 Thread Pawel Jakub Dawidek
, int _some_other_argument); when line exceeds 80 chars. Especially this one looks very strange: properties properties_read(int _fd); -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I

Re: svn commit: r230037 - head/lib/libutil

2012-01-14 Thread Pawel Jakub Dawidek
are harder to read). I'd prefer not to change that. All those functions are part of pidfile(3) API and it would be better, IMHO, to keep them together here too. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am

svn commit: r230092 - head/sbin/hastd

2012-01-13 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 13 23:25:35 2012 New Revision: 230092 URL: http://svn.freebsd.org/changeset/base/230092 Log: Style cleanups. MFC after:3 days Modified: head/sbin/hastd/secondary.c Modified: head/sbin/hastd/secondary.c

Re: svn commit: r229966 - head/lib/libutil

2012-01-11 Thread Pawel Jakub Dawidek
* to the proper descriptor. */ -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpW6Entf9saW.pgp Description: PGP signature

Re: svn commit: r229908 - head/usr.bin/brandelf

2012-01-10 Thread Pawel Jakub Dawidek
) -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgp627O20skxd.pgp Description: PGP signature

Re: svn commit: r229936 - head/lib/libutil

2012-01-10 Thread Pawel Jakub Dawidek
); + } + /* * Remember file information, so in pidfile_write() we are sure we write * to the proper descriptor. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am

Re: svn commit: r229937 - in head/lib: libc/gen libutil

2012-01-10 Thread Pawel Jakub Dawidek
); +} BTW. If you are working on pidfile, it would be nice to move pidfile structure declaration into pidfile.c. There is no need to expose it. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am

Re: svn commit: r229937 - in head/lib: libc/gen libutil

2012-01-10 Thread Pawel Jakub Dawidek
On Tue, Jan 10, 2012 at 03:52:35PM -0600, Guy Helmer wrote: On Jan 10, 2012, at 3:42 PM, Pawel Jakub Dawidek wrote: On Tue, Jan 10, 2012 at 07:53:25PM +, Guy Helmer wrote: Author: ghelmer Date: Tue Jan 10 19:53:25 2012 New Revision: 229937 URL: http://svn.freebsd.org/changeset

Re: svn commit: r229937 - in head/lib: libc/gen libutil

2012-01-10 Thread Pawel Jakub Dawidek
pidfile_fileno(struct pidfh *pfh); #endif #ifdef _UFS_UFS_QUOTA_H_ One more thing. You also need to add link in Makefile, so that 'man pidfile_fileno' will work. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am

svn commit: r229944 - head/sbin/hastd

2012-01-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Jan 10 22:24:57 2012 New Revision: 229944 URL: http://svn.freebsd.org/changeset/base/229944 Log: Don't touch pidfiles when running in foreground. Before that change we would create an empty pidfile on start and check if it changed on SIGHUP. MFC after:3 days

svn commit: r229945 - in head/sbin: hastctl hastd

2012-01-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Jan 10 22:39:07 2012 New Revision: 229945 URL: http://svn.freebsd.org/changeset/base/229945 Log: For functions that return -1 on failure check exactly for -1 and not for any negative number. MFC after:3 days Modified: head/sbin/hastctl/hastctl.c

svn commit: r229946 - head/sbin/hastd

2012-01-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Jan 10 22:41:09 2012 New Revision: 229946 URL: http://svn.freebsd.org/changeset/base/229946 Log: - Fix a bug where pidfile was removed in SIGHUP when it hasn't changed in configuration file. - Log the fact that pidfile has changed. MFC after:3 days

svn commit: r229951 - head/lib/libutil

2012-01-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Jan 11 00:31:04 2012 New Revision: 229951 URL: http://svn.freebsd.org/changeset/base/229951 Log: Constify arguments. Modified: head/lib/libutil/libutil.h head/lib/libutil/pidfile.c Modified: head/lib/libutil/libutil.h

Re: svn commit: r229800 - head/sys/conf

2012-01-09 Thread Pawel Jakub Dawidek
On Mon, Jan 09, 2012 at 08:15:44AM -0500, John Baldwin wrote: On Sunday, January 08, 2012 5:43:30 am Pawel Jakub Dawidek wrote: On Sun, Jan 08, 2012 at 12:55:22AM +, Adrian Chadd wrote: Author: adrian Date: Sun Jan 8 00:55:22 2012 New Revision: 229800 URL: http

Re: svn commit: r229800 - head/sys/conf

2012-01-08 Thread Pawel Jakub Dawidek
image) just enough to actually fit. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpUARkgwvlkF.pgp Description: PGP signature

Re: svn commit: r229800 - head/sys/conf

2012-01-08 Thread Pawel Jakub Dawidek
On Sun, Jan 08, 2012 at 02:58:56PM -0800, Adrian Chadd wrote: On 8 January 2012 02:43, Pawel Jakub Dawidek p...@freebsd.org wrote: If someone is actually using GENERIC kernel. This change will break all my system next time I upgrade. Adding UFS_ACL option to the kernel config to make ZFS

Re: svn commit: r229466 - head/usr.sbin/mptable

2012-01-07 Thread Pawel Jakub Dawidek
with process' umask. Most of the time umask is 022, so result file permission will be 0644. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com

svn commit: r229699 - head/sbin/hastd

2012-01-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 6 12:27:17 2012 New Revision: 229699 URL: http://svn.freebsd.org/changeset/base/229699 Log: Constify argument. MFC after:3 days Modified: head/sbin/hastd/subr.c head/sbin/hastd/subr.h Modified: head/sbin/hastd/subr.c

svn commit: r229701 - head/etc/rc.d

2012-01-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 6 14:00:31 2012 New Revision: 229701 URL: http://svn.freebsd.org/changeset/base/229701 Log: Add 'nojail' keyword as auditd(8) can't really do anything useful when inside a jail. Discussed with: rwatson MFC after:1 week Modified:

svn commit: r229744 - head/sbin/hastd

2012-01-06 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Jan 6 23:44:26 2012 New Revision: 229744 URL: http://svn.freebsd.org/changeset/base/229744 Log: fork(2) returns -1 on failure, not some random negative number. MFC after:3 days Modified: head/sbin/hastd/primary.c head/sbin/hastd/secondary.c Modified:

svn commit: r229663 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2012-01-05 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Jan 5 22:16:41 2012 New Revision: 229663 URL: http://svn.freebsd.org/changeset/base/229663 Log: - Allow to change vfs.zfs.arc_meta_limit at runtime. - Change vfs.zfs.arc_meta_used from CTLFLAG_RDTUN to CTLFLAG_RD, as it is not a tunable. MFC after:3 days

Re: svn commit: r229198 - in head: share/man/man9 sys/conf sys/libkern sys/sys

2012-01-03 Thread Pawel Jakub Dawidek
) Shouldn't this be memcchr.9? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgp5O1boTsBKY.pgp Description: PGP signature

svn commit: r229436 - head/tools/tools/net80211/wesside/wesside

2012-01-03 Thread Pawel Jakub Dawidek
Author: pjd Date: Tue Jan 3 22:52:29 2012 New Revision: 229436 URL: http://svn.freebsd.org/changeset/base/229436 Log: Fix an obvious typo. We do want to specify file permission when we pass O_CREAT. Modified: head/tools/tools/net80211/wesside/wesside/wesside.c Modified:

svn commit: r229466 - head/usr.sbin/mptable

2012-01-03 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Jan 4 07:04:43 2012 New Revision: 229466 URL: http://svn.freebsd.org/changeset/base/229466 Log: Add an missing argument to open(2). If O_CREAT flag is specified, file permission has to be specified as well. Modified: head/usr.sbin/mptable/mptable.c Modified:

svn commit: r229467 - head/usr.sbin/uhsoctl

2012-01-03 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Jan 4 07:21:37 2012 New Revision: 229467 URL: http://svn.freebsd.org/changeset/base/229467 Log: Add an missing argument to open(2). If O_CREAT flag is specified, file permission has to be specified as well. Modified: head/usr.sbin/uhsoctl/uhsoctl.c Modified:

svn commit: r229468 - head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/io

2012-01-03 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Jan 4 07:25:10 2012 New Revision: 229468 URL: http://svn.freebsd.org/changeset/base/229468 Log: Add missing file permission to open(O_CREAT) call. This doesn't really matter here, as we open /dev/null for test purposes, but it is useful for consistency and further

Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211

2011-12-22 Thread Pawel Jakub Dawidek
like that or I'll turn on mean Pawel:) -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpZEhLEZ7qQV.pgp Description: PGP signature

svn commit: r228685 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-12-18 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 18 12:19:03 2011 New Revision: 228685 URL: http://svn.freebsd.org/changeset/base/228685 Log: Implement replying of ACLs updates. ACL changes should go to ZIL only if the 'sync' property is set to 'always', so replying them is not common. MFC after:1 month

svn commit: r228686 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-12-18 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 18 12:27:45 2011 New Revision: 228686 URL: http://svn.freebsd.org/changeset/base/228686 Log: From time to time people report space map corruption resulting in panic (ss == NULL) on pool import. I had such a panic recently. With current version of ZFS it is still

svn commit: r228695 - head/sbin/hastd

2011-12-18 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 18 20:40:19 2011 New Revision: 228695 URL: http://svn.freebsd.org/changeset/base/228695 Log: Don't use function name as format string. Detected by: clang MFC after:1 week Modified: head/sbin/hastd/pjdlog.h Modified: head/sbin/hastd/pjdlog.h

svn commit: r228696 - head/sbin/hastd

2011-12-18 Thread Pawel Jakub Dawidek
Author: pjd Date: Sun Dec 18 20:41:58 2011 New Revision: 228696 URL: http://svn.freebsd.org/changeset/base/228696 Log: Use lex's standard way of not generating unused function. Inspired by: r228555 MFC after:1 week Modified: head/sbin/hastd/Makefile head/sbin/hastd/token.l

svn commit: r228541 - head/etc/rc.d

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 21:06:37 2011 New Revision: 228541 URL: http://svn.freebsd.org/changeset/base/228541 Log: - Put one file into one line. This makes keeping local changes and merging with FreeBSD easier for vendors. - For optional files use variables starting with underscore.

svn commit: r228542 - head/sbin/hastd

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 22:01:34 2011 New Revision: 228542 URL: http://svn.freebsd.org/changeset/base/228542 Log: Remove redundant setting of the error variable. Found by: Clang Static Analyzer MFC after:1 week Modified: head/sbin/hastd/control.c Modified:

svn commit: r228543 - head/sbin/hastd

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 22:03:17 2011 New Revision: 228543 URL: http://svn.freebsd.org/changeset/base/228543 Log: Simplify code by changing functions types from int to avoid, as the functions always return 0. Found by: Clang Static Analyzer MFC after:1 week Modified:

svn commit: r228544 - head/sbin/hastd

2011-12-15 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Dec 15 22:05:23 2011 New Revision: 228544 URL: http://svn.freebsd.org/changeset/base/228544 Log: Remove redundant assignment. Found by: Clang Static Analyzer MFC after:1 week Modified: head/sbin/hastd/secondary.c Modified: head/sbin/hastd/secondary.c

Re: svn commit: r197139 - in head/etc: . rc.d

2011-12-13 Thread Pawel Jakub Dawidek
and I'd really reconsider or found a way to make 'inet' not to be required. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpfBilNEleR0.pgp

Re: svn commit: r228470 - head/sys/kern

2011-12-13 Thread Pawel Jakub Dawidek
. [...] I'd suggest using consistent style with those two: [...] + unprivileged_idprio == 0)) { [...] + !unprivileged_idprio)) { [...] Because it should be either 0 or 1, the latter is better. -- Pawel Jakub Dawidek http://www.wheelsystems.com

svn commit: r228392 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-12-10 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Dec 10 13:02:52 2011 New Revision: 228392 URL: http://svn.freebsd.org/changeset/base/228392 Log: Move ru_inblock increment into arc_read_nolock() so we don't account for cached reads. Discussed with: gibbs No objections from: avg Tested by:

svn commit: r228363 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-12-09 Thread Pawel Jakub Dawidek
Author: pjd Date: Fri Dec 9 18:22:57 2011 New Revision: 228363 URL: http://svn.freebsd.org/changeset/base/228363 Log: The vfs.zfs.txg.timeout sysctl can be safely modified at run time. MFC after:1 week Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/txg.c Modified:

Re: svn commit: r228342 - head/contrib/tzcode/zic

2011-12-07 Thread Pawel Jakub Dawidek
); INITIALIZE(cuthitime); #if HAVE_GETTEXT It will good to to try to upstream it as this is contributed code. This change doesn't seem to be consistent with the style of this file. They use spaces around =. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD

Re: svn commit: r227873 - head/usr.bin/procstat

2011-11-26 Thread Pawel Jakub Dawidek
, since it's shorter. u_long is preferred in kernel, in userland unsigned long is better. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com

svn commit: r228008 - head/sys/netipsec

2011-11-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 26 23:11:41 2011 New Revision: 228008 URL: http://svn.freebsd.org/changeset/base/228008 Log: There is no need to virtualize esp_max_ivlen. Modified: head/sys/netipsec/xform_esp.c Modified: head/sys/netipsec/xform_esp.c

svn commit: r228009 - head/sys/netipsec

2011-11-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 26 23:13:30 2011 New Revision: 228009 URL: http://svn.freebsd.org/changeset/base/228009 Log: Simplify code a bit. Modified: head/sys/netipsec/xform_ah.c head/sys/netipsec/xform_esp.c Modified: head/sys/netipsec/xform_ah.c

svn commit: r228010 - head/sys/netipsec

2011-11-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 26 23:15:28 2011 New Revision: 228010 URL: http://svn.freebsd.org/changeset/base/228010 Log: Eliminate 'err' variable and just use existing 'error'. Modified: head/sys/netipsec/xform_ah.c head/sys/netipsec/xform_esp.c Modified: head/sys/netipsec/xform_ah.c

svn commit: r228011 - head/sys/netipsec

2011-11-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 26 23:18:19 2011 New Revision: 228011 URL: http://svn.freebsd.org/changeset/base/228011 Log: malloc(M_WAITOK) never fails, so there is no need to check for NULL. Modified: head/sys/netipsec/xform_esp.c Modified: head/sys/netipsec/xform_esp.c

svn commit: r228012 - head/sys/netipsec

2011-11-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 26 23:27:41 2011 New Revision: 228012 URL: http://svn.freebsd.org/changeset/base/228012 Log: The esp_max_ivlen global variable is not needed, we can just use EALG_MAX_BLOCK_LEN. Modified: head/sys/netipsec/xform_esp.c Modified: head/sys/netipsec/xform_esp.c

svn commit: r228014 - head/sys/netipsec

2011-11-26 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 26 23:57:03 2011 New Revision: 228014 URL: http://svn.freebsd.org/changeset/base/228014 Log: Remove unused 'plen' variable. Modified: head/sys/netipsec/xform_esp.c Modified: head/sys/netipsec/xform_esp.c

svn commit: r227923 - stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-23 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Nov 24 07:25:43 2011 New Revision: 227923 URL: http://svn.freebsd.org/changeset/base/227923 Log: MFC r227110,r227111: r227110: In zvol_open() if the spa_namespace_lock is already held, it means that ZFS is trying to open and taste ZVOL as its VDEV. This is not

svn commit: r227927 - releng/9.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-23 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Nov 24 07:39:01 2011 New Revision: 227927 URL: http://svn.freebsd.org/changeset/base/227927 Log: MFC r227110,r227111: r227110: In zvol_open() if the spa_namespace_lock is already held, it means that ZFS is trying to open and taste ZVOL as its VDEV. This is not

svn commit: r227702 - stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 19 10:24:46 2011 New Revision: 227702 URL: http://svn.freebsd.org/changeset/base/227702 Log: MFC r226620: Update per-thread I/O statistics collection in ZFS. This allows to see processes I/O activity in 'top -m io' output. PRkern/156218

svn commit: r227703 - in stable/9/cddl/contrib/opensolaris: cmd/zdb head lib/libzpool/common

2011-11-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 19 10:26:34 2011 New Revision: 227703 URL: http://svn.freebsd.org/changeset/base/227703 Log: MFC r226613,r226615,r226616: r226613: libzpool task_alloc: pass only valid flags to kmem_alloc tqflags may contain other flags besided those that are suitable

svn commit: r227704 - stable/9/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 19 10:28:06 2011 New Revision: 227704 URL: http://svn.freebsd.org/changeset/base/227704 Log: MFC r226617: zfs vdev_file_io_start: validate vdev before using vdev_tsd vdev_tsd can be NULL for certain vdev states. At least in userland testing with ztest.

svn commit: r227705 - in stable/9: sys/boot/common sys/boot/zfs sys/cddl/boot/zfs tools/tools/zfsboottest

2011-11-19 Thread Pawel Jakub Dawidek
(r227704) +++ stable/9/tools/tools/zfsboottest/zfsboottest.c Sat Nov 19 10:49:03 2011(r227705) @@ -1,6 +1,7 @@ /*- * Copyright (c) 2010 Doug Rabson * Copyright (c) 2011 Andriy Gapon + * Copyright (c) 2011 Pawel Jakub Dawidek pa...@dawidek.net * All rights reserved

svn commit: r227707 - releng/9.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 19 11:42:19 2011 New Revision: 227707 URL: http://svn.freebsd.org/changeset/base/227707 Log: MFC r226620: Update per-thread I/O statistics collection in ZFS. This allows to see processes I/O activity in 'top -m io' output. PRkern/156218

svn commit: r227708 - releng/9.0/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 19 11:43:18 2011 New Revision: 227708 URL: http://svn.freebsd.org/changeset/base/227708 Log: MFC r226617: zfs vdev_file_io_start: validate vdev before using vdev_tsd vdev_tsd can be NULL for certain vdev states. At least in userland testing with ztest.

svn commit: r227709 - in releng/9.0/cddl/contrib/opensolaris: cmd/zdb head lib/libzpool/common

2011-11-19 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 19 11:44:20 2011 New Revision: 227709 URL: http://svn.freebsd.org/changeset/base/227709 Log: MFC r226613,r226615,r226616: r226613: libzpool task_alloc: pass only valid flags to kmem_alloc tqflags may contain other flags besided those that are suitable

svn commit: r227710 - in releng/9.0: sys/boot/common sys/boot/zfs sys/cddl/boot/zfs tools/tools/zfsboottest

2011-11-19 Thread Pawel Jakub Dawidek
/zfsboottest.cSat Nov 19 11:44:20 2011(r227709) +++ releng/9.0/tools/tools/zfsboottest/zfsboottest.cSat Nov 19 11:47:15 2011(r227710) @@ -1,6 +1,7 @@ /*- * Copyright (c) 2010 Doug Rabson * Copyright (c) 2011 Andriy Gapon + * Copyright (c) 2011 Pawel Jakub Dawidek pa

Re: svn commit: r227528 - head/etc

2011-11-17 Thread Pawel Jakub Dawidek
'pkill -F /var/run/moused.pid'. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgp8NrVnJOEyv.pgp Description: PGP signature

Re: svn commit: r227536 - in head: release share/man/man7

2011-11-17 Thread Pawel Jakub Dawidek
gross but FBSD-9.0-RELEASE-amd64-amd64-bootonly.iso? Can't we use one if they are equal? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com

Re: svn commit: r227536 - in head: release share/man/man7

2011-11-17 Thread Pawel Jakub Dawidek
-- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpppXEHPuiV2.pgp Description: PGP signature

svn commit: r227578 - head/sys/sparc64/sbus

2011-11-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Nov 16 18:42:43 2011 New Revision: 227578 URL: http://svn.freebsd.org/changeset/base/227578 Log: Fix make universe. Modified: head/sys/sparc64/sbus/lsi64854.c Modified: head/sys/sparc64/sbus/lsi64854.c

svn commit: r227581 - in head: share/man/man9 sys/kern sys/sys

2011-11-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Nov 16 19:06:55 2011 New Revision: 227581 URL: http://svn.freebsd.org/changeset/base/227581 Log: Constify stack argument for functions that don't modify it. Reviewed by: ed, kib, jhb Modified: head/share/man/man9/stack.9 head/sys/kern/subr_stack.c

svn commit: r227588 - in head: share/man/man9 sys/kern sys/sys

2011-11-16 Thread Pawel Jakub Dawidek
Author: pjd Date: Wed Nov 16 21:51:17 2011 New Revision: 227588 URL: http://svn.freebsd.org/changeset/base/227588 Log: Constify arguments for locking KPIs where possible. This enables locking consumers to pass their own structures around as const and be able to assert locks embedded

Re: svn commit: r227473 - head/sbin/geom/class/multipath

2011-11-13 Thread Pawel Jakub Dawidek
); Shouldn't that be uintmax_t, not intmax_t ? No, ssize_t is signed. Although the best would be to use %zd for ssize_t. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am

Re: svn commit: r227394 - in head/sys: amd64/amd64 i386/i386

2011-11-10 Thread Pawel Jakub Dawidek
On Thu, Nov 10, 2011 at 12:08:39PM +0200, Kostik Belousov wrote: On Thu, Nov 10, 2011 at 07:23:23AM +0100, Pawel Jakub Dawidek wrote: On Wed, Nov 09, 2011 at 07:31:28PM +0200, Kostik Belousov wrote: On Wed, Nov 09, 2011 at 05:25:43PM +, Konstantin Belousov wrote: Author: kib Date

Re: svn commit: r227394 - in head/sys: amd64/amd64 i386/i386

2011-11-09 Thread Pawel Jakub Dawidek
. -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgp7wkI6DDPq1.pgp Description: PGP signature

svn commit: r227110 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-05 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 5 16:29:03 2011 New Revision: 227110 URL: http://svn.freebsd.org/changeset/base/227110 Log: In zvol_open() if the spa_namespace_lock is already held, it means that ZFS is trying to open and taste ZVOL as its VDEV. This is not supported, so return an error instead

svn commit: r227111 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-11-05 Thread Pawel Jakub Dawidek
Author: pjd Date: Sat Nov 5 16:44:25 2011 New Revision: 227111 URL: http://svn.freebsd.org/changeset/base/227111 Log: Correct typo in comment. Reported by: Fabian Keil f...@fabiankeil.de MFC after:3 days Modified: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zvol.c

Re: svn commit: r227015 - head/sys/geom

2011-11-03 Thread Pawel Jakub Dawidek
On Wed, Nov 02, 2011 at 05:09:42PM +0200, Alexander Motin wrote: On 11/02/11 15:42, Pawel Jakub Dawidek wrote: On Wed, Nov 02, 2011 at 09:24:59AM +, Alexander Motin wrote: Author: mav Date: Wed Nov 2 09:24:59 2011 New Revision: 227015 URL: http://svn.freebsd.org/changeset/base

Re: svn commit: r227015 - head/sys/geom

2011-11-02 Thread Pawel Jakub Dawidek
stay simple? -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com pgpEV00bF8eOc.pgp Description: PGP signature

svn commit: r226837 - head/sys/crypto/aesni

2011-10-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Oct 27 14:07:57 2011 New Revision: 226837 URL: http://svn.freebsd.org/changeset/base/226837 Log: Improve AES-NI performance for AES-XTS: - Operate on uint64_t types when doing XORing, etc. instead of uint8_t. - Don't bzero() temporary block for every AES block. Do it

svn commit: r226839 - head/sys/crypto/aesni

2011-10-27 Thread Pawel Jakub Dawidek
- * Copyright (c) 2010 Pawel Jakub Dawidek p...@freebsd.org + * Copyright (c) 2010-2011 Pawel Jakub Dawidek pa...@dawidek.net * All rights reserved. * * Redistribution and use in source and binary forms, with or without ___ svn-src-all@freebsd.org mailing list

svn commit: r226840 - head/sys/geom/eli

2011-10-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Oct 27 16:12:25 2011 New Revision: 226840 URL: http://svn.freebsd.org/changeset/base/226840 Log: Before this change when GELI detected hardware crypto acceleration it will start only one worker thread. For software crypto it will start by default N worker threads where

svn commit: r226842 - head/sbin/hastd

2011-10-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Oct 27 16:22:17 2011 New Revision: 226842 URL: http://svn.freebsd.org/changeset/base/226842 Log: Correct comments. MFC after:3 days Modified: head/sbin/hastd/secondary.c Modified: head/sbin/hastd/secondary.c

svn commit: r226851 - head/sbin/hastd

2011-10-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Oct 27 18:45:01 2011 New Revision: 226851 URL: http://svn.freebsd.org/changeset/base/226851 Log: Delay resuid generation until first connection to secondary, not until first write. This way on first connection we will synchronize only the extents that were modified

svn commit: r226852 - head/sbin/hastd

2011-10-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Oct 27 18:49:16 2011 New Revision: 226852 URL: http://svn.freebsd.org/changeset/base/226852 Log: Monor cleanups. MFC after:3 days Modified: head/sbin/hastd/primary.c Modified: head/sbin/hastd/primary.c

svn commit: r226854 - head/sbin/hastd

2011-10-27 Thread Pawel Jakub Dawidek
Author: pjd Date: Thu Oct 27 20:01:23 2011 New Revision: 226854 URL: http://svn.freebsd.org/changeset/base/226854 Log: - Eliminate the need for hio_nv. - Introduce hio_clear() function for clearing hio before returning it onto free queue. MFC after:3 days Modified:

<    2   3   4   5   6   7   8   9   10   11   >