svn commit: r364257 - head/sys/net

Author: qingli Date: Sat Aug 15 16:48:58 2020 New Revision: 364257 URL: https://svnweb.freebsd.org/changeset/base/364257 Log: Correct the mask byte order when checking for reserved bits. Reviewed by: gnn Approved by: gnn MFC after:2 weeks Differential Revision:

Re: svn commit: r301217 - in head/sys: net netinet netinet6

On Sun, Jun 5, 2016 at 11:06 PM, Alexander V. Chernikov < melif...@freebsd.org> wrote: > 06.06.2016, 04:40, "George Neville-Neil" : > > On 4 Jun 2016, at 15:05, Alexander V. Chernikov wrote: > > > >> 02.06.2016, 20:51, "George V. Neville-Neil" : > >>> Author:

svn commit: r252184 - head/sys/net

Author: qingli Date: Tue Jun 25 00:10:49 2013 New Revision: 252184 URL: http://svnweb.freebsd.org/changeset/base/252184 Log: Due to the routing related networking kernel redesign work in FBSD 8.0, interface routes have been returened to the applications without the RTF_GATEWAY bit. This

svn commit: r252141 - head/sys/netinet6

Author: qingli Date: Mon Jun 24 05:01:13 2013 New Revision: 252141 URL: http://svnweb.freebsd.org/changeset/base/252141 Log: Delete the nd6 entries associated with an off-link prefix if the same prefix cannot be found on an alternative interface. Reviewed by: hrs MFC after:1

Re: svn commit: r233773 - head/usr.sbin/arp

for an alternative patch ? --Qing 2012/4/8 Gleb Smirnoff gleb...@freebsd.org:  Qing, On Sun, Apr 08, 2012 at 10:41:11AM -0700, Qing Li wrote: Q This is not the right way to support RFC3021. Q Q The code you removed is used for checking against attempt at adding Q duplicate entry. Q Both

Re: svn commit: r233773 - head/usr.sbin/arp

This is not the right way to support RFC3021. The code you removed is used for checking against attempt at adding duplicate entry. Both the message and the code apply in that context. I tried to state clearly and concisely what r201282 was intended in solving and was verified by actual users who

svn commit: r230604 - stable/9/sys/netinet6

Author: qingli Date: Fri Jan 27 02:13:27 2012 New Revision: 230604 URL: http://svn.freebsd.org/changeset/base/230604 Log: MFC 227460 A default route learned from the RAs could be deleted manually after its installation. This removal may be accidental and can prevent the default route

svn commit: r228092 - stable/8/sys/netinet6

Author: qingli Date: Mon Nov 28 19:53:16 2011 New Revision: 228092 URL: http://svn.freebsd.org/changeset/base/228092 Log: MFC 227460 A default route learned from the RAs could be deleted manually after its installation. This removal may be accidental and can prevent the default route

Re: svn commit: r227791 - head/sys/netinet

 first I'd like to notice that we are speaking about obsoleted interfaces. Yup, that's why you don't see me commenting on your other commits around ia_netmask stuff, do you ? snip Back to your comments: I have made a test case that proves, that usage of deleted address isn't prevented

Re: svn commit: r227791 - head/sys/netinet

Logically speaking the prefix route should not be removed until all of the address related housing keeping tasks have been completed successfully. Putting in_scrubprefix() at the top does not gain you anything at all, but can potentially be problematic if additional tasks are in fact performed in

Re: svn commit: r227791 - head/sys/netinet

From my point of view logically speaking, we should first remove route, then remove address. Otherwise, for a short time we've got an invalid route in table. For a short time you have an invalid address, it is faster to remove the address from the list to prevent usage, then to flush the

svn commit: r227460 - head/sys/netinet6

Author: qingli Date: Fri Nov 11 23:22:38 2011 New Revision: 227460 URL: http://svn.freebsd.org/changeset/base/227460 Log: A default route learned from the RAs could be deleted manually after its installation. This removal may be accidental and can prevent the default route from being

svn commit: r227002 - stable/9/sys/netinet

Author: qingli Date: Tue Nov 1 18:29:06 2011 New Revision: 227002 URL: http://svn.freebsd.org/changeset/base/227002 Log: MFC 226713 Exclude host routes when checking for prefix coverage on multiple interfaces. A host route has a NULL mask so check for that condition. I have also been

svn commit: r227003 - stable/8/sys/net

Author: qingli Date: Tue Nov 1 19:29:03 2011 New Revision: 227003 URL: http://svn.freebsd.org/changeset/base/227003 Log: MFC 226710 The host-id/interface-id can have a specific value and is properly masked out when adding a prefix route through the route command. However, when

svn commit: r227005 - stable/9/sys/netinet6

Author: qingli Date: Tue Nov 1 21:21:36 2011 New Revision: 227005 URL: http://svn.freebsd.org/changeset/base/227005 Log: MFC 226451 The IPv6 code was influx at the time of r196865 due to the L2/L3 separation rewrite changes. r196865 was committed to fix a scope violation problem in

svn commit: r227008 - stable/9/sys/net

Author: qingli Date: Tue Nov 1 22:22:46 2011 New Revision: 227008 URL: http://svn.freebsd.org/changeset/base/227008 Log: MFC 226710 The host-id/interface-id can have a specific value and is properly masked out when adding a prefix route through the route command. However, when

svn commit: r226877 - stable/8/sys/netinet

Author: qingli Date: Fri Oct 28 03:58:33 2011 New Revision: 226877 URL: http://svn.freebsd.org/changeset/base/226877 Log: MFC 226713 Exclude host routes when checking for prefix coverage on multiple interfaces. A host route has a NULL mask so check for that condition. I have also been

svn commit: r226878 - stable/8/sys/netinet6

Author: qingli Date: Fri Oct 28 04:04:21 2011 New Revision: 226878 URL: http://svn.freebsd.org/changeset/base/226878 Log: MFC 226451 The IPv6 code was influx at the time of r196865 due to the L2/L3 separation rewrite changes. r196865 was committed to fix a scope violation problem in

svn commit: r226710 - head/sys/net

Author: qingli Date: Tue Oct 25 00:34:39 2011 New Revision: 226710 URL: http://svn.freebsd.org/changeset/base/226710 Log: The host-id/interface-id can have a specific value and is properly masked out when adding a prefix route through the route command. However, when deleting the route,

svn commit: r226713 - head/sys/netinet

Author: qingli Date: Tue Oct 25 04:06:29 2011 New Revision: 226713 URL: http://svn.freebsd.org/changeset/base/226713 Log: Exclude host routes when checking for prefix coverage on multiple interfaces. A host route has a NULL mask so check for that condition. I have also been told by

svn commit: r226485 - stable/8/sys/netinet6

Author: qingli Date: Tue Oct 18 01:56:43 2011 New Revision: 226485 URL: http://svn.freebsd.org/changeset/base/226485 Log: MFC 226453 The code change made in r226040 was incomplete and resulted in routes such as fe80::1%lo0 no being installed. This patch completes the original intended

svn commit: r226451 - head/sys/netinet6

Author: qingli Date: Sun Oct 16 22:15:13 2011 New Revision: 226451 URL: http://svn.freebsd.org/changeset/base/226451 Log: The IPv6 code was influx at the time of r196865 due to the L2/L3 separation rewrite changes. r196865 was committed to fix a scope violation problem in the following test

svn commit: r226453 - head/sys/netinet6

Author: qingli Date: Sun Oct 16 22:24:04 2011 New Revision: 226453 URL: http://svn.freebsd.org/changeset/base/226453 Log: The code change made in r226040 was incomplete and resulted in routes such as fe80::1%lo0 no being installed. This patch completes the original intended fix.

svn commit: r226455 - stable/9/sys/netinet6

Author: qingli Date: Mon Oct 17 03:35:24 2011 New Revision: 226455 URL: http://svn.freebsd.org/changeset/base/226455 Log: MFC 226453 The code change made in r226040 was incomplete and resulted in routes such as fe80::1%lo0 no being installed. This patch completes the original intended

svn commit: r226333 - stable/9/sys/netinet

Author: qingli Date: Thu Oct 13 08:26:23 2011 New Revision: 226333 URL: http://svn.freebsd.org/changeset/base/226333 Log: MFC 226114 Remove the reference held on the loopback route when the interface address is being deleted. Only the last reference holder deletes the loopback route.

svn commit: r226337 - stable/9/sys/netinet

Author: qingli Date: Thu Oct 13 09:21:49 2011 New Revision: 226337 URL: http://svn.freebsd.org/changeset/base/226337 Log: MFC 226120 PR: kern/159602 Submitted by: pluknet Approved by: re (kib) Modified: stable/9/sys/netinet/in.c Directory Properties: stable/9/sys/

svn commit: r226287 - stable/9/sys/netinet

Author: qingli Date: Wed Oct 12 08:08:08 2011 New Revision: 226287 URL: http://svn.freebsd.org/changeset/base/226287 Log: MFC 225946 This patch allows ARP to work properly in the presence of self-referencing routes. This patch is a rework of r223862. Reviewed by: bz, zec Approved

svn commit: r226326 - stable/9/sys/netinet

Author: qingli Date: Wed Oct 12 21:02:58 2011 New Revision: 226326 URL: http://svn.freebsd.org/changeset/base/226326 Log: MFC 225947 A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without

svn commit: r226330 - stable/8/sys/netinet

Author: qingli Date: Thu Oct 13 00:37:39 2011 New Revision: 226330 URL: http://svn.freebsd.org/changeset/base/226330 Log: MFC 226224 All indirect routes will fail the rtcheck, except for a special host route where the destination IP and the gateway IP is the same. This special case

svn commit: r226331 - stable/9/sys/netinet

Author: qingli Date: Thu Oct 13 00:44:24 2011 New Revision: 226331 URL: http://svn.freebsd.org/changeset/base/226331 Log: MFC 226224 All indirect routes will fail the rtcheck, except for a special host route where the destination IP and the gateway IP is the same. This special case

svn commit: r226332 - stable/9/sys/netinet6

Author: qingli Date: Thu Oct 13 03:21:48 2011 New Revision: 226332 URL: http://svn.freebsd.org/changeset/base/226332 Log: MFC 226040 The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to determine if a loopback route should be installed for an interface IPv6 address.

Re: svn commit: r225947 - head/sys/netinet

Okay, now I know what's confusing you ... it's that bug I introduced :-) The 2nd if() check on the RTF_GATEWAY flag should have been an else if(). In a nutshell, the logic is any indirect route should fail the check, except for that special host route. Attached is the rework of that part of the

svn commit: r226224 - head/sys/netinet

Author: qingli Date: Mon Oct 10 17:41:11 2011 New Revision: 226224 URL: http://svn.freebsd.org/changeset/base/226224 Log: All indirect routes will fail the rtcheck, except for a special host route where the destination IP and the gateway IP is the same. This special case handling is only

svn commit: r226230 - stable/8/sys/netinet

Author: qingli Date: Mon Oct 10 19:41:00 2011 New Revision: 226230 URL: http://svn.freebsd.org/changeset/base/226230 Log: MFC 225946 This patch allows ARP to work properly in the presence of self-referencing routes. This patch is a rework of r223862. Reviewed by: bz, zec Modified:

Re: svn commit: r226224 - head/sys/netinet

MFC 225946 is the original patch, 225947 messed up the logic a bit while putting in the fix for another issue. 226224 is the fix to 225947, which I will MFC tomorrow. --Qing 2011/10/10 Gleb Smirnoff gleb...@freebsd.org:  Qing, On Mon, Oct 10, 2011 at 05:41:11PM +, Qing Li wrote: Q

svn commit: r226232 - stable/8/sys/netinet

Author: qingli Date: Mon Oct 10 20:54:20 2011 New Revision: 226232 URL: http://svn.freebsd.org/changeset/base/226232 Log: MFC 225947 A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without

svn commit: r226235 - in stable/8/sys: net netinet netinet6

Author: qingli Date: Mon Oct 10 21:34:55 2011 New Revision: 226235 URL: http://svn.freebsd.org/changeset/base/226235 Log: MFC 222143 The statically configured (permanent) ARP entries are removed when an interface is brought down, even though the interface address is still valid. This

svn commit: r226236 - stable/8/sys/netinet

Author: qingli Date: Mon Oct 10 21:38:19 2011 New Revision: 226236 URL: http://svn.freebsd.org/changeset/base/226236 Log: MFC 222438 Supply the LLE_STATIC flag bit to in_ifscurb() when scrubbing interface address so that proper clean up will take place in the routing code. This patch

svn commit: r226237 - stable/8/sys/netinet

Author: qingli Date: Mon Oct 10 21:41:34 2011 New Revision: 226237 URL: http://svn.freebsd.org/changeset/base/226237 Log: MFC 226114 Remove the reference held on the loopback route when the interface address is being deleted. Only the last reference holder deletes the loopback route.

svn commit: r226238 - stable/8/sys/netinet

Author: qingli Date: Mon Oct 10 21:43:53 2011 New Revision: 226238 URL: http://svn.freebsd.org/changeset/base/226238 Log: MFC 226120 Do not try removing an ARP entry associated with a given interface address if that interface does not support ARP. Otherwise the system will generate

svn commit: r226239 - stable/8/sys/netinet

Author: qingli Date: Mon Oct 10 21:46:37 2011 New Revision: 226239 URL: http://svn.freebsd.org/changeset/base/226239 Log: MFC 225223 When an interface address route is removed from the system, another route with the same prefix is searched for as a replacement. The current code did not

svn commit: r226240 - stable/8/sys/netinet6

Author: qingli Date: Mon Oct 10 21:48:40 2011 New Revision: 226240 URL: http://svn.freebsd.org/changeset/base/226240 Log: MFC 226040 The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to determine if a loopback route should be installed for an interface IPv6 address.

svn commit: r226241 - stable/8/sys/net

Author: qingli Date: Mon Oct 10 21:54:19 2011 New Revision: 226241 URL: http://svn.freebsd.org/changeset/base/226241 Log: MFC 225163 When the RADIX_MPATH kernel option is enabled, the RADIX_MPATH code tries to find the first route node of an ECMP chain before executing the route

Re: svn commit: r225947 - head/sys/netinet

Hi Gleb, On Mon, Oct 03, 2011 at 07:51:19PM +, Qing Li wrote: Q Author: qingli Q Date: Mon Oct  3 19:51:18 2011 Q New Revision: 225947 Q URL: http://svn.freebsd.org/changeset/base/225947 Q Q Log: Q   A system may have multiple physical interfaces, all of which are on the Q   same

svn commit: r226114 - head/sys/netinet

Author: qingli Date: Fri Oct 7 18:01:34 2011 New Revision: 226114 URL: http://svn.freebsd.org/changeset/base/226114 Log: Remove the reference held on the loopback route when the interface address is being deleted. Only the last reference holder deletes the loopback route. All other delete

svn commit: r226120 - head/sys/netinet

Author: qingli Date: Fri Oct 7 22:22:19 2011 New Revision: 226120 URL: http://svn.freebsd.org/changeset/base/226120 Log: Do not try removing an ARP entry associated with a given interface address if that interface does not support ARP. Otherwise the system will generate error messages

svn commit: r226040 - head/sys/netinet6

Author: qingli Date: Wed Oct 5 16:27:11 2011 New Revision: 226040 URL: http://svn.freebsd.org/changeset/base/226040 Log: The IFA_RTSELF instead of the IFA_ROUTE flag should be checked to determine if a loopback route should be installed for an interface IPv6 address. Another condition is

Re: svn commit: r226040 - head/sys/netinet6

, Oct 5, 2011 at 4:21 PM, Bjoern A. Zeeb bzeeb-li...@lists.zabbadoz.net wrote: On 5. Oct 2011, at 16:27 , Qing Li wrote: Author: qingli Date: Wed Oct  5 16:27:11 2011 New Revision: 226040 URL: http://svn.freebsd.org/changeset/base/226040 Log:  The IFA_RTSELF instead of the IFA_ROUTE flag

svn commit: r225946 - head/sys/netinet

Author: qingli Date: Mon Oct 3 19:06:55 2011 New Revision: 225946 URL: http://svn.freebsd.org/changeset/base/225946 Log: This patch allows ARP to work properly in the presence of self-referencing routes. This patch is a rework of r223862. Reviewed by: bz, zec MFC after:5 days

svn commit: r225947 - head/sys/netinet

Author: qingli Date: Mon Oct 3 19:51:18 2011 New Revision: 225947 URL: http://svn.freebsd.org/changeset/base/225947 Log: A system may have multiple physical interfaces, all of which are on the same prefix. Since a single route entry is installed for the prefix (without RADIX_MPATH),

svn commit: r225405 - head/sys/dev/ixgbe

Author: qingli Date: Mon Sep 5 17:54:19 2011 New Revision: 225405 URL: http://svn.freebsd.org/changeset/base/225405 Log: The maximum read size of incoming packets is done in 1024-byte increments. The current code was rounding down the maximum frame size instead of routing up, resulting in

svn commit: r225223 - head/sys/netinet

Author: qingli Date: Sun Aug 28 00:14:40 2011 New Revision: 225223 URL: http://svn.freebsd.org/changeset/base/225223 Log: When an interface address route is removed from the system, another route with the same prefix is searched for as a replacement. The current code did not bypass routes

svn commit: r225163 - head/sys/net

Author: qingli Date: Thu Aug 25 04:31:20 2011 New Revision: 225163 URL: http://svn.freebsd.org/changeset/base/225163 Log: When the RADIX_MPATH kernel option is enabled, the RADIX_MPATH code tries to find the first route node of an ECMP chain before executing the route command. If the system

svn commit: r222438 - head/sys/netinet

Author: qingli Date: Sun May 29 02:21:35 2011 New Revision: 222438 URL: http://svn.freebsd.org/changeset/base/222438 Log: Supply the LLE_STATIC flag bit to in_ifscurb() when scrubbing interface address so that proper clean up will take place in the routing code. This patch fixes the bootp

svn commit: r222143 - in head/sys: net netinet netinet6

Author: qingli Date: Fri May 20 19:12:20 2011 New Revision: 222143 URL: http://svn.freebsd.org/changeset/base/222143 Log: The statically configured (permanent) ARP entries are removed when an interface is brought down, even though the interface address is still valid. This patch maintains

svn commit: r209524 - in releng/8.1/sys: net netinet

Author: qingli Date: Fri Jun 25 21:26:34 2010 New Revision: 209524 URL: http://svn.freebsd.org/changeset/base/209524 Log: MFC r208553 This patch fixes the problem where proxy ARP entries cannot be added over the if_ng interface. Approved by: re (bz) Modified:

svn commit: r209277 - in stable/8/sys: net netinet

Author: qingli Date: Fri Jun 18 03:31:33 2010 New Revision: 209277 URL: http://svn.freebsd.org/changeset/base/209277 Log: MFC r208553 This patch fixes the problem where proxy ARP entries cannot be added over the if_ng interface. Modified: stable/8/sys/net/if.c

svn commit: r208553 - in head/sys: net netinet

Author: qingli Date: Tue May 25 20:42:35 2010 New Revision: 208553 URL: http://svn.freebsd.org/changeset/base/208553 Log: This patch fixes the problem where proxy ARP entries cannot be added over the if_ng interface. MFC after:3 days Modified: head/sys/net/if.c

svn commit: r206055 - stable/8/sys/net

Author: qingli Date: Thu Apr 1 20:23:43 2010 New Revision: 206055 URL: http://svn.freebsd.org/changeset/base/206055 Log: MFC 205077 The flow-table module retrieves the destination and source address as well as the transport protocol port information from the outbound packets. The

svn commit: r206066 - stable/8/sys/netinet

Author: qingli Date: Fri Apr 2 04:58:17 2010 New Revision: 206066 URL: http://svn.freebsd.org/changeset/base/206066 Log: MFC 201131 introduce a local variable rte acting as a cache of ro-ro_rt within ip_output, achieving (in random order of importance): - a reduction of the number

svn commit: r206067 - in stable/8/sys: net netinet

Author: qingli Date: Fri Apr 2 05:02:50 2010 New Revision: 206067 URL: http://svn.freebsd.org/changeset/base/206067 Log: MFC 204902 One of the advantages of enabling ECMP (a.k.a RADIX_MPATH) is to allow for connection load balancing across interfaces. Currently the address alias

svn commit: r206068 - stable/8/sys/net

Author: qingli Date: Fri Apr 2 05:05:51 2010 New Revision: 206068 URL: http://svn.freebsd.org/changeset/base/206068 Log: MFC 205024 The if_tap interface is of IFT_ETHERNET type, but it does not set or update the if_link_state variable. As such RT_LINK_IS_UP() fails for the if_tap

svn commit: r206069 - in stable/8: sbin/ifconfig sys/net

Author: qingli Date: Fri Apr 2 05:12:46 2010 New Revision: 206069 URL: http://svn.freebsd.org/changeset/base/206069 Log: MFC 205222 Verify interface up status using its link state only if the interface has such capability. The interface capability flag indicates whether such

svn commit: r206071 - stable/8/sys/dev/mii

Author: qingli Date: Fri Apr 2 05:15:27 2010 New Revision: 206071 URL: http://svn.freebsd.org/changeset/base/206071 Log: MFC 205268 Set the device capabilities to include dynamic link-state for those modern drivers. Reviewed by: imp (and suggested by imp) Modified:

svn commit: r205493 - in stable/8/usr.sbin: . dumpcis makefs makefs/ffs mfiutil ppp

Author: qingli Date: Mon Mar 22 23:33:40 2010 New Revision: 205493 URL: http://svn.freebsd.org/changeset/base/205493 Log: MFC r205272 Need to set the proper flag bit when inserting ARP entries into the kernel. Modified: stable/8/usr.sbin/ppp/arp.c Directory Properties:

svn commit: r205268 - head/sys/dev/mii

Author: qingli Date: Wed Mar 17 22:12:12 2010 New Revision: 205268 URL: http://svn.freebsd.org/changeset/base/205268 Log: Set the device capabilities to include dynamic link-state for those modern drivers. Reviewed by: imp (and suggested by imp) MFC after:3 days Modified:

svn commit: r205272 - head/usr.sbin/ppp

Author: qingli Date: Thu Mar 18 00:23:39 2010 New Revision: 205272 URL: http://svn.freebsd.org/changeset/base/205272 Log: Need to set the proper flag bit when inserting ARP entries into the kernel. MFC after:3 days Modified: head/usr.sbin/ppp/arp.c Modified:

svn commit: r205222 - in head: sbin/ifconfig sys/net

Author: qingli Date: Tue Mar 16 17:59:12 2010 New Revision: 205222 URL: http://svn.freebsd.org/changeset/base/205222 Log: Verify interface up status using its link state only if the interface has such capability. The interface capability flag indicates whether such capability exists. This

Re: svn commit: r205024 - head/sys/net

: On Mar 12, 2010, at 7:52 AM, Qing Li wrote: Is there any way we can pick up via an assertion that an interface driver has failed to implement this functionality? This has never been a historic requirement, so I suspect there are a lot of drivers floating around that fail to meet the requirement

Re: svn commit: r205024 - head/sys/net

Nope, I meant Julian, and what he proposed, and if I understood correctly, is the simplest approach and easily done. -- Qing On Fri, Mar 12, 2010 at 12:29 AM, Robert N. M. Watson rwat...@freebsd.org wrote: On Mar 12, 2010, at 8:11 AM, Qing Li wrote: I like Julian's suggestion because

svn commit: r205077 - head/sys/net

Author: qingli Date: Fri Mar 12 10:24:58 2010 New Revision: 205077 URL: http://svn.freebsd.org/changeset/base/205077 Log: The flow-table module retrieves the destination and source address as well as the transport protocol port information from the outbound packets. The routing code is

Re: svn commit: r205024 - head/sys/net

We've got LINK_STATE_UNKNOWN, we can just initialize if_link_state to this value in ether_ifattach(). And Qing should treat this value as LINK_STATE_UP in routing decision until better times. Thanks everyone for your input. I generally try to avoid overloading a variable to have more than 1

svn commit: r205024 - head/sys/net

Author: qingli Date: Thu Mar 11 17:56:46 2010 New Revision: 205024 URL: http://svn.freebsd.org/changeset/base/205024 Log: The if_tap interface is of IFT_ETHERNET type, but it does not set or update the if_link_state variable. As such RT_LINK_IS_UP() fails for the if_tap interface.

Re: svn commit: r205024 - head/sys/net

A couple of questions: (1) It used to be the case that quite a few interface drivers and types didn't have a notion of link up -- especially older ethernet devices.  Do those all have the same problem?  It was probably a design oversight that  devices don't declare an explicit capability for

Re: svn commit: r205024 - head/sys/net

On Thu, Mar 11, 2010 at 3:35 PM, Juli Mallett jmall...@freebsd.org wrote: On Thu, Mar 11, 2010 at 15:30, Qing Li qin...@freebsd.org wrote: A couple of questions: (1) It used to be the case that quite a few interface drivers and types didn't have a notion of link up -- especially older ethernet

Re: svn commit: r205024 - head/sys/net

If you can think of a way to add some invariants (warn the first time a driver receives a packet without having ever set the link state, make sure the media status callback sets the valid flag in the request, etc) that would probably be very helpful for people who are writing network

Re: svn commit: r205024 - head/sys/net

That's a good idea. I will take your approach. -- Qing On Thu, Mar 11, 2010 at 11:15 PM, Julian Elischer jul...@elischer.org wrote: Juli Mallett wrote: On Thu, Mar 11, 2010 at 15:39, Qing Li qin...@freebsd.org wrote: I guess it's a good time to clean things up. The if_link_state code has

Re: svn commit: r205024 - head/sys/net

Is there any way we can pick up via an assertion that an interface driver has failed to implement this functionality? This has never been a historic requirement, so I suspect there are a lot of drivers floating around that fail to meet the requirement. Also, is this for IFT_ETHER only, or

Re: svn commit: r204902 - in head/sys: net netinet

I looked at it, and at the diff of his original commit.  The changes were large enough that I don't want to assume his patch takes care of all the issues given that patch hasn't been committed verbatim. The change itself is not a huge change but if you disagree, then please be specific. The

svn commit: r204893 - stable/8/sys/netinet6

Author: qingli Date: Mon Mar 8 21:30:12 2010 New Revision: 204893 URL: http://svn.freebsd.org/changeset/base/204893 Log: MFC 204402 Use reference counting instead of locking to secure an address while that address is being used to generate temporary IPv6 address. This approach is

svn commit: r204902 - in head/sys: net netinet

Author: qingli Date: Tue Mar 9 01:11:45 2010 New Revision: 204902 URL: http://svn.freebsd.org/changeset/base/204902 Log: One of the advantages of enabling ECMP (a.k.a RADIX_MPATH) is to allow for connection load balancing across interfaces. Currently the address alias handling method is

svn commit: r204402 - head/sys/netinet6

Author: qingli Date: Sat Feb 27 07:12:25 2010 New Revision: 204402 URL: http://svn.freebsd.org/changeset/base/204402 Log: Use reference counting instead of locking to secure an address while that address is being used to generate temporary IPv6 address. This approach is sufficient and

svn commit: r203718 - stable/8/sys/netinet

Author: qingli Date: Tue Feb 9 19:27:54 2010 New Revision: 203718 URL: http://svn.freebsd.org/changeset/base/203718 Log: MFC r203401 Some of the existing ppp and vpn related scripts create and set the IP addresses of the tunnel end points to the same value. In these cases the

svn commit: r203401 - head/sys/netinet

Author: qingli Date: Tue Feb 2 20:38:30 2010 New Revision: 203401 URL: http://svn.freebsd.org/changeset/base/203401 Log: Some of the existing ppp and vpn related scripts create and set the IP addresses of the tunnel end points to the same value. In these cases the loopback route is not

svn commit: r202132 - stable/8/sys/netinet

Author: qingli Date: Tue Jan 12 00:04:13 2010 New Revision: 202132 URL: http://svn.freebsd.org/changeset/base/202132 Log: MFC r201544 An existing incomplete ARP entry would expire a subsequent statically configured entry of the same host. This bug was due to the expiration timer was

svn commit: r201811 - head/sys/netinet

Author: qingli Date: Fri Jan 8 17:49:24 2010 New Revision: 201811 URL: http://svn.freebsd.org/changeset/base/201811 Log: Ensure an address is removed from the interface address list when the installation of that address fails. PR: 139559 Modified: head/sys/netinet/in.c

svn commit: r201614 - in stable/8: . contrib/top lib/libusb share/man/man4 sys/net sys/netinet sys/netinet6 tools/regression/lib/msun tools/regression/usr.bin/pkill tools/tools/ath/common tools/too...

Author: qingli Date: Tue Jan 5 22:14:55 2010 New Revision: 201614 URL: http://svn.freebsd.org/changeset/base/201614 Log: MFC r201282, r201543 r201282 --- The proxy arp entries could not be added into the system over the IFF_POINTOPOINT link types. The reason was due to the

svn commit: r201615 - stable/8/sys/netinet6

Author: qingli Date: Tue Jan 5 22:28:23 2010 New Revision: 201615 URL: http://svn.freebsd.org/changeset/base/201615 Log: MFC r201284 Multiple IPv6 addresses of the same prefix can be installed on the same interface. The first address will install the prefix route into the kernel

svn commit: r201616 - stable/8/sys/netinet

Author: qingli Date: Tue Jan 5 22:33:10 2010 New Revision: 201616 URL: http://svn.freebsd.org/changeset/base/201616 Log: MFC r201285 Consolidate the route message generation code for when address aliases were added or deleted. The announced route entry for an address alias is no

svn commit: r201617 - stable/8/sys/net

Author: qingli Date: Tue Jan 5 22:37:05 2010 New Revision: 201617 URL: http://svn.freebsd.org/changeset/base/201617 Log: MFC r201319 Remove a deleted comment line that was brought back by my previous commit. Modified: stable/8/sys/net/if_var.h Directory Properties: stable/8/sys/

svn commit: r201543 - head/sys/netinet6

Author: qingli Date: Mon Jan 4 23:39:53 2010 New Revision: 201543 URL: http://svn.freebsd.org/changeset/base/201543 Log: The IFA_RTSELF address flag marks a loopback route has been installed for the interface address. This marker is necessary to properly support PPP types of links where

svn commit: r201544 - head/sys/netinet

Author: qingli Date: Tue Jan 5 00:35:46 2010 New Revision: 201544 URL: http://svn.freebsd.org/changeset/base/201544 Log: An existing incomplete ARP entry would expire a subsequent statically configured entry of the same host. This bug was due to the expiration timer was not cancelled when

Re: svn commit: r201284 - head/sys/netinet6

Hmm... there is a possibility r201284, but on the other hand, I have been running this patch for a while now. However, that patch was created from several weeks ago, and -current had evolved. Would you mind sending me your configuration information, in particular, ifconfig -a and netstat -rn and

svn commit: r201284 - head/sys/netinet6

Author: qingli Date: Wed Dec 30 21:51:23 2009 New Revision: 201284 URL: http://svn.freebsd.org/changeset/base/201284 Log: Multiple IPv6 addresses of the same prefix can be installed on the same interface. The first address will install the prefix route into the kernel routing table and that

svn commit: r201285 - head/sys/netinet

Author: qingli Date: Wed Dec 30 22:13:01 2009 New Revision: 201285 URL: http://svn.freebsd.org/changeset/base/201285 Log: Consolidate the route message generation code for when address aliases were added or deleted. The announced route entry for an address alias is no longer empty because

svn commit: r201319 - head/sys/net

Author: qingli Date: Thu Dec 31 01:09:16 2009 New Revision: 201319 URL: http://svn.freebsd.org/changeset/base/201319 Log: Remove a deleted comment line that was brought back by my previous commit. MFC after:5 days Modified: head/sys/net/if_var.h Modified: head/sys/net/if_var.h

svn commit: r198566 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

Author: qingli Date: Wed Oct 28 21:43:16 2009 New Revision: 198566 URL: http://svn.freebsd.org/changeset/base/198566 Log: MFC r198353 Verify smp_started is true before calling sched_bind() and sched_unbind(). Reviewed by: kmacy Modified: stable/8/sys/ (props changed)

svn commit: r198567 - in stable/8/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci netinet netinet6

Author: qingli Date: Wed Oct 28 21:45:25 2009 New Revision: 198567 URL: http://svn.freebsd.org/changeset/base/198567 Log: MFC r198418 Use the correct option name in the preprocessor command to enable or disable diagnostic messages. Reviewed by: ru Modified: stable/8/sys/

svn commit: r198568 - in releng/8.0/sys: . amd64/include/xen cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/xen/xenpci net

Author: qingli Date: Wed Oct 28 22:00:49 2009 New Revision: 198568 URL: http://svn.freebsd.org/changeset/base/198568 Log: MFC r198353 Verify smp_started is true before calling sched_bind() and sched_unbind(). Reviewed by: kmacy Approved by: re Modified: releng/8.0/sys/

svn commit: r198418 - in head/sys: netinet netinet6

Author: qingli Date: Fri Oct 23 18:27:34 2009 New Revision: 198418 URL: http://svn.freebsd.org/changeset/base/198418 Log: Use the correct option name in the preprocessor command to enable or disable diagnostic messages. Reviewed by: ru MFC after:3 days Modified:

  1   2   >