Author: rmacklem
Date: Thu Mar 8 02:27:29 2012
New Revision: 232682
URL: http://svn.freebsd.org/changeset/base/232682
Log:
MFC: r232327
Fix the NFS clients so that they use copyin() instead of bcopy(),
when doing direct I/O. This direct I/O code is not enabled by default.
Modified:
stabl
Author: rmacklem
Date: Sat Mar 3 16:13:20 2012
New Revision: 232467
URL: http://svn.freebsd.org/changeset/base/232467
Log:
The name caching changes of r230394 exposed an intermittent bug
in the new NFS server for NFSv4, where it would report ENOENT
when the file actually existed on the serv
John Baldwin wrote:
> On Friday, March 02, 2012 8:29:21 am Peter Holm wrote:
> > On Thu, Mar 01, 2012 at 04:47:41PM -0500, John Baldwin wrote:
> > > On Monday, October 31, 2011 11:01:47 am Peter Holm wrote:
> > > > Author: pho
> > > > Date: Mon Oct 31 15:01:47 2011
> > > > New Revision: 226967
> >
Author: rmacklem
Date: Sat Mar 3 01:06:54 2012
New Revision: 232420
URL: http://svn.freebsd.org/changeset/base/232420
Log:
Post r230394, the Lookup RPC counts for both NFS clients increased
significantly. Upon investigation this was caused by name cache
misses for lookups of "..". For name
Author: rmacklem
Date: Thu Mar 1 03:53:07 2012
New Revision: 232327
URL: http://svn.freebsd.org/changeset/base/232327
Log:
Fix the NFS clients so that they use copyin() instead of bcopy(),
when doing direct I/O. This direct I/O code is not enabled by default.
Submitted by: kib (earlier v
Author: rmacklem
Date: Tue Feb 28 15:52:01 2012
New Revision: 232259
URL: http://svn.freebsd.org/changeset/base/232259
Log:
MFC: r232050
hrs@ reported a panic to freebsd-stable@ under the subject line
"panic in 8.3-PRERELEASE" on Feb. 22, 2012. This panic was caused
by use of a mix of tsle
Maxim Konovalov wrote:
> Author: maxim
> Date: Sat Feb 25 12:06:40 2012
> New Revision: 232156
> URL: http://svn.freebsd.org/changeset/base/232156
>
> Log:
> o Reduce chances for integer overflow.
> o More verbose sysctl description added.
>
> MFC after: 2 weeks
> Sponsored by: Nginx, Inc.
>
> M
Author: rmacklem
Date: Thu Feb 23 16:47:05 2012
New Revision: 232050
URL: http://svn.freebsd.org/changeset/base/232050
Log:
hrs@ reported a panic to freebsd-stable@ under the subject line
"panic in 8.3-PRERELEASE" on Feb. 22, 2012. This panic was caused
by use of a mix of tsleep() and msleep
Author: rmacklem
Date: Thu Feb 23 04:32:41 2012
New Revision: 232018
URL: http://svn.freebsd.org/changeset/base/232018
Log:
MFC: r231805
Delete a couple of out of date comments that are no longer true in
the new NFS client.
Modified:
stable/9/sys/fs/nfs/nfs_commonport.c
stable/9/sys/fs/
Author: rmacklem
Date: Thu Feb 16 02:19:53 2012
New Revision: 231805
URL: http://svn.freebsd.org/changeset/base/231805
Log:
Delete a couple of out of date comments that are no longer true in
the new NFS client.
Requested by: bde
MFC after:1 week
Modified:
head/sys/fs/nfs/nfs_comm
Author: rmacklem
Date: Tue Feb 14 05:12:52 2012
New Revision: 231637
URL: http://svn.freebsd.org/changeset/base/231637
Log:
MFC: r230803
When a "mount -u" switches an NFS mount point from TCP to UDP,
any thread doing an I/O RPC with a transfer size greater than
NFS_UDPMAXDATA will be hung
Author: rmacklem
Date: Tue Feb 14 04:48:36 2012
New Revision: 231636
URL: http://svn.freebsd.org/changeset/base/231636
Log:
MFC: r230803
When a "mount -u" switches an NFS mount point from TCP to UDP,
any thread doing an I/O RPC with a transfer size greater than
NFS_UDPMAXDATA will be hung
Author: rmacklem
Date: Tue Feb 14 04:07:35 2012
New Revision: 231633
URL: http://svn.freebsd.org/changeset/base/231633
Log:
MFC: r230801
jwd@ reported a problem via email to freebsd-fs@ on Aug 25, 2011
under the subject "F_RDLCK lock to FreeBSD NFS fails to R/O target file".
This occurred
Author: rmacklem
Date: Sun Feb 12 06:41:29 2012
New Revision: 231547
URL: http://svn.freebsd.org/changeset/base/231547
Log:
MFC: r231133
r228827 fixed a problem where copying of NFSv4 open credentials into
a credential structure would corrupt it. This happened when the
p argument was != NU
Author: rmacklem
Date: Sun Feb 12 06:01:49 2012
New Revision: 231545
URL: http://svn.freebsd.org/changeset/base/231545
Log:
MFC: r231133
r228827 fixed a problem where copying of NFSv4 open credentials into
a credential structure would corrupt it. This happened when the
p argument was != NU
Author: rmacklem
Date: Fri Feb 10 04:01:17 2012
New Revision: 231332
URL: http://svn.freebsd.org/changeset/base/231332
Log:
MFC: r230605
A problem with respect to data read through the buffer cache for both
NFS clients was reported to freebsd-fs@ under the subject "NFS
corruption in recent
Author: rmacklem
Date: Fri Feb 10 03:32:29 2012
New Revision: 231330
URL: http://svn.freebsd.org/changeset/base/231330
Log:
MFC: r230605
A problem with respect to data read through the buffer cache for both
NFS clients was reported to freebsd-fs@ under the subject "NFS
corruption in recent
Author: rmacklem
Date: Tue Feb 7 16:32:43 2012
New Revision: 231133
URL: http://svn.freebsd.org/changeset/base/231133
Log:
r228827 fixed a problem where copying of NFSv4 open credentials into
a credential structure would corrupt it. This happened when the
p argument was != NULL. However, I
Author: rmacklem
Date: Fri Feb 3 03:41:43 2012
New Revision: 230930
URL: http://svn.freebsd.org/changeset/base/230930
Log:
MFC: r230345
Martin Cracauer reported a problem to freebsd-current@ under the
subject "Data corruption over NFS in -current". During investigation
of this, I came acr
Author: rmacklem
Date: Fri Feb 3 03:05:41 2012
New Revision: 230928
URL: http://svn.freebsd.org/changeset/base/230928
Log:
MFC: r230345
Martin Cracauer reported a problem to freebsd-current@ under the
subject "Data corruption over NFS in -current". During investigation
of this, I came acr
Author: rmacklem
Date: Tue Jan 31 03:58:26 2012
New Revision: 230803
URL: http://svn.freebsd.org/changeset/base/230803
Log:
When a "mount -u" switches an NFS mount point from TCP to UDP,
any thread doing an I/O RPC with a transfer size greater than
NFS_UDPMAXDATA will be hung indefinitely, r
Author: rmacklem
Date: Tue Jan 31 02:11:05 2012
New Revision: 230801
URL: http://svn.freebsd.org/changeset/base/230801
Log:
jwd@ reported a problem via email to freebsd-fs@ on Aug 25, 2011
under the subject "F_RDLCK lock to FreeBSD NFS fails to R/O target file".
This occurred because the ser
Author: rmacklem
Date: Sat Jan 28 02:18:50 2012
New Revision: 230638
URL: http://svn.freebsd.org/changeset/base/230638
Log:
MFC: r230100
Tai Horgan reported via email that there were two places in
the new NFSv4 server where the code follows the wrong list.
Fortunately, for these fairly rar
Author: rmacklem
Date: Sat Jan 28 01:45:19 2012
New Revision: 230637
URL: http://svn.freebsd.org/changeset/base/230637
Log:
MFC: r230100
Tai Horgan reported via email that there were two places in
the new NFSv4 server where the code follows the wrong list.
Fortunately, for these fairly rar
Bruce Evans wrote:
> On Thu, 26 Jan 2012, Rick Macklem wrote:
>
> > Bruce Evans wrote:
> >
> >> Doesn't umount -f have to wait for i/o anyway? When it closes
> >> files,
> >> it must wait for all in-progress i/o for the files, and for all new
&g
Author: rmacklem
Date: Fri Jan 27 02:46:12 2012
New Revision: 230605
URL: http://svn.freebsd.org/changeset/base/230605
Log:
A problem with respect to data read through the buffer cache for both
NFS clients was reported to freebsd-fs@ under the subject "NFS
corruption in recent HEAD" on Nov.
Bruce Evans wrote:
> On Wed, 25 Jan 2012, Rick Macklem wrote:
>
> > Bruce Evans wrote:
> >> On Tue, 24 Jan 2012, Rick Macklem wrote:
> >>
> >>> Bruce Evans wrote:
> >>>> On Wed, 25 Jan 2012, Rick Macklem wrote:
> >>>>
> &
Author: rmacklem
Date: Thu Jan 26 00:07:34 2012
New Revision: 230559
URL: http://svn.freebsd.org/changeset/base/230559
Log:
Revert r230516, since it doesn't really fix the problem.
Modified:
head/sys/fs/nfsclient/nfs_clvfsops.c
head/sys/nfsclient/nfs_vfsops.c
Modified: head/sys/fs/nfsclien
Bruce Evans wrote:
> On Tue, 24 Jan 2012, Rick Macklem wrote:
>
> > Bruce Evans wrote:
> >> On Wed, 25 Jan 2012, Rick Macklem wrote:
> >>
> >>> Log:
> >>> If a mount -u is done to either NFS client that switches it
> >>> from
Bruce Evans wrote:
> On Wed, 25 Jan 2012, Rick Macklem wrote:
>
> > Log:
> > If a mount -u is done to either NFS client that switches it
> > from TCP to UDP and the rsize/wsize/readdirsize is greater
> > than NFS_MAXDGRAMDATA, it is possible for a thread doin
Author: rmacklem
Date: Wed Jan 25 02:22:16 2012
New Revision: 230521
URL: http://svn.freebsd.org/changeset/base/230521
Log:
MFC: r229956
jwd@ reported via email that the "CacheSize" field reported by "nfsstat -e -s"
would go negative after using the "-z" option to zero out the stats.
This
Author: rmacklem
Date: Wed Jan 25 01:45:19 2012
New Revision: 230518
URL: http://svn.freebsd.org/changeset/base/230518
Log:
MFC: r229956
jwd@ reported via email that the "CacheSize" field reported by "nfsstat -e -s"
would go negative after using the "-z" option to zero out the stats.
This
Author: rmacklem
Date: Wed Jan 25 00:22:53 2012
New Revision: 230516
URL: http://svn.freebsd.org/changeset/base/230516
Log:
If a mount -u is done to either NFS client that switches it
from TCP to UDP and the rsize/wsize/readdirsize is greater
than NFS_MAXDGRAMDATA, it is possible for a threa
Author: rmacklem
Date: Sun Jan 22 06:00:50 2012
New Revision: 230448
URL: http://svn.freebsd.org/changeset/base/230448
Log:
MFC: r229802
opt_inet6.h was missing from some files in the new NFS subsystem.
The effect of this was, for clients mounted via inet6 addresses,
that the DRC cache wou
Author: rmacklem
Date: Sun Jan 22 05:16:31 2012
New Revision: 230446
URL: http://svn.freebsd.org/changeset/base/230446
Log:
MFC: r229802
opt_inet6.h was missing from some files in the new NFS subsystem.
The effect of this was, for clients mounted via inet6 addresses,
that the DRC cache wou
Author: rmacklem
Date: Fri Jan 20 00:58:51 2012
New Revision: 230345
URL: http://svn.freebsd.org/changeset/base/230345
Log:
Martin Cracauer reported a problem to freebsd-current@ under the
subject "Data corruption over NFS in -current". During investigation
of this, I came across an ugly bog
Author: rmacklem
Date: Sat Jan 14 04:04:58 2012
New Revision: 230100
URL: http://svn.freebsd.org/changeset/base/230100
Log:
Tai Horgan reported via email that there were two places in
the new NFSv4 server where the code follows the wrong list.
Fortunately, for these fairly rare cases, the lc
Author: rmacklem
Date: Wed Jan 11 02:46:42 2012
New Revision: 229956
URL: http://svn.freebsd.org/changeset/base/229956
Log:
jwd@ reported via email that the "CacheSize" field reported by "nfsstat -e -s"
would go negative after using the "-z" option to zero out the stats.
This patch fixes tha
Author: rmacklem
Date: Wed Jan 11 01:58:49 2012
New Revision: 229955
URL: http://svn.freebsd.org/changeset/base/229955
Log:
MFC: r228827
During investigation of an NFSv4 client crash reported by glebius@,
jhb@ spotted that nfscl_getstateid() might modify credentials when
called from nfsrpc
Author: rmacklem
Date: Wed Jan 11 01:24:35 2012
New Revision: 229953
URL: http://svn.freebsd.org/changeset/base/229953
Log:
MFC: r228827
During investigation of an NFSv4 client crash reported by glebius@,
jhb@ spotted that nfscl_getstateid() might modify credentials when
called from nfsrpc
Author: rmacklem
Date: Tue Jan 10 02:55:43 2012
New Revision: 229906
URL: http://svn.freebsd.org/changeset/base/229906
Log:
MFC: r228757
jwd@ reported a problem via email where the old NFS client would
get a reply of EEXIST from an NFS server when a Mkdir RPC was retried,
for an NFS over U
Author: rmacklem
Date: Tue Jan 10 02:16:38 2012
New Revision: 229902
URL: http://svn.freebsd.org/changeset/base/229902
Log:
MFC: r228757
jwd@ reported a problem via email where the old NFS client would
get a reply of EEXIST from an NFS server when a Mkdir RPC was retried,
for an NFS over U
Thanks John. Sorry about that. Pointy hat goes on me.
rick
ps: I probably shouldn't have merged in into stable/8, but
since you've fixed it, it might as well stay there.
- Original Message -
> Author: jhb
> Date: Mon Jan 9 18:46:03 2012
> New Revision: 229861
> URL: http://svn.freebsd
Author: rmacklem
Date: Sun Jan 8 23:30:23 2012
New Revision: 229830
URL: http://svn.freebsd.org/changeset/base/229830
Log:
MFC: r228560
Patch the new NFS server in a manner analagous to r228520 for the
old NFS server, so that it correctly handles a count == 0 argument
for Commit.
Modifie
Author: rmacklem
Date: Sun Jan 8 23:05:36 2012
New Revision: 229827
URL: http://svn.freebsd.org/changeset/base/229827
Log:
MFC: r228560
Patch the new NFS server in a manner analagous to r228520 for the
old NFS server, so that it correctly handles a count == 0 argument
for Commit.
Modifie
Author: rmacklem
Date: Sun Jan 8 01:54:46 2012
New Revision: 229802
URL: http://svn.freebsd.org/changeset/base/229802
Log:
opt_inet6.h was missing from some files in the new NFS subsystem.
The effect of this was, for clients mounted via inet6 addresses,
that the DRC cache would never have a
Author: rmacklem
Date: Sun Jan 8 01:09:00 2012
New Revision: 229801
URL: http://svn.freebsd.org/changeset/base/229801
Log:
MFC: r228260
This patch adds a sysctl to the NFSv4 server which optionally disables the
check for a UTF-8 compliant file name. Enabling this sysctl results in
an NFSv
Author: rmacklem
Date: Sun Jan 8 00:42:07 2012
New Revision: 229799
URL: http://svn.freebsd.org/changeset/base/229799
Log:
MFC: r228260
This patch adds a sysctl to the NFSv4 server which optionally disables the
check for a UTF-8 compliant file name. Enabling this sysctl results in
an NFSv
Author: rmacklem
Date: Sat Jan 7 02:09:49 2012
New Revision: 229759
URL: http://svn.freebsd.org/changeset/base/229759
Log:
MFC: r228217
Post r223774, the NFSv4 client no longer has multiple instances
of the same lock_owner4 string. As such, the handling of cleanup
of lock_owners could be
Author: rmacklem
Date: Sat Jan 7 00:36:17 2012
New Revision: 229752
URL: http://svn.freebsd.org/changeset/base/229752
Log:
MFC: r228217
Post r223774, the NFSv4 client no longer has multiple instances
of the same lock_owner4 string. As such, the handling of cleanup
of lock_owners could be
Author: rmacklem
Date: Fri Jan 6 02:23:33 2012
New Revision: 229679
URL: http://svn.freebsd.org/changeset/base/229679
Log:
MFC: r227796
Clean up some cruft in the NFSv4 client left over from the
OpenBSD port, so that it is more readable. No logic change
is made by this commit.
Modified:
Author: rmacklem
Date: Fri Jan 6 01:57:41 2012
New Revision: 229678
URL: http://svn.freebsd.org/changeset/base/229678
Log:
MFC: r227796
Clean up some cruft in the NFSv4 client left over from the
OpenBSD port, so that it is more readable. No logic change
is made by this commit.
Modified:
Author: rmacklem
Date: Fri Jan 6 01:20:48 2012
New Revision: 229676
URL: http://svn.freebsd.org/changeset/base/229676
Log:
MFC: r227760
Add two arguments to the nfsrpc_rellockown() function in the NFSv4
client. This does not change the client's behaviour, but prepares
the code so that nfs
Author: rmacklem
Date: Fri Jan 6 00:42:32 2012
New Revision: 229674
URL: http://svn.freebsd.org/changeset/base/229674
Log:
MFC: r227760
Add two arguments to the nfsrpc_rellockown() function in the NFSv4
client. This does not change the client's behaviour, but prepares
the code so that nfs
Author: rmacklem
Date: Thu Jan 5 17:20:03 2012
New Revision: 229603
URL: http://svn.freebsd.org/changeset/base/229603
Log:
MFC: r227744
Since the nfscl_cleanup() function isn't used by the FreeBSD NFSv4 client,
delete the code and fix up the related comments. This should not have
any func
Author: rmacklem
Date: Thu Jan 5 16:43:54 2012
New Revision: 229599
URL: http://svn.freebsd.org/changeset/base/229599
Log:
MFC: r227744
Since the nfscl_cleanup() function isn't used by the FreeBSD NFSv4 client,
delete the code and fix up the related comments. This should not have
any func
Author: rmacklem
Date: Thu Jan 5 02:05:15 2012
New Revision: 229552
URL: http://svn.freebsd.org/changeset/base/229552
Log:
MFC: r227743
Post r223774 the NFSv4 client never uses the linked list with the
head nfsc_defunctlockowner. This patch simply removes the code that
loops through this
Author: rmacklem
Date: Thu Jan 5 01:25:47 2012
New Revision: 229548
URL: http://svn.freebsd.org/changeset/base/229548
Log:
MFC: r227743
Post r223774 the NFSv4 client never uses the linked list with the
head nfsc_defunctlockowner. This patch simply removes the code that
loops through this
Author: rmacklem
Date: Wed Jan 4 00:51:05 2012
New Revision: 229451
URL: http://svn.freebsd.org/changeset/base/229451
Log:
MFC: r227690
The old NFS client will crash due to the reply being m_freem()'d
twice if the server bogusly returns an error with the NFSERR_RETERR
bit (bit 31) set. No
Author: rmacklem
Date: Wed Jan 4 00:24:09 2012
New Revision: 229450
URL: http://svn.freebsd.org/changeset/base/229450
Log:
MFC: r227690
The old NFS client will crash due to the reply being m_freem()'d
twice if the server bogusly returns an error with the NFSERR_RETERR
bit (bit 31) set. No
Author: rmacklem
Date: Tue Jan 3 16:32:33 2012
New Revision: 229391
URL: http://svn.freebsd.org/changeset/base/229391
Log:
MFC: r227690
The old NFS client will crash due to the reply being m_freem()'d
twice if the server bogusly returns an error with the NFSERR_RETERR
bit (bit 31) set. No
Author: rmacklem
Date: Tue Jan 3 04:12:40 2012
New Revision: 229365
URL: http://svn.freebsd.org/changeset/base/229365
Log:
MFC: r227543
Modify the new NFS client so that nfs_fsync() only calls ncl_flush()
for regular files. Since other file types don't write into the
buffer cache, calling
Author: rmacklem
Date: Mon Jan 2 16:54:21 2012
New Revision: 229287
URL: http://svn.freebsd.org/changeset/base/229287
Log:
MFC: r227543
Modify the new NFS client so that nfs_fsync() only calls ncl_flush()
for regular files. Since other file types don't write into the
buffer cache, calling
Author: rmacklem
Date: Mon Jan 2 04:47:38 2012
New Revision: 229264
URL: http://svn.freebsd.org/changeset/base/229264
Log:
MFC: r227517
Move the setting of the default value for nm_wcommitsize to
before the nfs_decode_args() call in the new NFS client, so
that a specfied command line valu
Author: rmacklem
Date: Mon Jan 2 04:25:25 2012
New Revision: 229263
URL: http://svn.freebsd.org/changeset/base/229263
Log:
MFC: r227517
Move the setting of the default value for nm_wcommitsize to
before the nfs_decode_args() call in the new NFS client, so
that a specfied command line valu
Author: rmacklem
Date: Mon Jan 2 03:52:34 2012
New Revision: 229259
URL: http://svn.freebsd.org/changeset/base/229259
Log:
MFC: r227494
Since NFSv4 byte range locking only works for regular files,
add a sanity check for the vnode type to the NFSv4 client.
Modified:
stable/8/sys/fs/nfscli
Author: rmacklem
Date: Mon Jan 2 03:26:59 2012
New Revision: 229258
URL: http://svn.freebsd.org/changeset/base/229258
Log:
MFC: r227494
Since NFSv4 byte range locking only works for regular files,
add a sanity check for the vnode type to the NFSv4 client.
Modified:
stable/9/sys/fs/nfscli
Author: rmacklem
Date: Sun Jan 1 17:05:24 2012
New Revision: 229173
URL: http://svn.freebsd.org/changeset/base/229173
Log:
MFC: r227493
Move the assignment of default values for some mount options
to before the nfs_decode_args() call in the new NFS client,
so they don't overwrite the valu
Author: rmacklem
Date: Sun Jan 1 16:41:33 2012
New Revision: 229172
URL: http://svn.freebsd.org/changeset/base/229172
Log:
MFC: r227493
Move the assignment of default values for some mount options
to before the nfs_decode_args() call in the new NFS client,
so they don't overwrite the valu
Author: rmacklem
Date: Fri Dec 23 02:04:35 2011
New Revision: 228827
URL: http://svn.freebsd.org/changeset/base/228827
Log:
During investigation of an NFSv4 client crash reported by glebius@,
jhb@ spotted that nfscl_getstateid() might modify credentials when
called from nfsrpc_read() for the
Author: rmacklem
Date: Wed Dec 21 02:45:51 2011
New Revision: 228757
URL: http://svn.freebsd.org/changeset/base/228757
Log:
jwd@ reported a problem via email where the old NFS client would
get a reply of EEXIST from an NFS server when a Mkdir RPC was retried,
for an NFS over UDP mount.
Upo
Author: rmacklem
Date: Fri Dec 16 00:58:41 2011
New Revision: 228560
URL: http://svn.freebsd.org/changeset/base/228560
Log:
Patch the new NFS server in a manner analagous to r228520 for the
old NFS server, so that it correctly handles a count == 0 argument
for Commit.
PR: kern
Author: rmacklem
Date: Sun Dec 4 16:33:04 2011
New Revision: 228260
URL: http://svn.freebsd.org/changeset/base/228260
Log:
This patch adds a sysctl to the NFSv4 server which optionally disables the
check for a UTF-8 compliant file name. Enabling this sysctl results in
an NFSv4 server that i
Author: rmacklem
Date: Sat Dec 3 02:27:26 2011
New Revision: 228217
URL: http://svn.freebsd.org/changeset/base/228217
Log:
Post r223774, the NFSv4 client no longer has multiple instances
of the same lock_owner4 string. As such, the handling of cleanup
of lock_owners could be simplified. Thi
Mark Saad wrote:
> On Thu, Nov 17, 2011 at 1:36 PM, Alfred Perlstein
> wrote:
> > * Rick Macklem [16 21:16] wrote:
> >> Alfred Perlstein wrote:
> >> > Rick, I have a question, what will happen if the
> >> > nfs_freesillyrename()
> >> &g
Author: rmacklem
Date: Tue Nov 22 01:32:57 2011
New Revision: 227810
URL: http://svn.freebsd.org/changeset/base/227810
Log:
MFC: r227059
Both a crash reported on freebsd-current on Oct. 18 under the
subject heading "mtx_lock() of destroyed mutex on NFS" and
PR# 156168 appear to be caused b
Author: rmacklem
Date: Tue Nov 22 00:35:30 2011
New Revision: 227809
URL: http://svn.freebsd.org/changeset/base/227809
Log:
This patch enables the new/default NFS server's use of shared
vnode locking for read, readdir, readlink, getattr and access.
It is hoped that this will improve server p
Author: rmacklem
Date: Mon Nov 21 16:06:23 2011
New Revision: 227796
URL: http://svn.freebsd.org/changeset/base/227796
Log:
Clean up some cruft in the NFSv4 client left over from the
OpenBSD port, so that it is more readable. No logic change
is made by this commit.
MFC after:2 weeks
Author: rmacklem
Date: Sun Nov 20 16:46:50 2011
New Revision: 227760
URL: http://svn.freebsd.org/changeset/base/227760
Log:
Add two arguments to the nfsrpc_rellockown() function in the NFSv4
client. This does not change the client's behaviour, but prepares
the code so that nfsrpc_rellockown(
Author: rmacklem
Date: Sun Nov 20 01:18:47 2011
New Revision: 227744
URL: http://svn.freebsd.org/changeset/base/227744
Log:
Since the nfscl_cleanup() function isn't used by the FreeBSD NFSv4 client,
delete the code and fix up the related comments. This should not have
any functional effect o
Author: rmacklem
Date: Sun Nov 20 00:39:15 2011
New Revision: 227743
URL: http://svn.freebsd.org/changeset/base/227743
Log:
Post r223774 the NFSv4 client never uses the linked list with the
head nfsc_defunctlockowner. This patch simply removes the code that
loops through this always empty li
Author: rmacklem
Date: Sat Nov 19 03:20:15 2011
New Revision: 227690
URL: http://svn.freebsd.org/changeset/base/227690
Log:
The old NFS client will crash due to the reply being m_freem()'d
twice if the server bogusly returns an error with the NFSERR_RETERR
bit (bit 31) set. No actual NFS err
Author: rmacklem
Date: Thu Nov 17 16:38:22 2011
New Revision: 227631
URL: http://svn.freebsd.org/changeset/base/227631
Log:
MFC: r227059
Both a crash reported on freebsd-current on Oct. 18 under the
subject heading "mtx_lock() of destroyed mutex on NFS" and
PR# 156168 appear to be caused b
Author: rmacklem
Date: Thu Nov 17 16:08:46 2011
New Revision: 227630
URL: http://svn.freebsd.org/changeset/base/227630
Log:
MFC: r227059
Both a crash reported on freebsd-current on Oct. 18 under the
subject heading "mtx_lock() of destroyed mutex on NFS" and
PR# 156168 appear to be caused b
is fixes is a LOR that would occur when the vrele() on
the directory was done by the thread doing VOP_INACTIVE(), since it
already has the file vnode lock and the vrele() was locking the parent
directory. This could cause a fairly rare deadlock.
rick
> -Alfred
>
> * Rick Macklem [15
Author: rmacklem
Date: Thu Nov 17 01:02:45 2011
New Revision: 227601
URL: http://svn.freebsd.org/changeset/base/227601
Log:
MFC: r227059
Both a crash reported on freebsd-current on Oct. 18 under the
subject heading "mtx_lock() of destroyed mutex on NFS" and
PR# 156168 appear to be caused b
Author: rmacklem
Date: Wed Nov 16 05:05:13 2011
New Revision: 227549
URL: http://svn.freebsd.org/changeset/base/227549
Log:
MFC: r224604
Fix a LOR in the NFS client which could cause a deadlock.
This was reported to the mailing list freebsd-...@freebsd.org
on July 21, 2011 under the subjec
Author: rmacklem
Date: Tue Nov 15 23:35:43 2011
New Revision: 227543
URL: http://svn.freebsd.org/changeset/base/227543
Log:
Modify the new NFS client so that nfs_fsync() only calls ncl_flush()
for regular files. Since other file types don't write into the
buffer cache, calling ncl_flush() is
Author: rmacklem
Date: Tue Nov 15 01:39:02 2011
New Revision: 227517
URL: http://svn.freebsd.org/changeset/base/227517
Log:
Move the setting of the default value for nm_wcommitsize to
before the nfs_decode_args() call in the new NFS client, so
that a specfied command line value won't be over
Author: rmacklem
Date: Mon Nov 14 00:10:11 2011
New Revision: 227494
URL: http://svn.freebsd.org/changeset/base/227494
Log:
Since NFSv4 byte range locking only works for regular files,
add a sanity check for the vnode type to the NFSv4 client.
MFC after:2 weeks
Modified:
head/sys/f
Author: rmacklem
Date: Sun Nov 13 23:09:26 2011
New Revision: 227493
URL: http://svn.freebsd.org/changeset/base/227493
Log:
Move the assignment of default values for some mount options
to before the nfs_decode_args() call in the new NFS client,
so they don't overwrite the value specified on
Author: rmacklem
Date: Thu Nov 3 14:38:03 2011
New Revision: 227059
URL: http://svn.freebsd.org/changeset/base/227059
Log:
Both a crash reported on freebsd-current on Oct. 18 under the
subject heading "mtx_lock() of destroyed mutex on NFS" and
PR# 156168 appear to be caused by clnt_dg_destr
Author: rmacklem
Date: Sun Oct 30 02:36:49 2011
New Revision: 226926
URL: http://svn.freebsd.org/changeset/base/226926
Log:
MFC: r225537
Modify vfs_register() to use a hash calculation
on vfc_name to set vfc_typenum, so that vfc_typenum doesn't
change when file systems are loaded in differ
Author: rmacklem
Date: Mon Oct 10 14:35:26 2011
New Revision: 226213
URL: http://svn.freebsd.org/changeset/base/226213
Log:
MFC: r226081, r226104
A crash reported on freebsd-fs@ on Sep. 23, 2011 under the subject
heading "kernel panics with RPCSEC_GSS" appears to be caused by a
corrupted t
Author: rmacklem
Date: Mon Oct 10 13:51:21 2011
New Revision: 226209
URL: http://svn.freebsd.org/changeset/base/226209
Log:
MFC: r226081, r226104
A crash reported on freebsd-fs@ on Sep. 23, 2011 under the subject
heading "kernel panics with RPCSEC_GSS" appears to be caused by a
corrupted t
Author: rmacklem
Date: Fri Oct 7 13:16:21 2011
New Revision: 226104
URL: http://svn.freebsd.org/changeset/base/226104
Log:
Remove an extraneous "already" from a comment introduced by r226081.
Submitted by: bf1783 at googlemail.com
MFC after:3 days
Modified:
head/sys/rpc/rpcsec_gss
Author: rmacklem
Date: Fri Oct 7 01:15:04 2011
New Revision: 226081
URL: http://svn.freebsd.org/changeset/base/226081
Log:
A crash reported on freebsd-fs@ on Sep. 23, 2011 under the subject
heading "kernel panics with RPCSEC_GSS" appears to be caused by a
corrupted tailq list for the client
Author: rmacklem
Date: Tue Sep 13 21:01:26 2011
New Revision: 225537
URL: http://svn.freebsd.org/changeset/base/225537
Log:
Modify vfs_register() to use a hash calculation
on vfc_name to set vfc_typenum, so that vfc_typenum doesn't
change when file systems are loaded in different orders. Thi
Author: rmacklem
Date: Thu Sep 8 00:45:28 2011
New Revision: 225442
URL: http://svn.freebsd.org/changeset/base/225442
Log:
MFC: r225109
Fix nfsstat(1) so that it prints out correct stats for the
new NFS server when the "-w" option is used. The problem was
spotted by hrs@ during testing wh
Author: rmacklem
Date: Sat Sep 3 01:45:37 2011
New Revision: 225358
URL: http://svn.freebsd.org/changeset/base/225358
Log:
MFC: r225049
Fix the NFSv4 server so that it returns NFSERR_SYMLINK when
an attempt to do an Open operation on any type of file other
than VREG is done. A recent disc
1101 - 1200 of 1741 matches
Mail list logo