svn commit: r224860 - stable/8/sys/fs/nfsserver

2011-08-13 Thread Rick Macklem
Author: rmacklem Date: Sun Aug 14 00:55:18 2011 New Revision: 224860 URL: http://svn.freebsd.org/changeset/base/224860 Log: MFC: r224554 Fix rename in the new NFS server so that it does not require a recursive vnode lock on the directory for the case where the new file name is in the same

svn commit: r224606 - head/sys/fs/nfsclient

2011-08-02 Thread Rick Macklem
Author: rmacklem Date: Tue Aug 2 11:28:42 2011 New Revision: 224606 URL: http://svn.freebsd.org/changeset/base/224606 Log: Fix a LOR in the NFS client which could cause a deadlock. This was reported to the mailing list freebsd-...@freebsd.org on July 21, 2011 under the subject LOR with

svn commit: r224554 - head/sys/fs/nfsserver

2011-07-31 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 31 20:06:11 2011 New Revision: 224554 URL: http://svn.freebsd.org/changeset/base/224554 Log: Fix rename in the new NFS server so that it does not require a recursive vnode lock on the directory for the case where the new file name is in the same directory as

svn commit: r224534 - stable/8/sys/fs/nfs

2011-07-30 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 30 23:42:15 2011 New Revision: 224534 URL: http://svn.freebsd.org/changeset/base/224534 Log: MFC: r224117 The new NFSv4 client handled NFSERR_GRACE as a fatal error for the remove and rename operations. Some NFSv4 servers will report NFSERR_GRACE for these

svn commit: r224487 - stable/8/sys/fs/nfsclient

2011-07-28 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 28 21:00:46 2011 New Revision: 224487 URL: http://svn.freebsd.org/changeset/base/224487 Log: MFC: r223971 r222389 introduced a case where the NFSv4 client could loop in nfscl_getcl() when a forced dismount is in progress, because nfsv4_lock() will return 0

svn commit: r224461 - stable/8/usr.sbin/mountd

2011-07-26 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 26 20:51:58 2011 New Revision: 224461 URL: http://svn.freebsd.org/changeset/base/224461 Log: MFC: r223954 Try and fix the exports.5 man page so that it clarifies how NFSv4 exports are handled. Improved by comments from mckusick, kudak at mit.edu and bde.

svn commit: r224203 - stable/8/sys/fs/nfsclient

2011-07-18 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 18 21:04:35 2011 New Revision: 224203 URL: http://svn.freebsd.org/changeset/base/224203 Log: MFC: r223774 The algorithm used by nfscl_getopen() could have resulted in multiple instances of the same lock_owner when a process both inherited an open file

svn commit: r224149 - in stable/8/sys/fs: nfs nfsclient

2011-07-17 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 17 20:49:38 2011 New Revision: 224149 URL: http://svn.freebsd.org/changeset/base/224149 Log: MFC: r223747 Modify the new NFSv4 client so that it appends a file handle to the lock_owner4 string that goes on the wire. Also, add code to do a ReleaseLockOwner Op

svn commit: r224117 - head/sys/fs/nfs

2011-07-16 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 16 20:53:27 2011 New Revision: 224117 URL: http://svn.freebsd.org/changeset/base/224117 Log: The new NFSv4 client handled NFSERR_GRACE as a fatal error for the remove and rename operations. Some NFSv4 servers will report NFSERR_GRACE for these operations. This

svn commit: r223954 - head/usr.sbin/mountd

2011-07-12 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 12 14:04:36 2011 New Revision: 223954 URL: http://svn.freebsd.org/changeset/base/223954 Log: Try and fix the exports.5 man page so that it clarifies how NFSv4 exports are handled. Improved by informal review comments from mckusick, kudak at mit.edu and bde.

svn commit: r223968 - in stable/8/sys/fs: nfs nfsclient

2011-07-12 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 12 21:01:09 2011 New Revision: 223968 URL: http://svn.freebsd.org/changeset/base/223968 Log: MFC: r223657 Fix the new NFSv4 client so that it doesn't fill the cached mode attribute in as 0 when doing writes. The change adds the Mode attribute plus the others

svn commit: r223971 - head/sys/fs/nfsclient

2011-07-12 Thread Rick Macklem
Author: rmacklem Date: Wed Jul 13 00:48:36 2011 New Revision: 223971 URL: http://svn.freebsd.org/changeset/base/223971 Log: r222389 introduced a case where the NFSv4 client could loop in nfscl_getcl() when a forced dismount is in progress, because nfsv4_lock() will return 0 without sleeping

svn commit: r223847 - head/etc/rc.d

2011-07-07 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 7 20:59:42 2011 New Revision: 223847 URL: http://svn.freebsd.org/changeset/base/223847 Log: Fix the /etc/rc.d/nfsd script so that it no longer uses the /etc/rc.d/nfsserver script to load the old nfs server module. Tested by:sgk at

svn commit: r223848 - stable/8

2011-07-07 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 7 22:30:12 2011 New Revision: 223848 URL: http://svn.freebsd.org/changeset/base/223848 Log: MFC: r221333 Remove usr/include/nfs/krpc.h and usr/include/nfs/nfsdiskless.h from ObsoleteFiles.inc, since these files have been reincarnated in the new NFS

svn commit: r223852 - in head: . etc/rc.d

2011-07-07 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 8 00:49:50 2011 New Revision: 223852 URL: http://svn.freebsd.org/changeset/base/223852 Log: Delete the /etc/rc.d/nfsserver script, since it is no longer used by /etc/rc.d/nfsd and it is no longer necessary to load the old nfs server by default, when

svn commit: r223829 - stable/8/sys/fs/nfs

2011-07-06 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 7 00:14:20 2011 New Revision: 223829 URL: http://svn.freebsd.org/changeset/base/223829 Log: MFC: r223436 Fix the new NFSv4 client so that it uses the same uid as was used for doing a mount when performing system operations on AUTH_SYS mounts. This resolved

svn commit: r223830 - stable/8/sys/fs/nfs

2011-07-06 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 7 00:30:34 2011 New Revision: 223830 URL: http://svn.freebsd.org/changeset/base/223830 Log: MFC: r223441 Plug an mbuf leak in the new NFS client that occurred when a server replied NFS3ERR_JUKEBOX/NFS4ERR_DELAY to an rpc. This affected both NFSv3 and NFSv4.

svn commit: r223794 - head

2011-07-05 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 5 18:40:19 2011 New Revision: 223794 URL: http://svn.freebsd.org/changeset/base/223794 Log: Delete files made obsolete by the change in default NFS client and the move of nfs_kdtrace.h to sys/nfs. Modified: head/ObsoleteFiles.inc Modified:

svn commit: r223802 - head

2011-07-05 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 5 19:26:58 2011 New Revision: 223802 URL: http://svn.freebsd.org/changeset/base/223802 Log: Delete files made obsolete because they were moved to sys/nfs in order to be shared by both NFS clients. Modified: head/ObsoleteFiles.inc Modified:

svn commit: r223774 - head/sys/fs/nfsclient

2011-07-04 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 4 23:32:09 2011 New Revision: 223774 URL: http://svn.freebsd.org/changeset/base/223774 Log: The algorithm used by nfscl_getopen() could have resulted in multiple instances of the same lock_owner when a process both inherited an open file descriptor plus

svn commit: r223775 - stable/8/sys/fs/nfsserver

2011-07-04 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 5 01:58:09 2011 New Revision: 223775 URL: http://svn.freebsd.org/changeset/base/223775 Log: MFC: r223373 Fix the new NFSv4 server so that it checks for VREAD_ACL when a client does a Getattr for an ACL and not VREAD_ATTRIBUTES. This was found during the

svn commit: r223747 - in head/sys/fs: nfs nfsclient

2011-07-03 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 3 21:44:26 2011 New Revision: 223747 URL: http://svn.freebsd.org/changeset/base/223747 Log: Modify the new NFSv4 client so that it appends a file handle to the lock_owner4 string that goes on the wire. Also, add code to do a ReleaseLockOwner Op on the

svn commit: r223748 - in stable/8/sys: fs/nfs fs/nfsclient fs/nfsserver kgssapi modules modules/kgssapi_krb5 nfsclient nfsserver rpc

2011-07-03 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 4 00:24:59 2011 New Revision: 223748 URL: http://svn.freebsd.org/changeset/base/223748 Log: MFC: r223309 Fix the kgssapi so that it can be loaded as a module. Currently the NFS subsystems use five of the rpcsec_gss/kgssapi entry points, but since it was not

svn commit: r223749 - stable/8/sys/fs/nfsserver

2011-07-03 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 4 00:45:21 2011 New Revision: 223749 URL: http://svn.freebsd.org/changeset/base/223749 Log: MFC: r223312 Fix a number of places where the new NFS server did not lock the mutex when manipulating rc_flag in the DRC cache. This is believed to fix a hung server

svn commit: r223750 - stable/8/sys/fs/nfsserver

2011-07-03 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 4 01:06:19 2011 New Revision: 223750 URL: http://svn.freebsd.org/changeset/base/223750 Log: MFC: r223348 Fix the new NFSv4 server so that it allows Access and Readlink operations while traversing non-exported file systems. This is required for some

svn commit: r223751 - stable/8/sys/fs/nfsserver

2011-07-03 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 4 01:27:41 2011 New Revision: 223751 URL: http://svn.freebsd.org/changeset/base/223751 Log: MFC: r223349 Fix the new NFSv4 server so that it only allows Lookup of directories and symbolic links when traversing non-exported file systems. Found during the

svn commit: r223657 - in head/sys/fs: nfs nfsclient

2011-06-28 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 28 22:52:38 2011 New Revision: 223657 URL: http://svn.freebsd.org/changeset/base/223657 Log: Fix the new NFSv4 client so that it doesn't fill the cached mode attribute in as 0 when doing writes. The change adds the Mode attribute plus the others except Owner

svn commit: r223516 - stable/8/usr.sbin/mountd

2011-06-24 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 24 20:15:44 2011 New Revision: 223516 URL: http://svn.freebsd.org/changeset/base/223516 Log: MFC: r216587, r222623 Fix the nfs related daemons so that they don't intermittently fail with bind: address already in use. This problem was reported to the

svn commit: r223436 - head/sys/fs/nfs

2011-06-22 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 22 19:47:45 2011 New Revision: 223436 URL: http://svn.freebsd.org/changeset/base/223436 Log: Fix the new NFSv4 client so that it uses the same uid as was used for doing a mount when performing system operations on AUTH_SYS mounts. This resolved an issue when

svn commit: r223441 - head/sys/fs/nfs

2011-06-22 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 22 21:10:12 2011 New Revision: 223441 URL: http://svn.freebsd.org/changeset/base/223441 Log: Plug an mbuf leak in the new NFS client that occurred when a server replied NFS3ERR_JUKEBOX/NFS4ERR_DELAY to an rpc. This affected both NFSv3 and NFSv4. Found during

svn commit: r223373 - head/sys/fs/nfsserver

2011-06-21 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 21 19:58:29 2011 New Revision: 223373 URL: http://svn.freebsd.org/changeset/base/223373 Log: Fix the new NFSv4 server so that it checks for VREAD_ACL when a client does a Getattr for an ACL and not VREAD_ATTRIBUTES. This was found during the recent NFSv4

svn commit: r223382 - head/usr.sbin/nfsuserd

2011-06-21 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 21 21:07:33 2011 New Revision: 223382 URL: http://svn.freebsd.org/changeset/base/223382 Log: Change the NFSv4 nfsuserd(8) daemon so that it doesn't preload the uid-username mapping cache with an entry when another entry for that uid is already loaded. This

svn commit: r223349 - head/sys/fs/nfsserver

2011-06-20 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 20 22:02:01 2011 New Revision: 223349 URL: http://svn.freebsd.org/changeset/base/223349 Log: Fix the new NFSv4 server so that it only allows Lookup of directories and symbolic links when traversing non-exported file systems. Found during the recent NFSv4

svn commit: r223348 - head/sys/fs/nfsserver

2011-06-20 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 20 21:57:26 2011 New Revision: 223348 URL: http://svn.freebsd.org/changeset/base/223348 Log: Fix the new NFSv4 server so that it allows Access and Readlink operations while traversing non-exported file systems. This is required for some non-FreeBSD clients to

svn commit: r223309 - in head/sys: fs/nfs fs/nfsclient fs/nfsserver kgssapi modules modules/kgssapi_krb5 nfsclient nfsserver rpc

2011-06-19 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 19 22:08:55 2011 New Revision: 223309 URL: http://svn.freebsd.org/changeset/base/223309 Log: Fix the kgssapi so that it can be loaded as a module. Currently the NFS subsystems use five of the rpcsec_gss/kgssapi entry points, but since it was not obvious which

svn commit: r223312 - head/sys/fs/nfsserver

2011-06-19 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 19 23:54:01 2011 New Revision: 223312 URL: http://svn.freebsd.org/changeset/base/223312 Log: Fix a number of places where the new NFS server did not lock the mutex when manipulating rc_flag in the DRC cache. This is believed to fix a hung server that was

svn commit: r223280 - in head/sys: fs/nfs fs/nfsclient modules/dtrace modules/dtrace/dtnfscl modules/dtrace/dtraceall sys

2011-06-18 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 18 23:02:53 2011 New Revision: 223280 URL: http://svn.freebsd.org/changeset/base/223280 Log: Add DTrace support to the new NFS client. This is essentially cloned from the old NFS client, plus additions for NFSv4. A review of this code is in progress, however

svn commit: r223284 - stable/8/sys/fs/nfsserver

2011-06-18 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 19 01:44:50 2011 New Revision: 223284 URL: http://svn.freebsd.org/changeset/base/223284 Log: MFC: r222663 Modify the new NFS server so that the NFSv3 Pathconf RPC doesn't return an error when the underlying file system lacks support for any of the four

svn commit: r223285 - stable/8/sys/fs/nfsclient

2011-06-18 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 19 02:03:12 2011 New Revision: 223285 URL: http://svn.freebsd.org/changeset/base/223285 Log: MFC: r222718 Fix the new NFSv4 client so that it doesn't crash when a mount is done for a VIMAGE kernel. Modified: stable/8/sys/fs/nfsclient/nfs_clport.c Directory

svn commit: r223286 - in stable/8/sys/fs: nfs nfsclient

2011-06-18 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 19 02:24:36 2011 New Revision: 223286 URL: http://svn.freebsd.org/changeset/base/223286 Log: MFC: r222719 The new NFSv4 client was erroneously using p instead of p_leader for the id for POSIX byte range locking. I think this would only have affected

svn commit: r223287 - stable/8/sys/fs/nfsclient

2011-06-18 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 19 02:39:02 2011 New Revision: 223287 URL: http://svn.freebsd.org/changeset/base/223287 Log: MFC: r222722 Add support for flock(2) locks to the new NFSv4 client. I think this should be ok, since the client now delays NFSv4 Close operations until

svn commit: r223187 - stable/8/usr.sbin/rpc.lockd

2011-06-17 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 17 16:03:00 2011 New Revision: 223187 URL: http://svn.freebsd.org/changeset/base/223187 Log: MFC: r222624 Fix the nfs related daemons so that they don't intermittently fail with bind: address already in use. This problem was reported to the freebsd-stable@

svn commit: r223191 - stable/8/usr.sbin/rpc.statd

2011-06-17 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 17 16:23:50 2011 New Revision: 223191 URL: http://svn.freebsd.org/changeset/base/223191 Log: MFC: r222627 Fix the nfs related daemons so that they don't intermittently fail with bind: address already in use. This problem was reported to the freebsd-stable@

svn commit: r223157 - stable/8/sys/fs/nfsclient

2011-06-16 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 16 19:32:00 2011 New Revision: 223157 URL: http://svn.freebsd.org/changeset/base/223157 Log: MFC: r222540 Fix the new NFS client so that it doesn't do an NFSv3 Pathconf RPC for cases where the reply doesn't include the answer. This fixes a problem reported

svn commit: r223159 - stable/8/sbin/umount

2011-06-16 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 16 19:47:56 2011 New Revision: 223159 URL: http://svn.freebsd.org/changeset/base/223159 Log: MFC: r222541 Add a sentence to the umount.8 man page to clarify the behaviour for forced dismount when used on an NFS mount point. This is a content change.

svn commit: r222993 - in head/etc: defaults rc.d

2011-06-11 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 11 21:14:22 2011 New Revision: 222993 URL: http://svn.freebsd.org/changeset/base/222993 Log: Make three one line changes to the rc scripts so that they work with the new NFS client being the default, since the new NFS client's module name is nfscl and not

svn commit: r223002 - stable/8/sys/nfsclient

2011-06-11 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 12 01:48:31 2011 New Revision: 223002 URL: http://svn.freebsd.org/changeset/base/223002 Log: MFC: r222464 Add a check for MNTK_UNMOUNTF at the beginning of nfs_sync() in the old NFS client so that a forced dismount doesn't get stuck in the VFS_SYNC() call

svn commit: r223003 - stable/8/sbin/umount

2011-06-11 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 12 02:05:59 2011 New Revision: 223003 URL: http://svn.freebsd.org/changeset/base/223003 Log: MFC: r222466 Modify the umount(8) command so that it doesn't do a sync(2) syscall before unmount(2) for the -f case. This avoids a forced dismount from getting stuck

svn commit: r222931 - in stable/8/sys/fs: nfs nfsclient nfsserver

2011-06-10 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 10 13:28:14 2011 New Revision: 222931 URL: http://svn.freebsd.org/changeset/base/222931 Log: MFC: r222389 Fix the new NFS client so that it handles NFSv4 state correctly during a forced dismount. This required that the exclusive and shared (refcnt) sleep

svn commit: r222886 - stable/8/sys/fs/nfsclient

2011-06-08 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 9 01:10:39 2011 New Revision: 222886 URL: http://svn.freebsd.org/changeset/base/222886 Log: MFC: r222329 Add a check for MNTK_UNMOUNTF at the beginning of nfs_sync() in the new NFS client so that a forced dismount doesn't get stuck in the VFS_SYNC() call

svn commit: r222842 - in stable/8/sys/fs: nfs nfsclient

2011-06-07 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 8 01:14:31 2011 New Revision: 222842 URL: http://svn.freebsd.org/changeset/base/222842 Log: MFC: r89 Fix the new NFS client so that it correctly sets the must_commit argument for a write RPC when it succeeds for the first one and fails for a subsequent

svn commit: r222844 - stable/8/sys/fs/nfsclient

2011-06-07 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 8 01:28:46 2011 New Revision: 222844 URL: http://svn.freebsd.org/changeset/base/222844 Log: MFC: r91 Add some missing mutex locking to the new NFS client. Modified: stable/8/sys/fs/nfsclient/nfs_clvnops.c Directory Properties: stable/8/sys/ (props

svn commit: r222789 - stable/8/sys/fs/nfsclient

2011-06-06 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 6 21:51:35 2011 New Revision: 222789 URL: http://svn.freebsd.org/changeset/base/222789 Log: MFC: r33 Set the MNT_NFS4ACLS flag for an NFSv4 client mount if the NFSv4 server supports it. Modified: stable/8/sys/fs/nfsclient/nfs_clvfsops.c Directory

svn commit: r222718 - head/sys/fs/nfsclient

2011-06-05 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 5 17:31:44 2011 New Revision: 222718 URL: http://svn.freebsd.org/changeset/base/222718 Log: Fix the new NFSv4 client so that it doesn't crash when a mount is done for a VIMAGE kernel. Tested by:glz at hidden-powers dot com Reviewed by: bz MFC

svn commit: r222719 - in head/sys/fs: nfs nfsclient

2011-06-05 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 5 18:17:37 2011 New Revision: 222719 URL: http://svn.freebsd.org/changeset/base/222719 Log: The new NFSv4 client was erroneously using p instead of p_leader for the id for POSIX byte range locking. I think this would only have affected processes created by

svn commit: r222663 - head/sys/fs/nfsserver

2011-06-03 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 4 01:13:09 2011 New Revision: 222663 URL: http://svn.freebsd.org/changeset/base/222663 Log: Modify the new NFS server so that the NFSv3 Pathconf RPC doesn't return an error when the underlying file system lacks support for any of the four _PC_xxx values used,

svn commit: r222623 - head/usr.sbin/mountd

2011-06-02 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 2 19:33:33 2011 New Revision: 222623 URL: http://svn.freebsd.org/changeset/base/222623 Log: Fix the nfs related daemons so that they don't intermittently fail with bind: address already in use. This problem was reported to the freebsd-stable@ mailing list on

svn commit: r222624 - head/usr.sbin/rpc.lockd

2011-06-02 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 2 19:49:47 2011 New Revision: 222624 URL: http://svn.freebsd.org/changeset/base/222624 Log: Fix the nfs related daemons so that they don't intermittently fail with bind: address already in use. This problem was reported to the freebsd-stable@ mailing list on

svn commit: r222627 - head/usr.sbin/rpc.statd

2011-06-02 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 2 20:15:32 2011 New Revision: 222627 URL: http://svn.freebsd.org/changeset/base/222627 Log: Fix the nfs related daemons so that they don't intermittently fail with bind: address already in use. This problem was reported to the freebsd-stable@ mailing list on

svn commit: r222629 - in stable/8/sys: fs/nfsclient nfsclient

2011-06-02 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 2 20:57:36 2011 New Revision: 222629 URL: http://svn.freebsd.org/changeset/base/222629 Log: MFC: r222075 Add a sanity check for the existence of an addr option to both NFS clients. This avoids the crash reported by Sergey Kandaurov (pluk...@gmail.com) to

Re: svn commit: r222466 - head/sbin/umount

2011-06-01 Thread Rick Macklem
Did you have to change VFS_SYNC() to pass the forced-dismount flag? I don't like that, but see the problem: VFS_SYNC(XXX_WAIT) should normally just try to sync everything, but return an error if this is impossible, but for an nfs server it would take too long to determine that it is

svn commit: r222540 - head/sys/fs/nfsclient

2011-05-31 Thread Rick Macklem
Author: rmacklem Date: Tue May 31 17:43:25 2011 New Revision: 222540 URL: http://svn.freebsd.org/changeset/base/222540 Log: Fix the new NFS client so that it doesn't do an NFSv3 Pathconf RPC for cases where the reply doesn't include the answer. This fixes a problem reported by avg@ where

svn commit: r222541 - head/sbin/umount

2011-05-31 Thread Rick Macklem
Author: rmacklem Date: Tue May 31 18:27:18 2011 New Revision: 222541 URL: http://svn.freebsd.org/changeset/base/222541 Log: Add a sentence to the umount.8 man page to clarify the behaviour for forced dismount when used on an NFS mount point. Requested by Jeremy Chadwick. This is a content

Re: svn commit: r222466 - head/sbin/umount

2011-05-31 Thread Rick Macklem
It is only an optimization. Any number of syncs are useless for actually syncing the system, since sync(2) only does an async sync (it returns without waiting for most writes to complete). As you pointed out later in this thread, unmount(2) does a sync that works -- a sync sync -- before

Re: svn commit: r222466 - head/sbin/umount

2011-05-30 Thread Rick Macklem
On Mon, May 30, 2011 at 01:48:53PM +0100, Robert Watson wrote: On Sun, 29 May 2011, Rick Macklem wrote: Modify the umount(8) command so that it doesn't do a sync(2) syscall before unmount(2) for the -f case. This avoids a forced dismount from getting stuck for an NFS mountpoint

Re: svn commit: r222466 - head/sbin/umount

2011-05-30 Thread Rick Macklem
No doubt. :-) If the sync(2) has actual consistency and reliability benefits, it should probably be done by the umount(2) system call, so that other future auto-mounters, etc, also get the same result, rather than having to encode it in every application. If it's done on blind faith,

Re: svn commit: r222466 - head/sbin/umount

2011-05-30 Thread Rick Macklem
If it masks, for example, lateny for a synchronous RPC to the remote mountd to deregister the mountpoint, allowing a cache flush and unmount to take place concurrently, that might be a useful benefit. I'm not sure I see any evidence that is the case in the source code, however. Well, I

svn commit: r222464 - head/sys/nfsclient

2011-05-29 Thread Rick Macklem
Author: rmacklem Date: Sun May 29 20:55:23 2011 New Revision: 222464 URL: http://svn.freebsd.org/changeset/base/222464 Log: Add a check for MNTK_UNMOUNTF at the beginning of nfs_sync() in the old NFS client so that a forced dismount doesn't get stuck in the VFS_SYNC() call that happens

svn commit: r222466 - head/sbin/umount

2011-05-29 Thread Rick Macklem
Author: rmacklem Date: Sun May 29 21:13:53 2011 New Revision: 222466 URL: http://svn.freebsd.org/changeset/base/222466 Log: Modify the umount(8) command so that it doesn't do a sync(2) syscall before unmount(2) for the -f case. This avoids a forced dismount from getting stuck for an NFS

svn commit: r222389 - in head/sys/fs: nfs nfsclient nfsserver

2011-05-27 Thread Rick Macklem
Author: rmacklem Date: Fri May 27 22:05:10 2011 New Revision: 222389 URL: http://svn.freebsd.org/changeset/base/222389 Log: Fix the new NFS client so that it handles NFSv4 state correctly during a forced dismount. This required that the exclusive and shared (refcnt) sleep lock functions

svn commit: r222329 - head/sys/fs/nfsclient

2011-05-26 Thread Rick Macklem
Author: rmacklem Date: Thu May 26 22:05:35 2011 New Revision: 222329 URL: http://svn.freebsd.org/changeset/base/222329 Log: Add a check for MNTK_UNMOUNTF at the beginning of nfs_sync() in the new NFS client so that a forced dismount doesn't get stuck in the VFS_SYNC() call that happens

svn commit: r222289 - in head/sys/fs: nfs nfsclient

2011-05-25 Thread Rick Macklem
Author: rmacklem Date: Wed May 25 20:53:08 2011 New Revision: 89 URL: http://svn.freebsd.org/changeset/base/89 Log: Fix the new NFS client so that it correctly sets the must_commit argument for a write RPC when it succeeds for the first one and fails for a subsequent RPC within the

svn commit: r222291 - head/sys/fs/nfsclient

2011-05-25 Thread Rick Macklem
Author: rmacklem Date: Wed May 25 21:17:53 2011 New Revision: 91 URL: http://svn.freebsd.org/changeset/base/91 Log: Add some missing mutex locking to the new NFS client. MFC after:2 weeks Modified: head/sys/fs/nfsclient/nfs_clvnops.c Modified:

svn commit: r222233 - head/sys/fs/nfsclient

2011-05-23 Thread Rick Macklem
Author: rmacklem Date: Mon May 23 22:31:42 2011 New Revision: 33 URL: http://svn.freebsd.org/changeset/base/33 Log: Set the MNT_NFS4ACLS flag for an NFSv4 client mount if the NFSv4 server supports it. Requested by trasz. MFC after:2 weeks Modified:

svn commit: r222196 - head/sys/ufs/ufs

2011-05-22 Thread Rick Macklem
Author: rmacklem Date: Sun May 22 20:39:07 2011 New Revision: 222196 URL: http://svn.freebsd.org/changeset/base/222196 Log: Fix the ufs/ffs file system so that it uses the lock flags argument added to VFS_FHTOVP() by r222167. Reviewed by: mckusick Modified:

svn commit: r222199 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs

2011-05-22 Thread Rick Macklem
Author: rmacklem Date: Sun May 22 21:04:32 2011 New Revision: 222199 URL: http://svn.freebsd.org/changeset/base/222199 Log: Fix the zfs file system so that it uses the lock flags argument added to VFS_FHTOVP() by r222167. Reviewed by: pjd Modified:

svn commit: r222167 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/cd9660 fs/ext2fs fs/hpfs fs/msdosfs fs/nfsserver fs/ntfs fs/nullfs fs/tmpfs fs/udf fs/unionfs gnu/fs/reiserfs gnu/fs...

2011-05-21 Thread Rick Macklem
Author: rmacklem Date: Sun May 22 01:07:54 2011 New Revision: 222167 URL: http://svn.freebsd.org/changeset/base/222167 Log: Add a lock flags argument to the VFS_FHTOVP() file system method, so that callers can indicate the minimum vnode locking requirement. This will allow some file systems

svn commit: r222109 - stable/8/sys/fs/nfsserver

2011-05-19 Thread Rick Macklem
Author: rmacklem Date: Fri May 20 00:51:52 2011 New Revision: 222109 URL: http://svn.freebsd.org/changeset/base/222109 Log: MFC: r221517 Change the new NFS server so that it returns 0 when the f_bavail or f_ffree fields of struct statfs are negative, since the values that go on the wire

svn commit: r222110 - stable/8/sys/fs/nfsclient

2011-05-19 Thread Rick Macklem
Author: rmacklem Date: Fri May 20 01:04:33 2011 New Revision: 222110 URL: http://svn.freebsd.org/changeset/base/222110 Log: MFC: r221537 Set the initial value of maxfilesize to OFF_MAX in the new NFS client. It will then be reduced to whatever the server says it can support. There might

svn commit: r222075 - in head/sys: fs/nfsclient nfsclient

2011-05-18 Thread Rick Macklem
Author: rmacklem Date: Wed May 18 18:36:40 2011 New Revision: 222075 URL: http://svn.freebsd.org/changeset/base/222075 Log: Add a sanity check for the existence of an addr option to both NFS clients. This avoids the crash reported by Sergey Kandaurov (pluk...@gmail.com) to the freebsd-fs@

svn commit: r222088 - stable/8/sys/fs/nfsclient

2011-05-18 Thread Rick Macklem
Author: rmacklem Date: Thu May 19 01:35:52 2011 New Revision: 222088 URL: http://svn.freebsd.org/changeset/base/222088 Log: MFC: r221467 Fix the new NFS client so that it handles the 64bit fields that are now in struct statfs for NFSv3 and NFSv4. Since the ffiles value is uint64_t on the

svn commit: r222089 - stable/8/sys/nfs

2011-05-18 Thread Rick Macklem
Author: rmacklem Date: Thu May 19 01:56:46 2011 New Revision: 222089 URL: http://svn.freebsd.org/changeset/base/222089 Log: MFC: r221473 Modify the NFS nfssvc(2) syscall so that it allows anyone to get the statistics for the new NFS subsystem. Modified: stable/8/sys/nfs/nfs_nfssvc.c

svn commit: r222044 - in stable/8/sys: fs/nfs nfs

2011-05-17 Thread Rick Macklem
Author: rmacklem Date: Wed May 18 01:14:27 2011 New Revision: 222044 URL: http://svn.freebsd.org/changeset/base/222044 Log: MFC: r221439 Add kernel support for NFSSVC_ZEROCLTSTATS and NFSSVC_ZEROSRVSTATS so that they can be used by nfsstat(1) to implement the -z option for the new NFS

svn commit: r222045 - stable/8/usr.bin/nfsstat

2011-05-17 Thread Rick Macklem
Author: rmacklem Date: Wed May 18 01:26:08 2011 New Revision: 222045 URL: http://svn.freebsd.org/changeset/base/222045 Log: MFC: r221440 Fix nfsstat.c so that the -z option works for the new NFS subsystem. Modified: stable/8/usr.bin/nfsstat/nfsstat.c Directory Properties:

svn commit: r222046 - stable/8/usr.bin/nfsstat

2011-05-17 Thread Rick Macklem
Author: rmacklem Date: Wed May 18 01:36:42 2011 New Revision: 222046 URL: http://svn.freebsd.org/changeset/base/222046 Log: MFC: r221309 Fix nfsstat.1 to indicate that -z now works for the new NFS subsystems after r221308. This is a content change. Modified:

svn commit: r222047 - stable/8/usr.bin/nfsstat

2011-05-17 Thread Rick Macklem
Author: rmacklem Date: Wed May 18 01:47:23 2011 New Revision: 222047 URL: http://svn.freebsd.org/changeset/base/222047 Log: MFC: r221454 Modify nfsstat(1) so that it prints out the buffer cache stats in the same way for the new client as the old one. Modified:

svn commit: r221986 - head/sys/nfsclient

2011-05-16 Thread Rick Macklem
Author: rmacklem Date: Mon May 16 13:12:09 2011 New Revision: 221986 URL: http://svn.freebsd.org/changeset/base/221986 Log: Fix a comment that got missed by r221973 which changed the sysctl naming for the old NFS client to vfs.oldnfs. Modified: head/sys/nfsclient/nfs.h Modified:

svn commit: r221973 - in head: sys/fs/nfs sys/fs/nfsclient sys/nfs sys/nfsclient usr.bin/nfsstat

2011-05-15 Thread Rick Macklem
Author: rmacklem Date: Sun May 15 20:52:43 2011 New Revision: 221973 URL: http://svn.freebsd.org/changeset/base/221973 Log: Change the sysctl naming for the old and new NFS clients to vfs.oldnfs.xxx and vfs.nfs.xxx respectively. This makes the default nfs client use vfs.nfs.xxx after

svn commit: r221976 - head/usr.sbin/nfsd

2011-05-15 Thread Rick Macklem
Author: rmacklem Date: Sun May 15 22:46:45 2011 New Revision: 221976 URL: http://svn.freebsd.org/changeset/base/221976 Log: Fix the nfsv4 man page to reflect the changes related to making the new NFS client and server the default. This is a content change. Modified:

svn commit: r221933 - in stable/8/sys: amd64/amd64 conf fs/nfs fs/nfsclient i386/i386 modules/nfscl modules/nfsclient nfs nfsclient

2011-05-14 Thread Rick Macklem
Author: rmacklem Date: Sun May 15 00:11:00 2011 New Revision: 221933 URL: http://svn.freebsd.org/changeset/base/221933 Log: MFC: r221032,r221040,r221066 Move the files used for a diskless NFS root from sys/nfsclient to sys/nfs in preparation for them to be used by both NFS clients. Also,

svn commit: r221934 - stable/8/sys/rpc

2011-05-14 Thread Rick Macklem
Author: rmacklem Date: Sun May 15 00:25:19 2011 New Revision: 221934 URL: http://svn.freebsd.org/changeset/base/221934 Log: MFC: r221127 This patch is believed to fix a problem in the kernel rpc for non-interruptible NFS mounts, where a kernel thread will seem to be stuck sleeping on

svn commit: r221935 - stable/8/sys/fs/nfsclient

2011-05-14 Thread Rick Macklem
Author: rmacklem Date: Sun May 15 00:43:51 2011 New Revision: 221935 URL: http://svn.freebsd.org/changeset/base/221935 Log: MFC: r221190,r221205 Fix the new NFS client so that it handles the nfs_args value in mnt_optnew. This is needed so that the old mount(2) syscall works and that is

svn commit: r221871 - in stable/8/sys: fs/nfs fs/nfsclient nfsclient

2011-05-13 Thread Rick Macklem
Author: rmacklem Date: Sat May 14 02:28:21 2011 New Revision: 221871 URL: http://svn.freebsd.org/changeset/base/221871 Log: MFC: r221014,r221018 Modify the experimental NFS client so that it uses the same struct nfs_args as the regular NFS client. This is needed so that the old mount(2)

svn commit: r221615 - in head: etc/rc.d sys/fs/nfsserver

2011-05-07 Thread Rick Macklem
Author: rmacklem Date: Sun May 8 01:01:27 2011 New Revision: 221615 URL: http://svn.freebsd.org/changeset/base/221615 Log: Change the new NFS server so that it uses vfs.nfsd naming for its sysctls instead of vfs.newnfs. This separates the names from the ones used by the client. Modified:

Re: svn commit: r221124 - in head: . sbin/mount sbin/mount_nfs sys/amd64/conf sys/fs/nfsclient sys/i386/conf sys/ia64/conf sys/nfsclient sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf

2011-05-06 Thread Rick Macklem
On Thu, May 05, 2011 at 07:06:46PM -0400, Rick Macklem wrote: Also, except for the SYSCTL() naming issue they don't comflict. At the moment it is perfectly ok to use both for mounts concurrently. For example, you could have the following 2 lines in your /etc/fstab: nfs-server:/sub1

Re: svn commit: r221124 - in head: . sbin/mount sbin/mount_nfs sys/amd64/conf sys/fs/nfsclient sys/i386/conf sys/ia64/conf sys/nfsclient sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf

2011-05-06 Thread Rick Macklem
If you don't share my preference then it would be good to make new NFS just 'nfs' everywhere (sysctls, fstype, etc.), so that we won't end up with 'newnfs' in random places in five years from now. What you do with old NFS is less important to me:) As you'll see from the post I just sent

Re: svn commit: r221124 - in head: . sbin/mount sbin/mount_nfs sys/amd64/conf sys/fs/nfsclient sys/i386/conf sys/ia64/conf sys/nfsclient sys/pc98/conf sys/powerpc/conf sys/sparc64/conf sys/sun4v/conf

2011-05-06 Thread Rick Macklem
Pawel Jakub Dawidek p...@freebsd.org writes: My personal opinion is that supporting such configuration is not worth the efforts and actually I'd prefer to use the same sysctl tree (vfs.nfs.*) and the same fstype (nfs) in both clients. User would decide which to use by loading one

svn commit: r221537 - head/sys/fs/nfsclient

2011-05-06 Thread Rick Macklem
Author: rmacklem Date: Fri May 6 17:51:00 2011 New Revision: 221537 URL: http://svn.freebsd.org/changeset/base/221537 Log: Set the initial value of maxfilesize to OFF_MAX in the new NFS client. It will then be reduced to whatever the server says it can support. There might be an argument

svn commit: r221542 - head/sys/nfsclient

2011-05-06 Thread Rick Macklem
Author: rmacklem Date: Fri May 6 19:55:15 2011 New Revision: 221542 URL: http://svn.freebsd.org/changeset/base/221542 Log: Fix the module dependency in nfs_kdtrace.c for the old NFS client. This should fix a problem reported by Marcus Reid. Modified: head/sys/nfsclient/nfs_kdtrace.c

svn commit: r221543 - in head/sys: nfs nfsclient

2011-05-06 Thread Rick Macklem
Author: rmacklem Date: Fri May 6 20:02:19 2011 New Revision: 221543 URL: http://svn.freebsd.org/changeset/base/221543 Log: Move sys/nfsclient/nfs_kdtrace.h to sys/nfs/nfs_kdtrace.h so it can be used by the new NFS client as well as the old one. Added: head/sys/nfs/nfs_kdtrace.h -

<    8   9   10   11   12   13   14   15   16   17   >