svn commit: r336839 - in head/sys/fs: nfs nfsserver

2018-07-28 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 28 20:21:04 2018 New Revision: 336839 URL: https://svnweb.freebsd.org/changeset/base/336839 Log: Modify the NFSv4.1 server so that it allows ReclaimComplete as done by ESXi 6.7. I believe that a ReclaimComplete with rca_one_fs == TRUE is only to be used

svn commit: r336798 - head/usr.sbin/nfsd

2018-07-27 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 27 23:38:31 2018 New Revision: 336798 URL: https://svnweb.freebsd.org/changeset/base/336798 Log: Update nfsd.8 for support of IPv6 addresses for hosts in the "-p" option. r336795 adds support for handling of IPv6 addresses returned by getaddrinfo(3) for DS

svn commit: r336795 - head/usr.sbin/nfsd

2018-07-27 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 27 23:10:28 2018 New Revision: 336795 URL: https://svnweb.freebsd.org/changeset/base/336795 Log: Add support for IPv6 addresses to the pNFS "-p" option. This patch adds code to handle IPv6 addresses returned by getaddrinfo() for the host entries in the "-p"

svn commit: r336573 - head/sys/fs/nfs

2018-07-20 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 21 01:33:07 2018 New Revision: 336573 URL: https://svnweb.freebsd.org/changeset/base/336573 Log: Set CLSET_TIMEOUT on TCP connections to pNFS DSs. Use CLSET_TIMEOUT to set the timeout for connections to DSs instead of specifying a timeout on each RPC. This

svn commit: r336542 - head/sys/rpc

2018-07-20 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 20 12:03:16 2018 New Revision: 336542 URL: https://svnweb.freebsd.org/changeset/base/336542 Log: Set SO_SNDTIMEO in the client side krpc when CLSET_TIMEOUT is done. During testing of the pNFS client, it was observed that an RPC could get stuck in sosend()

svn commit: r336518 - stable/10/sys/fs/nfsserver

2018-07-19 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 19 21:07:39 2018 New Revision: 336518 URL: https://svnweb.freebsd.org/changeset/base/336518 Log: MFC: r333766 Add a missing nfsrv_freesession() call for an unlikely failure case. Since NFSv4.1 clients normally create a single session which supports both

svn commit: r336516 - stable/11/sys/fs/nfsserver

2018-07-19 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 19 20:58:59 2018 New Revision: 336516 URL: https://svnweb.freebsd.org/changeset/base/336516 Log: MFC: r333766 Add a missing nfsrv_freesession() call for an unlikely failure case. Since NFSv4.1 clients normally create a single session which supports both

svn commit: r336422 - in stable/10/sys/fs: nfs nfsserver

2018-07-17 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 17 19:26:17 2018 New Revision: 336422 URL: https://svnweb.freebsd.org/changeset/base/336422 Log: MFC: r333645 End grace for the NFSv4 server if all mounts do ReclaimComplete. The NFSv4 protocol requires that the server only allow reclaim of state and not

svn commit: r336421 - in stable/11/sys/fs: nfs nfsserver

2018-07-17 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 17 19:10:15 2018 New Revision: 336421 URL: https://svnweb.freebsd.org/changeset/base/336421 Log: MFC: r333645 End grace for the NFSv4 server if all mounts do ReclaimComplete. The NFSv4 protocol requires that the server only allow reclaim of state and not

svn commit: r336357 - in head/sys/fs: nfs nfsserver

2018-07-16 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 16 21:32:50 2018 New Revision: 336357 URL: https://svnweb.freebsd.org/changeset/base/336357 Log: Modify the reasons for not issuing a delegation in the NFSv4.1 server. The ESXi NFSv4.1 client will generate warning messages when the reason for not issuing a

svn commit: r336312 - in head/sys/fs: nfs nfsclient

2018-07-15 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 15 18:54:44 2018 New Revision: 336312 URL: https://svnweb.freebsd.org/changeset/base/336312 Log: Shut down the TCP connection to a DS in the pNFS client when Renew fails. When a NFSv4.1 client mount using pNFS detects a failure trying to do a Renew

svn commit: r336292 - in head/sys/fs: nfs nfsclient

2018-07-14 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 14 19:51:44 2018 New Revision: 336292 URL: https://svnweb.freebsd.org/changeset/base/336292 Log: Fix the pNFS client when mirrors aren't on the same machine. Without this patch, the client side NFSv4.1 pNFS code erroneously did writes and commits to both DS

svn commit: r336260 - head/sys/fs/nfsclient

2018-07-13 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 13 20:03:05 2018 New Revision: 336260 URL: https://svnweb.freebsd.org/changeset/base/336260 Log: Close down the TCP connection to a pNFS DS when it is disabled. So long as the TCP connection to a pNFS DS isn't shared with other DSs, it can be closed down

svn commit: r336239 - head/sys/fs/nfsclient

2018-07-13 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 13 12:39:27 2018 New Revision: 336239 URL: https://svnweb.freebsd.org/changeset/base/336239 Log: Change the pNFS client so that it does not report an NFSERR_STALE from an I/O attempt on a DS to the server via LayoutReturn. The current FreeBSD client can

svn commit: r336234 - stable/10/sys/fs/nfsserver

2018-07-12 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 12 22:59:02 2018 New Revision: 336234 URL: https://svnweb.freebsd.org/changeset/base/336234 Log: MFC: r333579 The NFSv4.1 server should return NFSERR_BACKCHANBUSY instead of NFS_OK. When an NFSv4.1 session is busy due to a callback being in progress,

svn commit: r336233 - stable/11/sys/fs/nfsserver

2018-07-12 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 12 22:53:37 2018 New Revision: 336233 URL: https://svnweb.freebsd.org/changeset/base/336233 Log: MFC: r333579 The NFSv4.1 server should return NFSERR_BACKCHANBUSY instead of NFS_OK. When an NFSv4.1 session is busy due to a callback being in progress,

svn commit: r336229 - in head/sys/fs: nfs nfsclient

2018-07-12 Thread Rick Macklem
Author: rmacklem Date: Thu Jul 12 20:46:22 2018 New Revision: 336229 URL: https://svnweb.freebsd.org/changeset/base/336229 Log: Modify the NFSv4.1 pNFS client to use separate TCP connections for DSs. Without this patch, the NFSv4.1 pNFS client shared a single TCP connection for all DSs

svn commit: r336215 - head/sys/fs/nfsserver

2018-07-11 Thread Rick Macklem
Author: rmacklem Date: Wed Jul 11 23:23:29 2018 New Revision: 336215 URL: https://svnweb.freebsd.org/changeset/base/336215 Log: Ignore the cookie verifier for NFSv4.1 when the cookie is 0. RFC5661 states that the cookie verifier should be 0 when the cookie is 0. However, the wording is

svn commit: r336183 - head/usr.sbin/nfsd

2018-07-10 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 10 22:53:07 2018 New Revision: 336183 URL: https://svnweb.freebsd.org/changeset/base/336183 Log: Update the pnfs(4) man page. This is a content change. Modified: head/usr.sbin/nfsd/pnfs.4 Modified: head/usr.sbin/nfsd/pnfs.4

svn commit: r336179 - in stable/10/sys/fs: nfs nfsserver

2018-07-10 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 10 19:37:52 2018 New Revision: 336179 URL: https://svnweb.freebsd.org/changeset/base/336179 Log: MFC: r333508 Add support for the TestStateID operation to the NFSv4.1 server. The Linux client now uses the TestStateID operation, so this patch adds support

svn commit: r336178 - in stable/11/sys/fs: nfs nfsserver

2018-07-10 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 10 19:28:16 2018 New Revision: 336178 URL: https://svnweb.freebsd.org/changeset/base/336178 Log: MFC: r333508 Add support for the TestStateID operation to the NFSv4.1 server. The Linux client now uses the TestStateID operation, so this patch adds support

svn commit: r336177 - head/usr.sbin/pnfsdskill

2018-07-10 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 10 18:44:44 2018 New Revision: 336177 URL: https://svnweb.freebsd.org/changeset/base/336177 Log: Document the "-f" option added to pnfsdskill(8) by r336176. This is a content change. Modified: head/usr.sbin/pnfsdskill/pnfsdskill.8 Modified:

svn commit: r336176 - head/usr.sbin/pnfsdskill

2018-07-10 Thread Rick Macklem
Author: rmacklem Date: Tue Jul 10 18:41:16 2018 New Revision: 336176 URL: https://svnweb.freebsd.org/changeset/base/336176 Log: Add a "-f" option to pnfsdskill(8) to force disabling of a DS. The pnfsdskill(8) command will normally fail if there is no valid mirror for the DS to be

svn commit: r336141 - in head/sys/fs: nfs nfsserver

2018-07-09 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 9 19:58:01 2018 New Revision: 336141 URL: https://svnweb.freebsd.org/changeset/base/336141 Log: Add support for a "forced" pnfsdskill to the pNFS server kernel code. The pnfsdskill(8) command will normally fail if there is no valid mirror for the DS to be

svn commit: r336093 - head/sys/fs/nfsserver

2018-07-08 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 8 18:15:55 2018 New Revision: 336093 URL: https://svnweb.freebsd.org/changeset/base/336093 Log: Fix the kernel part of pnfsdscopymr() to handle holes in the file being copied. If a mirrored DS is being recovered that has a lot of large sparse files,

Re: svn commit: r335967 - head/sys/dev/mxge

2018-07-07 Thread Rick Macklem
Andrew Gallatin wrote: >Given that we do TSO like Linux, and not like MS (meaning >we express the size of the pre-segmented packet using the >a 16-bit value in the IPv4/IPv6 header), supporting more >than 64K is not possible in FreeBSD, so I'm basically >saying "nerf this constraint". Well, my

svn commit: r336075 - head/sys/fs/nfsserver

2018-07-07 Thread Rick Macklem
Author: rmacklem Date: Sat Jul 7 19:27:49 2018 New Revision: 336075 URL: https://svnweb.freebsd.org/changeset/base/336075 Log: Fix handling of the hybrid DS case for a pNFS server. After the addition of the "#mds_path" suffix for a DS specification on the "-p" nfsd option, it is

svn commit: r336041 - head/sys/fs/nfsserver

2018-07-06 Thread Rick Macklem
Author: rmacklem Date: Fri Jul 6 19:18:45 2018 New Revision: 336041 URL: https://svnweb.freebsd.org/changeset/base/336041 Log: Change the pNFS server so that it does not disable a mirrored DS for an NFSERR_STALE error reported via a LayoutReturn. The current FreeBSD client can generate

Re: svn commit: r335967 - head/sys/dev/mxge

2018-07-05 Thread Rick Macklem
Andrew Gallatin wrote: On 7/4/18 9:20 PM, Rodney W. Grimes wrote: [stuff snipped] >> >> It is using a magic constant twice, where one has a >> derived value that is dependent on the value of the other. >> That is bad and error prone and does not document that >> one depends on the other. Please

svn commit: r335968 - head/sys/fs/nfsserver

2018-07-04 Thread Rick Macklem
Author: rmacklem Date: Wed Jul 4 19:46:26 2018 New Revision: 335968 URL: https://svnweb.freebsd.org/changeset/base/335968 Log: Fix the pNFS server so that it handles the "#mds_path" check for mirrors. The recently added feature of the pNFS server will set an fsid for the MDS file system

svn commit: r335872 - head/usr.sbin/nfsd

2018-07-02 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 2 19:33:26 2018 New Revision: 335872 URL: https://svnweb.freebsd.org/changeset/base/335872 Log: Document the "#mds_path" suffix for the "-p" command line option. r335871 added support for an optional suffix of "#mds_path" that can be applied to each entry

svn commit: r335871 - head/usr.sbin/nfsd

2018-07-02 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 2 19:26:31 2018 New Revision: 335871 URL: https://svnweb.freebsd.org/changeset/base/335871 Log: Add an optional feature to the pNFS server. Without this patch, the pNFS server distributes the data storage files across all of the specified DSs. A tester

svn commit: r335870 - in head/sys/fs: nfs nfsserver

2018-07-02 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 2 19:21:33 2018 New Revision: 335870 URL: https://svnweb.freebsd.org/changeset/base/335870 Log: Add an optional feature to the pNFS server. Without this patch, the pNFS server distributes the data storage files across all of the specified DSs. A tester

svn commit: r335866 - head/sys/rpc

2018-07-02 Thread Rick Macklem
Author: rmacklem Date: Mon Jul 2 17:50:46 2018 New Revision: 335866 URL: https://svnweb.freebsd.org/changeset/base/335866 Log: Fix the server side krpc so that the kernel nfsd threads terminate. Occationally the kernel nfsd threads would not terminate when a SIGKILL was posted for the

svn commit: r335846 - head/usr.sbin/pnfsdsfile

2018-07-01 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 1 17:51:52 2018 New Revision: 335846 URL: https://svnweb.freebsd.org/changeset/base/335846 Log: Document the new "-m" command line option for pnfsdsfile(8). This is a content change. Modified: head/usr.sbin/pnfsdsfile/pnfsdsfile.8 Modified:

svn commit: r335845 - head/usr.sbin/pnfsdsfile

2018-07-01 Thread Rick Macklem
Author: rmacklem Date: Sun Jul 1 17:49:02 2018 New Revision: 335845 URL: https://svnweb.freebsd.org/changeset/base/335845 Log: Add a new "-m" option to pnfsdsfile(8) to prepare a file for mirroring. When pnfsdscopymr(8) is used to create a mirror of a file on a mirrored pNFS service, it

svn commit: r335814 - head/usr.sbin/nfsd

2018-06-30 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 30 12:14:20 2018 New Revision: 335814 URL: https://svnweb.freebsd.org/changeset/base/335814 Log: Add a safety belt assignment to the nfsd for when "-p" isn't specified. The kernel code assumes that nfsdargs.addr == NULL and nfsdargs.addrlen == 0 when there

svn commit: r335794 - head/sys/fs/nfsserver

2018-06-29 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 29 12:41:36 2018 New Revision: 335794 URL: https://svnweb.freebsd.org/changeset/base/335794 Log: Fix the pNFS server for a case where mirror level equals number of DSs. If a pNFS service was set up where the number of DSs equals the mirror level and then a

svn commit: r335573 - head/sys/fs/nfs

2018-06-22 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 23 00:48:45 2018 New Revision: 335573 URL: https://svnweb.freebsd.org/changeset/base/335573 Log: Set the slotid and ND_HASSLOTID flag for NFSv4.1 sequenced operations. Most NFSv4.1 compound RPCs start with a Sequence operation. For these cases, save the

svn commit: r335571 - head/sys/fs/nfs

2018-06-22 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 23 00:37:15 2018 New Revision: 335571 URL: https://svnweb.freebsd.org/changeset/base/335571 Log: Define ND_HASSLOTID needed by r335568. r335568 uses a flag called ND_HASSLOTID to indicate that the slotid is set, so it can free and invalidate it. This flag

svn commit: r335568 - head/sys/fs/nfs

2018-06-22 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 22 21:37:20 2018 New Revision: 335568 URL: https://svnweb.freebsd.org/changeset/base/335568 Log: Fix the handling of NFSv4.1 sessions for "soft" mounts. When a "soft" mount is used for NFSv4.1, an RPC that fails without completing will leave a slot in the

svn commit: r335567 - in head/sys/fs: nfs nfsclient

2018-06-22 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 22 21:25:27 2018 New Revision: 335567 URL: https://svnweb.freebsd.org/changeset/base/335567 Log: Change the NFSv4.1 pNFS client so that it returns the DS error in layoutreturn. When the NFSv4.1 pNFS client gets an error for a DS I/O operation using a

svn commit: r335566 - head/etc/rc.d

2018-06-22 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 22 20:58:51 2018 New Revision: 335566 URL: https://svnweb.freebsd.org/changeset/base/335566 Log: Add "mountcritremote" to the REQUIRE line for nfsd. For a pNFS MDS server, there must be mounts done to the DSs before the nfsd is started. Adding the REQUIRE

svn commit: r335525 - head/sys/fs/nfsserver

2018-06-21 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 22 00:55:39 2018 New Revision: 335525 URL: https://svnweb.freebsd.org/changeset/base/335525 Log: Add a counter to limit the number of disabled DSs for a mirrored pNFS MDS. This patch adds a counter that limits the number of disabled mirrored DSs to mirror

svn commit: r335309 - head/sys/fs/nfs

2018-06-17 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 17 23:08:54 2018 New Revision: 335309 URL: https://svnweb.freebsd.org/changeset/base/335309 Log: Revert r335263, since it can cause crashes in unusual circumstances. This needs to be fixed in a different way. Modified: head/sys/fs/nfs/nfs_commonkrpc.c

svn commit: r335286 - in head/sys/fs: nfs nfsclient

2018-06-17 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 17 16:30:06 2018 New Revision: 335286 URL: https://svnweb.freebsd.org/changeset/base/335286 Log: Make the pNFS NFSv4.1 client return a Flexible File layout upon error. The Flexible File layout LayoutReturn operation has argument fields where an I/O error

svn commit: r335263 - head/sys/fs/nfs

2018-06-16 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 16 19:45:06 2018 New Revision: 335263 URL: https://svnweb.freebsd.org/changeset/base/335263 Log: Fix NFSv4.1 client side handling of "soft,retrans=2" mounts. Normally "soft,retrans=2" cannot be safely used on NFSv4 mounts, since the RPC can fail and leave

svn commit: r335240 - head/usr.sbin/pnfsdscopymr

2018-06-15 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 15 21:07:14 2018 New Revision: 335240 URL: https://svnweb.freebsd.org/changeset/base/335240 Log: Use the .Fx macro in the man page. Reported by: bjk Modified: head/usr.sbin/pnfsdscopymr/pnfsdscopymr.8 Modified: head/usr.sbin/pnfsdscopymr/pnfsdscopymr.8

svn commit: r335239 - head/usr.sbin/pnfsdsfile

2018-06-15 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 15 21:04:28 2018 New Revision: 335239 URL: https://svnweb.freebsd.org/changeset/base/335239 Log: Use the .Fx macro in the man page. Reported by: bjk Modified: head/usr.sbin/pnfsdsfile/pnfsdsfile.8 Modified: head/usr.sbin/pnfsdsfile/pnfsdsfile.8

svn commit: r335238 - head/usr.sbin/pnfsdskill

2018-06-15 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 15 21:02:33 2018 New Revision: 335238 URL: https://svnweb.freebsd.org/changeset/base/335238 Log: Use the .Fx macro in the man page. Reported by: bjk Modified: head/usr.sbin/pnfsdskill/pnfsdskill.8 Modified: head/usr.sbin/pnfsdskill/pnfsdskill.8

svn commit: r335236 - in head/usr.sbin: . pnfsdscopymr

2018-06-15 Thread Rick Macklem
(r335236) @@ -0,0 +1,99 @@ +.\" Copyright (c) 2018 Rick Macklem +.\" +.\" Redistribution and use in source and binary forms, with or without +.\" modification, are permitted provided that the following conditions +.\" are met: +.\" 1. Redistributions of source code m

svn commit: r335234 - in head/usr.sbin: . pnfsdsfile

2018-06-15 Thread Rick Macklem
) +++ head/usr.sbin/pnfsdsfile/pnfsdsfile.8 Fri Jun 15 19:35:08 2018 (r335234) @@ -0,0 +1,133 @@ +.\" Copyright (c) 2017 Rick Macklem +.\" +.\" Redistribution and use in source and binary forms, with or without +.\" modification, are permitted provided that the

svn commit: r335193 - head/usr.sbin

2018-06-15 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 15 11:54:55 2018 New Revision: 335193 URL: https://svnweb.freebsd.org/changeset/base/335193 Log: Add an entry into the Makefile for pnfsdskill. pnfsdskill was added by r335192. This commit adds an entry for it to the Makefile. Modified:

svn commit: r335192 - head/usr.sbin/pnfsdskill

2018-06-15 Thread Rick Macklem
/pnfsdskill/pnfsdskill.8 Fri Jun 15 11:52:34 2018 (r335192) @@ -0,0 +1,64 @@ +.\" Copyright (c) 2018 Rick Macklem +.\" +.\" Redistribution and use in source and binary forms, with or without +.\" modification, are permitted provided that the following conditions

svn commit: r335175 - head/usr.sbin/nfsd

2018-06-14 Thread Rick Macklem
1970 (empty, because file is newly added) +++ head/usr.sbin/nfsd/pnfs.4 Thu Jun 14 21:12:08 2018(r335175) @@ -0,0 +1,187 @@ +.\" Copyright (c) 2017 Rick Macklem +.\" +.\" Redistribution and use in source and binary forms, with or without +.\" modification, ar

svn commit: r335174 - head/usr.sbin/nfsd

2018-06-14 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 14 20:55:33 2018 New Revision: 335174 URL: https://svnweb.freebsd.org/changeset/base/335174 Log: Document the "-p" and "-m" options added to nfsd.c by r335172. This is a content change. Modified: head/usr.sbin/nfsd/nfsd.8 Modified:

svn commit: r335172 - head/usr.sbin/nfsd

2018-06-14 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 14 20:36:55 2018 New Revision: 335172 URL: https://svnweb.freebsd.org/changeset/base/335172 Log: Add the "-p" and "-m" options to nfsd.c for the pNFS service. The "-p" option specifies that the nfsd should run a pNFS service instead of a regular NFS

svn commit: r335130 - in head/sys/fs: nfs nfsclient

2018-06-14 Thread Rick Macklem
Author: rmacklem Date: Thu Jun 14 10:00:19 2018 New Revision: 335130 URL: https://svnweb.freebsd.org/changeset/base/335130 Log: Move four functions in nfscl.ko to nfscommon.ko. Four functions nfscl_reqstart(), nfscl_fillsattr(), nfsm_stateidtom() and nfsmnt_mdssession() are now called

svn commit: r335019 - head

2018-06-12 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 12 22:52:27 2018 New Revision: 335019 URL: https://svnweb.freebsd.org/changeset/base/335019 Log: Explain why a __FreeBSD_version bump was done for r334930. Modified: head/UPDATING Modified: head/UPDATING

svn commit: r335018 - head/sys/sys

2018-06-12 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 12 22:48:19 2018 New Revision: 335018 URL: https://svnweb.freebsd.org/changeset/base/335018 Log: Version bump since r334930 changed the interface between the NFS modules, so they all need to be rebuilt. Modified: head/sys/sys/param.h Modified:

svn commit: r335012 - in head/sys: fs/nfs fs/nfsclient fs/nfsserver nfs

2018-06-12 Thread Rick Macklem
Author: rmacklem Date: Tue Jun 12 19:36:32 2018 New Revision: 335012 URL: https://svnweb.freebsd.org/changeset/base/335012 Log: Merge the pNFS server code from projects/pnfs-planb-server into head. This code merge adds a pNFS service to the NFSv4.1 server. Although it is a large commit

svn commit: r334966 - in head/sys/fs: nfs nfsclient

2018-06-11 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 11 19:00:07 2018 New Revision: 334966 URL: https://svnweb.freebsd.org/changeset/base/334966 Log: Add a couple of safety belt checks to the NFSv4.1 client related to sessions. There were a couple of cases in newnfs_request() that it assumed that it was an

svn commit: r334930 - head/sys/fs/nfsclient

2018-06-10 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 10 19:03:21 2018 New Revision: 334930 URL: https://svnweb.freebsd.org/changeset/base/334930 Log: Add checks for the Flexible File layout to LayoutRecall callbacks. The Flexible File layout case wasn't handled by LayoutRecall callbacks because it just

svn commit: r334904 - head/sys/fs/nfs

2018-06-09 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 9 23:38:22 2018 New Revision: 334904 URL: https://svnweb.freebsd.org/changeset/base/334904 Log: Delete some macros that are unused. These macros were added because they were used by the pNFS server last year. However, they are no longer used by the pNFS

svn commit: r334902 - head/sys/fs/nfs

2018-06-09 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 9 23:14:59 2018 New Revision: 334902 URL: https://svnweb.freebsd.org/changeset/base/334902 Log: Delete an unused macro and clean up a comment about it. NFSDEV_MIRRORSTR was defined for the pNFS server, but has not been used, so this patch deletes it. It

svn commit: r334741 - stable/10/sys/fs/nfsserver

2018-06-06 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 6 22:18:24 2018 New Revision: 334741 URL: https://svnweb.freebsd.org/changeset/base/334741 Log: MFC: r333580 Fix a slow leak of session structures in the NFSv4.1 server. For a fairly rare case of a client doing an ExchangeID after a hard reboot, the old

svn commit: r334739 - stable/11/sys/fs/nfsserver

2018-06-06 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 6 22:02:20 2018 New Revision: 334739 URL: https://svnweb.freebsd.org/changeset/base/334739 Log: MFC: r333580 Fix a slow leak of session structures in the NFSv4.1 server. For a fairly rare case of a client doing an ExchangeID after a hard reboot, the old

svn commit: r334699 - stable/10/sys/fs/nfsserver

2018-06-05 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 6 01:30:48 2018 New Revision: 334699 URL: https://svnweb.freebsd.org/changeset/base/334699 Log: MFC: r334396 Strengthen locking for the NFSv4.1 server DestroySession operation. If a client did a DestroySession on a session while it was still in use, the

svn commit: r334698 - stable/11/sys/fs/nfsserver

2018-06-05 Thread Rick Macklem
Author: rmacklem Date: Wed Jun 6 01:21:33 2018 New Revision: 334698 URL: https://svnweb.freebsd.org/changeset/base/334698 Log: MFC: r334396 Strengthen locking for the NFSv4.1 server DestroySession operation. If a client did a DestroySession on a session while it was still in use, the

svn commit: r334635 - stable/10/sys/fs/nfsclient

2018-06-04 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 4 20:55:25 2018 New Revision: 334635 URL: https://svnweb.freebsd.org/changeset/base/334635 Log: MFC: r334252 Fix the sleep event for layout recall. The sleep for I/O completion during an NFSv4.1 pNFS layout recall used the wrong event value and could

svn commit: r334634 - stable/11/sys/fs/nfsclient

2018-06-04 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 4 20:47:37 2018 New Revision: 334634 URL: https://svnweb.freebsd.org/changeset/base/334634 Log: MFC: r334252 Fix the sleep event for layout recall. The sleep for I/O completion during an NFSv4.1 pNFS layout recall used the wrong event value and could

svn commit: r334633 - stable/10/sys/fs/nfsserver

2018-06-04 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 4 20:40:22 2018 New Revision: 334633 URL: https://svnweb.freebsd.org/changeset/base/334633 Log: MFC: r333592 Fix the eir_server_scope reply argument for NFSv4.1 ExchangeID. In the reply to an ExchangeID operation, the NFSv4.1 server returns a "scope"

svn commit: r334629 - stable/11/sys/fs/nfsserver

2018-06-04 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 4 20:21:51 2018 New Revision: 334629 URL: https://svnweb.freebsd.org/changeset/base/334629 Log: MFC: r333592 Fix the eir_server_scope reply argument for NFSv4.1 ExchangeID. In the reply to an ExchangeID operation, the NFSv4.1 server returns a "scope"

svn commit: r334610 - head/sys/fs/nfsserver

2018-06-04 Thread Rick Macklem
Author: rmacklem Date: Mon Jun 4 11:35:04 2018 New Revision: 334610 URL: https://svnweb.freebsd.org/changeset/base/334610 Log: Revert r334586 since I now think __unused is the better way to handle this. Modified: head/sys/fs/nfsserver/nfs_nfsdport.c Modified:

Re: svn commit: r334586 - head/sys/fs/nfsserver

2018-06-03 Thread Rick Macklem
Dimitry Andric wrote: >On 3 Jun 2018, at 21:46, Rick Macklem wrote: >> >> Author: rmacklem >> Date: Sun Jun 3 19:46:44 2018 >> New Revision: 334586 >> URL: https://svnweb.freebsd.org/changeset/base/334586 >> >> Log: >> Fix a gcc8 warning about

svn commit: r334586 - head/sys/fs/nfsserver

2018-06-03 Thread Rick Macklem
Author: rmacklem Date: Sun Jun 3 19:46:44 2018 New Revision: 334586 URL: https://svnweb.freebsd.org/changeset/base/334586 Log: Fix a gcc8 warning about a write only variable. gcc8 warns that "verf" was set but not used. This was because the code that uses it is disabled via a "#if 0".

svn commit: r334511 - in head/sys/fs: nfs nfsclient

2018-06-01 Thread Rick Macklem
Author: rmacklem Date: Sat Jun 2 00:11:26 2018 New Revision: 334511 URL: https://svnweb.freebsd.org/changeset/base/334511 Log: Fix the default number of threads for Flex File layout pNFS client I/O. The intent was that the default would be based on number of CPUs, but the code disabled

svn commit: r334492 - in head/sys/fs: nfs nfsserver

2018-06-01 Thread Rick Macklem
Author: rmacklem Date: Fri Jun 1 19:47:41 2018 New Revision: 334492 URL: https://svnweb.freebsd.org/changeset/base/334492 Log: Add the BindConnectiontoSession operation to the NFSv4.1 server. Under some fairly unusual circumstances, the Linux NFSv4.1 client is doing a

svn commit: r334396 - head/sys/fs/nfsserver

2018-05-30 Thread Rick Macklem
Author: rmacklem Date: Wed May 30 20:16:17 2018 New Revision: 334396 URL: https://svnweb.freebsd.org/changeset/base/334396 Log: Strengthen locking for the NFSv4.1 server DestroySession operation. If a client did a DestroySession on a session while it was still in use, the server might

svn commit: r334252 - head/sys/fs/nfsclient

2018-05-26 Thread Rick Macklem
Author: rmacklem Date: Sat May 26 23:02:15 2018 New Revision: 334252 URL: https://svnweb.freebsd.org/changeset/base/334252 Log: Fix the sleep event for layout recall. The sleep for I/O completion during an NFSv4.1 pNFS layout recall used the wrong event value and could result in the

Re: svn commit: r334197 - head/sys/kern

2018-05-25 Thread Rick Macklem
Andriy Gapon wrote: >On 25/05/2018 04:15, Mateusz Guzik wrote: >> Author: mjg >> Date: Thu May 25 23:58:57 2018 >> New Revision: 334197 >> URL: https://svnweb.freebsd.org/changeset/base/334197 >> >> Log: >> Implement Mostly Exclusive locks. >> >> High lock contention is one of the biggest

Re: svn commit: r333924 - head/sys/fs/nfsclient

2018-05-20 Thread Rick Macklem
I'm not in a situation where I can use gcc, but if you email me the list of warnings, I can look at them. rick From: Matthew Macy <mm...@freebsd.org> Sent: Sunday, May 20, 2018 7:16:31 PM To: Rick Macklem Cc: src-committ...@freebsd.org; svn-s

Re: svn commit: r333924 - head/sys/fs/nfsclient

2018-05-20 Thread Rick Macklem
Matt Macy wrote: >Author: mmacy >Date: Sun May 20 06:14:12 2018 >New Revision: 333924 >URL: https://svnweb.freebsd.org/changeset/base/333924 > >Log: > nfsclient: warnings cleanups Just wondering what compiler you are using. I haven't seen warnings for these? FYI, for the first two cases, ncookie

svn commit: r333766 - head/sys/fs/nfsserver

2018-05-17 Thread Rick Macklem
Author: rmacklem Date: Thu May 17 21:17:20 2018 New Revision: 333766 URL: https://svnweb.freebsd.org/changeset/base/333766 Log: Add a missing nfsrv_freesession() call for an unlikely failure case. Since NFSv4.1 clients normally create a single session which supports both fore and back

svn commit: r333645 - in head/sys/fs: nfs nfsserver

2018-05-15 Thread Rick Macklem
Author: rmacklem Date: Tue May 15 20:28:50 2018 New Revision: 333645 URL: https://svnweb.freebsd.org/changeset/base/333645 Log: End grace for the NFSv4 server if all mounts do ReclaimComplete. The NFSv4 protocol requires that the server only allow reclaim of state and not issue any new

svn commit: r333592 - head/sys/fs/nfsserver

2018-05-13 Thread Rick Macklem
Author: rmacklem Date: Sun May 13 23:38:01 2018 New Revision: 333592 URL: https://svnweb.freebsd.org/changeset/base/333592 Log: Fix the eir_server_scope reply argument for NFSv4.1 ExchangeID. In the reply to an ExchangeID operation, the NFSv4.1 server returns a "scope" value

svn commit: r333580 - head/sys/fs/nfsserver

2018-05-13 Thread Rick Macklem
Author: rmacklem Date: Sun May 13 12:42:53 2018 New Revision: 333580 URL: https://svnweb.freebsd.org/changeset/base/333580 Log: Fix a slow leak of session structures in the NFSv4.1 server. For a fairly rare case of a client doing an ExchangeID after a hard reboot, the old confirmed

svn commit: r333579 - head/sys/fs/nfsserver

2018-05-13 Thread Rick Macklem
Author: rmacklem Date: Sun May 13 12:29:09 2018 New Revision: 333579 URL: https://svnweb.freebsd.org/changeset/base/333579 Log: The NFSv4.1 server should return NFSERR_BACKCHANBUSY instead of NFS_OK. When an NFSv4.1 session is busy due to a callback being in progress, nfsrv_freesession()

svn commit: r333508 - in head/sys/fs: nfs nfsserver

2018-05-11 Thread Rick Macklem
Author: rmacklem Date: Fri May 11 22:16:23 2018 New Revision: 333508 URL: https://svnweb.freebsd.org/changeset/base/333508 Log: Add support for the TestStateID operation to the NFSv4.1 server. The Linux client now uses the TestStateID operation, so this patch adds support for it to the

svn commit: r333184 - head/sys/fs/nfsserver

2018-05-02 Thread Rick Macklem
Author: rmacklem Date: Wed May 2 21:29:42 2018 New Revision: 333184 URL: https://svnweb.freebsd.org/changeset/base/333184 Log: Revert r333183, since I am not sure that just initializing the list is the correct thing to do and that is already done without this commit. Modified:

svn commit: r333183 - head/sys/fs/nfsserver

2018-05-02 Thread Rick Macklem
Author: rmacklem Date: Wed May 2 20:36:11 2018 New Revision: 333183 URL: https://svnweb.freebsd.org/changeset/base/333183 Log: Add two missing LIST_INIT()s. This patch adds two missing LIST_INIT()s. Found by inspection. In practice, these are currently no-ops, since the structure they

svn commit: r333061 - stable/11/sys/fs/nfsclient

2018-04-27 Thread Rick Macklem
Author: rmacklem Date: Fri Apr 27 12:57:39 2018 New Revision: 333061 URL: https://svnweb.freebsd.org/changeset/base/333061 Log: MFC: r332813 Fix use of pointer after being set NULL. Using a pointer after setting it NULL is probably not a good plan. Spotted by inspection during changes

svn commit: r333060 - stable/11/sys/fs/nfsserver

2018-04-27 Thread Rick Macklem
Author: rmacklem Date: Fri Apr 27 12:50:17 2018 New Revision: 333060 URL: https://svnweb.freebsd.org/changeset/base/333060 Log: MFC: r332790 Fix OpenDowngrade for NFSv4.1 if a client sets the OPEN_SHARE_ACCESS_WANT* bits. The NFSv4.1 RFC specifies that the OPEN_SHARE_ACCESS_WANT bits

svn commit: r332813 - head/sys/fs/nfsclient

2018-04-20 Thread Rick Macklem
Author: rmacklem Date: Fri Apr 20 11:38:29 2018 New Revision: 332813 URL: https://svnweb.freebsd.org/changeset/base/332813 Log: Fix use of pointer after being set NULL. Using a pointer after setting it NULL is probably not a good plan. Spotted by inspection during changes for Flexible

svn commit: r332790 - head/sys/fs/nfsserver

2018-04-19 Thread Rick Macklem
Author: rmacklem Date: Thu Apr 19 20:30:33 2018 New Revision: 332790 URL: https://svnweb.freebsd.org/changeset/base/332790 Log: Fix OpenDowngrade for NFSv4.1 if a client sets the OPEN_SHARE_ACCESS_WANT* bits. The NFSv4.1 RFC specifies that the OPEN_SHARE_ACCESS_WANT bits can be set in

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-18 Thread Rick Macklem
Julian Elischer wrote: [stuff snipped] >our issue is that we make a server that combines CIFS/SMB access (via >samba), credential setting from a company wide AD server (windows) >via winbindd (samba) via nsswitch.. and NFS. > >The problem is that when one looks up a user name from the AD server

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Rick Macklem
I wrote: >Julian Elischer wrote: >>On 16/4/18 6:56 pm, Konstantin Belousov wrote: >[stuff snipped] +ngroups =3D XU_NGROUPS + 1; >>> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >>valid question.. because that is how many are allocated? >>it was a "minimally

Re: svn commit: r332559 - head/usr.sbin/mountd

2018-04-16 Thread Rick Macklem
Julian Elischer wrote: >On 16/4/18 6:56 pm, Konstantin Belousov wrote: [stuff snipped] >>> +ngroups = XU_NGROUPS + 1; >> Why XU_NGROUPS and not the value of sysctl("kern.ngroups") ? >valid question.. because that is how many are allocated? >it was a "minimally invasive patch"..

Re: svn commit: r329875 - head/sys/kern

2018-02-23 Thread Rick Macklem
Konstantin Belousov wrote: >Author: kib >Date: Fri Feb 23 18:26:31 2018 >New Revision: 329875 >URL: https://svnweb.freebsd.org/changeset/base/329875 > >Log: > Restore UP build. > > Reviewed by: truckman > Sponsored by: The FreeBSD Foundation > >Modified: > head/sys/kern/sched_ule.c >

Re: svn commit: r328129 - head/sys/fs/nfsserver

2018-01-19 Thread Rick Macklem
Emmanuel Vadot wrote: [stuff snipped] > So should we warn once or maybe return EBUSY on unloading if there is >still lock structures ? My intent was that a module unload would clear out all data structures, so I would so no. I would also say that I envisioned an unload of nfsd.ko as a last resort,

<    1   2   3   4   5   6   7   8   9   10   >