Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Doug Rabson
On 12 May 2009, at 20:16, Jung-uk Kim wrote: On Tuesday 12 May 2009 04:18 am, Doug Rabson wrote: On 12 May 2009, at 09:16, Kip Macy wrote: On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: On 12 May 2009, at 06:03, Kip Macy wrote: Here is the problem, FreeBSD is sloppy about 32-bit vs.

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Jung-uk Kim
On Tuesday 12 May 2009 04:18 am, Doug Rabson wrote: > On 12 May 2009, at 09:16, Kip Macy wrote: > > On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: > >> On 12 May 2009, at 06:03, Kip Macy wrote: > >>> Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit > >>> for xdr > >>> whereas

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Kip Macy
On Tue, May 12, 2009 at 2:13 AM, Frank Behrens wrote: > On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: >> > I thought that XDR 'long' types were 32 bit regardless of whether the >> > platform was 32 or 64 bit. I'll have to read the code again. > > XDR is defined in RFC 4506. It should be in

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Frank Behrens
On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: > > I thought that XDR 'long' types were 32 bit regardless of whether the > > platform was 32 or 64 bit. I'll have to read the code again. XDR is defined in RFC 4506. It should be independent from architecture. "An XDR {signed,unsigned} inte

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Doug Rabson
On 12 May 2009, at 09:16, Kip Macy wrote: On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: On 12 May 2009, at 06:03, Kip Macy wrote: Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr whereas in the kernel, Solaris is not. I thought that XDR 'long' types were 32

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Kip Macy
On Tue, May 12, 2009 at 12:33 AM, Doug Rabson wrote: > > On 12 May 2009, at 06:03, Kip Macy wrote: > >> Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr >> whereas in the kernel, Solaris is not. > > I thought that XDR 'long' types were 32 bit regardless of whether the > platf

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-12 Thread Doug Rabson
On 12 May 2009, at 06:03, Kip Macy wrote: Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr whereas in the kernel, Solaris is not. I thought that XDR 'long' types were 32 bit regardless of whether the platform was 32 or 64 bit. I'll have to read the code again. __

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-11 Thread Kip Macy
Here is the problem, FreeBSD is sloppy about 32-bit vs. 64-bit for xdr whereas in the kernel, Solaris is not. Solaris: bool_t xdr_int(XDR *xdrs, int *ip) { if (xdrs->x_op == XDR_ENCODE) return (XDR_PUTINT32(xdrs, ip)); if (xdrs->x_op == XDR_DECODE)

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-11 Thread Kip Macy
On Mon, May 11, 2009 at 11:21 AM, Doug Rabson wrote: > The XDR support code that is in the main kernel should have a very similar > API to the opensolaris bits, possibly identical. Perhaps the opensolaris > compat could use the main kernel's XDR implementation? I tried that. The label reads end u

Re: svn commit: r191984 - in head/sys: cddl/contrib/opensolaris/uts/common/rpc modules/zfs

2009-05-11 Thread Doug Rabson
The XDR support code that is in the main kernel should have a very similar API to the opensolaris bits, possibly identical. Perhaps the opensolaris compat could use the main kernel's XDR implementation? On 11 May 2009, at 05:18, Kip Macy wrote: Author: kmacy Date: Mon May 11 04:18:58 2009 N