Re: svn commit: r323942 - head/sys/net

2017-09-25 Thread Bjoern A. Zeeb
On 25 Sep 2017, at 17:04, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 23:46, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 6:32, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14

Re: svn commit: r323942 - head/sys/net

2017-09-25 Thread Stephen Hurd
Bjoern A. Zeeb wrote: On 23 Sep 2017, at 23:46, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 6:32, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14 2017 New Revision: 323942 URL: https://svnweb.f

Re: svn commit: r323942 - head/sys/net

2017-09-25 Thread Bjoern A. Zeeb
On 23 Sep 2017, at 23:46, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 6:32, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14 2017 New Revision: 323942 URL: https://svnweb.freebsd.org/changeset/ba

Re: svn commit: r323942 - head/sys/net

2017-09-25 Thread Hans Petter Selasky
On 09/25/17 00:12, Stephen Hurd wrote: I've done an initial pass here: https://reviews.freebsd.org/D12487 Feel free to test it out and report findings in the review. I see some bugs. I'll send you a patch off-list. --HPS ___ svn-src-all@freebsd.org

Re: svn commit: r323942 - head/sys/net

2017-09-24 Thread Stephen Hurd
Stephen Hurd wrote: Hans Petter Selasky wrote: On 09/24/17 01:46, Stephen Hurd wrote: Basically, it changed from this: foreach (mbuf in rx) { if (lro && tcp_lro_rx(mbuf) == 0) continue; if_input(mbuf) } To this: prev_mbuf = first_mbuf = NULL; foreach (mbuf in rx) { if (lro && t

Re: svn commit: r323942 - head/sys/net

2017-09-24 Thread Stephen Hurd
Hans Petter Selasky wrote: On 09/24/17 01:46, Stephen Hurd wrote: Basically, it changed from this: foreach (mbuf in rx) { if (lro && tcp_lro_rx(mbuf) == 0) continue; if_input(mbuf) } To this: prev_mbuf = first_mbuf = NULL; foreach (mbuf in rx) { if (lro && tcp_lro_rx(mbuf) == 0)

Re: svn commit: r323942 - head/sys/net

2017-09-24 Thread Hans Petter Selasky
On 09/24/17 01:46, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 6:32, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14 2017 New Revision: 323942 URL: https://svnweb.freebsd.org/changeset/base/32394

Re: svn commit: r323942 - head/sys/net

2017-09-23 Thread Stephen Hurd
Bjoern A. Zeeb wrote: On 23 Sep 2017, at 6:32, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14 2017 New Revision: 323942 URL: https://svnweb.freebsd.org/changeset/base/323942 Log: Chain mbufs before passing to

Re: svn commit: r323942 - head/sys/net

2017-09-23 Thread Jonathan Looney
On Sat, Sep 23, 2017 at 4:37 AM, Bjoern A. Zeeb < bzeeb-li...@lists.zabbadoz.net> wrote: > > Then this makes no sense as we don’t do LRO if forwarding is enabled on > the machine; > https://svnweb.freebsd.org/base/head/sys/netinet/tcp_lro.c? > annotate=317390#l645 Yes, that is true. However, thi

Re: svn commit: r323942 - head/sys/net

2017-09-23 Thread Bjoern A. Zeeb
On 23 Sep 2017, at 6:32, Stephen Hurd wrote: Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14 2017 New Revision: 323942 URL: https://svnweb.freebsd.org/changeset/base/323942 Log: Chain mbufs before passing to if_input() Build a

Re: svn commit: r323942 - head/sys/net

2017-09-22 Thread Stephen Hurd
Bjoern A. Zeeb wrote: On 23 Sep 2017, at 1:35, Stephen Hurd wrote: Author: shurd Date: Sat Sep 23 01:35:14 2017 New Revision: 323942 URL: https://svnweb.freebsd.org/changeset/base/323942 Log: Chain mbufs before passing to if_input() Build a list of mbufs to pass to if_input() after LRO.

Re: svn commit: r323942 - head/sys/net

2017-09-22 Thread Bjoern A. Zeeb
On 23 Sep 2017, at 1:35, Stephen Hurd wrote: > Author: shurd > Date: Sat Sep 23 01:35:14 2017 > New Revision: 323942 > URL: https://svnweb.freebsd.org/changeset/base/323942 > > Log: > Chain mbufs before passing to if_input() > > Build a list of mbufs to pass to if_input() after LRO. Results in