Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-28 Thread Bruce Evans
On Thu, 27 Nov 2008, [utf-8] Dag-Erling Sm??rgrav wrote: M. Warner Losh [EMAIL PROTECTED] writes: I personally really dislike the style (and yes, I know all the arguments for it). If you really want something that complex inside a block to need block scoped variables, then that really argues

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Roman Divacky
On Wed, Nov 26, 2008 at 09:32:04PM -0500, Alexander Kabaev wrote: On Thu, 27 Nov 2008 02:19:44 + (UTC) Jack F Vogel [EMAIL PROTECTED] wrote: Author: jfv Date: Thu Nov 27 02:19:44 2008 New Revision: 185356 URL: http://svn.freebsd.org/changeset/base/185356 Log: Small nit I

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
Jack F Vogel [EMAIL PROTECTED] writes: Log: Small nit I just noticed, a pre-decrement should be post. Why? It makes absolutely no difference. (s/decrement/increment/, btw) Personally, I always use pre-{inc,dec}rement when I don't care about the value of the expression, but I guess it's a

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Ivan Voras
2008/11/27 Dag-Erling Smørgrav [EMAIL PROTECTED]: Ivan Voras [EMAIL PROTECTED] writes: And at least the newer GEOM code also uses c99 variable declarations (not only for initializers - they were c99 from the start). I'm curious about what you mean with c99 variable declarations. If you are

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Erik Trulsson
On Thu, Nov 27, 2008 at 11:38:05AM +0100, Ivan Voras wrote: 2008/11/27 Dag-Erling Smørgrav [EMAIL PROTECTED]: Ivan Voras [EMAIL PROTECTED] writes: And at least the newer GEOM code also uses c99 variable declarations (not only for initializers - they were c99 from the start). I'm curious

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
Ivan Voras [EMAIL PROTECTED] writes: Dag-Erling Smørgrav [EMAIL PROTECTED] writes: I'm curious about what you mean with c99 variable declarations. [...] [...] I mean things like: if () { struct *something abc; int y; ... } C has always allowed declaring variables at the top of

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Dag-Erling Smørgrav
Ivan Voras [EMAIL PROTECTED] writes: And at least the newer GEOM code also uses c99 variable declarations (not only for initializers - they were c99 from the start). I'm curious about what you mean with c99 variable declarations. If you are referring to loop variable declarations, I can only

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Ivan Voras [EMAIL PROTECTED] writes: : 2008/11/27 Dag-Erling Smørgrav [EMAIL PROTECTED]: : Ivan Voras [EMAIL PROTECTED] writes: : And at least the newer GEOM code also uses c99 variable declarations : (not only for initializers - they were c99 from the

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-27 Thread Sam Leffler
Ivan Voras wrote: 2008/11/27 Dag-Erling Smørgrav [EMAIL PROTECTED]: Ivan Voras [EMAIL PROTECTED] writes: And at least the newer GEOM code also uses c99 variable declarations (not only for initializers - they were c99 from the start). I'm curious about what you mean with c99

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-26 Thread Alexander Kabaev
On Thu, 27 Nov 2008 02:19:44 + (UTC) Jack F Vogel [EMAIL PROTECTED] wrote: Author: jfv Date: Thu Nov 27 02:19:44 2008 New Revision: 185356 URL: http://svn.freebsd.org/changeset/base/185356 Log: Small nit I just noticed, a pre-decrement should be post. Modified:

Re: svn commit: r185356 - head/sys/dev/ixgbe

2008-11-26 Thread M. Warner Losh
In message: [EMAIL PROTECTED] Alexander Kabaev [EMAIL PROTECTED] writes: : On Thu, 27 Nov 2008 02:19:44 + (UTC) : Jack F Vogel [EMAIL PROTECTED] wrote: : : Author: jfv : Date: Thu Nov 27 02:19:44 2008 : New Revision: 185356 : URL: http://svn.freebsd.org/changeset/base/185356 :