svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-25 Thread Xin LI
Author: delphij Date: Tue Aug 25 19:07:26 2009 New Revision: 196550 URL: http://svn.freebsd.org/changeset/base/196550 Log: Add a new rc.d script, static_arp, which enables the administrator to statically bind IPv4 <-> MAC address at boot time. In order to use this, the administrator needs

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-25 Thread Doug Barton
My sincere apologies for missing this the first N times I reviewed it, but both variables in functions should be declared local. Attached is a suggested patch. Doug -- This .signature sanitized for your protection Index: static_arp =

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-25 Thread Gleb Kurtsou
On (25/08/2009 19:07), Xin LI wrote: > Author: delphij > Date: Tue Aug 25 19:07:26 2009 > New Revision: 196550 > URL: http://svn.freebsd.org/changeset/base/196550 > > Log: > Add a new rc.d script, static_arp, which enables the administrator to > statically bind IPv4 <-> MAC address at boot tim

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-25 Thread Doug Barton
Gleb Kurtsou wrote: > Would you please add support for reading pairs from file It does read them from a file, the file is named "rc.conf." :) Doug -- This .signature sanitized for your protection ___ svn-src-all@freebsd.org mailing list http:/

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-26 Thread Pawel Jakub Dawidek
On Tue, Aug 25, 2009 at 10:42:58PM +0300, Gleb Kurtsou wrote: > On (25/08/2009 19:07), Xin LI wrote: > > Author: delphij > > Date: Tue Aug 25 19:07:26 2009 > > New Revision: 196550 > > URL: http://svn.freebsd.org/changeset/base/196550 > > > > Log: > > Add a new rc.d script, static_arp, which ena

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-26 Thread Bruce Simpson
Xin LI wrote: Log: Add a new rc.d script, static_arp, which enables the administrator to statically bind IPv4 <-> MAC address at boot time. Thanks for doing this -- users will love this! ___ svn-src-all@freebsd.org mailing list http://lists.fr

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-26 Thread Doug Barton
Pawel Jakub Dawidek wrote: > I put '/usr/sbin/arp -f /etc/arp.conf' into /etc/rc.local on almost all > of my servers, which is very handy, indeed. And with your patch proposed > in another e-mail to be able to remove entries defined in a file seems > to be a complete solution. I'd also like to see

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-26 Thread Gleb Kurtsou
On (26/08/2009 12:42), Doug Barton wrote: > Pawel Jakub Dawidek wrote: > > > I put '/usr/sbin/arp -f /etc/arp.conf' into /etc/rc.local on almost all > > of my servers, which is very handy, indeed. And with your patch proposed > > in another e-mail to be able to remove entries defined in a file see

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-27 Thread Pawel Jakub Dawidek
On Wed, Aug 26, 2009 at 12:42:24PM -0700, Doug Barton wrote: > Pawel Jakub Dawidek wrote: > > > I put '/usr/sbin/arp -f /etc/arp.conf' into /etc/rc.local on almost all > > of my servers, which is very handy, indeed. And with your patch proposed > > in another e-mail to be able to remove entries de

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-27 Thread Doug Barton
Pawel Jakub Dawidek wrote: > But giving multiple tools to accomplish the same thing might confuse our > users, so its probably not worth it. The proposed solution is good enough. That was the primary focus of my initial concern but enough people have chimed in saying that this would be useful tha

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-27 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Doug Barton wrote: > Pawel Jakub Dawidek wrote: > >> But giving multiple tools to accomplish the same thing might confuse our >> users, so its probably not worth it. The proposed solution is good enough. > > That was the primary focus of my initial c

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-27 Thread Doug Barton
Xin LI wrote: > Doug Barton wrote: >> Pawel Jakub Dawidek wrote: > >>> But giving multiple tools to accomplish the same thing might confuse our >>> users, so its probably not worth it. The proposed solution is good enough. >> That was the primary focus of my initial concern but enough people >> ha

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-27 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Doug, Doug Barton wrote: > Xin LI wrote: >> Doug Barton wrote: >>> Pawel Jakub Dawidek wrote: But giving multiple tools to accomplish the same thing might confuse our users, so its probably not worth it. The proposed solution is good eno

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-28 Thread Xin LI
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Doug Barton wrote: > Xin LI wrote: > >> I think /etc/rc.d/static_arp stop should revert what was done by >> static_arp start by removing entries from the ARP table. > > I agree with you. > >> Gleb has >> kindly worked out a patch that adds '-d -f'

Re: svn commit: r196550 - in head: etc/defaults etc/rc.d share/man/man5

2009-08-28 Thread Doug Barton
Xin LI wrote: > I think /etc/rc.d/static_arp stop should revert what was done by > static_arp start by removing entries from the ARP table. I agree with you. > Gleb has > kindly worked out a patch that adds '-d -f' functionality. But wouldn't it be easier to just parse the file and undo whatev