Re: svn commit: r201773 - head/sys/fs/tmpfs

2010-01-09 Thread Bruce Evans
On Fri, 8 Jan 2010, Jaakko Heinonen wrote: Does following patch look reasonable? - Fix style bugs introduced in r201773. - Change the type of nodes_max to u_int and use %u format string to convert its value. Index: sys/fs/tmpfs/tmpfs_vfsops.c

Re: svn commit: r201773 - head/sys/fs/tmpfs

2010-01-08 Thread Gleb Kurtsou
On (08/01/2010 23:48), Jaakko Heinonen wrote: Thank you for looking at this. On 2010-01-09, Bruce Evans wrote: The current incorrect way is to use %d. Since ino_t happens to have type uint32_t and u_int happens to have type uint32_t on all supported machines, %u would work but %d

Re: svn commit: r201773 - head/sys/fs/tmpfs

2010-01-08 Thread Bruce Evans
On Fri, 8 Jan 2010, Jaakko Heinonen wrote: Author: jh Date: Fri Jan 8 07:57:43 2010 New Revision: 201773 URL: http://svn.freebsd.org/changeset/base/201773 Log: - Change the type of size_max to u_quad_t because its value is converted with vfs_scanopt(9) using the %qu format string. %qu

Re: svn commit: r201773 - head/sys/fs/tmpfs

2010-01-08 Thread Jaakko Heinonen
Thank you for looking at this. On 2010-01-09, Bruce Evans wrote: The current incorrect way is to use %d. Since ino_t happens to have type uint32_t and u_int happens to have type uint32_t on all supported machines, %u would work but %d gives undefined behaviour when the value exceeds

svn commit: r201773 - head/sys/fs/tmpfs

2010-01-07 Thread Jaakko Heinonen
Author: jh Date: Fri Jan 8 07:57:43 2010 New Revision: 201773 URL: http://svn.freebsd.org/changeset/base/201773 Log: - Change the type of size_max to u_quad_t because its value is converted with vfs_scanopt(9) using the %qu format string. - Limit the maximum value of size_max to