Re: svn commit: r210321 - head/lib/libelf

2010-07-22 Thread Brian Somers
On Wed, 21 Jul 2010 19:51:49 +1000 (EST) Bruce Evans wrote: > On Wed, 21 Jul 2010, Alexey Dokuchaev wrote: > > > On Wed, Jul 21, 2010 at 08:43:48AM +, Kai Wang wrote: > >> Log: > >> Remove a superfluous comment. > >> > >> Obtained from:elftoolchain > >> MFC after:1

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Ed Schouten
* Alexey Dokuchaev wrote: > Second, I think > blindly converting tabs to spaces would bring even more mess to > alignment than we happen to have now. In what kind of way? -- Ed Schouten WWW: http://80386.nl/ pgpiC37U1RAje.pgp Description: PGP signature

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Alexey Dokuchaev
On Wed, Jul 21, 2010 at 06:58:49PM +0200, Ed Schouten wrote: > * Ed Schouten wrote: > > * Alexey Dokuchaev wrote: > > > (Just picking random of the similar commits): guys, please, try to > > > uniformly align commit meta tags: > > > > I guess it was aligned properly using tabs, but the whitespac

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Ed Schouten
* Ed Schouten wrote: > * Alexey Dokuchaev wrote: > > (Just picking random of the similar commits): guys, please, try to > > uniformly align commit meta tags: > > I guess it was aligned properly using tabs, but the whitespace added to > the beginning of the line causes it to jump one tab forward.

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Alexey Dokuchaev
On Wed, Jul 21, 2010 at 07:51:49PM +1000, Bruce Evans wrote: > On Wed, 21 Jul 2010, Alexey Dokuchaev wrote: > >On Wed, Jul 21, 2010 at 08:43:48AM +, Kai Wang wrote: > >>Log: > >> Remove a superfluous comment. > >> > >> Obtained from: elftoolchain > >> MFC after: 1 month >

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Dag-Erling Smørgrav
Alexey Dokuchaev writes: > Obtained from:somewhere > MFC after:sometime > Foo bar: baz qux ... > > Broken alignment considerably pessimizes commit log grasping, as it > requires more post-processing work after reading it off. my ($tag, $value) = split(/:\s*/); but perhaps it's c

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Bruce Evans
On Wed, 21 Jul 2010, Alexey Dokuchaev wrote: On Wed, Jul 21, 2010 at 08:43:48AM +, Kai Wang wrote: Log: Remove a superfluous comment. Obtained from: elftoolchain MFC after: 1 month (Just picking random of the similar commits): guys, please, try to uniformly alig

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Kai Wang
On Wed, Jul 21, 2010 at 09:06:23AM +, Alexey Dokuchaev wrote: > On Wed, Jul 21, 2010 at 08:43:48AM +, Kai Wang wrote: > > Author: kaiw > > Date: Wed Jul 21 08:43:48 2010 > > New Revision: 210321 > > URL: http://svn.freebsd.org/changeset/base/210321 > > > > Log: > > Remove a superfluous c

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Ed Schouten
* Alexey Dokuchaev wrote: > (Just picking random of the similar commits): guys, please, try to > uniformly align commit meta tags: I guess it was aligned properly using tabs, but the whitespace added to the beginning of the line causes it to jump one tab forward. -- Ed Schouten WWW: http://8

Re: svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Alexey Dokuchaev
On Wed, Jul 21, 2010 at 08:43:48AM +, Kai Wang wrote: > Author: kaiw > Date: Wed Jul 21 08:43:48 2010 > New Revision: 210321 > URL: http://svn.freebsd.org/changeset/base/210321 > > Log: > Remove a superfluous comment. > > Obtained from: elftoolchain > MFC after: 1 mont

svn commit: r210321 - head/lib/libelf

2010-07-21 Thread Kai Wang
Author: kaiw Date: Wed Jul 21 08:43:48 2010 New Revision: 210321 URL: http://svn.freebsd.org/changeset/base/210321 Log: Remove a superfluous comment. Obtained from: elftoolchain MFC after: 1 month Modified: head/lib/libelf/elf_update.c Modified: head/lib/libelf/elf