Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-28 Thread Ed Schouten
* David O'Brien , 20110427 21:35: > One has to do all the various greps of the output in order to be > confident of their belief of the results. I usually run this afterwards: tail -n 3 _.* | less Or something like this to simply give a list of failures: fgrep -L 'completed on'

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread Warner Losh
see make tinderbox if you want first fail semantics. On Apr 27, 2011, at 1:35 PM, David O'Brien wrote: > On Wed, Apr 27, 2011 at 10:48:33AM -0400, John Baldwin wrote: >> For changing WARNS, 'make universe' works well > > I have to disagree. Due to its silent failing, it is only suitable for > w

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread John Baldwin
On Wednesday, April 27, 2011 3:35:50 pm David O'Brien wrote: > On Wed, Apr 27, 2011 at 10:48:33AM -0400, John Baldwin wrote: > > For changing WARNS, 'make universe' works well > > I have to disagree. Due to its silent failing, it is only suitable for > what PHK added it for -- "what if" changes.

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread David O'Brien
On Tue, Apr 26, 2011 at 07:27:11AM -0600, Warner Losh wrote: > I read the test log as "not really tested, feel free to back it out if > it fails on a different architecture" Irregardless of the reasons for a build break -- one should feel free to fix or back the change out until the change can be

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread David O'Brien
On Wed, Apr 27, 2011 at 10:48:33AM -0400, John Baldwin wrote: > For changing WARNS, 'make universe' works well I have to disagree. Due to its silent failing, it is only suitable for what PHK added it for -- "what if" changes. [Message-ID: <13101.1227520...@critter.freebsd.dk>] One has to do all

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-27 Thread John Baldwin
On Tuesday, April 26, 2011 6:26:41 pm David O'Brien wrote: > On Tue, Apr 26, 2011 at 09:32:44AM -0400, John Baldwin wrote: > > On Tuesday, April 26, 2011 12:09:20 am David E. O'Brien wrote: > > > Author: obrien > > > Date: Tue Apr 26 04:09:20 2011 > > > New Revision: 221053 > > > URL: http://svn.fr

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-26 Thread Warner Losh
On Apr 26, 2011, at 4:26 PM, David O'Brien wrote: > On Tue, Apr 26, 2011 at 09:32:44AM -0400, John Baldwin wrote: >> On Tuesday, April 26, 2011 12:09:20 am David E. O'Brien wrote: >>> Author: obrien >>> Date: Tue Apr 26 04:09:20 2011 >>> New Revision: 221053 >>> URL: http://svn.freebsd.org/change

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-26 Thread David O'Brien
On Tue, Apr 26, 2011 at 09:32:44AM -0400, John Baldwin wrote: > On Tuesday, April 26, 2011 12:09:20 am David E. O'Brien wrote: > > Author: obrien > > Date: Tue Apr 26 04:09:20 2011 > > New Revision: 221053 > > URL: http://svn.freebsd.org/changeset/base/221053 > > > > Log: > > This builds OK usin

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-26 Thread Warner Losh
On Apr 26, 2011, at 3:57 AM, Gavin Atkinson wrote: > On Tue, 2011-04-26 at 04:09 +, David E. O'Brien wrote: >> Author: obrien >> Date: Tue Apr 26 04:09:20 2011 >> New Revision: 221053 >> URL: http://svn.freebsd.org/changeset/base/221053 >> >> Log: >> This builds OK using the parent dir's WA

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-26 Thread John Baldwin
On Tuesday, April 26, 2011 12:09:20 am David E. O'Brien wrote: > Author: obrien > Date: Tue Apr 26 04:09:20 2011 > New Revision: 221053 > URL: http://svn.freebsd.org/changeset/base/221053 > > Log: > This builds OK using the parent dir's WARNS=6. > [built on both AMD64 and i386] This breaks th

Re: svn commit: r221053 - head/usr.bin/rlogin

2011-04-26 Thread Gavin Atkinson
On Tue, 2011-04-26 at 04:09 +, David E. O'Brien wrote: > Author: obrien > Date: Tue Apr 26 04:09:20 2011 > New Revision: 221053 > URL: http://svn.freebsd.org/changeset/base/221053 > > Log: > This builds OK using the parent dir's WARNS=6. > [built on both AMD64 and i386] As a general rule,

svn commit: r221053 - head/usr.bin/rlogin

2011-04-25 Thread David E. O'Brien
Author: obrien Date: Tue Apr 26 04:09:20 2011 New Revision: 221053 URL: http://svn.freebsd.org/changeset/base/221053 Log: This builds OK using the parent dir's WARNS=6. [built on both AMD64 and i386] Modified: head/usr.bin/rlogin/Makefile Modified: head/usr.bin/rlogin/Makefile