Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread Bruce Evans
On Fri, 1 Jun 2012 m...@freebsd.org wrote: On Fri, Jun 1, 2012 at 2:14 AM, Bruce Evans wrote: +SYSCTL_OID(_vm, OID_AUTO, swap_free, CTLTYPE_INT|CTLFLAG_RD|CTLFLAG_MPSAFE, + ? ? ? ? ? ? ? NULL, 0, sysctl_vm_swap_free, "Q", + ? ? ? ? ? ? ? "Blocks of free swap storage."); Bug 9 is a style bug.

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread mdf
On Fri, Jun 1, 2012 at 2:14 AM, Bruce Evans wrote: >>> +SYSCTL_OID(_vm, OID_AUTO, swap_free, >>> CTLTYPE_INT|CTLFLAG_RD|CTLFLAG_MPSAFE, >>> +               NULL, 0, sysctl_vm_swap_free, "Q", >>> +               "Blocks of free swap storage."); > > > Bug 9 is a style bug.  I didn't even know that t

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread Eitan Adler
On 1 June 2012 05:14, Bruce Evans wrote: >> On 1 June 2012 08:42, Eitan Adler wrote: ... I want to ack the replies to this commit. I'll either try to fix the bugs mentioned here, or more likely revert the commit. Note that it may take a few days for me to get to this though. -- Eitan Adler S

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread Bruce Evans
On Fri, 1 Jun 2012, Sergey Kandaurov wrote: On 1 June 2012 08:42, Eitan Adler wrote: ... Log: ?Add sysctl to query amount of swap space free ?PR: ? ? ? ? ? kern/166780 ?Submitted by: Radim Kolar ?Approved by: ?cperciva ?MFC after: ? ?1 week Well, we already have more powerful vm.swap_info,

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread Konstantin Belousov
On Fri, Jun 01, 2012 at 04:42:52AM +, Eitan Adler wrote: > Author: eadler > Date: Fri Jun 1 04:42:52 2012 > New Revision: 236380 > URL: http://svn.freebsd.org/changeset/base/236380 > > Log: > Add sysctl to query amount of swap space free > > PR: kern/166780 > Submitted by:

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread Daniel O'Connor
On 01/06/2012, at 15:38, Sergey Kandaurov wrote: > Well, we already have more powerful vm.swap_info, so > I see no reason to add yet another one to do the same thing > (but now with a human interface). > Probably sysctl(8) should be enhanced to parse it instead. There are already sysctls which ha

Re: svn commit: r236380 - head/sys/vm

2012-06-01 Thread Sergey Kandaurov
On 1 June 2012 08:42, Eitan Adler wrote: > Author: eadler > Date: Fri Jun  1 04:42:52 2012 > New Revision: 236380 > URL: http://svn.freebsd.org/changeset/base/236380 > > Log: >  Add sysctl to query amount of swap space free > >  PR:           kern/166780 >  Submitted by: Radim Kolar >  Approved b

svn commit: r236380 - head/sys/vm

2012-05-31 Thread Eitan Adler
Author: eadler Date: Fri Jun 1 04:42:52 2012 New Revision: 236380 URL: http://svn.freebsd.org/changeset/base/236380 Log: Add sysctl to query amount of swap space free PR: kern/166780 Submitted by: Radim Kolar Approved by: cperciva MFC after:1 week Modified: head/sy