Re: svn commit: r236414 - in head/sys: amd64/acpica i386/acpica

2012-06-01 Thread Mitsuru IWASAKI
> > Regarding to ACPICA source code, they said nothing about this so I > > think it's not big deal. > > > > Just FYI, AcpiSetFirmwareWakingVector(0) was called with interrupt > > enabled in Linux. > > This function does not care about interrupt context. However, the > first AcpiSetFirmwareWakin

Re: svn commit: r236414 - in head/sys: amd64/acpica i386/acpica

2012-06-01 Thread Jung-uk Kim
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 2012-06-01 14:43:49 -0400, Mitsuru IWASAKI wrote: > Hi, thanks for following up. > >> Log: Call AcpiSetFirmwareWakingVector() with interrupt disabled >> for consistency. > > Are you sure about this? Original code is like this (interrupt > ENABLED

Re: svn commit: r236414 - in head/sys: amd64/acpica i386/acpica

2012-06-01 Thread Mitsuru IWASAKI
Hi, thanks for following up. > Log: > Call AcpiSetFirmwareWakingVector() with interrupt disabled for consistency. Are you sure about this? Original code is like this (interrupt ENABLED); intr_restore(rf); AcpiSetFirmwareWakingVector(0); if (ret == 0 && mem_rang

svn commit: r236414 - in head/sys: amd64/acpica i386/acpica

2012-06-01 Thread Jung-uk Kim
Author: jkim Date: Fri Jun 1 18:18:48 2012 New Revision: 236414 URL: http://svn.freebsd.org/changeset/base/236414 Log: Call AcpiSetFirmwareWakingVector() with interrupt disabled for consistency. Modified: head/sys/amd64/acpica/acpi_wakeup.c head/sys/i386/acpica/acpi_wakeup.c Modified: hea