Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-24 Thread Justin T. Gibbs
Why wouldn’t we fix these with explicit subdir dependencies (e.g: subdira: subdirb)? I’m pretty sure I had this working with a hacked up bsd.subdir.mk at a previous job, but my memory is hazy. — Justin On Apr 21, 2014, at 7:35 AM, Warner Losh i...@bsdimp.com wrote: (sorry for the top

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-24 Thread Ian Lepore
I couldn't think of a way to do that, because the directory itself isn't the dependency. That is, whether one directory has a newer/older timestamp than the other isn't a function of the build process. The fact that someone else mentioned inserting .WAIT into the list is something I took as a

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-24 Thread Jilles Tjoelker
On Thu, Apr 24, 2014 at 12:14:06PM -0600, Ian Lepore wrote: On Thu, 2014-04-24 at 11:17 -0600, Justin T. Gibbs wrote: Why wouldn’t we fix these with explicit subdir dependencies (e.g: subdira: subdirb)? I’m pretty sure I had this working with a hacked up bsd.subdir.mk at a previous job,

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-24 Thread Warner Losh
The dependency would have to be on the artificial targets that are created, and could easily be done. .WAIT is good for things like libc where everything is dependent on it, but poor for other dependencies which would be expressed as individual dependencies. Warner On Apr 24, 2014, at 12:14 PM,

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-24 Thread Ian Lepore
On Thu, 2014-04-24 at 20:19 +0200, Jilles Tjoelker wrote: On Thu, Apr 24, 2014 at 12:14:06PM -0600, Ian Lepore wrote: On Thu, 2014-04-24 at 11:17 -0600, Justin T. Gibbs wrote: Why wouldn’t we fix these with explicit subdir dependencies (e.g: subdira: subdirb)? I’m pretty sure I had this

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-21 Thread Ian Lepore
On Thu, 2014-03-27 at 20:44 +0100, Dimitry Andric wrote: On 27 Mar 2014, at 19:12, Jilles Tjoelker jil...@stack.nl wrote: On Thu, Mar 27, 2014 at 11:05:00AM -0600, Warner Losh wrote: On Mar 26, 2014, at 4:30 PM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Wed Mar 26 22:30:38

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-04-21 Thread Warner Losh
(sorry for the top post) This looks good to my eye. I’d be tempted to toss in a comment about the __wait=.WAIT construct is due to the primitive nature of bmake’s parser so it runs afoul of the .for/.if construction rules and this is needed to expand the for variable. It tripped me up when I

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread John Baldwin
On Wednesday, March 26, 2014 6:30:39 pm Dimitry Andric wrote: Author: dim Date: Wed Mar 26 22:30:38 2014 New Revision: 263778 URL: http://svnweb.freebsd.org/changeset/base/263778 Log: Add a SUBDIR_PARALLEL option to bsd.subdir.mk, to allow make to process all the SUBDIR entries in

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread David Chisnall
On 26 Mar 2014, at 22:30, Dimitry Andric d...@freebsd.org wrote: Add a SUBDIR_PARALLEL option to bsd.subdir.mk, to allow make to process all the SUBDIR entries in parallel, instead of serially. Apply this option to a selected number of Makefiles, which can greatly speed up the build on

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread Bryan Drewery
On 2014-03-27 10:39, David Chisnall wrote: On 26 Mar 2014, at 22:30, Dimitry Andric d...@freebsd.org wrote: Add a SUBDIR_PARALLEL option to bsd.subdir.mk, to allow make to process all the SUBDIR entries in parallel, instead of serially. Apply this option to a selected number of Makefiles,

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread Warner Losh
Why not have this ‘opt out’ rather than ‘opt in’ like it is now? Are there any known bad dependencies this introduces? Warner On Mar 26, 2014, at 4:30 PM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Wed Mar 26 22:30:38 2014 New Revision: 263778 URL:

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread Ian Lepore
It's also a bit odd that the way of opting in makes it appear as if you're opting out. -- Ian On Thu, 2014-03-27 at 11:05 -0600, Warner Losh wrote: Why not have this ‘opt out’ rather than ‘opt in’ like it is now? Are there any known bad dependencies this introduces? Warner On Mar 26,

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread Jilles Tjoelker
On Thu, Mar 27, 2014 at 11:05:00AM -0600, Warner Losh wrote: On Mar 26, 2014, at 4:30 PM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Wed Mar 26 22:30:38 2014 New Revision: 263778 URL: http://svnweb.freebsd.org/changeset/base/263778 Log: Add a SUBDIR_PARALLEL option to

Re: svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-27 Thread Dimitry Andric
On 27 Mar 2014, at 19:12, Jilles Tjoelker jil...@stack.nl wrote: On Thu, Mar 27, 2014 at 11:05:00AM -0600, Warner Losh wrote: On Mar 26, 2014, at 4:30 PM, Dimitry Andric d...@freebsd.org wrote: Author: dim Date: Wed Mar 26 22:30:38 2014 New Revision: 263778 URL:

svn commit: r263778 - in head: bin lib lib/clang sbin share/mk usr.bin usr.sbin

2014-03-26 Thread Dimitry Andric
Author: dim Date: Wed Mar 26 22:30:38 2014 New Revision: 263778 URL: http://svnweb.freebsd.org/changeset/base/263778 Log: Add a SUBDIR_PARALLEL option to bsd.subdir.mk, to allow make to process all the SUBDIR entries in parallel, instead of serially. Apply this option to a selected number