Re: svn commit: r278431 - head/sys/contrib/vchiq/interface/vchiq_arm

2015-02-09 Thread Konstantin Belousov
On Mon, Feb 09, 2015 at 05:00:49PM +1100, Bruce Evans wrote: On Mon, 9 Feb 2015, Oleksandr Tymoshenko wrote: Log: Do not mark shared structures as __packed, it leads to race condition If structure packed as __packed clang (and probably gcc) generates code that loads word fields

Re: svn commit: r278431 - head/sys/contrib/vchiq/interface/vchiq_arm

2015-02-09 Thread Bruce Evans
On Mon, 9 Feb 2015, Konstantin Belousov wrote: On Mon, Feb 09, 2015 at 05:00:49PM +1100, Bruce Evans wrote: On Mon, 9 Feb 2015, Oleksandr Tymoshenko wrote: ... I think the full bugs only occur when arch has strict alignment requirements and the alignment of the __packed objects is not known.

Re: svn commit: r278431 - head/sys/contrib/vchiq/interface/vchiq_arm

2015-02-09 Thread Konstantin Belousov
On Mon, Feb 09, 2015 at 08:51:02PM +1100, Bruce Evans wrote: On Mon, 9 Feb 2015, Konstantin Belousov wrote: On Mon, Feb 09, 2015 at 05:00:49PM +1100, Bruce Evans wrote: On Mon, 9 Feb 2015, Oleksandr Tymoshenko wrote: ... I think the full bugs only occur when arch has strict alignment

Re: svn commit: r278431 - head/sys/contrib/vchiq/interface/vchiq_arm

2015-02-08 Thread Bruce Evans
On Mon, 9 Feb 2015, Oleksandr Tymoshenko wrote: Log: Do not mark shared structures as __packed, it leads to race condition If structure packed as __packed clang (and probably gcc) generates code that loads word fields (e.g. tx_pos) byte-by-byte and if it's modified by VideoCore in the

svn commit: r278431 - head/sys/contrib/vchiq/interface/vchiq_arm

2015-02-08 Thread Oleksandr Tymoshenko
Author: gonzo Date: Mon Feb 9 02:31:27 2015 New Revision: 278431 URL: https://svnweb.freebsd.org/changeset/base/278431 Log: Do not mark shared structures as __packed, it leads to race condition If structure packed as __packed clang (and probably gcc) generates code that loads word