Re: svn commit: r281239 - head/sys/netinet

2015-04-09 Thread Adrian Chadd
On 9 April 2015 at 13:35, Gleb Smirnoff wrote: > On Thu, Apr 09, 2015 at 12:45:31PM -0700, Adrian Chadd wrote: > A> Hi, > A> > A> Are you going to take a crack at fixing V_nipq? > > Yes, working on it. Patch written, now being debugged. Woo! -a ___ svn

Re: svn commit: r281239 - head/sys/netinet

2015-04-09 Thread Gleb Smirnoff
On Thu, Apr 09, 2015 at 12:45:31PM -0700, Adrian Chadd wrote: A> Hi, A> A> Are you going to take a crack at fixing V_nipq? Yes, working on it. Patch written, now being debugged. -- Totus tuus, Glebius. ___ svn-src-all@freebsd.org mailing list http://l

Re: svn commit: r281239 - head/sys/netinet

2015-04-09 Thread Adrian Chadd
Hi, Are you going to take a crack at fixing V_nipq? This is something that's popped up in a few places in my recent work/not-work hacking, and I think it's about time we had something like counter, but for resource management and not per-cpu. I'd rather not leave things be racy and broken, so if

Re: svn commit: r281239 - head/sys/netinet

2015-04-08 Thread Adrian Chadd
hi gleb, /* Skip initialization of globals for non-default instances. */ if (!IS_DEFAULT_VNET(curvnet)) return; .. ie, no. It doesn't double-init the mutexes. And the purging from bucket behaviour should have been precisely what the previous behaviour was.

Re: svn commit: r281239 - head/sys/netinet

2015-04-08 Thread Gleb Smirnoff
On Wed, Apr 08, 2015 at 11:48:39AM +0300, Gleb Smirnoff wrote: T> On Tue, Apr 07, 2015 at 11:09:35PM +, Adrian Chadd wrote: T> A> Author: adrian T> A> Date: Tue Apr 7 23:09:34 2015 T> A> New Revision: 281239 T> A> URL: https://svnweb.freebsd.org/changeset/base/281239 T> A> T> A> Log: T> A>

Re: svn commit: r281239 - head/sys/netinet

2015-04-08 Thread Gleb Smirnoff
On Tue, Apr 07, 2015 at 11:09:35PM +, Adrian Chadd wrote: A> Author: adrian A> Date: Tue Apr 7 23:09:34 2015 A> New Revision: 281239 A> URL: https://svnweb.freebsd.org/changeset/base/281239 A> A> Log: A> Move the IPv4 reassembly queue locking from a single lock to be per-bucket (global). A

svn commit: r281239 - head/sys/netinet

2015-04-07 Thread Adrian Chadd
Author: adrian Date: Tue Apr 7 23:09:34 2015 New Revision: 281239 URL: https://svnweb.freebsd.org/changeset/base/281239 Log: Move the IPv4 reassembly queue locking from a single lock to be per-bucket (global). This significantly improves performance on multi-core servers where there is