Re: svn commit: r283088 - head/sys/ddb

2015-05-20 Thread Pedro Giffuni
On 05/19/15 10:58, Pedro Giffuni wrote: On 05/19/15 08:45, John Baldwin wrote: ... I will disagree with Bruce a bit and put my vote in for replacing boolean_t with bool where it is used. I do think that logically (if not strictly) your commit is a type mismatch as TRUE/FALSE is for boo

Re: svn commit: r283088 - head/sys/ddb

2015-05-19 Thread Pedro Giffuni
On 05/19/15 08:45, John Baldwin wrote: On Tuesday, May 19, 2015 12:28:05 AM Pedro Giffuni wrote: Modified: head/sys/ddb/db_break.c == --- head/sys/ddb/db_break.c Mon May 18 22:14:06 2015(r283087) +++ head/

Re: svn commit: r283088 - head/sys/ddb

2015-05-19 Thread Ian Lepore
On Mon, 2015-05-18 at 22:49 -0500, Pedro Giffuni wrote: > > Il giorno 18/mag/2015, alle ore 20:48, Bruce Evans > > ha scritto: > > > > On Mon, 18 May 2015, Pedro F. Giffuni wrote: > > > >> Log: > >> ddb: stop boolean screaming. > >> > >> TRUE --> true > >> FALSE--> false > >> > >> Hinted by:

Re: svn commit: r283088 - head/sys/ddb

2015-05-19 Thread John Baldwin
On Tuesday, May 19, 2015 12:28:05 AM Pedro Giffuni wrote: > Modified: head/sys/ddb/db_break.c > == > --- head/sys/ddb/db_break.c Mon May 18 22:14:06 2015 > (r283087) > +++ head/sys/ddb/

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Garrett Cooper
> On May 18, 2015, at 22:28, Pedro Giffuni wrote: > > >> Il giorno 18/mag/2015, alle ore 23:34, Bruce Evans ha >> scritto: >> >> On Mon, 18 May 2015, Pedro Giffuni wrote: >> Il giorno 18/mag/2015, alle ore 20:48, Bruce Evans ha scritto: > On Mon, 18 May 2015, Pedro F.

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Pedro Giffuni
> Il giorno 18/mag/2015, alle ore 23:34, Bruce Evans ha > scritto: > > On Mon, 18 May 2015, Pedro Giffuni wrote: > >>> Il giorno 18/mag/2015, alle ore 20:48, Bruce Evans >>> ha scritto: >>> >>> On Mon, 18 May 2015, Pedro F. Giffuni wrote: >>> Log: ddb: stop boolean screaming. >>>

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Bruce Evans
On Mon, 18 May 2015, Pedro Giffuni wrote: Il giorno 18/mag/2015, alle ore 20:48, Bruce Evans ha scritto: On Mon, 18 May 2015, Pedro F. Giffuni wrote: Log: ddb: stop boolean screaming. TRUE --> true FALSE--> false Hinted by: NetBSD This is not just churn to a style regression, but a

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Pedro Giffuni
> Il giorno 18/mag/2015, alle ore 20:48, Bruce Evans ha > scritto: > > On Mon, 18 May 2015, Pedro F. Giffuni wrote: > >> Log: >> ddb: stop boolean screaming. >> >> TRUE --> true >> FALSE--> false >> >> Hinted by: NetBSD > > This is not just churn to a style regression, but a type mismatch

Re: svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Bruce Evans
On Mon, 18 May 2015, Pedro F. Giffuni wrote: Log: ddb: stop boolean screaming. TRUE --> true FALSE--> false Hinted by: NetBSD This is not just churn to a style regression, but a type mismatch. Modified: head/sys/ddb/db_break.c ===

svn commit: r283088 - head/sys/ddb

2015-05-18 Thread Pedro F. Giffuni
Author: pfg Date: Mon May 18 22:27:46 2015 New Revision: 283088 URL: https://svnweb.freebsd.org/changeset/base/283088 Log: ddb: stop boolean screaming. TRUE --> true FALSE--> false Hinted by:NetBSD Modified: head/sys/ddb/db_break.c head/sys/ddb/db_command.c head/sys/ddb/db