Re: svn commit: r294536 - head/sys/netinet

2016-01-23 Thread Gleb Smirnoff
Lawrence, On Sat, Jan 23, 2016 at 06:09:19PM +1100, Lawrence Stewart wrote: L> > Is that the race you refer to? L> L> No, the TCP_CONGESTION refactoring i.e. this commit, introduced races in L> the get and set cases. I guess I didn't provide enough context in L> Crucible, so here goes... L> L>

Re: svn commit: r294536 - head/sys/netinet

2016-01-22 Thread Lawrence Stewart
On 01/23/16 05:04, Gleb Smirnoff wrote: > On Fri, Jan 22, 2016 at 05:19:34PM +1100, Lawrence Stewart wrote: > L> On 01/22/16 09:53, Gleb Smirnoff wrote: > L> > Author: glebius > L> > Date: Thu Jan 21 22:53:12 2016 > L> > New Revision: 294536 > L> > URL: https://svnweb.freebsd.org/changeset/base/294

Re: svn commit: r294536 - head/sys/netinet

2016-01-22 Thread Gleb Smirnoff
On Fri, Jan 22, 2016 at 05:19:34PM +1100, Lawrence Stewart wrote: L> On 01/22/16 09:53, Gleb Smirnoff wrote: L> > Author: glebius L> > Date: Thu Jan 21 22:53:12 2016 L> > New Revision: 294536 L> > URL: https://svnweb.freebsd.org/changeset/base/294536 L> > L> > Log: L> > Refactor TCP_CONGESTION s

Re: svn commit: r294536 - head/sys/netinet

2016-01-21 Thread NGie Cooper
> On Jan 21, 2016, at 22:19, Lawrence Stewart wrote: > > Hi Gleb, > > On 01/22/16 09:53, Gleb Smirnoff wrote: >> Author: glebius >> Date: Thu Jan 21 22:53:12 2016 >> New Revision: 294536 >> URL: https://svnweb.freebsd.org/changeset/base/294536 >> >> Log: >> Refactor TCP_CONGESTION setsockopt

Re: svn commit: r294536 - head/sys/netinet

2016-01-21 Thread Lawrence Stewart
Hi Gleb, On 01/22/16 09:53, Gleb Smirnoff wrote: > Author: glebius > Date: Thu Jan 21 22:53:12 2016 > New Revision: 294536 > URL: https://svnweb.freebsd.org/changeset/base/294536 > > Log: > Refactor TCP_CONGESTION setsockopt handling: > - Use M_TEMP instead of stack variable. > - Unroll err

svn commit: r294536 - head/sys/netinet

2016-01-21 Thread Gleb Smirnoff
Author: glebius Date: Thu Jan 21 22:53:12 2016 New Revision: 294536 URL: https://svnweb.freebsd.org/changeset/base/294536 Log: Refactor TCP_CONGESTION setsockopt handling: - Use M_TEMP instead of stack variable. - Unroll error handling, removing several levels of indentation. Modified: he