Author: arybchik
Date: Sat Jun  4 17:19:25 2016
New Revision: 301397
URL: https://svnweb.freebsd.org/changeset/base/301397

Log:
  MFC r300845
  
  sfxge(4): cope with lint for EFX_SET_OWORD_BIT() with const bit arg
  
  Found by lint on illumos.
  
  Submitted by:   Garrett D'Amore <garrett at damore.org>
  Sponsored by:   Solarflare Communications, Inc.

Modified:
  stable/10/sys/dev/sfxge/common/siena_mac.c
Directory Properties:
  stable/10/   (props changed)

Modified: stable/10/sys/dev/sfxge/common/siena_mac.c
==============================================================================
--- stable/10/sys/dev/sfxge/common/siena_mac.c  Sat Jun  4 17:18:35 2016        
(r301396)
+++ stable/10/sys/dev/sfxge/common/siena_mac.c  Sat Jun  4 17:19:25 2016        
(r301397)
@@ -158,8 +158,17 @@ siena_mac_reconfigure(
         * so we always add bit 0xff to the mask (bit 0x7f in the
         * second octword).
         */
-       if (epp->ep_brdcst)
+       if (epp->ep_brdcst) {
+               /*
+                * NOTE: due to constant folding, some of this evaluates
+                * to null expressions, giving E_EXPR_NULL_EFFECT during
+                * lint on Illumos.  No good way to fix this without
+                * explicit coding the individual word/bit setting.
+                * So just suppress lint for this one line.
+                */
+               /* LINTED */
                EFX_SET_OWORD_BIT(multicast_hash[1], 0x7f);
+       }
 
        (void) memset(payload, 0, sizeof (payload));
        req.emr_cmd = MC_CMD_SET_MCAST_HASH;
_______________________________________________
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Reply via email to