Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-31 Thread Ed Schouten
Hi Antoine, 2016-07-31 8:37 GMT+02:00 Antoine Brodin : > This change broke a few games in the ports tree: > > http://beefy4.nyi.freebsd.org/data/head-amd64-default/p419204_s303419/logs/errors/falconseye-1.9.3_11.log >

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-31 Thread Antoine Brodin
On Tue, Jul 26, 2016 at 11:41 PM, Ed Schouten wrote: > Hi Pedro, Benjamin, > > 2016-07-26 22:35 GMT+02:00 Pedro Giffuni : >> On 07/26/16 15:14, Benjamin Kaduk wrote: >>> Is a __FreeBSD_version bump planned? (Third-party software might want >>> to be

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-28 Thread Ed Schouten
Hi Bruce, 2016-07-27 2:44 GMT+02:00 Bruce Evans : > This might work here since the type is unsigned, but it wouldn't work to > change from int to long. Yes. That's a pretty good remark. What makes this pretty safe in this case is that srandom() discard the top bits anyway.

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Bruce Evans
On Tue, 26 Jul 2016, Ed Schouten wrote: Log: Fix typing of srandom() and initstate(). POSIX requires that these functions have an unsigned int for their first argument; not an unsigned long. My reasoning is that we can safely change these functions without breaking the ABI. As far as I

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Ed Schouten
Hi Pedro, Benjamin, 2016-07-26 22:35 GMT+02:00 Pedro Giffuni : > On 07/26/16 15:14, Benjamin Kaduk wrote: >> Is a __FreeBSD_version bump planned? (Third-party software might want >> to be warning-clean.) > > Third party software should already follow standards ;). Not only

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Pedro Giffuni
On 07/26/16 15:14, Benjamin Kaduk wrote: On Tue, Jul 26, 2016 at 3:11 PM, Ed Schouten > wrote: Author: ed Date: Tue Jul 26 20:11:29 2016 New Revision: 303342 URL: https://svnweb.freebsd.org/changeset/base/303342 Log: Fix

Re: svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Benjamin Kaduk
On Tue, Jul 26, 2016 at 3:11 PM, Ed Schouten wrote: > Author: ed > Date: Tue Jul 26 20:11:29 2016 > New Revision: 303342 > URL: https://svnweb.freebsd.org/changeset/base/303342 > > Log: > Fix typing of srandom() and initstate(). > > POSIX requires that these functions have

svn commit: r303342 - in head: include lib/libc/stdlib

2016-07-26 Thread Ed Schouten
Author: ed Date: Tue Jul 26 20:11:29 2016 New Revision: 303342 URL: https://svnweb.freebsd.org/changeset/base/303342 Log: Fix typing of srandom() and initstate(). POSIX requires that these functions have an unsigned int for their first argument; not an unsigned long. My reasoning is