Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Pedro Giffuni
On 08/01/16 01:08, Bruce Evans wrote: On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 Differe

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Pedro Giffuni
On 08/01/16 10:24, Piotr Stefaniak wrote: On 2016-08-01 08:08, Bruce Evans wrote: On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: -bzero(f, sizeof *f); +memset(f, 0, sizeof(struct fstate)); ^ This is much more e

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Pedro Giffuni
On 08/01/16 00:28, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Author: pfg Date: Sun Jul 31 21:36:40 2016 New Revision: 303600 URL: https://svnweb.freebsd.org/changeset/base/303600 Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Piotr Stefaniak
On 2016-08-01 08:08, Bruce Evans wrote: > On Sun, 31 Jul 2016, Xin Li wrote: > >> On 7/31/16 14:36, Pedro F. Giffuni wrote: >>> -bzero(f, sizeof *f); >>> +memset(f, 0, sizeof(struct fstate)); >>^ This is much more error-prone >> than sizeof(*f) IMHO

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Bruce Evans
On Sun, 31 Jul 2016, Xin Li wrote: On 7/31/16 14:36, Pedro F. Giffuni wrote: Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 Differential Revision: https://reviews.freebsd.

Re: svn commit: r303600 - head/usr.bin/indent

2016-08-01 Thread Xin Li
On 7/31/16 14:36, Pedro F. Giffuni wrote: > Author: pfg > Date: Sun Jul 31 21:36:40 2016 > New Revision: 303600 > URL: https://svnweb.freebsd.org/changeset/base/303600 > > Log: > indent(1): replace function call to bzero with memset. > > Reference: > > https://github.com/pstef/freebsd_

svn commit: r303600 - head/usr.bin/indent

2016-07-31 Thread Pedro F. Giffuni
Author: pfg Date: Sun Jul 31 21:36:40 2016 New Revision: 303600 URL: https://svnweb.freebsd.org/changeset/base/303600 Log: indent(1): replace function call to bzero with memset. Reference: https://github.com/pstef/freebsd_indent/commit/7422f42f80099c69d34833d7106035dc09230235 Differ