svn commit: r306473 - head/sys/dev/fdt

2016-09-29 Thread Justin Hibbits
Author: jhibbits Date: Fri Sep 30 02:48:40 2016 New Revision: 306473 URL: https://svnweb.freebsd.org/changeset/base/306473 Log: Use the cell-index property as the unit number if available. Summary: NXP/Freescale, among others, includes an optional cell-index property on nodes to denote

Re: svn commit: r306473 - head/sys/dev/fdt

2016-09-29 Thread Nathan Whitehorn
I'm a little dubious about this change. It's not really safe to rely on newbus unit numbers anywhere, so making them meaningful in this context seems like a bad idea. -Nathan On 09/29/16 19:48, Justin Hibbits wrote: Author: jhibbits Date: Fri Sep 30 02:48:40 2016 New Revision: 306473 URL: http

Re: svn commit: r306473 - head/sys/dev/fdt

2016-09-29 Thread Justin Hibbits
It's more cosmetic than anything else. I did realize a potential complication with it tonight, too, if newbus devices are created as children (like DMA channels in this case), and have the cell-index property. If you object it's an easy revert. - Justin On Sep 29, 2016 23:10, "Nathan Whitehorn"

Re: svn commit: r306473 - head/sys/dev/fdt

2016-09-29 Thread Nathan Whitehorn
Eh, I don't care much, especially if it's for cosmetic reasons only. I'm not sure I understand your suggested complication, but will leave the choice to you in any case. -Nathan On 09/29/16 21:16, Justin Hibbits wrote: It's more cosmetic than anything else. I did realize a potential complica

Re: svn commit: r306473 - head/sys/dev/fdt

2016-09-29 Thread Justin Hibbits
If I remember correctly, newbus will throw an error if you try to create two devices with the same number. Applying the logic of using the cell-index property for all device nodes, if two sub buses from simplebus have the same set of child nodes, with the same cell-index property values, one set of

Re: svn commit: r306473 - head/sys/dev/fdt

2016-09-30 Thread John Baldwin
On Thursday, September 29, 2016 11:38:13 PM Justin Hibbits wrote: > If I remember correctly, newbus will throw an error if you try to create > two devices with the same number. Applying the logic of using the > cell-index property for all device nodes, if two sub buses from simplebus > have the sam